Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate to nx 19.0.8 #31825

Merged
merged 1 commit into from
Jun 26, 2024
Merged

chore: migrate to nx 19.0.8 #31825

merged 1 commit into from
Jun 26, 2024

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Jun 26, 2024

Previous Behavior

New Behavior

  • Release announcement https://nx.dev/blog/nx-19-release
  • bumps to 1st stable v19.0.x, latest (19.3.1) introduces swc core and helpers bump which might be problematic for our packages, will need further testing

Related Issue(s)

@github-actions github-actions bot added this to the April Project Cycle Q1 2024 milestone Jun 26, 2024
@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 612 634 5000
Button mount 299 303 5000
Field mount 1153 1084 5000
FluentProvider mount 714 707 5000
FluentProviderWithTheme mount 72 78 10
FluentProviderWithTheme virtual-rerender 38 32 10
FluentProviderWithTheme virtual-rerender-with-unmount 84 68 10
MakeStyles mount 867 872 50000
Persona mount 1782 1713 5000
SpinButton mount 1410 1354 5000
SwatchPicker mount 1651 1692 5000

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
TreeWith60ListItems.default 98 84 1.17:1
VideoMinimalPerf.default 483 415 1.16:1
SegmentMinimalPerf.default 210 189 1.11:1
ButtonSlotsPerf.default 322 295 1.09:1
GridMinimalPerf.default 212 197 1.08:1
PortalMinimalPerf.default 93 86 1.08:1
BoxMinimalPerf.default 207 194 1.07:1
AccordionMinimalPerf.default 88 83 1.06:1
AvatarMinimalPerf.default 114 108 1.06:1
LayoutMinimalPerf.default 206 194 1.06:1
LoaderMinimalPerf.default 209 198 1.06:1
ButtonOverridesMissPerf.default 679 645 1.05:1
FlexMinimalPerf.default 161 154 1.05:1
RefMinimalPerf.default 116 111 1.05:1
TextMinimalPerf.default 206 197 1.05:1
ChatDuplicateMessagesPerf.default 167 160 1.04:1
HeaderMinimalPerf.default 221 213 1.04:1
ItemLayoutMinimalPerf.default 736 709 1.04:1
ListMinimalPerf.default 336 325 1.03:1
ListNestedPerf.default 339 329 1.03:1
ListWith60ListItems.default 382 371 1.03:1
SkeletonMinimalPerf.default 204 199 1.03:1
DropdownManyItemsPerf.default 428 420 1.02:1
MenuMinimalPerf.default 520 511 1.02:1
ProviderMergeThemesPerf.default 669 656 1.02:1
SliderMinimalPerf.default 751 736 1.02:1
IconMinimalPerf.default 403 397 1.02:1
ToolbarMinimalPerf.default 574 561 1.02:1
AlertMinimalPerf.default 163 161 1.01:1
CarouselMinimalPerf.default 261 258 1.01:1
ChatMinimalPerf.default 460 454 1.01:1
DialogMinimalPerf.default 478 472 1.01:1
EmbedMinimalPerf.default 2054 2026 1.01:1
MenuButtonMinimalPerf.default 969 962 1.01:1
TableMinimalPerf.default 241 239 1.01:1
AnimationMinimalPerf.default 307 308 1:1
AttachmentSlotsPerf.default 640 642 1:1
FormMinimalPerf.default 226 225 1:1
HeaderSlotsPerf.default 470 469 1:1
InputMinimalPerf.default 564 563 1:1
ListCommonPerf.default 396 397 1:1
ProviderMinimalPerf.default 207 207 1:1
RadioGroupMinimalPerf.default 271 270 1:1
ReactionMinimalPerf.default 211 210 1:1
TextAreaMinimalPerf.default 307 307 1:1
ButtonMinimalPerf.default 91 92 0.99:1
DatepickerMinimalPerf.default 3707 3733 0.99:1
ImageMinimalPerf.default 228 231 0.99:1
PopupMinimalPerf.default 353 356 0.99:1
SplitButtonMinimalPerf.default 2325 2346 0.99:1
StatusMinimalPerf.default 401 407 0.99:1
TableManyItemsPerf.default 1147 1157 0.99:1
CheckboxMinimalPerf.default 1169 1197 0.98:1
CustomToolbarPrototype.default 1485 1517 0.98:1
DropdownMinimalPerf.default 1507 1546 0.97:1
TooltipMinimalPerf.default 1275 1318 0.97:1
TreeMinimalPerf.default 502 517 0.97:1
ChatWithPopoverPerf.default 199 208 0.96:1
LabelMinimalPerf.default 234 243 0.96:1
RosterPerf.default 1583 1641 0.96:1
AttachmentMinimalPerf.default 80 84 0.95:1
CardMinimalPerf.default 295 315 0.94:1
DividerMinimalPerf.default 198 218 0.91:1

@fabricteam
Copy link
Collaborator

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

📊 Bundle size report

✅ No changes found

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 618 639 5000
Breadcrumb mount 1698 1689 1000
Checkbox mount 1697 1693 5000
CheckboxBase mount 1470 1480 5000
ChoiceGroup mount 2945 2957 5000
ComboBox mount 679 674 1000
CommandBar mount 6571 6509 1000
ContextualMenu mount 12248 12351 1000
DefaultButton mount 820 798 5000
DetailsRow mount 2222 2237 5000
DetailsRowFast mount 2212 2227 5000
DetailsRowNoStyles mount 2010 2039 5000
Dialog mount 2643 2640 1000
DocumentCardTitle mount 231 234 1000
Dropdown mount 2026 2093 5000
FocusTrapZone mount 1167 1143 5000
FocusZone mount 1098 1082 5000
GroupedList mount 41628 41886 2
GroupedList virtual-rerender 17992 20031 2
GroupedList virtual-rerender-with-unmount 50931 51004 2
GroupedListV2 mount 230 226 2
GroupedListV2 virtual-rerender 207 217 2
GroupedListV2 virtual-rerender-with-unmount 220 228 2
IconButton mount 1105 1133 5000
Label mount 345 342 5000
Layer mount 2785 2727 5000
Link mount 390 387 5000
MenuButton mount 1004 1002 5000
MessageBar mount 21277 21467 5000
Nav mount 2011 2001 1000
OverflowSet mount 781 787 5000
Panel mount 2032 1815 1000
Persona mount 738 748 1000
Pivot mount 890 914 1000
PrimaryButton mount 925 950 5000
Rating mount 4625 4613 5000
SearchBox mount 936 909 5000
Shimmer mount 1890 1891 5000
Slider mount 1309 1334 5000
SpinButton mount 2965 2951 5000
Spinner mount 391 395 5000
SplitButton mount 1856 1875 5000
Stack mount 414 417 5000
StackWithIntrinsicChildren mount 875 872 5000
StackWithTextChildren mount 2825 2836 5000
SwatchColorPicker mount 6418 6382 5000
TagPicker mount 1434 1447 5000
Text mount 393 395 5000
TextField mount 932 956 5000
ThemeProvider mount 860 873 5000
ThemeProvider virtual-rerender 586 576 5000
ThemeProvider virtual-rerender-with-unmount 1316 1327 5000
Toggle mount 592 620 5000
buttonNative mount 186 178 5000

@Hotell Hotell marked this pull request as ready for review June 26, 2024 10:13
@Hotell Hotell requested a review from a team as a code owner June 26, 2024 10:13
@Hotell Hotell merged commit 4cacb0a into microsoft:master Jun 26, 2024
21 checks passed
@Hotell Hotell deleted the nx/migrate/19_0 branch June 26, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants