Fix: Ensure createV9Theme uses appropriate base theme for dark theme #31743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report✅ No changes found |
mark-wiemer
reviewed
Aug 4, 2024
packages/react-components/react-migration-v8-v9/src/components/Theme/v9ThemeShim.ts
Outdated
Show resolved
Hide resolved
…/Theme/v9ThemeShim.ts Co-authored-by: Mark Wiemer <[email protected]>
github-actions
bot
modified the milestones:
April Project Cycle Q1 2024,
October Project Cycle Q4 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
The
createV9Themefunction did not fully support some tokens in the dark theme. Specifically, there was no mapping for status tokens between V8 and V9. As a result, even in the dark theme, the token values were derived fromwebLightTheme, leading to incorrect colors in the dark theme.New Behavior
The
createV9Themefunction now correctly detects if the provided V8 theme is a dark theme and useswebDarkThemeas the base theme instead ofwebLightTheme. This ensures that the tokens are correctly mapped and rendered for the dark theme.🚨 With the fix,
createV9Themenow depends on bothwebLightThemeandwebDarkThemeand adds both to a bundle. We need to decide whether that is worth it.Related Issue(s)