Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: configure e2e target properly in order to make fix affected e2e target execution on ci #31685

Merged
merged 2 commits into from
Jun 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "fix: configure e2e target properly in order to make fix affected e2e target execution on ci",
"packageName": "@fluentui/react",
"email": "[email protected]",
"dependentChangeType": "none"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "fix: configure e2e target properly in order to make fix affected e2e target execution on ci",
"packageName": "@fluentui/web-components",
"email": "[email protected]",
"dependentChangeType": "none"
}
3 changes: 3 additions & 0 deletions lage.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ module.exports = {
'build:info': [],
bundle: ['build'],
'bundle-size': ['build'],
'build-storybook': [],
// adding temporary back until import plugin rule is resolved https://github.com/microsoft/fluentui/issues/27727
lint: ['build'],
clean: [],
Expand All @@ -16,6 +17,8 @@ module.exports = {
'update-snapshots': ['^update-snapshots'],
'@fluentui/docs#build': ['@fluentui/react-northstar#build:info'],
'verify-packaging': ['build'],
e2e: [],
'@fluentui/web-components#e2e': ['build-storybook'],
},

// Adds some ADO-specific logging commands for reporting failures
Expand Down
10 changes: 10 additions & 0 deletions nx.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,11 @@
"inputs": ["production", "^production"],
"cache": true
},
"build-storybook": {
"dependsOn": [],
"inputs": ["default", "{workspaceRoot}/.storybook/**", "{projectRoot}/.storybook/**"],
"cache": true
},
"generate-api": {
"dependsOn": ["^generate-api"],
"cache": true
Expand All @@ -46,6 +51,11 @@
"test-ssr": {
"cache": true
},
"e2e": {
"dependsOn": [],
"cache": true,
"inputs": ["default", "{projectRoot}/cypress.config.ts", "!{projectRoot}/**/?(*.)+cy.[jt]s?(x)?"]
},
"lint": {
"dependsOn": ["build"],
"cache": true,
Expand Down
4 changes: 2 additions & 2 deletions packages/react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
"clean": "just-scripts clean",
"code-style": "just-scripts code-style",
"codepen": "node ../../scripts/executors/src/local-codepen.js",
"e2e": "yarn workspace @fluentui/react-examples cypress run --component",
"e2e:local": "yarn workspace @fluentui/react-examples cypress open --component",
"e2e": "yarn lage e2e --to @fluentui/react-examples --verbose",
"e2e:local": "yarn workspace @fluentui/react-examples e2e:local",
"just": "just-scripts",
"lint": "just-scripts lint",
"start": "cross-env NODE_OPTIONS=--max-old-space-size=3072 just-scripts dev:storybook",
Expand Down
5 changes: 4 additions & 1 deletion packages/web-components/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,8 @@
"$schema": "../../node_modules/nx/schemas/project-schema.json",
"projectType": "library",
"implicitDependencies": [],
"tags": ["platform:web", "web-components"]
"tags": ["platform:web", "web-components"],
"targets": {
"e2e": { "dependsOn": ["build-storybook"] }
}
}
Loading