Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove react-alert from monorepo #31642

Merged
merged 1 commit into from
Jun 11, 2024
Merged

chore: remove react-alert from monorepo #31642

merged 1 commit into from
Jun 11, 2024

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Jun 10, 2024 •
edited
Loading

Previous Behavior

New Behavior

Since react-alert has been deprecated during v9 preview development and is not used in any way. This PR removes the source from monorepo

Note

While we are removing this, react-components will still re-export the package since removing it would break semver even though it's under /unstable.

Note

changes made via:

  • yarn nx g @nx/workspace:remove --projectName=@fluentui/react-alert --forceRemove=true
  • yarn nx g @fluentui/workspace-plugin:tsconfig-base-all
  • manual update of CODEOWNERS

Related Issue(s)

@github-actions github-actions bot added this to the April Project Cycle Q1 2024 milestone Jun 10, 2024
@Hotell Hotell marked this pull request as ready for review June 10, 2024 16:33
@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
FluentProviderWithTheme virtual-rerender 35 37 10 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 656 631 5000
Button mount 306 313 5000
Field mount 1097 1197 5000
FluentProvider mount 710 720 5000
FluentProviderWithTheme mount 88 81 10
FluentProviderWithTheme virtual-rerender 35 37 10 Possible regression
FluentProviderWithTheme virtual-rerender-with-unmount 72 75 10
MakeStyles mount 897 884 50000
Persona mount 1758 1738 5000
SpinButton mount 1413 1446 5000
SwatchPicker mount 1543 1562 5000

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-northstar)

⚠️ 2 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
AccordionMinimalPerf.default 87 81 1.07:1 analysis
DividerMinimalPerf.default 207 206 1:1 analysis
Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AttachmentMinimalPerf.default 90 79 1.14:1
ListWith60ListItems.default 387 344 1.13:1
TreeWith60ListItems.default 92 84 1.1:1
LoaderMinimalPerf.default 189 175 1.08:1
IconMinimalPerf.default 412 381 1.08:1
ChatWithPopoverPerf.default 198 185 1.07:1
FormMinimalPerf.default 227 213 1.07:1
LabelMinimalPerf.default 227 213 1.07:1
GridMinimalPerf.default 200 188 1.06:1
LayoutMinimalPerf.default 206 194 1.06:1
SkeletonMinimalPerf.default 209 197 1.06:1
HeaderMinimalPerf.default 228 217 1.05:1
ImageMinimalPerf.default 232 220 1.05:1
RefMinimalPerf.default 111 106 1.05:1
CarouselMinimalPerf.default 268 258 1.04:1
InputMinimalPerf.default 547 528 1.04:1
SplitButtonMinimalPerf.default 2332 2250 1.04:1
AlertMinimalPerf.default 159 155 1.03:1
ListCommonPerf.default 400 389 1.03:1
PopupMinimalPerf.default 355 346 1.03:1
ProviderMinimalPerf.default 202 197 1.03:1
StatusMinimalPerf.default 408 398 1.03:1
TextMinimalPerf.default 193 188 1.03:1
AttachmentSlotsPerf.default 646 633 1.02:1
CardMinimalPerf.default 307 300 1.02:1
DatepickerMinimalPerf.default 3666 3578 1.02:1
DialogMinimalPerf.default 444 435 1.02:1
ListMinimalPerf.default 316 309 1.02:1
ListNestedPerf.default 331 325 1.02:1
RadioGroupMinimalPerf.default 271 266 1.02:1
SliderMinimalPerf.default 745 730 1.02:1
TextAreaMinimalPerf.default 295 288 1.02:1
CustomToolbarPrototype.default 1503 1469 1.02:1
AnimationMinimalPerf.default 297 295 1.01:1
AvatarMinimalPerf.default 108 107 1.01:1
ButtonMinimalPerf.default 87 86 1.01:1
ButtonOverridesMissPerf.default 653 646 1.01:1
ChatDuplicateMessagesPerf.default 155 154 1.01:1
DropdownManyItemsPerf.default 393 389 1.01:1
EmbedMinimalPerf.default 1902 1876 1.01:1
FlexMinimalPerf.default 160 158 1.01:1
MenuButtonMinimalPerf.default 961 948 1.01:1
RosterPerf.default 1571 1555 1.01:1
ChatMinimalPerf.default 447 445 1:1
CheckboxMinimalPerf.default 1130 1128 1:1
HeaderSlotsPerf.default 477 475 1:1
ItemLayoutMinimalPerf.default 722 723 1:1
SegmentMinimalPerf.default 191 191 1:1
ToolbarMinimalPerf.default 545 545 1:1
DropdownMinimalPerf.default 1428 1438 0.99:1
MenuMinimalPerf.default 498 504 0.99:1
ReactionMinimalPerf.default 207 210 0.99:1
TableMinimalPerf.default 246 248 0.99:1
ButtonSlotsPerf.default 319 324 0.98:1
TooltipMinimalPerf.default 1258 1285 0.98:1
VideoMinimalPerf.default 431 442 0.98:1
BoxMinimalPerf.default 187 193 0.97:1
ProviderMergeThemesPerf.default 636 654 0.97:1
TableManyItemsPerf.default 1103 1132 0.97:1
TreeMinimalPerf.default 493 508 0.97:1
PortalMinimalPerf.default 78 83 0.94:1

@fabricteam
Copy link
Collaborator

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

📊 Bundle size report

✅ No changes found

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 638 661 5000
Breadcrumb mount 1775 1744 1000
Checkbox mount 1729 1772 5000
CheckboxBase mount 1517 1553 5000
ChoiceGroup mount 3095 3069 5000
ComboBox mount 696 705 1000
CommandBar mount 6910 6935 1000
ContextualMenu mount 16274 16390 1000
DefaultButton mount 835 829 5000
DetailsRow mount 2304 2241 5000
DetailsRowFast mount 2269 2319 5000
DetailsRowNoStyles mount 2075 2095 5000
Dialog mount 2720 2770 1000
DocumentCardTitle mount 238 229 1000
Dropdown mount 2063 2028 5000
FocusTrapZone mount 1140 1140 5000
FocusZone mount 1104 1131 5000
GroupedList mount 39471 43235 2
GroupedList virtual-rerender 21101 21402 2
GroupedList virtual-rerender-with-unmount 52553 53685 2
GroupedListV2 mount 239 232 2
GroupedListV2 virtual-rerender 225 221 2
GroupedListV2 virtual-rerender-with-unmount 243 236 2
IconButton mount 1130 1140 5000
Label mount 345 343 5000
Layer mount 2827 2821 5000
Link mount 405 407 5000
MenuButton mount 1002 1023 5000
MessageBar mount 21662 21583 5000
Nav mount 2082 2071 1000
OverflowSet mount 828 802 5000
Panel mount 1792 1838 1000
Persona mount 755 783 1000
Pivot mount 960 939 1000
PrimaryButton mount 967 955 5000
Rating mount 4811 4749 5000
SearchBox mount 977 923 5000
Shimmer mount 1961 1986 5000
Slider mount 1364 1377 5000
SpinButton mount 3098 3086 5000
Spinner mount 402 401 5000
SplitButton mount 1946 1937 5000
Stack mount 435 453 5000
StackWithIntrinsicChildren mount 887 863 5000
StackWithTextChildren mount 2742 2780 5000
SwatchColorPicker mount 6393 6442 5000
TagPicker mount 1462 1481 5000
Text mount 386 387 5000
TextField mount 992 942 5000
ThemeProvider mount 884 852 5000
ThemeProvider virtual-rerender 608 596 5000
ThemeProvider virtual-rerender-with-unmount 1326 1329 5000
Toggle mount 645 634 5000
buttonNative mount 199 192 5000

@Hotell Hotell merged commit b52f89e into microsoft:master Jun 11, 2024
21 checks passed
@Hotell Hotell deleted the v9/remove-react-alert branch June 11, 2024 09:01
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Jun 11, 2024
@marcosmoura
Merge branch 'master' into feat/react-nav-preview/transition-examples…
4ec1cb8 
…-and-drawer-compat

* master: (43 commits)
  chore: remove react-alert from monorepo (microsoft#31642)
  docs(react-skeleton): extend Skeleton story with SkeletonItem examples (microsoft#31608)
  feat(react-motion): add support for params (microsoft#31566)
  applying package updates
  fix: show default title action in dialog body for modal dialogs (microsoft#31648)
  chore:(react-nav-preview)Remove redundant NavDrawerHeaderNav component. (microsoft#31646)
  Update Accordion Size story to allow collapsing (microsoft#31624)
  fix(react-accordion): deprecate navigation prop (microsoft#31587)
  fix: Drawer story accessibility fixes and docs update (microsoft#31570)
  feat:(react-nav-preview) Adds small size variant (microsoft#31589)
  feat: update divider to use element internals (microsoft#31627)
  chore(react-components): split react libraries in two (/library and /stories) - teams-prg /3rd batch (microsoft#31601)
  chore:(docs) Adding Jest testing document (microsoft#31554)
  chore(react-components): split react libraries in two (/library and /stories) - teams-prg /2nd batch (microsoft#31600)
  build(deps): bump tar from 6.1.11 to 6.2.1 (microsoft#31633)
  applying package updates
  fix: allow updating of CSS properties when they are already defined (microsoft#31629)
  fix: corrects the border-color for switch when in the checked state on rest (microsoft#31628)
  chore: update Switch to leverage ElementInternals via Checkbox (microsoft#31613)
  chore: update temporarily codeowners for split-in-two migrated packages to maintain proper PR review assignemnt for outdated branches (microsoft#31616)
  ...
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Jun 11, 2024
@marcosmoura
Merge branch 'master' into rfc/z-index-handling
8cf78e9 
* master: (43 commits)
  chore: remove react-alert from monorepo (microsoft#31642)
  docs(react-skeleton): extend Skeleton story with SkeletonItem examples (microsoft#31608)
  feat(react-motion): add support for params (microsoft#31566)
  applying package updates
  fix: show default title action in dialog body for modal dialogs (microsoft#31648)
  chore:(react-nav-preview)Remove redundant NavDrawerHeaderNav component. (microsoft#31646)
  Update Accordion Size story to allow collapsing (microsoft#31624)
  fix(react-accordion): deprecate navigation prop (microsoft#31587)
  fix: Drawer story accessibility fixes and docs update (microsoft#31570)
  feat:(react-nav-preview) Adds small size variant (microsoft#31589)
  feat: update divider to use element internals (microsoft#31627)
  chore(react-components): split react libraries in two (/library and /stories) - teams-prg /3rd batch (microsoft#31601)
  chore:(docs) Adding Jest testing document (microsoft#31554)
  chore(react-components): split react libraries in two (/library and /stories) - teams-prg /2nd batch (microsoft#31600)
  build(deps): bump tar from 6.1.11 to 6.2.1 (microsoft#31633)
  applying package updates
  fix: allow updating of CSS properties when they are already defined (microsoft#31629)
  fix: corrects the border-color for switch when in the checked state on rest (microsoft#31628)
  chore: update Switch to leverage ElementInternals via Checkbox (microsoft#31613)
  chore: update temporarily codeowners for split-in-two migrated packages to maintain proper PR review assignemnt for outdated branches (microsoft#31616)
  ...
miroslavstastny pushed a commit to miroslavstastny/fluentui that referenced this pull request Jun 14, 2024
@Hotell @miroslavstastny
chore: remove react-alert from monorepo (microsoft#31642)
333ca9f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabricteam fabricteam fabricteam left review comments

@layershifter layershifter layershifter approved these changes

@ling1726 ling1726 ling1726 approved these changes

@ms-acalzaretto ms-acalzaretto Awaiting requested review from ms-acalzaretto ms-acalzaretto is a code owner

@JustSlone JustSlone Awaiting requested review from JustSlone JustSlone is a code owner

@jurokapsiar jurokapsiar Awaiting requested review from jurokapsiar jurokapsiar is a code owner

@tudorpopams tudorpopams Awaiting requested review from tudorpopams tudorpopams is a code owner

Assignees
No one assigned
Labels
Fluent UI react-components (v9)
Projects
None yet
Milestone
April Project Cycle Q1 2024
Development

Successfully merging this pull request may close these issues.
4 participants
@Hotell @fabricteam @layershifter @ling1726