chore(react-components): split react libraries in two (/library and /stories) - teams-prg /3rd batch #31601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hotell
force-pushed
the
type-checking-perf/apply/teams-3
branch
from
687b156 to
5ab32ab
Compare
17 tasks
fabricteam
reviewed
Jun 6, 2024
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender | 31 | 37 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 633 | 615 | 5000 | |
| Button | mount | 313 | 301 | 5000 | |
| Field | mount | 1098 | 1127 | 5000 | |
| FluentProvider | mount | 711 | 736 | 5000 | |
| FluentProviderWithTheme | mount | 76 | 81 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 31 | 37 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 65 | 77 | 10 | |
| MakeStyles | mount | 859 | 861 | 50000 | |
| Persona | mount | 1772 | 1679 | 5000 | |
| SpinButton | mount | 1431 | 1431 | 5000 | |
| SwatchPicker | mount | 1542 | 1533 | 5000 |
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| TreeWith60ListItems.default | 98 | 84 | 1.17:1 |
| AccordionMinimalPerf.default | 94 | 84 | 1.12:1 |
| FlexMinimalPerf.default | 165 | 150 | 1.1:1 |
| AvatarMinimalPerf.default | 115 | 106 | 1.08:1 |
| LabelMinimalPerf.default | 235 | 219 | 1.07:1 |
| GridMinimalPerf.default | 200 | 188 | 1.06:1 |
| AttachmentMinimalPerf.default | 88 | 84 | 1.05:1 |
| ButtonMinimalPerf.default | 92 | 88 | 1.05:1 |
| ChatDuplicateMessagesPerf.default | 160 | 153 | 1.05:1 |
| InputMinimalPerf.default | 555 | 529 | 1.05:1 |
| LoaderMinimalPerf.default | 201 | 191 | 1.05:1 |
| MenuMinimalPerf.default | 522 | 499 | 1.05:1 |
| PopupMinimalPerf.default | 361 | 343 | 1.05:1 |
| ReactionMinimalPerf.default | 219 | 209 | 1.05:1 |
| SplitButtonMinimalPerf.default | 2334 | 2213 | 1.05:1 |
| CarouselMinimalPerf.default | 273 | 263 | 1.04:1 |
| ChatWithPopoverPerf.default | 213 | 205 | 1.04:1 |
| HeaderSlotsPerf.default | 482 | 462 | 1.04:1 |
| ListCommonPerf.default | 408 | 391 | 1.04:1 |
| ListWith60ListItems.default | 388 | 372 | 1.04:1 |
| ProviderMergeThemesPerf.default | 674 | 648 | 1.04:1 |
| ProviderMinimalPerf.default | 205 | 197 | 1.04:1 |
| RadioGroupMinimalPerf.default | 262 | 253 | 1.04:1 |
| AnimationMinimalPerf.default | 299 | 291 | 1.03:1 |
| ChatMinimalPerf.default | 454 | 439 | 1.03:1 |
| DropdownMinimalPerf.default | 1467 | 1431 | 1.03:1 |
| LayoutMinimalPerf.default | 207 | 201 | 1.03:1 |
| ListMinimalPerf.default | 317 | 308 | 1.03:1 |
| IconMinimalPerf.default | 388 | 377 | 1.03:1 |
| TextAreaMinimalPerf.default | 283 | 276 | 1.03:1 |
| ButtonOverridesMissPerf.default | 665 | 654 | 1.02:1 |
| ImageMinimalPerf.default | 229 | 225 | 1.02:1 |
| MenuButtonMinimalPerf.default | 968 | 949 | 1.02:1 |
| TooltipMinimalPerf.default | 1308 | 1280 | 1.02:1 |
| AlertMinimalPerf.default | 160 | 159 | 1.01:1 |
| BoxMinimalPerf.default | 201 | 199 | 1.01:1 |
| DatepickerMinimalPerf.default | 3829 | 3776 | 1.01:1 |
| RosterPerf.default | 1577 | 1561 | 1.01:1 |
| SliderMinimalPerf.default | 736 | 732 | 1.01:1 |
| TableMinimalPerf.default | 241 | 238 | 1.01:1 |
| CheckboxMinimalPerf.default | 1149 | 1151 | 1:1 |
| DialogMinimalPerf.default | 446 | 444 | 1:1 |
| EmbedMinimalPerf.default | 1875 | 1876 | 1:1 |
| FormMinimalPerf.default | 221 | 222 | 1:1 |
| TextMinimalPerf.default | 201 | 200 | 1:1 |
| CustomToolbarPrototype.default | 1530 | 1525 | 1:1 |
| TreeMinimalPerf.default | 489 | 489 | 1:1 |
| ButtonSlotsPerf.default | 327 | 331 | 0.99:1 |
| HeaderMinimalPerf.default | 210 | 213 | 0.99:1 |
| SkeletonMinimalPerf.default | 194 | 195 | 0.99:1 |
| TableManyItemsPerf.default | 1120 | 1132 | 0.99:1 |
| ToolbarMinimalPerf.default | 538 | 541 | 0.99:1 |
| ListNestedPerf.default | 320 | 328 | 0.98:1 |
| VideoMinimalPerf.default | 427 | 437 | 0.98:1 |
| DividerMinimalPerf.default | 199 | 205 | 0.97:1 |
| DropdownManyItemsPerf.default | 410 | 422 | 0.97:1 |
| ItemLayoutMinimalPerf.default | 713 | 737 | 0.97:1 |
| RefMinimalPerf.default | 106 | 109 | 0.97:1 |
| AttachmentSlotsPerf.default | 674 | 701 | 0.96:1 |
| CardMinimalPerf.default | 300 | 311 | 0.96:1 |
| PortalMinimalPerf.default | 80 | 83 | 0.96:1 |
| SegmentMinimalPerf.default | 197 | 206 | 0.96:1 |
| StatusMinimalPerf.default | 386 | 401 | 0.96:1 |
📊 Bundle size report
Unchanged fixtures
|
🕵 FluentUIV0 No visual regressions between this PR and main |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 612 | 621 | 5000 | |
| Breadcrumb | mount | 1682 | 1726 | 1000 | |
| Checkbox | mount | 1717 | 1720 | 5000 | |
| CheckboxBase | mount | 1469 | 1495 | 5000 | |
| ChoiceGroup | mount | 3027 | 3011 | 5000 | |
| ComboBox | mount | 668 | 692 | 1000 | |
| CommandBar | mount | 6448 | 6411 | 1000 | |
| ContextualMenu | mount | 12069 | 11973 | 1000 | |
| DefaultButton | mount | 778 | 795 | 5000 | |
| DetailsRow | mount | 2196 | 2235 | 5000 | |
| DetailsRowFast | mount | 2226 | 2224 | 5000 | |
| DetailsRowNoStyles | mount | 2045 | 2016 | 5000 | |
| Dialog | mount | 2815 | 2835 | 1000 | |
| DocumentCardTitle | mount | 230 | 224 | 1000 | |
| Dropdown | mount | 2032 | 2015 | 5000 | |
| FocusTrapZone | mount | 1148 | 1140 | 5000 | |
| FocusZone | mount | 1081 | 1085 | 5000 | |
| GroupedList | mount | 37663 | 42181 | 2 | |
| GroupedList | virtual-rerender | 18229 | 20038 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 51564 | 50986 | 2 | |
| GroupedListV2 | mount | 225 | 234 | 2 | |
| GroupedListV2 | virtual-rerender | 215 | 215 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 227 | 242 | 2 | |
| IconButton | mount | 1103 | 1083 | 5000 | |
| Label | mount | 346 | 344 | 5000 | |
| Layer | mount | 2741 | 2776 | 5000 | |
| Link | mount | 397 | 403 | 5000 | |
| MenuButton | mount | 974 | 987 | 5000 | |
| MessageBar | mount | 21361 | 21396 | 5000 | |
| Nav | mount | 2046 | 2024 | 1000 | |
| OverflowSet | mount | 774 | 786 | 5000 | |
| Panel | mount | 1842 | 1819 | 1000 | |
| Persona | mount | 739 | 758 | 1000 | |
| Pivot | mount | 889 | 913 | 1000 | |
| PrimaryButton | mount | 906 | 945 | 5000 | |
| Rating | mount | 4699 | 4732 | 5000 | |
| SearchBox | mount | 934 | 916 | 5000 | |
| Shimmer | mount | 1904 | 1907 | 5000 | |
| Slider | mount | 1368 | 1337 | 5000 | |
| SpinButton | mount | 2987 | 3020 | 5000 | |
| Spinner | mount | 388 | 399 | 5000 | |
| SplitButton | mount | 1899 | 1866 | 5000 | |
| Stack | mount | 411 | 414 | 5000 | |
| StackWithIntrinsicChildren | mount | 848 | 874 | 5000 | |
| StackWithTextChildren | mount | 2667 | 2701 | 5000 | |
| SwatchColorPicker | mount | 6347 | 6431 | 5000 | |
| TagPicker | mount | 1499 | 1497 | 5000 | |
| Text | mount | 369 | 370 | 5000 | |
| TextField | mount | 945 | 927 | 5000 | |
| ThemeProvider | mount | 834 | 857 | 5000 | |
| ThemeProvider | virtual-rerender | 578 | 587 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1276 | 1300 | 5000 | |
| Toggle | mount | 608 | 627 | 5000 | |
| buttonNative | mount | 190 | 192 | 5000 |
fabricteam
reviewed
Jun 6, 2024
Hotell
force-pushed
the
type-checking-perf/apply/teams-3
branch
from
01621ee to
0982e70
Compare
fabricteam
reviewed
Jun 10, 2024
…stories) - teams-prg /3rd batch
Hotell
force-pushed
the
type-checking-perf/apply/teams-3
branch
from
0982e70 to
22b7ae4
Compare
Hotell
requested review from
a team,
JustSlone,
jurokapsiar and
tudorpopams
as code owners
mainframev
pushed a commit
to mainframev/fluentui
that referenced
this pull request
Jun 11, 2024
…stories) - teams-prg /3rd batch (microsoft#31601)
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Jun 11, 2024
…-and-drawer-compat * master: (43 commits) chore: remove react-alert from monorepo (microsoft#31642) docs(react-skeleton): extend Skeleton story with SkeletonItem examples (microsoft#31608) feat(react-motion): add support for params (microsoft#31566) applying package updates fix: show default title action in dialog body for modal dialogs (microsoft#31648) chore:(react-nav-preview)Remove redundant NavDrawerHeaderNav component. (microsoft#31646) Update Accordion Size story to allow collapsing (microsoft#31624) fix(react-accordion): deprecate navigation prop (microsoft#31587) fix: Drawer story accessibility fixes and docs update (microsoft#31570) feat:(react-nav-preview) Adds small size variant (microsoft#31589) feat: update divider to use element internals (microsoft#31627) chore(react-components): split react libraries in two (/library and /stories) - teams-prg /3rd batch (microsoft#31601) chore:(docs) Adding Jest testing document (microsoft#31554) chore(react-components): split react libraries in two (/library and /stories) - teams-prg /2nd batch (microsoft#31600) build(deps): bump tar from 6.1.11 to 6.2.1 (microsoft#31633) applying package updates fix: allow updating of CSS properties when they are already defined (microsoft#31629) fix: corrects the border-color for switch when in the checked state on rest (microsoft#31628) chore: update Switch to leverage ElementInternals via Checkbox (microsoft#31613) chore: update temporarily codeowners for split-in-two migrated packages to maintain proper PR review assignemnt for outdated branches (microsoft#31616) ...
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Jun 11, 2024
* master: (43 commits) chore: remove react-alert from monorepo (microsoft#31642) docs(react-skeleton): extend Skeleton story with SkeletonItem examples (microsoft#31608) feat(react-motion): add support for params (microsoft#31566) applying package updates fix: show default title action in dialog body for modal dialogs (microsoft#31648) chore:(react-nav-preview)Remove redundant NavDrawerHeaderNav component. (microsoft#31646) Update Accordion Size story to allow collapsing (microsoft#31624) fix(react-accordion): deprecate navigation prop (microsoft#31587) fix: Drawer story accessibility fixes and docs update (microsoft#31570) feat:(react-nav-preview) Adds small size variant (microsoft#31589) feat: update divider to use element internals (microsoft#31627) chore(react-components): split react libraries in two (/library and /stories) - teams-prg /3rd batch (microsoft#31601) chore:(docs) Adding Jest testing document (microsoft#31554) chore(react-components): split react libraries in two (/library and /stories) - teams-prg /2nd batch (microsoft#31600) build(deps): bump tar from 6.1.11 to 6.2.1 (microsoft#31633) applying package updates fix: allow updating of CSS properties when they are already defined (microsoft#31629) fix: corrects the border-color for switch when in the checked state on rest (microsoft#31628) chore: update Switch to leverage ElementInternals via Checkbox (microsoft#31613) chore: update temporarily codeowners for split-in-two migrated packages to maintain proper PR review assignemnt for outdated branches (microsoft#31616) ...
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
Jun 14, 2024
…stories) - teams-prg /3rd batch (microsoft#31601)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
Note
Based on RFC v9 react packages are split in two: #30514
Package/Scaffold changes:
yarn nx g @fluentui/workspace-plugin:split-library-in-two --project @fluentui/react-<name>Related Issue(s)