Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(react-components): split react libraries in two (/library and /stories) - teams-prg #31582

Closed
wants to merge 6 commits into from
Closed

chore(react-components): split react libraries in two (/library and /stories) - teams-prg #31582

wants to merge 6 commits into from

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Jun 5, 2024

Previous Behavior

New Behavior

Note

Based on RFC v9 react packages are split in two: #30514

Package/Scaffold changes:
package split changes within react-components. before and after.

  • this PR applies the migration for cxe-prg owned packages
    • fully automated via yarn nx g @fluentui/workspace-plugin:split-library-in-two --project @fluentui/react-<name>
  • api.md files needed to be re-generated ( only formatting changes - caused by inconsistent api-extractor parser )

Related Issue(s)

@github-actions github-actions bot added this to the April Project Cycle Q1 2024 milestone Jun 5, 2024
@Hotell Hotell force-pushed the type-checking-perf/apply/teams branch from 3c83373 to e5ec9ed Compare June 5, 2024 14:22
@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Jun 5, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

fabricteam
fabricteam reviewed Jun 5, 2024
View reviewed changes
.github/CODEOWNERS
@@ -144,7 +144,8 @@ packages/merge-styles @dzearing @microsoft/cxe-red
packages/monaco-editor @microsoft/fluentui-v8-website
Copy link
Collaborator

@fabricteam fabricteam Jun 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵 fluentui-web-components-v3 Open the Visual Regressions report to inspect the affected screenshots

Accordion 3 screenshots
Image Name Diff(in Pixels) Image Type
Accordion.Size.normal.chromium.png 2 Changed
Accordion.Size - RTL.normal.chromium.png 2 Changed
Accordion.Size - Dark Mode.normal.chromium.png 2 Changed
Avatar 5 screenshots
Image Name Diff(in Pixels) Image Type
Avatar.Active Appearance - Dark Mode.normal.chromium.png 2 Changed
Avatar.Active Appearance.normal.chromium.png 10 Changed
Avatar.Color.normal.chromium.png 1 Changed
Avatar.Active.normal.chromium.png 5 Changed
Avatar.Color - RTL.normal.chromium.png 1 Changed
Badge 6 screenshots
Image Name Diff(in Pixels) Image Type
Badge.Shape.normal.chromium.png 1 Changed
Badge.Appearance.normal.chromium.png 1 Changed
Badge.Size.normal.chromium.png 6 Changed
Badge.Appearance - Dark Mode.normal.chromium.png 15 Changed
Badge.Default.normal.chromium.png 1 Changed
Badge.Color.normal.chromium.png 1 Changed
Button 15 screenshots
Image Name Diff(in Pixels) Image Type
Button.Large Icon Only.default.chromium.png 5 Changed
Button.Large Icon Only - Dark Mode.pressed.chromium.png 5 Changed
Button.Large Icon Only.hover.chromium.png 4 Changed
Button.Large Icon Only.pressed.chromium.png 3 Changed
Button.Large With Icon - Dark Mode.default.chromium.png 4 Changed
Button.Large With Icon - Dark Mode.pressed.chromium.png 5 Changed
Button.Large With Icon.default.chromium.png 5 Changed
Button.Large With Icon.hover.chromium.png 4 Changed
Button.Large Icon Only - Dark Mode.hover.chromium.png 3 Changed
Button.Large With Icon - Dark Mode.hover.chromium.png 3 Changed
Button.Large With Icon - RTL.default.chromium.png 5 Changed
Button.Large With Icon - RTL.pressed.chromium.png 3 Changed
Button.Large With Icon.pressed.chromium.png 3 Changed
Button.Large Icon Only - Dark Mode.default.chromium.png 4 Changed
Button.Large With Icon - RTL.hover.chromium.png 4 Changed
Divider 3 screenshots
Image Name Diff(in Pixels) Image Type
Divider.With Svg.normal.chromium.png 3 Changed
Divider.With Svg - RTL.normal.chromium.png 3 Changed
Divider.Vertical With Svg.normal.chromium.png 4 Changed
MenuList 16 screenshots
Image Name Diff(in Pixels) Image Type
MenuList.Checkbox With Icons - RTL.normal.chromium.png 4 Changed
MenuList.Checkbox.2nd selected.chromium.png 1 Changed
MenuList.Checkbox With Icons - RTL.1st selected.chromium.png 4 Changed
MenuList.Checkbox With Icons - RTL.2nd selected.chromium.png 5 Changed
MenuList.Checkbox With Icons.2nd selected.chromium.png 5 Changed
MenuList.Checkbox - RTL.2nd selected.chromium.png 1 Changed
MenuList.Checkbox With Icons.normal.chromium.png 4 Changed
MenuList.Radio With Icons.2nd selected.chromium.png 4 Changed
MenuList.Radio With Icons - RTL.1st selected.chromium.png 4 Changed
MenuList.Radio With Icons.1st selected.chromium.png 4 Changed
MenuList.Radio With Icons - RTL.normal.chromium.png 4 Changed
MenuList.Radio With Icons - RTL.2nd selected.chromium.png 4 Changed
MenuList.Radio With Icons.normal.chromium.png 4 Changed
MenuList.Checkbox With Icons.1st selected.chromium.png 4 Changed
MenuList.With Icons.normal.chromium.png 4 Changed
MenuList.With Icons.hover menuitem.chromium.png 3 Changed
Slider 2 screenshots
Image Name Diff(in Pixels) Image Type
Slider.Size Small.normal.chromium.png 1 Changed
Slider.Size Small.rightArrow.chromium.png 1 Changed
Switch 2 screenshots
Image Name Diff(in Pixels) Image Type
Switch.Checked.hover.chromium.png 1 Changed
Switch.Checked - RTL.hover.chromium.png 1 Changed
Text 1 screenshots
Image Name Diff(in Pixels) Image Type
Text.Block.normal.chromium.png 995 Changed
TextInput 1 screenshots
Image Name Diff(in Pixels) Image Type
TextInput.Size Large.normal.chromium.png 2 Changed

@fabricteam
Copy link
Collaborator

fabricteam commented Jun 5, 2024 •
edited
Loading

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-alert
Alert		 78.817 kB
22.543 kB		 78.819 kB
22.545 kB		 2 B
2 B
react-dialog
Dialog (including children components)		 99.313 kB
29.997 kB		 99.313 kB
30 kB
3 B
react-menu
Menu (including children components)		 152.023 kB
45.98 kB		 152.023 kB
45.982 kB
2 B
react-menu
Menu (including selectable components)		 154.709 kB
46.477 kB		 154.709 kB
46.478 kB
1 B
react-message-bar
MessageBar (all components)		 24.411 kB
9.114 kB		 24.413 kB
9.117 kB		 2 B
3 B
react-overflow
hooks only		 12.87 kB
4.83 kB		 12.868 kB
4.828 kB		 -2 B
-2 B
react-provider
FluentProvider		 24.616 kB
8.903 kB		 24.618 kB
8.906 kB		 2 B
3 B
react-table
DataGrid		 162.843 kB
46.317 kB		 162.843 kB
46.318 kB
1 B
react-table
Table (Primitives only)		 42.48 kB
13.866 kB		 42.482 kB
13.868 kB		 2 B
2 B
react-table
Table as DataGrid		 131.934 kB
36.682 kB		 131.936 kB
36.686 kB		 2 B
4 B
react-table
Table (Selection only)		 70.334 kB
20.026 kB		 70.336 kB
20.028 kB		 2 B
2 B
react-table
Table (Sort only)		 68.977 kB
19.63 kB		 68.979 kB
19.633 kB		 2 B
3 B
react-tag-picker
@fluentui/react-tag-picker - package		 181.063 kB
54.547 kB		 181.063 kB
54.549 kB
2 B
react-tags
InteractionTag		 15.165 kB
6.134 kB		 15.167 kB
6.135 kB		 2 B
1 B
react-tags
Tag		 28.994 kB
9.518 kB		 28.996 kB
9.52 kB		 2 B
2 B
react-tags
TagGroup		 82.911 kB
24.642 kB		 82.913 kB
24.643 kB		 2 B
1 B
react-toast
Toast (including Toaster)		 97.868 kB
29.513 kB		 97.87 kB
29.516 kB		 2 B
3 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext		 510 B
328 B
global-context
createContextSelector		 537 B
339 B
keyboard-key
keyboard-key package		 3.746 kB
1.928 kB
priority-overflow
createOverflowManager		 4.457 kB
1.856 kB
react
ActivityItem		 71.019 kB
23.288 kB
react
Announced		 38.291 kB
13.239 kB
react
Autofill		 15.365 kB
4.743 kB
react
Breadcrumb		 201.877 kB
60.317 kB
react
Button		 195.341 kB
56.521 kB
react
ButtonGrid		 180.288 kB
54.565 kB
react
Calendar		 121.542 kB
36.943 kB
react
Callout		 84.108 kB
27.552 kB
react
Check		 52.963 kB
17.773 kB
react
Checkbox		 59.751 kB
19.806 kB
react
ChoiceGroup		 65.276 kB
21.438 kB
react
ChoiceGroupOption		 58.531 kB
19.309 kB
react
Coachmark		 92.937 kB
29.356 kB
react
Color		 7.737 kB
3.106 kB
react
ColorPicker		 132.985 kB
41.502 kB
react
ComboBox		 251.642 kB
72.135 kB
react
CommandBar		 202.91 kB
60.025 kB
react
ContextualMenu		 154.87 kB
48.119 kB
react
DatePicker		 183.939 kB
56.079 kB
react
DateTimeUtilities		 5.244 kB
1.849 kB
react
DetailsList		 229.317 kB
65.63 kB
react
Dialog		 211.201 kB
63.036 kB
react
Divider		 19.399 kB
6.798 kB
react
DocumentCard		 216.886 kB
64.32 kB
react
DragDrop		 8.343 kB
2.724 kB
react
DraggableZone		 34.109 kB
11.448 kB
react
Dropdown		 233.807 kB
68.507 kB
react
ExtendedPicker		 96.565 kB
27.809 kB
react
Fabric		 41.537 kB
14.283 kB
react
Facepile		 210.458 kB
63.087 kB
react
FloatingPicker		 241.932 kB
68.878 kB
react
FocusTrapZone		 16.975 kB
5.917 kB
react
FocusZone		 54.844 kB
17.402 kB
react
Grid		 180.288 kB
54.565 kB
react
GroupedList		 134.634 kB
40.596 kB
react
GroupedListV2		 122.251 kB
37.703 kB
react
HoverCard		 96.969 kB
30.741 kB
react
Icon		 51.644 kB
17.197 kB
react
Icons		 66.305 kB
24.379 kB
react
Image		 46.701 kB
15.646 kB
react
Keytip		 81.482 kB
26.712 kB
react
KeytipData		 13.969 kB
4.57 kB
react
KeytipLayer		 103.278 kB
31.961 kB
react
Keytips		 106.046 kB
32.966 kB
react
Label		 38.134 kB
13.207 kB
react
Layer		 47.887 kB
16.295 kB
react
Link		 39.488 kB
13.614 kB
react
List		 39.176 kB
12.384 kB
react
MarqueeSelection		 74.321 kB
22.385 kB
react
MessageBar		 190.392 kB
56.991 kB
react
Modal		 93.44 kB
30.18 kB
react
Nav		 187.87 kB
56.43 kB
react
OverflowSet		 33.191 kB
11.252 kB
react
Overlay		 40.694 kB
14.023 kB
react
Panel		 200.912 kB
59.92 kB
react
Persona		 114.617 kB
36.442 kB
react
PersonaCoin		 114.617 kB
36.442 kB
react
PersonaPresence		 57.833 kB
19.303 kB
react
Pickers		 293.618 kB
82.223 kB
react
Pivot		 188.784 kB
57.162 kB
react
Popup		 12.242 kB
4.181 kB
react
Positioning		 22.608 kB
7.63 kB
react
PositioningContainer		 73.643 kB
23.706 kB
react
ProgressIndicator		 39.286 kB
13.482 kB
react
Rating		 81.762 kB
26.057 kB
react
Fluent UI React (entire library)		 1.013 MB
281.343 kB
react
ResizeGroup		 13.286 kB
4.365 kB
react
ResponsiveMode		 8.078 kB
2.95 kB
react
ScrollablePane		 55.325 kB
17.669 kB
react
SearchBox		 188.667 kB
56.595 kB
react
SelectableOption		 724 B
413 B
react
SelectedItemsList		 232.427 kB
67.829 kB
react
Selection		 42.252 kB
12.203 kB
react
Separator		 35.183 kB
12.088 kB
react
Shimmer		 49.049 kB
16.206 kB
react
ShimmeredDetailsList		 240.092 kB
68.397 kB
react
Slider		 57.449 kB
19.143 kB
react
SpinButton		 192.395 kB
57.716 kB
react
Spinner		 41.481 kB
14.412 kB
react
Stack		 41.547 kB
14.233 kB
react
Sticky		 32.541 kB
10.49 kB
react
Styling		 45.853 kB
15.082 kB
react
SwatchColorPicker		 190.614 kB
58.051 kB
react
TeachingBubble		 205.667 kB
60.945 kB
react
Text		 36.723 kB
12.763 kB
react
TextField		 80.555 kB
25.262 kB
react
Theme		 43.321 kB
14.129 kB
react
ThemeGenerator		 12.34 kB
4.106 kB
react
TimePicker		 241.446 kB
69.904 kB
react
Toggle		 46.02 kB
15.903 kB
react
Tooltip		 87.136 kB
28.164 kB
react
Utilities		 82.495 kB
25.047 kB
react
Viewport		 23.703 kB
7.589 kB
react
WeeklyDayPicker		 101.682 kB
31.738 kB
react
WindowProvider		 1.059 kB
541 B
react-accordion
Accordion (including children components)		 100.008 kB
30.527 kB
react-avatar
Avatar		 49.299 kB
15.837 kB
react-avatar
AvatarGroup		 20.107 kB
7.973 kB
react-avatar
AvatarGroupItem		 63.316 kB
20.017 kB
react-badge
Badge		 25.95 kB
8.612 kB
react-badge
CounterBadge		 26.729 kB
8.886 kB
react-badge
PresenceBadge		 25.717 kB
9.483 kB
react-breadcrumb
@fluentui/react-breadcrumb - package		 114.486 kB
31.821 kB
react-button
Button		 37.103 kB
10.784 kB
react-button
CompoundButton		 43.514 kB
12.074 kB
react-button
MenuButton		 41.884 kB
12.132 kB
react-button
SplitButton		 49.896 kB
13.724 kB
react-button
ToggleButton		 53.03 kB
12.543 kB
react-calendar-compat
Calendar Compat		 150.314 kB
40.099 kB
react-card
Card - All		 101.184 kB
29.049 kB
react-card
Card		 94.218 kB
27.333 kB
react-card
CardFooter		 14.354 kB
5.795 kB
react-card
CardHeader		 16.618 kB
6.555 kB
react-card
CardPreview		 14.418 kB
5.931 kB
react-checkbox
Checkbox		 35.103 kB
12.11 kB
react-combobox
Combobox (including child components)		 100.496 kB
33.156 kB
react-combobox
Dropdown (including child components)		 101.129 kB
33.096 kB
react-components
react-components: Button, FluentProvider & webLightTheme		 69.141 kB
20.157 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 212.636 kB
61.23 kB
react-components
react-components: FluentProvider & webLightTheme		 44.442 kB
14.607 kB
react-components
react-components: entire library		 1.092 MB
269.637 kB
react-datepicker-compat
DatePicker Compat		 223.895 kB
63.417 kB
react-divider
Divider		 21.326 kB
7.963 kB
react-field
Field		 23.382 kB
8.901 kB
react-image
Image		 15.36 kB
6.245 kB
react-input
Input		 27.985 kB
9.444 kB
react-jsx-runtime
Classic Pragma		 1.057 kB
530 B
react-jsx-runtime
JSX Dev Runtime		 3.781 kB
1.646 kB
react-jsx-runtime
JSX Runtime		 4.377 kB
1.881 kB
react-label
Label		 14.67 kB
6 kB
react-link
Link		 17.191 kB
6.991 kB
react-persona
Persona		 56.19 kB
17.726 kB
react-popover
Popover		 127.766 kB
40.096 kB
react-portal
Portal		 14.563 kB
5.118 kB
react-positioning
usePositioning		 26.489 kB
9.552 kB
react-progress
ProgressBar		 17.084 kB
6.904 kB
react-radio
Radio		 32.671 kB
10.348 kB
react-radio
RadioGroup		 15.758 kB
6.431 kB
react-select
Select		 27.636 kB
10.106 kB
react-slider
Slider		 37.168 kB
12.543 kB
react-spinbutton
SpinButton		 36.047 kB
11.833 kB
react-spinner
Spinner		 25.244 kB
8.552 kB
react-swatch-picker
@fluentui/react-swatch-picker - package		 104.378 kB
30.355 kB
react-switch
Switch		 35.299 kB
11.345 kB
react-text
Text - Default		 17.061 kB
6.731 kB
react-text
Text - Wrappers		 20.233 kB
7.061 kB
react-textarea
Textarea		 26.519 kB
9.739 kB
react-theme
Single theme token import		 69 B
89 B
react-theme
Teams: all themes		 35.666 kB
7.453 kB
react-theme
Teams: Light theme		 19.642 kB
5.549 kB
react-tooltip
Tooltip		 54.556 kB
19.226 kB
react-utilities
SSRProvider		 180 B
160 B
🤖 This report was generated against 48ff23e70fe47f8f91dcbaceb0cb7f3621bca339

@fabricteam
Copy link
Collaborator

fabricteam commented Jun 5, 2024 •
edited
Loading

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 611 623 5000
Button mount 310 325 5000
Field mount 1116 1129 5000
FluentProvider mount 712 707 5000
FluentProviderWithTheme mount 89 80 10
FluentProviderWithTheme virtual-rerender 38 35 10
FluentProviderWithTheme virtual-rerender-with-unmount 75 79 10
MakeStyles mount 873 867 50000
Persona mount 1735 1724 5000
SpinButton mount 1377 1386 5000
SwatchPicker mount 1515 1500 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Jun 5, 2024 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ButtonMinimalPerf.default 96 85 1.13:1
FlexMinimalPerf.default 161 144 1.12:1
PortalMinimalPerf.default 86 77 1.12:1
ButtonSlotsPerf.default 329 297 1.11:1
ImageMinimalPerf.default 227 206 1.1:1
TextAreaMinimalPerf.default 301 274 1.1:1
VideoMinimalPerf.default 456 418 1.09:1
AttachmentMinimalPerf.default 83 77 1.08:1
TableMinimalPerf.default 247 231 1.07:1
BoxMinimalPerf.default 203 191 1.06:1
CardMinimalPerf.default 307 289 1.06:1
DividerMinimalPerf.default 211 199 1.06:1
FormMinimalPerf.default 232 219 1.06:1
TextMinimalPerf.default 194 183 1.06:1
AvatarMinimalPerf.default 108 103 1.05:1
CarouselMinimalPerf.default 263 250 1.05:1
ChatDuplicateMessagesPerf.default 152 145 1.05:1
DropdownManyItemsPerf.default 386 367 1.05:1
LayoutMinimalPerf.default 196 187 1.05:1
InputMinimalPerf.default 560 539 1.04:1
ListMinimalPerf.default 315 303 1.04:1
PopupMinimalPerf.default 358 345 1.04:1
ChatMinimalPerf.default 455 441 1.03:1
LabelMinimalPerf.default 221 215 1.03:1
AlertMinimalPerf.default 158 155 1.02:1
GridMinimalPerf.default 187 183 1.02:1
ListCommonPerf.default 394 385 1.02:1
SkeletonMinimalPerf.default 196 192 1.02:1
CustomToolbarPrototype.default 1461 1426 1.02:1
ToolbarMinimalPerf.default 544 534 1.02:1
DatepickerMinimalPerf.default 3569 3522 1.01:1
DropdownMinimalPerf.default 1413 1398 1.01:1
HeaderSlotsPerf.default 459 454 1.01:1
ListNestedPerf.default 310 308 1.01:1
MenuMinimalPerf.default 504 500 1.01:1
MenuButtonMinimalPerf.default 945 935 1.01:1
ProviderMergeThemesPerf.default 654 649 1.01:1
RefMinimalPerf.default 112 111 1.01:1
SliderMinimalPerf.default 765 757 1.01:1
TooltipMinimalPerf.default 1268 1250 1.01:1
DialogMinimalPerf.default 435 434 1:1
EmbedMinimalPerf.default 1829 1827 1:1
ItemLayoutMinimalPerf.default 717 714 1:1
RosterPerf.default 1533 1529 1:1
ProviderMinimalPerf.default 205 204 1:1
ReactionMinimalPerf.default 215 216 1:1
TableManyItemsPerf.default 1081 1079 1:1
AnimationMinimalPerf.default 284 287 0.99:1
ButtonOverridesMissPerf.default 630 639 0.99:1
ChatWithPopoverPerf.default 197 200 0.99:1
RadioGroupMinimalPerf.default 251 254 0.99:1
SegmentMinimalPerf.default 186 188 0.99:1
AttachmentSlotsPerf.default 633 649 0.98:1
HeaderMinimalPerf.default 199 203 0.98:1
SplitButtonMinimalPerf.default 2235 2280 0.98:1
TreeMinimalPerf.default 475 487 0.98:1
CheckboxMinimalPerf.default 1101 1131 0.97:1
ListWith60ListItems.default 365 375 0.97:1
IconMinimalPerf.default 388 402 0.97:1
TreeWith60ListItems.default 89 92 0.97:1
LoaderMinimalPerf.default 189 196 0.96:1
StatusMinimalPerf.default 392 407 0.96:1
AccordionMinimalPerf.default 75 79 0.95:1

@fabricteam
Copy link
Collaborator

fabricteam commented Jun 5, 2024 •
edited
Loading

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Jun 5, 2024 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 641 624 5000
Breadcrumb mount 1693 1678 1000
Checkbox mount 1687 1705 5000
CheckboxBase mount 1476 1458 5000
ChoiceGroup mount 2984 2990 5000
ComboBox mount 651 670 1000
CommandBar mount 6461 6479 1000
ContextualMenu mount 12363 12891 1000
DefaultButton mount 785 791 5000
DetailsRow mount 2226 2232 5000
DetailsRowFast mount 2196 2233 5000
DetailsRowNoStyles mount 2024 2037 5000
Dialog mount 2754 2830 1000
DocumentCardTitle mount 232 215 1000
Dropdown mount 2010 2009 5000
FocusTrapZone mount 1102 1147 5000
FocusZone mount 1078 1068 5000
GroupedList mount 42289 42176 2
GroupedList virtual-rerender 20180 20170 2
GroupedList virtual-rerender-with-unmount 51407 51336 2
GroupedListV2 mount 223 230 2
GroupedListV2 virtual-rerender 203 209 2
GroupedListV2 virtual-rerender-with-unmount 218 223 2
IconButton mount 1149 1117 5000
Label mount 337 344 5000
Layer mount 2803 2764 5000
Link mount 390 407 5000
MenuButton mount 966 1027 5000
MessageBar mount 21206 21501 5000
Nav mount 2016 2020 1000
OverflowSet mount 777 772 5000
Panel mount 1804 1877 1000
Persona mount 747 742 1000
Pivot mount 889 898 1000
PrimaryButton mount 948 924 5000
Rating mount 4644 4729 5000
SearchBox mount 917 939 5000
Shimmer mount 1885 1920 5000
Slider mount 1308 1324 5000
SpinButton mount 2966 3012 5000
Spinner mount 389 404 5000
SplitButton mount 1882 1877 5000
Stack mount 413 411 5000
StackWithIntrinsicChildren mount 843 872 5000
StackWithTextChildren mount 2685 2629 5000
SwatchColorPicker mount 6324 6315 5000
TagPicker mount 1447 1487 5000
Text mount 375 379 5000
TextField mount 931 944 5000
ThemeProvider mount 854 836 5000
ThemeProvider virtual-rerender 592 582 5000
ThemeProvider virtual-rerender-with-unmount 1325 1300 5000
Toggle mount 622 600 5000
buttonNative mount 194 191 5000

fabricteam
fabricteam reviewed Jun 5, 2024
View reviewed changes
.github/CODEOWNERS
@@ -144,7 +144,8 @@ packages/merge-styles @dzearing @microsoft/cxe-red
packages/monaco-editor @microsoft/fluentui-v8-website
Copy link
Collaborator

@fabricteam fabricteam Jun 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵 fluentuiv9 Open the Visual Regressions report to inspect the affected screenshots

Avatar Converged 1 screenshots
Image Name Diff(in Pixels) Image Type
Avatar Converged.badgeMask.normal.chromium.png 3 Changed
Card Converged 1 screenshots
Image Name Diff(in Pixels) Image Type
Card Converged.appearance - RTL.normal.chromium.png 0 Added
Card Converged - Interactive 3 screenshots
Image Name Diff(in Pixels) Image Type
Card Converged - Interactive.appearance interactive - Filled - High Contrast.click.chromium.png 0 Added
Card Converged - Interactive.appearance interactive - Filled - High Contrast.hover.chromium.png 0 Added
Card Converged - Interactive.appearance interactive - Filled - High Contrast.normal.chromium.png 0 Added
Card Converged - Selectable 4 screenshots
Image Name Diff(in Pixels) Image Type
Card Converged - Selectable.appearance selectable - Outline - Dark Mode.click.chromium.png 0 Removed
Card Converged - Selectable.appearance selectable - Outline - Dark Mode.hover.chromium.png 0 Removed
Card Converged - Selectable.appearance selectable - Outline - Dark Mode.normal.chromium.png 0 Removed
Card Converged - Selectable.appearance selectable - Outline - Dark Mode.selected.chromium.png 0 Removed

@Hotell Hotell mentioned this pull request Jun 5, 2024
Closed
17 tasks
@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Jun 5, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Jun 5, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

fabricteam
fabricteam reviewed Jun 5, 2024
View reviewed changes
.github/CODEOWNERS
@@ -144,7 +144,8 @@ packages/merge-styles @dzearing @microsoft/cxe-red
packages/monaco-editor @microsoft/fluentui-v8-website
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵 fluentuiv8 Open the Visual Regressions report to inspect the affected screenshots

Pivot - Overflow 4 screenshots
Image Name Diff(in Pixels) Image Type
Pivot - Overflow.Root.Narrow - Last tab selected.chromium.png 0 Removed
Pivot - Overflow.Root.Narrow - Overflow menu.chromium.png 0 Removed
Pivot - Overflow.Tabs - RTL.Narrow - Last tab selected.chromium.png 0 Removed
Pivot - Overflow.Tabs - RTL.Narrow - Overflow menu.chromium.png 0 Removed

@Hotell Hotell closed this Jun 10, 2024
@Hotell Hotell deleted the type-checking-perf/apply/teams branch June 10, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabricteam fabricteam fabricteam left review comments

@chpalac chpalac Awaiting requested review from chpalac chpalac will be requested when the pull request is marked ready for review chpalac is a code owner

@ling1726 ling1726 Awaiting requested review from ling1726 ling1726 will be requested when the pull request is marked ready for review ling1726 is a code owner

@JustSlone JustSlone Awaiting requested review from JustSlone JustSlone will be requested when the pull request is marked ready for review JustSlone is a code owner

@jurokapsiar jurokapsiar Awaiting requested review from jurokapsiar jurokapsiar will be requested when the pull request is marked ready for review jurokapsiar is a code owner

@tudorpopams tudorpopams Awaiting requested review from tudorpopams tudorpopams will be requested when the pull request is marked ready for review tudorpopams is a code owner

Assignees
No one assigned
Labels
Fluent UI react-components (v9)
Projects
None yet
Milestone
April Project Cycle Q1 2024
Development

Successfully merging this pull request may close these issues.
2 participants
@Hotell @fabricteam