-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(react-components): split react libraries in two (/library and /stories) - last batch #31581
chore(react-components): split react libraries in two (/library and /stories) - last batch #31581
Conversation
f2c80d9
to
c0ba110
Compare
📊 Bundle size reportUnchanged fixtures
|
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 625 | 596 | 5000 | |
Button | mount | 301 | 317 | 5000 | |
Field | mount | 1161 | 1131 | 5000 | |
FluentProvider | mount | 731 | 719 | 5000 | |
FluentProviderWithTheme | mount | 82 | 76 | 10 | |
FluentProviderWithTheme | virtual-rerender | 35 | 35 | 10 | |
FluentProviderWithTheme | virtual-rerender-with-unmount | 77 | 70 | 10 | |
MakeStyles | mount | 842 | 866 | 50000 | |
Persona | mount | 1743 | 1721 | 5000 | |
SpinButton | mount | 1389 | 1382 | 5000 | |
SwatchPicker | mount | 1564 | 1531 | 5000 |
Perf Analysis (
|
Scenario | Current PR Ticks | Baseline Ticks | Ratio | Regression Analysis |
---|---|---|---|---|
PortalMinimalPerf.default | 88 | 84 | 1.05:1 | analysis |
Perf tests with no regressions
Scenario | Current PR Ticks | Baseline Ticks | Ratio |
---|---|---|---|
AvatarMinimalPerf.default | 118 | 96 | 1.23:1 |
ChatDuplicateMessagesPerf.default | 160 | 143 | 1.12:1 |
DropdownManyItemsPerf.default | 409 | 376 | 1.09:1 |
RefMinimalPerf.default | 119 | 110 | 1.08:1 |
HeaderSlotsPerf.default | 474 | 446 | 1.06:1 |
ImageMinimalPerf.default | 229 | 216 | 1.06:1 |
VideoMinimalPerf.default | 434 | 410 | 1.06:1 |
ChatWithPopoverPerf.default | 203 | 193 | 1.05:1 |
DividerMinimalPerf.default | 214 | 203 | 1.05:1 |
TextMinimalPerf.default | 203 | 193 | 1.05:1 |
BoxMinimalPerf.default | 198 | 190 | 1.04:1 |
GridMinimalPerf.default | 190 | 183 | 1.04:1 |
LayoutMinimalPerf.default | 206 | 198 | 1.04:1 |
StatusMinimalPerf.default | 409 | 392 | 1.04:1 |
ButtonSlotsPerf.default | 325 | 315 | 1.03:1 |
ChatMinimalPerf.default | 452 | 438 | 1.03:1 |
ListCommonPerf.default | 398 | 386 | 1.03:1 |
AnimationMinimalPerf.default | 307 | 301 | 1.02:1 |
CardMinimalPerf.default | 316 | 311 | 1.02:1 |
DropdownMinimalPerf.default | 1448 | 1417 | 1.02:1 |
EmbedMinimalPerf.default | 1876 | 1846 | 1.02:1 |
MenuMinimalPerf.default | 526 | 515 | 1.02:1 |
IconMinimalPerf.default | 409 | 402 | 1.02:1 |
TooltipMinimalPerf.default | 1304 | 1284 | 1.02:1 |
TreeMinimalPerf.default | 492 | 480 | 1.02:1 |
AlertMinimalPerf.default | 158 | 157 | 1.01:1 |
CheckboxMinimalPerf.default | 1143 | 1135 | 1.01:1 |
DatepickerMinimalPerf.default | 3878 | 3841 | 1.01:1 |
FlexMinimalPerf.default | 158 | 157 | 1.01:1 |
ListMinimalPerf.default | 308 | 306 | 1.01:1 |
PopupMinimalPerf.default | 358 | 353 | 1.01:1 |
ProviderMergeThemesPerf.default | 648 | 643 | 1.01:1 |
ProviderMinimalPerf.default | 209 | 207 | 1.01:1 |
CustomToolbarPrototype.default | 1532 | 1514 | 1.01:1 |
FormMinimalPerf.default | 211 | 211 | 1:1 |
ItemLayoutMinimalPerf.default | 715 | 716 | 1:1 |
MenuButtonMinimalPerf.default | 961 | 964 | 1:1 |
RadioGroupMinimalPerf.default | 263 | 262 | 1:1 |
SliderMinimalPerf.default | 745 | 745 | 1:1 |
AttachmentSlotsPerf.default | 650 | 657 | 0.99:1 |
HeaderMinimalPerf.default | 207 | 209 | 0.99:1 |
ListNestedPerf.default | 329 | 332 | 0.99:1 |
ListWith60ListItems.default | 363 | 365 | 0.99:1 |
SegmentMinimalPerf.default | 201 | 203 | 0.99:1 |
SkeletonMinimalPerf.default | 193 | 194 | 0.99:1 |
TableManyItemsPerf.default | 1101 | 1114 | 0.99:1 |
ToolbarMinimalPerf.default | 552 | 560 | 0.99:1 |
AccordionMinimalPerf.default | 82 | 84 | 0.98:1 |
ButtonOverridesMissPerf.default | 638 | 653 | 0.98:1 |
DialogMinimalPerf.default | 445 | 454 | 0.98:1 |
InputMinimalPerf.default | 517 | 529 | 0.98:1 |
RosterPerf.default | 1550 | 1587 | 0.98:1 |
ReactionMinimalPerf.default | 215 | 219 | 0.98:1 |
SplitButtonMinimalPerf.default | 2282 | 2318 | 0.98:1 |
ButtonMinimalPerf.default | 91 | 94 | 0.97:1 |
CarouselMinimalPerf.default | 250 | 259 | 0.97:1 |
TableMinimalPerf.default | 236 | 244 | 0.97:1 |
TextAreaMinimalPerf.default | 284 | 292 | 0.97:1 |
TreeWith60ListItems.default | 86 | 89 | 0.97:1 |
LoaderMinimalPerf.default | 190 | 200 | 0.95:1 |
AttachmentMinimalPerf.default | 77 | 82 | 0.94:1 |
LabelMinimalPerf.default | 206 | 223 | 0.92:1 |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
BaseButton | mount | 627 | 641 | 5000 | |
Breadcrumb | mount | 1689 | 1697 | 1000 | |
Checkbox | mount | 1732 | 1708 | 5000 | |
CheckboxBase | mount | 1485 | 1463 | 5000 | |
ChoiceGroup | mount | 2966 | 2947 | 5000 | |
ComboBox | mount | 688 | 690 | 1000 | |
CommandBar | mount | 6456 | 6419 | 1000 | |
ContextualMenu | mount | 11744 | 11908 | 1000 | |
DefaultButton | mount | 799 | 788 | 5000 | |
DetailsRow | mount | 2168 | 2220 | 5000 | |
DetailsRowFast | mount | 2240 | 2186 | 5000 | |
DetailsRowNoStyles | mount | 2101 | 2075 | 5000 | |
Dialog | mount | 2752 | 2663 | 1000 | |
DocumentCardTitle | mount | 233 | 227 | 1000 | |
Dropdown | mount | 1983 | 1995 | 5000 | |
FocusTrapZone | mount | 1171 | 1167 | 5000 | |
FocusZone | mount | 1113 | 1087 | 5000 | |
GroupedList | mount | 41363 | 41753 | 2 | |
GroupedList | virtual-rerender | 17913 | 19822 | 2 | |
GroupedList | virtual-rerender-with-unmount | 50447 | 51025 | 2 | |
GroupedListV2 | mount | 223 | 214 | 2 | |
GroupedListV2 | virtual-rerender | 210 | 208 | 2 | |
GroupedListV2 | virtual-rerender-with-unmount | 235 | 231 | 2 | |
IconButton | mount | 1114 | 1134 | 5000 | |
Label | mount | 341 | 335 | 5000 | |
Layer | mount | 2754 | 2758 | 5000 | |
Link | mount | 378 | 399 | 5000 | |
MenuButton | mount | 983 | 978 | 5000 | |
MessageBar | mount | 21338 | 21334 | 5000 | |
Nav | mount | 2056 | 2045 | 1000 | |
OverflowSet | mount | 777 | 776 | 5000 | |
Panel | mount | 1779 | 1864 | 1000 | |
Persona | mount | 747 | 758 | 1000 | |
Pivot | mount | 905 | 913 | 1000 | |
PrimaryButton | mount | 940 | 918 | 5000 | |
Rating | mount | 4624 | 4762 | 5000 | |
SearchBox | mount | 896 | 910 | 5000 | |
Shimmer | mount | 1886 | 1921 | 5000 | |
Slider | mount | 1339 | 1296 | 5000 | |
SpinButton | mount | 2996 | 2991 | 5000 | |
Spinner | mount | 381 | 385 | 5000 | |
SplitButton | mount | 1864 | 1898 | 5000 | |
Stack | mount | 411 | 408 | 5000 | |
StackWithIntrinsicChildren | mount | 844 | 866 | 5000 | |
StackWithTextChildren | mount | 2624 | 2680 | 5000 | |
SwatchColorPicker | mount | 6348 | 6447 | 5000 | |
TagPicker | mount | 1455 | 1454 | 5000 | |
Text | mount | 366 | 392 | 5000 | |
TextField | mount | 933 | 940 | 5000 | |
ThemeProvider | mount | 829 | 830 | 5000 | |
ThemeProvider | virtual-rerender | 570 | 578 | 5000 | |
ThemeProvider | virtual-rerender-with-unmount | 1292 | 1297 | 5000 | |
Toggle | mount | 618 | 607 | 5000 | |
buttonNative | mount | 191 | 191 | 5000 |
🕵 FluentUIV0 No visual regressions between this PR and main |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
9c0413f
to
87ab2cb
Compare
…escription * master: chore(react-list-preview): Add bundle size tests (microsoft#31658) applying package updates feat:react-nav-preview Add a handful of accessibility features for Nav (microsoft#31649) feat: refactor anchor-button to use element internals and anchor proxy element (microsoft#31653) chore:(docs) New Component doc (microsoft#31611) style(react-nav-preview): fix formatting in barel file (microsoft#31671) feat(web-components): refactor progress bar to use ElementInternals (microsoft#31652) chore(react-components): split react libraries in two (/library and /stories) - last batch (microsoft#31581) fix(scripts-beachball): ignore web-components packages from v8 release scope (microsoft#31667) chore(react-components): split react libraries in two (/library and /stories) - cxe-red /2nd batch (microsoft#31580) chore: Remove recipes-react-components in favor of recipes package (microsoft#31647) feat: Add consistent start and finish lifecycle callbacks (microsoft#31644) chore(docs): Remove requirement of performance tests from epic template (microsoft#31662) chore(react-components): split react libraries in two (/library and /stories) - cxe-red /1st batch (microsoft#31579) docs(react-swatch-picker): added SwatchPicker page to Component Mapping (microsoft#31637) docs(dev-env): update minimal node version (microsoft#31638)
* master: chore(react-list-preview): Add bundle size tests (microsoft#31658) applying package updates feat:react-nav-preview Add a handful of accessibility features for Nav (microsoft#31649) feat: refactor anchor-button to use element internals and anchor proxy element (microsoft#31653) chore:(docs) New Component doc (microsoft#31611) style(react-nav-preview): fix formatting in barel file (microsoft#31671) feat(web-components): refactor progress bar to use ElementInternals (microsoft#31652) chore(react-components): split react libraries in two (/library and /stories) - last batch (microsoft#31581) fix(scripts-beachball): ignore web-components packages from v8 release scope (microsoft#31667) chore(react-components): split react libraries in two (/library and /stories) - cxe-red /2nd batch (microsoft#31580) chore: Remove recipes-react-components in favor of recipes package (microsoft#31647) feat: Add consistent start and finish lifecycle callbacks (microsoft#31644) chore(docs): Remove requirement of performance tests from epic template (microsoft#31662) chore(react-components): split react libraries in two (/library and /stories) - cxe-red /1st batch (microsoft#31579) docs(react-swatch-picker): added SwatchPicker page to Component Mapping (microsoft#31637) docs(dev-env): update minimal node version (microsoft#31638)
…stories) - last batch (microsoft#31581)
Previous Behavior
New Behavior
Note
Based on RFC v9 react packages are split in two: #30514
Package/Scaffold changes:

yarn nx g @fluentui/workspace-plugin:split-library-in-two --project @fluentui/react-<name>
Related Issue(s)