Add contenteditable people picker prototypes #31491
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jirivyhnalek/content editable tags
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 638 | 635 | 5000 | |
| Button | mount | 295 | 306 | 5000 | |
| Field | mount | 1146 | 1151 | 5000 | |
| FluentProvider | mount | 720 | 735 | 5000 | |
| FluentProviderWithTheme | mount | 80 | 79 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 38 | 34 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 75 | 71 | 10 | |
| MakeStyles | mount | 900 | 877 | 50000 | |
| Persona | mount | 1814 | 1758 | 5000 | |
| SpinButton | mount | 1424 | 1407 | 5000 | |
| SwatchPicker | mount | 1556 | 1540 | 5000 |
fabricteam
reviewed
May 28, 2024
| @@ -88,7 +88,9 @@ | |||
| "@fluentui/react-rating": "^9.0.10", | |||
There was a problem hiding this comment.
🕵 fluentui-web-components-v3 Open the Visual Regressions report to inspect the affected screenshots
Accordion 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Accordion.Size - Dark Mode.normal.chromium.png | 2 | Changed |
| Accordion.Size.normal.chromium.png | 2 | Changed |
| Accordion.Size - RTL.normal.chromium.png | 2 | Changed |
Avatar 5 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Avatar.Active Appearance - Dark Mode.normal.chromium.png | 2 | Changed |
| Avatar.Active Appearance.normal.chromium.png | 10 | Changed |
| Avatar.Active.normal.chromium.png | 5 | Changed |
| Avatar.Color.normal.chromium.png | 1 | Changed |
| Avatar.Color - RTL.normal.chromium.png | 1 | Changed |
Badge 6 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Badge.Appearance.normal.chromium.png | 1 | Changed |
| Badge.Default.normal.chromium.png | 1 | Changed |
| Badge.Shape.normal.chromium.png | 1 | Changed |
| Badge.Size.normal.chromium.png | 6 | Changed |
| Badge.Appearance - Dark Mode.normal.chromium.png | 15 | Changed |
| Badge.Color.normal.chromium.png | 1 | Changed |
Button 15 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Button.Large Icon Only.default.chromium.png | 5 | Changed |
| Button.Large Icon Only.hover.chromium.png | 4 | Changed |
| Button.Large With Icon - RTL.hover.chromium.png | 4 | Changed |
| Button.Large Icon Only - Dark Mode.pressed.chromium.png | 5 | Changed |
| Button.Large With Icon - Dark Mode.pressed.chromium.png | 5 | Changed |
| Button.Large With Icon - Dark Mode.default.chromium.png | 4 | Changed |
| Button.Large With Icon - RTL.pressed.chromium.png | 3 | Changed |
| Button.Large Icon Only - Dark Mode.hover.chromium.png | 3 | Changed |
| Button.Large With Icon - Dark Mode.hover.chromium.png | 3 | Changed |
| Button.Large With Icon.pressed.chromium.png | 3 | Changed |
| Button.Large Icon Only - Dark Mode.default.chromium.png | 4 | Changed |
| Button.Large With Icon.hover.chromium.png | 4 | Changed |
| Button.Large With Icon - RTL.default.chromium.png | 5 | Changed |
| Button.Large Icon Only.pressed.chromium.png | 3 | Changed |
| Button.Large With Icon.default.chromium.png | 5 | Changed |
Divider 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Divider.With Svg - RTL.normal.chromium.png | 3 | Changed |
| Divider.With Svg.normal.chromium.png | 3 | Changed |
| Divider.Vertical With Svg.normal.chromium.png | 4 | Changed |
MenuList 16 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| MenuList.Checkbox With Icons - RTL.1st selected.chromium.png | 4 | Changed |
| MenuList.Checkbox - RTL.2nd selected.chromium.png | 1 | Changed |
| MenuList.Checkbox With Icons.normal.chromium.png | 4 | Changed |
| MenuList.Checkbox With Icons - RTL.2nd selected.chromium.png | 5 | Changed |
| MenuList.Checkbox With Icons - RTL.normal.chromium.png | 4 | Changed |
| MenuList.Radio With Icons.1st selected.chromium.png | 4 | Changed |
| MenuList.Checkbox With Icons.2nd selected.chromium.png | 5 | Changed |
| MenuList.With Icons.normal.chromium.png | 4 | Changed |
| MenuList.Radio With Icons.normal.chromium.png | 4 | Changed |
| MenuList.With Icons.hover menuitem.chromium.png | 3 | Changed |
| MenuList.Radio With Icons - RTL.1st selected.chromium.png | 4 | Changed |
| MenuList.Checkbox.2nd selected.chromium.png | 1 | Changed |
| MenuList.Radio With Icons.2nd selected.chromium.png | 4 | Changed |
| MenuList.Radio With Icons - RTL.normal.chromium.png | 4 | Changed |
| MenuList.Checkbox With Icons.1st selected.chromium.png | 4 | Changed |
| MenuList.Radio With Icons - RTL.2nd selected.chromium.png | 4 | Changed |
Slider 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Slider.Size Small.normal.chromium.png | 1 | Changed |
| Slider.Size Small.rightArrow.chromium.png | 1 | Changed |
Switch 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Switch.Checked - RTL.hover.chromium.png | 1 | Changed |
| Switch.Checked.hover.chromium.png | 1 | Changed |
Text 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Text.Block.normal.chromium.png | 995 | Changed |
TextInput 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| TextInput.Size Large.normal.chromium.png | 2 | Changed |
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| ButtonMinimalPerf.default | 98 | 84 | 1.17:1 |
| ChatWithPopoverPerf.default | 207 | 187 | 1.11:1 |
| SegmentMinimalPerf.default | 208 | 188 | 1.11:1 |
| AvatarMinimalPerf.default | 116 | 105 | 1.1:1 |
| SkeletonMinimalPerf.default | 215 | 199 | 1.08:1 |
| DropdownManyItemsPerf.default | 401 | 376 | 1.07:1 |
| SliderMinimalPerf.default | 772 | 720 | 1.07:1 |
| CardMinimalPerf.default | 322 | 308 | 1.05:1 |
| LabelMinimalPerf.default | 232 | 221 | 1.05:1 |
| PortalMinimalPerf.default | 89 | 85 | 1.05:1 |
| ReactionMinimalPerf.default | 224 | 214 | 1.05:1 |
| AccordionMinimalPerf.default | 86 | 83 | 1.04:1 |
| BoxMinimalPerf.default | 197 | 189 | 1.04:1 |
| MenuMinimalPerf.default | 525 | 507 | 1.04:1 |
| AlertMinimalPerf.default | 158 | 154 | 1.03:1 |
| ButtonSlotsPerf.default | 316 | 306 | 1.03:1 |
| CarouselMinimalPerf.default | 271 | 262 | 1.03:1 |
| DatepickerMinimalPerf.default | 3622 | 3526 | 1.03:1 |
| DropdownMinimalPerf.default | 1447 | 1415 | 1.02:1 |
| EmbedMinimalPerf.default | 1902 | 1870 | 1.02:1 |
| FlexMinimalPerf.default | 164 | 161 | 1.02:1 |
| InputMinimalPerf.default | 549 | 540 | 1.02:1 |
| ListMinimalPerf.default | 319 | 314 | 1.02:1 |
| LoaderMinimalPerf.default | 187 | 183 | 1.02:1 |
| MenuButtonMinimalPerf.default | 972 | 953 | 1.02:1 |
| ProviderMinimalPerf.default | 202 | 198 | 1.02:1 |
| RadioGroupMinimalPerf.default | 270 | 264 | 1.02:1 |
| SplitButtonMinimalPerf.default | 2305 | 2259 | 1.02:1 |
| TextMinimalPerf.default | 199 | 196 | 1.02:1 |
| ToolbarMinimalPerf.default | 548 | 535 | 1.02:1 |
| ButtonOverridesMissPerf.default | 667 | 660 | 1.01:1 |
| ChatMinimalPerf.default | 449 | 446 | 1.01:1 |
| GridMinimalPerf.default | 183 | 182 | 1.01:1 |
| ListNestedPerf.default | 326 | 322 | 1.01:1 |
| RosterPerf.default | 1560 | 1547 | 1.01:1 |
| ProviderMergeThemesPerf.default | 649 | 643 | 1.01:1 |
| RefMinimalPerf.default | 108 | 107 | 1.01:1 |
| TableManyItemsPerf.default | 1112 | 1102 | 1.01:1 |
| TextAreaMinimalPerf.default | 285 | 282 | 1.01:1 |
| AnimationMinimalPerf.default | 302 | 302 | 1:1 |
| AttachmentSlotsPerf.default | 648 | 649 | 1:1 |
| CheckboxMinimalPerf.default | 1144 | 1148 | 1:1 |
| DialogMinimalPerf.default | 444 | 443 | 1:1 |
| HeaderSlotsPerf.default | 475 | 474 | 1:1 |
| ImageMinimalPerf.default | 237 | 236 | 1:1 |
| LayoutMinimalPerf.default | 207 | 206 | 1:1 |
| IconMinimalPerf.default | 412 | 412 | 1:1 |
| CustomToolbarPrototype.default | 1472 | 1477 | 1:1 |
| TreeMinimalPerf.default | 490 | 490 | 1:1 |
| TreeWith60ListItems.default | 87 | 87 | 1:1 |
| ChatDuplicateMessagesPerf.default | 156 | 157 | 0.99:1 |
| HeaderMinimalPerf.default | 207 | 210 | 0.99:1 |
| TooltipMinimalPerf.default | 1289 | 1301 | 0.99:1 |
| DividerMinimalPerf.default | 201 | 205 | 0.98:1 |
| ListCommonPerf.default | 393 | 399 | 0.98:1 |
| TableMinimalPerf.default | 239 | 244 | 0.98:1 |
| ItemLayoutMinimalPerf.default | 716 | 740 | 0.97:1 |
| PopupMinimalPerf.default | 346 | 355 | 0.97:1 |
| VideoMinimalPerf.default | 419 | 434 | 0.97:1 |
| AttachmentMinimalPerf.default | 78 | 81 | 0.96:1 |
| StatusMinimalPerf.default | 384 | 406 | 0.95:1 |
| FormMinimalPerf.default | 218 | 232 | 0.94:1 |
| ListWith60ListItems.default | 340 | 377 | 0.9:1 |
🕵 FluentUIV0 No visual regressions between this PR and main |
📊 Bundle size report✅ No changes found |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 626 | 629 | 5000 | |
| Breadcrumb | mount | 1672 | 1669 | 1000 | |
| Checkbox | mount | 1740 | 1715 | 5000 | |
| CheckboxBase | mount | 1499 | 1486 | 5000 | |
| ChoiceGroup | mount | 2982 | 2973 | 5000 | |
| ComboBox | mount | 657 | 682 | 1000 | |
| CommandBar | mount | 6443 | 6480 | 1000 | |
| ContextualMenu | mount | 12236 | 12112 | 1000 | |
| DefaultButton | mount | 815 | 803 | 5000 | |
| DetailsRow | mount | 2203 | 2211 | 5000 | |
| DetailsRowFast | mount | 2219 | 2233 | 5000 | |
| DetailsRowNoStyles | mount | 2035 | 2062 | 5000 | |
| Dialog | mount | 2669 | 2715 | 1000 | |
| DocumentCardTitle | mount | 234 | 225 | 1000 | |
| Dropdown | mount | 2034 | 2046 | 5000 | |
| FocusTrapZone | mount | 1155 | 1160 | 5000 | |
| FocusZone | mount | 1089 | 1089 | 5000 | |
| GroupedList | mount | 41979 | 41963 | 2 | |
| GroupedList | virtual-rerender | 18241 | 20159 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 51224 | 51233 | 2 | |
| GroupedListV2 | mount | 224 | 239 | 2 | |
| GroupedListV2 | virtual-rerender | 205 | 213 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 226 | 226 | 2 | |
| IconButton | mount | 1121 | 1135 | 5000 | |
| Label | mount | 364 | 334 | 5000 | |
| Layer | mount | 2775 | 2729 | 5000 | |
| Link | mount | 396 | 388 | 5000 | |
| MenuButton | mount | 990 | 1000 | 5000 | |
| MessageBar | mount | 21477 | 21483 | 5000 | |
| Nav | mount | 2062 | 2057 | 1000 | |
| OverflowSet | mount | 785 | 779 | 5000 | |
| Panel | mount | 1823 | 1790 | 1000 | |
| Persona | mount | 730 | 753 | 1000 | |
| Pivot | mount | 900 | 915 | 1000 | |
| PrimaryButton | mount | 936 | 938 | 5000 | |
| Rating | mount | 4658 | 4683 | 5000 | |
| SearchBox | mount | 909 | 908 | 5000 | |
| Shimmer | mount | 1901 | 1904 | 5000 | |
| Slider | mount | 1335 | 1347 | 5000 | |
| SpinButton | mount | 2980 | 3003 | 5000 | |
| Spinner | mount | 386 | 405 | 5000 | |
| SplitButton | mount | 1853 | 1888 | 5000 | |
| Stack | mount | 405 | 411 | 5000 | |
| StackWithIntrinsicChildren | mount | 882 | 875 | 5000 | |
| StackWithTextChildren | mount | 2691 | 2687 | 5000 | |
| SwatchColorPicker | mount | 6363 | 6393 | 5000 | |
| TagPicker | mount | 1463 | 1462 | 5000 | |
| Text | mount | 385 | 379 | 5000 | |
| TextField | mount | 940 | 924 | 5000 | |
| ThemeProvider | mount | 851 | 850 | 5000 | |
| ThemeProvider | virtual-rerender | 578 | 596 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1309 | 1279 | 5000 | |
| Toggle | mount | 603 | 602 | 5000 | |
| buttonNative | mount | 194 | 194 | 5000 |
added 2 commits
May 28, 2024 14:24
fabricteam
reviewed
May 28, 2024
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵 fluentuiv9 Open the Visual Regressions report to inspect the affected screenshots
Avatar Converged 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Avatar Converged.badgeMask.normal.chromium.png | 1 | Changed |
Card Converged - Selectable 4 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Card Converged - Selectable.appearance selectable - Filled - Dark Mode.click.chromium.png | 0 | Removed |
| Card Converged - Selectable.appearance selectable - Filled - Dark Mode.hover.chromium.png | 0 | Removed |
| Card Converged - Selectable.appearance selectable - Filled - Dark Mode.normal.chromium.png | 0 | Removed |
| Card Converged - Selectable.appearance selectable - Filled - Dark Mode.selected.chromium.png | 0 | Removed |
SwatchPicker Converged 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| SwatchPicker Converged.default - High Contrast.default.chromium.png | 0 | Added |
| SwatchPicker Converged.spacing.default.chromium.png | 0 | Added |
|
@adamsamec we moved all storybook related files from react-components package to public-docsite-v9 application ( you can find more context within the PR #31440 ) you'll need to update your branch against latest master branch and apply your |
🕵 fluentuiv8 No visual regressions between this PR and main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR is not intended for merge. It is meant only for presentation of accessible implementation of people picker prototypes based on the contenteditable HTML feature.
The contenteditable people picker prototypes can be viewed on this link.