Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(test-ssr): add custom esbuild-plugin to properly resolve TS path aliases which stopped working starting esbuild 0.19 #31227

Merged
merged 3 commits into from
Apr 30, 2024

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Apr 30, 2024

Previous Behavior

Esbuild stopped resolving TS path aliases since version 0.19 (BREAKING CHANGE)

https://github.com/evanw/esbuild/blob/main/CHANGELOG.md#0190 /
image

With this in place our SSR test are working by "accident" ( lage scheduling build task prior to executing test-ssr ),
and following pipeline issues might start happening at any time (#29327).

This issue started to appear in one of PR's that removes a deprecated package from the repo #31007

New Behavior

More context

Even if we added build task as pre-requirement for test-ssr pipeline issues would appear sooner than later.

So we can either:

  • provide proper dependency declarations to all packages ( which would introduce circular dependencies - this will be mitigated after implementing [Feature]: improve type-checking performance #30516) + moving test-ssr to *-stories packages
  • implement tsConfigPathAliases esbuild plugin

Ideal solution is to have both so until that type-checking epic is done

Related Issue(s)

Hotell added 2 commits April 30, 2024 11:16
… aliases which stopped working starting esbuild 0.19
…TS path aliases which stopped working starting esbuild 0.19
@github-actions github-actions bot added this to the April Project Cycle Q1 2024 milestone Apr 30, 2024
@Hotell Hotell changed the title Test ssr/bring ts path aliases back feat(test-ssr): add custom esbuild-plugin to properly resolve TS path aliases which stopped working starting esbuild 0.19 Apr 30, 2024
@fabricteam
Copy link
Collaborator

fabricteam commented Apr 30, 2024

📊 Bundle size report

✅ No changes found

@Hotell Hotell requested a review from layershifter April 30, 2024 09:29
Copy link

codesandbox-ci bot commented Apr 30, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

…esolve TS path aliases which stopped working starting esbuild 0.19
@Hotell Hotell marked this pull request as ready for review April 30, 2024 10:51
@Hotell Hotell requested a review from a team as a code owner April 30, 2024 10:51
@tudorpopams tudorpopams self-requested a review April 30, 2024 11:13
Copy link
Member

@layershifter layershifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫶

@Hotell Hotell merged commit 25027bf into microsoft:master Apr 30, 2024
18 checks passed
@Hotell Hotell deleted the test-ssr/bring-ts-path-aliases-back branch April 30, 2024 16:06
miroslavstastny pushed a commit to miroslavstastny/fluentui that referenced this pull request Jun 14, 2024
… aliases which stopped working starting esbuild 0.19 (microsoft#31227)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants