Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove react-infobutton in favor of keeping only react-infolabel #31007

Merged
merged 8 commits into from
May 3, 2024
Merged

chore: Remove react-infobutton in favor of keeping only react-infolabel #31007

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7aa0a40
chore: Remove react-infobutton in favor of keeping only react-infolabel.
sopranopillow Apr 9, 2024
166f864
Merge branch 'master' of https://www.github.com/microsoft/fluentui in…
sopranopillow Apr 9, 2024
4682653
updating snapshots
sopranopillow Apr 9, 2024
137413f
reverting snapshots
sopranopillow Apr 23, 2024
80c9fd0
Merge branch 'master' of https://www.github.com/microsoft/fluentui in…
sopranopillow Apr 23, 2024
a088f85
revert change logs
sopranopillow Apr 23, 2024
f7cf9d9
Merge branch 'master' of https://www.github.com/microsoft/fluentui in…
sopranopillow May 2, 2024
c4ef895
u
sopranopillow May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,6 @@ packages/react-components/babel-preset-global-context @microsoft/teams-prg
packages/react-components/react-table @microsoft/teams-prg
packages/react-components/react-progress @microsoft/cxe-red @tomi-msft
packages/react-components/react-persona @microsoft/cxe-red @sopranopillow
packages/react-components/react-infobutton @microsoft/cxe-red @sopranopillow
packages/react-components/react-tree @microsoft/teams-prg
packages/react-components/react-virtualizer @microsoft/xc-uxe @Mitch-At-Work
packages/react-components/react-skeleton @microsoft/cxe-red
Expand Down
2 changes: 0 additions & 2 deletions packages/react-charting/UnitTests/__snapshots__/VerticalBarChartUT.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ exports[`vertical bar chart with numeric x-axis data Should render the vertical
overflow: auto;
}
data-focuszone-id="FocusZone5"
data-tabster="{\\"uncontrolled\\": {}}"
>
<svg
focusable="false"
Expand Down Expand Up @@ -460,7 +459,6 @@ exports[`vertical bar chart with numeric x-axis data Should render the vertical
outline: none;
}
data-focuszone-id="FocusZone6"
data-tabster="{\\"uncontrolled\\": {}}"
role="listbox"
>
<div
Expand Down
6 changes: 0 additions & 6 deletions packages/react-charting/src/components/AreaChart/__snapshots__/AreaChart.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ exports[`AreaChart - mouse events Should render callout correctly on mouseover 1
overflow: auto;
}
data-focuszone-id="FocusZone8"
data-tabster="{\\"uncontrolled\\": {}}"
onFocus={[Function]}
onKeyDown={[Function]}
onMouseDownCapture={[Function]}
Expand Down Expand Up @@ -237,7 +236,6 @@ exports[`AreaChart - mouse events Should render callout correctly on mouseover 1
outline: none;
}
data-focuszone-id="FocusZone9"
data-tabster="{\\"uncontrolled\\": {}}"
onFocus={[Function]}
onKeyDown={[Function]}
onMouseDownCapture={[Function]}
Expand Down Expand Up @@ -588,7 +586,6 @@ exports[`AreaChart - mouse events Should render customized callout on mouseover
overflow: auto;
}
data-focuszone-id="FocusZone8"
data-tabster="{\\"uncontrolled\\": {}}"
onFocus={[Function]}
onKeyDown={[Function]}
onMouseDownCapture={[Function]}
Expand Down Expand Up @@ -792,7 +789,6 @@ exports[`AreaChart - mouse events Should render customized callout on mouseover
outline: none;
}
data-focuszone-id="FocusZone9"
data-tabster="{\\"uncontrolled\\": {}}"
onFocus={[Function]}
onKeyDown={[Function]}
onMouseDownCapture={[Function]}
Expand Down Expand Up @@ -1040,7 +1036,6 @@ exports[`AreaChart - mouse events Should render customized callout per stack on
overflow: auto;
}
data-focuszone-id="FocusZone8"
data-tabster="{\\"uncontrolled\\": {}}"
onFocus={[Function]}
onKeyDown={[Function]}
onMouseDownCapture={[Function]}
Expand Down Expand Up @@ -1244,7 +1239,6 @@ exports[`AreaChart - mouse events Should render customized callout per stack on
outline: none;
}
data-focuszone-id="FocusZone9"
data-tabster="{\\"uncontrolled\\": {}}"
onFocus={[Function]}
onKeyDown={[Function]}
onMouseDownCapture={[Function]}
Expand Down
8 changes: 0 additions & 8 deletions packages/react-charting/src/components/AreaChart/__snapshots__/AreaChartRTL.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6077,7 +6077,6 @@ exports[`Area chart rendering Should render the area chart with numeric x-axis d
overflow: auto;
}
data-focuszone-id="FocusZone8"
data-tabster="{\\"uncontrolled\\": {}}"
>
<svg
aria-label="Area chart multiple example"
Expand Down Expand Up @@ -6855,7 +6854,6 @@ exports[`Area chart rendering Should render the area chart with numeric x-axis d
outline: none;
}
data-focuszone-id="FocusZone9"
data-tabster="{\\"uncontrolled\\": {}}"
role="listbox"
>
<div
Expand Down Expand Up @@ -7184,7 +7182,6 @@ exports[`AreaChart - Theme Should reflect theme change 1`] = `
overflow: auto;
}
data-focuszone-id="FocusZone11"
data-tabster="{\\"uncontrolled\\": {}}"
>
<svg
aria-label="Area chart multiple example"
Expand Down Expand Up @@ -7962,7 +7959,6 @@ exports[`AreaChart - Theme Should reflect theme change 1`] = `
outline: none;
}
data-focuszone-id="FocusZone12"
data-tabster="{\\"uncontrolled\\": {}}"
role="listbox"
>
<div
Expand Down Expand Up @@ -8279,7 +8275,6 @@ exports[`Screen resolution Should remain unchanged on zoom in 1`] = `
overflow: auto;
}
data-focuszone-id="FocusZone8"
data-tabster="{\\"uncontrolled\\": {}}"
>
<svg
aria-label="Area chart multiple example"
Expand Down Expand Up @@ -9057,7 +9052,6 @@ exports[`Screen resolution Should remain unchanged on zoom in 1`] = `
outline: none;
}
data-focuszone-id="FocusZone9"
data-tabster="{\\"uncontrolled\\": {}}"
role="listbox"
>
<div
Expand Down Expand Up @@ -9373,7 +9367,6 @@ exports[`Screen resolution Should remain unchanged on zoom out 1`] = `
overflow: auto;
}
data-focuszone-id="FocusZone8"
data-tabster="{\\"uncontrolled\\": {}}"
>
<svg
aria-label="Area chart multiple example"
Expand Down Expand Up @@ -10151,7 +10144,6 @@ exports[`Screen resolution Should remain unchanged on zoom out 1`] = `
outline: none;
}
data-focuszone-id="FocusZone9"
data-tabster="{\\"uncontrolled\\": {}}"
role="listbox"
>
<div
Expand Down
21 changes: 0 additions & 21 deletions packages/react-charting/src/components/DonutChart/__snapshots__/DonutChart.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ exports[`DonutChart - mouse events Should render callout correctly on mouseover
outline: none;
}
data-focuszone-id="FocusZone3"
data-tabster="{\\"uncontrolled\\": {}}"
onFocus={[Function]}
onKeyDown={[Function]}
onMouseDownCapture={[Function]}
Expand Down Expand Up @@ -347,7 +346,6 @@ exports[`DonutChart - mouse events Should render callout correctly on mouseover
outline: none;
}
data-focuszone-id="FocusZone4"
data-tabster="{\\"uncontrolled\\": {}}"
onFocus={[Function]}
onKeyDown={[Function]}
onMouseDownCapture={[Function]}
Expand Down Expand Up @@ -672,7 +670,6 @@ exports[`DonutChart - mouse events Should render customized callout on mouseover
outline: none;
}
data-focuszone-id="FocusZone3"
data-tabster="{\\"uncontrolled\\": {}}"
onFocus={[Function]}
onKeyDown={[Function]}
onMouseDownCapture={[Function]}
Expand Down Expand Up @@ -903,7 +900,6 @@ exports[`DonutChart - mouse events Should render customized callout on mouseover
outline: none;
}
data-focuszone-id="FocusZone4"
data-tabster="{\\"uncontrolled\\": {}}"
onFocus={[Function]}
onKeyDown={[Function]}
onMouseDownCapture={[Function]}
Expand Down Expand Up @@ -1228,7 +1224,6 @@ exports[`DonutChart snapShot testing Should elevate all smaller values to minimu
outline: none;
}
data-focuszone-id="FocusZone3"
data-tabster="{\\"uncontrolled\\": {}}"
onFocus={[Function]}
onKeyDown={[Function]}
onMouseDownCapture={[Function]}
Expand Down Expand Up @@ -1382,7 +1377,6 @@ exports[`DonutChart snapShot testing Should elevate all smaller values to minimu
outline: none;
}
data-focuszone-id="FocusZone4"
data-tabster="{\\"uncontrolled\\": {}}"
onFocus={[Function]}
onKeyDown={[Function]}
onMouseDownCapture={[Function]}
Expand Down Expand Up @@ -1704,7 +1698,6 @@ exports[`DonutChart snapShot testing Should render arc labels 1`] = `
outline: none;
}
data-focuszone-id="FocusZone3"
data-tabster="{\\"uncontrolled\\": {}}"
onFocus={[Function]}
onKeyDown={[Function]}
onMouseDownCapture={[Function]}
Expand Down Expand Up @@ -1906,7 +1899,6 @@ exports[`DonutChart snapShot testing Should render arc labels 1`] = `
outline: none;
}
data-focuszone-id="FocusZone4"
data-tabster="{\\"uncontrolled\\": {}}"
onFocus={[Function]}
onKeyDown={[Function]}
onMouseDownCapture={[Function]}
Expand Down Expand Up @@ -2228,7 +2220,6 @@ exports[`DonutChart snapShot testing Should render arc labels in percentage form
outline: none;
}
data-focuszone-id="FocusZone3"
data-tabster="{\\"uncontrolled\\": {}}"
onFocus={[Function]}
onKeyDown={[Function]}
onMouseDownCapture={[Function]}
Expand Down Expand Up @@ -2430,7 +2421,6 @@ exports[`DonutChart snapShot testing Should render arc labels in percentage form
outline: none;
}
data-focuszone-id="FocusZone4"
data-tabster="{\\"uncontrolled\\": {}}"
onFocus={[Function]}
onKeyDown={[Function]}
onMouseDownCapture={[Function]}
Expand Down Expand Up @@ -2752,7 +2742,6 @@ exports[`DonutChart snapShot testing renders DonutChart correctly 1`] = `
outline: none;
}
data-focuszone-id="FocusZone3"
data-tabster="{\\"uncontrolled\\": {}}"
onFocus={[Function]}
onKeyDown={[Function]}
onMouseDownCapture={[Function]}
Expand Down Expand Up @@ -2906,7 +2895,6 @@ exports[`DonutChart snapShot testing renders DonutChart correctly 1`] = `
outline: none;
}
data-focuszone-id="FocusZone4"
data-tabster="{\\"uncontrolled\\": {}}"
onFocus={[Function]}
onKeyDown={[Function]}
onMouseDownCapture={[Function]}
Expand Down Expand Up @@ -3228,7 +3216,6 @@ exports[`DonutChart snapShot testing renders DonutChart correctly without color
outline: none;
}
data-focuszone-id="FocusZone3"
data-tabster="{\\"uncontrolled\\": {}}"
onFocus={[Function]}
onKeyDown={[Function]}
onMouseDownCapture={[Function]}
Expand Down Expand Up @@ -3382,7 +3369,6 @@ exports[`DonutChart snapShot testing renders DonutChart correctly without color
outline: none;
}
data-focuszone-id="FocusZone4"
data-tabster="{\\"uncontrolled\\": {}}"
onFocus={[Function]}
onKeyDown={[Function]}
onMouseDownCapture={[Function]}
Expand Down Expand Up @@ -3704,7 +3690,6 @@ exports[`DonutChart snapShot testing renders enabledLegendsWrapLines correctly 1
outline: none;
}
data-focuszone-id="FocusZone3"
data-tabster="{\\"uncontrolled\\": {}}"
onFocus={[Function]}
onKeyDown={[Function]}
onMouseDownCapture={[Function]}
Expand Down Expand Up @@ -3858,7 +3843,6 @@ exports[`DonutChart snapShot testing renders enabledLegendsWrapLines correctly 1
outline: none;
}
data-focuszone-id="FocusZone4"
data-tabster="{\\"uncontrolled\\": {}}"
onFocus={[Function]}
onKeyDown={[Function]}
onMouseDownCapture={[Function]}
Expand Down Expand Up @@ -4180,7 +4164,6 @@ exports[`DonutChart snapShot testing renders hideLegend correctly 1`] = `
outline: none;
}
data-focuszone-id="FocusZone3"
data-tabster="{\\"uncontrolled\\": {}}"
onFocus={[Function]}
onKeyDown={[Function]}
onMouseDownCapture={[Function]}
Expand Down Expand Up @@ -4315,7 +4298,6 @@ exports[`DonutChart snapShot testing renders hideTooltip correctly 1`] = `
outline: none;
}
data-focuszone-id="FocusZone3"
data-tabster="{\\"uncontrolled\\": {}}"
onFocus={[Function]}
onKeyDown={[Function]}
onMouseDownCapture={[Function]}
Expand Down Expand Up @@ -4469,7 +4451,6 @@ exports[`DonutChart snapShot testing renders hideTooltip correctly 1`] = `
outline: none;
}
data-focuszone-id="FocusZone4"
data-tabster="{\\"uncontrolled\\": {}}"
onFocus={[Function]}
onKeyDown={[Function]}
onMouseDownCapture={[Function]}
Expand Down Expand Up @@ -4791,7 +4772,6 @@ exports[`DonutChart snapShot testing renders value inside onf the pie 1`] = `
outline: none;
}
data-focuszone-id="FocusZone3"
data-tabster="{\\"uncontrolled\\": {}}"
onFocus={[Function]}
onKeyDown={[Function]}
onMouseDownCapture={[Function]}
Expand Down Expand Up @@ -4963,7 +4943,6 @@ exports[`DonutChart snapShot testing renders value inside onf the pie 1`] = `
outline: none;
}
data-focuszone-id="FocusZone4"
data-tabster="{\\"uncontrolled\\": {}}"
onFocus={[Function]}
onKeyDown={[Function]}
onMouseDownCapture={[Function]}
Expand Down
4 changes: 0 additions & 4 deletions packages/react-charting/src/components/DonutChart/__snapshots__/DonutChartRTL.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ exports[`Donut chart interactions Should hide callout on mouse leave 1`] = `
outline: none;
}
data-focuszone-id="FocusZone3"
data-tabster="{\\"uncontrolled\\": {}}"
>
<div>
<svg
Expand Down Expand Up @@ -311,7 +310,6 @@ exports[`Donut chart interactions Should hide callout on mouse leave 1`] = `
outline: none;
}
data-focuszone-id="FocusZone4"
data-tabster="{\\"uncontrolled\\": {}}"
role="listbox"
>
<div
Expand Down Expand Up @@ -632,7 +630,6 @@ exports[`Donut chart interactions Should reflect theme change 1`] = `
outline: none;
}
data-focuszone-id="FocusZone6"
data-tabster="{\\"uncontrolled\\": {}}"
>
<div>
<svg
Expand Down Expand Up @@ -764,7 +761,6 @@ exports[`Donut chart interactions Should reflect theme change 1`] = `
outline: none;
}
data-focuszone-id="FocusZone7"
data-tabster="{\\"uncontrolled\\": {}}"
role="listbox"
>
<div
Expand Down
Loading
Loading