Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eslint-plugin): add triple-slash-reference rule to ban TS '///' within source code #30993

Merged
merged 2 commits into from
Apr 11, 2024
Merged

feat(eslint-plugin): add triple-slash-reference rule to ban TS '///' within source code #30993

merged 2 commits into from
Apr 11, 2024

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Apr 8, 2024 •
edited
Loading

Previous Behavior

New Behavior

Related Issue(s)

@github-actions github-actions bot added this to the April Project Cycle Q1 2024 milestone Apr 8, 2024
@fabricteam
Copy link
Collaborator

fabricteam commented Apr 8, 2024 •
edited
Loading

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
FluentProviderWithTheme mount 79 86 10 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 624 638 5000
Button mount 299 294 5000
Field mount 1101 1129 5000
FluentProvider mount 705 732 5000
FluentProviderWithTheme mount 79 86 10 Possible regression
FluentProviderWithTheme virtual-rerender 35 32 10
FluentProviderWithTheme virtual-rerender-with-unmount 73 76 10
MakeStyles mount 850 858 50000
Persona mount 1768 1697 5000
SpinButton mount 1373 1376 5000

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Apr 8, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 8, 2024 •
edited
Loading

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 8, 2024 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AccordionMinimalPerf.default 95 79 1.2:1
TreeWith60ListItems.default 96 86 1.12:1
ButtonMinimalPerf.default 94 86 1.09:1
CardMinimalPerf.default 331 307 1.08:1
AttachmentMinimalPerf.default 89 83 1.07:1
DatepickerMinimalPerf.default 3755 3520 1.07:1
ListMinimalPerf.default 318 298 1.07:1
TableMinimalPerf.default 245 228 1.07:1
AnimationMinimalPerf.default 299 283 1.06:1
AttachmentSlotsPerf.default 643 606 1.06:1
ChatWithPopoverPerf.default 209 197 1.06:1
MenuMinimalPerf.default 517 490 1.06:1
RefMinimalPerf.default 116 109 1.06:1
ButtonOverridesMissPerf.default 661 631 1.05:1
ChatDuplicateMessagesPerf.default 159 151 1.05:1
DividerMinimalPerf.default 215 204 1.05:1
FormMinimalPerf.default 222 211 1.05:1
RadioGroupMinimalPerf.default 268 256 1.05:1
ReactionMinimalPerf.default 218 208 1.05:1
HeaderMinimalPerf.default 214 205 1.04:1
LayoutMinimalPerf.default 206 198 1.04:1
ListCommonPerf.default 400 386 1.04:1
ProviderMinimalPerf.default 205 197 1.04:1
SegmentMinimalPerf.default 205 197 1.04:1
SkeletonMinimalPerf.default 199 191 1.04:1
ImageMinimalPerf.default 234 228 1.03:1
LoaderMinimalPerf.default 193 188 1.03:1
IconMinimalPerf.default 409 396 1.03:1
TextAreaMinimalPerf.default 291 283 1.03:1
BoxMinimalPerf.default 192 189 1.02:1
ButtonSlotsPerf.default 333 327 1.02:1
CarouselMinimalPerf.default 271 266 1.02:1
ChatMinimalPerf.default 440 431 1.02:1
EmbedMinimalPerf.default 1897 1863 1.02:1
ItemLayoutMinimalPerf.default 713 698 1.02:1
MenuButtonMinimalPerf.default 972 953 1.02:1
TableManyItemsPerf.default 1136 1112 1.02:1
TooltipMinimalPerf.default 1278 1252 1.02:1
TreeMinimalPerf.default 494 486 1.02:1
VideoMinimalPerf.default 433 423 1.02:1
CheckboxMinimalPerf.default 1152 1139 1.01:1
DropdownMinimalPerf.default 1438 1417 1.01:1
FlexMinimalPerf.default 158 157 1.01:1
CustomToolbarPrototype.default 1489 1473 1.01:1
DialogMinimalPerf.default 440 439 1:1
ProviderMergeThemesPerf.default 646 648 1:1
AvatarMinimalPerf.default 108 109 0.99:1
DropdownManyItemsPerf.default 393 396 0.99:1
HeaderSlotsPerf.default 467 471 0.99:1
SliderMinimalPerf.default 747 753 0.99:1
SplitButtonMinimalPerf.default 2212 2228 0.99:1
ToolbarMinimalPerf.default 532 535 0.99:1
InputMinimalPerf.default 545 556 0.98:1
ListNestedPerf.default 317 324 0.98:1
PortalMinimalPerf.default 82 84 0.98:1
TextMinimalPerf.default 185 189 0.98:1
AlertMinimalPerf.default 154 158 0.97:1
LabelMinimalPerf.default 210 217 0.97:1
PopupMinimalPerf.default 342 352 0.97:1
StatusMinimalPerf.default 383 395 0.97:1
RosterPerf.default 1541 1607 0.96:1
ListWith60ListItems.default 355 374 0.95:1
GridMinimalPerf.default 174 190 0.92:1

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 8, 2024 •
edited
Loading

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 8, 2024 •
edited
Loading

📊 Bundle size report

✅ No changes found

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 8, 2024 •
edited
Loading

🕵 fluentuiv9 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 8, 2024 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 610 628 5000
Breadcrumb mount 1671 1673 1000
Checkbox mount 1689 1669 5000
CheckboxBase mount 1486 1471 5000
ChoiceGroup mount 2950 2901 5000
ComboBox mount 651 626 1000
CommandBar mount 6235 6078 1000
ContextualMenu mount 12053 12624 1000
DefaultButton mount 756 739 5000
DetailsRow mount 2144 2148 5000
DetailsRowFast mount 2207 2156 5000
DetailsRowNoStyles mount 1963 1961 5000
Dialog mount 2611 2639 1000
DocumentCardTitle mount 219 225 1000
Dropdown mount 1970 1966 5000
FocusTrapZone mount 1126 1124 5000
FocusZone mount 1067 1084 5000
GroupedList mount 41529 41556 2
GroupedList virtual-rerender 19841 19825 2
GroupedList virtual-rerender-with-unmount 50588 50677 2
GroupedListV2 mount 221 211 2
GroupedListV2 virtual-rerender 219 214 2
GroupedListV2 virtual-rerender-with-unmount 224 229 2
IconButton mount 1055 1085 5000
Label mount 322 330 5000
Layer mount 2727 2721 5000
Link mount 390 387 5000
MenuButton mount 957 944 5000
MessageBar mount 21295 21230 5000
Nav mount 1937 1945 1000
OverflowSet mount 802 779 5000
Panel mount 1788 1773 1000
Persona mount 726 735 1000
Pivot mount 868 863 1000
PrimaryButton mount 823 831 5000
Rating mount 4559 4565 5000
SearchBox mount 929 887 5000
Shimmer mount 1851 1902 5000
Slider mount 1322 1312 5000
SpinButton mount 2860 2797 5000
Spinner mount 387 381 5000
SplitButton mount 1838 1823 5000
Stack mount 402 410 5000
StackWithIntrinsicChildren mount 869 847 5000
StackWithTextChildren mount 2570 2570 5000
SwatchColorPicker mount 6171 6118 5000
TagPicker mount 1424 1472 5000
Text mount 360 368 5000
TextField mount 929 932 5000
ThemeProvider mount 814 825 5000
ThemeProvider virtual-rerender 577 585 5000
ThemeProvider virtual-rerender-with-unmount 1282 1276 5000
Toggle mount 621 607 5000
buttonNative mount 191 194 5000

@Hotell Hotell marked this pull request as ready for review April 8, 2024 16:07
@Hotell Hotell requested a review from a team as a code owner April 8, 2024 16:07
@tudorpopams tudorpopams self-requested a review April 9, 2024 11:52
@Hotell Hotell force-pushed the type-checking-perf/prerequirements/eslint-rule-for-tripple-slash branch from bb21382 to 19a5691 Compare April 11, 2024 09:40
@Hotell Hotell enabled auto-merge (squash) April 11, 2024 09:41
@Hotell Hotell force-pushed the type-checking-perf/prerequirements/eslint-rule-for-tripple-slash branch from 19a5691 to dd4286a Compare April 11, 2024 10:13
@Hotell Hotell requested a review from a team as a code owner April 11, 2024 11:32
@Hotell Hotell merged commit 43033b4 into microsoft:master Apr 11, 2024
21 checks passed
robertpenner pushed a commit to robertpenner/fluentui that referenced this pull request Apr 11, 2024
@Hotell @robertpenner
feat(eslint-plugin): add triple-slash-reference rule to ban TS '///' …
9100b2b 
…within source code (microsoft#30993)
@Hotell Hotell deleted the type-checking-perf/prerequirements/eslint-rule-for-tripple-slash branch April 12, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsunderhus bsunderhus bsunderhus approved these changes

@layershifter layershifter layershifter approved these changes

@tudorpopams tudorpopams tudorpopams approved these changes

Assignees
No one assigned
Labels
Area: Linting Fluent UI react-components (v9) Package: eslint-plugin
Projects
None yet
Milestone
April Project Cycle Q1 2024
Development

Successfully merging this pull request may close these issues.
5 participants
@Hotell @fabricteam @bsunderhus @layershifter @tudorpopams