[xplat] Implement JSX runtime for react strict dom #30768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lat-griffel-stylex-adapter
…lat-jsx-adapter
behowell
requested review from
a team,
sopranopillow and
micahgodbolt
as code owners
spmonahan
reviewed
Mar 13, 2024
JasonVMo
reviewed
Mar 13, 2024
packages/react-components/react-jsx-runtime/src/utils/DevRuntime.native.ts
Outdated
Show resolved
Hide resolved
JasonVMo
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ Note: this is being merged into the
xplatbranch, notmaster.New Behavior
Redirect the JSX runtime to create react-strict-dom elements for react native, instead of intrinsic DOM elements. This allows fluentui components to render in react-strict-dom.
The native runtime also converts the className prop to stylex styles by looking up the values in the map created by makeStyles calls in the react-platform-adapter.