Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate lage task dependencies to nx #30503

Merged
merged 2 commits into from
Feb 13, 2024
Merged

feat: migrate lage task dependencies to nx #30503

merged 2 commits into from
Feb 13, 2024

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Feb 8, 2024 •
edited
Loading

Previous Behavior

New Behavior

  • migrate lage task dependency graph to nx

Related Issue(s)

@Hotell Hotell added the NX: core label Feb 8, 2024
@fabricteam
Copy link
Collaborator

fabricteam commented Feb 8, 2024 •
edited
Loading

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 641 623 5000
Button mount 308 309 5000
Field mount 1114 1092 5000
FluentProvider mount 702 715 5000
FluentProviderWithTheme mount 81 85 10
FluentProviderWithTheme virtual-rerender 67 59 10
FluentProviderWithTheme virtual-rerender-with-unmount 85 75 10
MakeStyles mount 854 850 50000
Persona mount 1762 1710 5000
SpinButton mount 1403 1390 5000

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Feb 8, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5dc8c39:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Feb 8, 2024 •
edited
Loading

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Feb 8, 2024 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
AccordionMinimalPerf.default 83 90 0.92:1 analysis
Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AvatarMinimalPerf.default 127 108 1.18:1
LoaderMinimalPerf.default 205 183 1.12:1
AttachmentMinimalPerf.default 89 82 1.09:1
SegmentMinimalPerf.default 203 187 1.09:1
BoxMinimalPerf.default 203 189 1.07:1
LabelMinimalPerf.default 229 216 1.06:1
ListMinimalPerf.default 316 298 1.06:1
ProviderMinimalPerf.default 214 202 1.06:1
ReactionMinimalPerf.default 214 201 1.06:1
IconMinimalPerf.default 404 382 1.06:1
TableMinimalPerf.default 242 228 1.06:1
VideoMinimalPerf.default 443 416 1.06:1
CarouselMinimalPerf.default 263 250 1.05:1
FlexMinimalPerf.default 161 153 1.05:1
FormMinimalPerf.default 225 215 1.05:1
GridMinimalPerf.default 198 188 1.05:1
ListNestedPerf.default 331 315 1.05:1
StatusMinimalPerf.default 411 393 1.05:1
CardMinimalPerf.default 324 312 1.04:1
HeaderSlotsPerf.default 471 454 1.04:1
SliderMinimalPerf.default 764 737 1.04:1
AttachmentSlotsPerf.default 646 628 1.03:1
InputMinimalPerf.default 556 539 1.03:1
ItemLayoutMinimalPerf.default 721 703 1.03:1
MenuButtonMinimalPerf.default 984 959 1.03:1
PopupMinimalPerf.default 357 346 1.03:1
TextMinimalPerf.default 193 188 1.03:1
ChatMinimalPerf.default 435 428 1.02:1
ListCommonPerf.default 399 391 1.02:1
TextAreaMinimalPerf.default 297 291 1.02:1
CustomToolbarPrototype.default 1493 1460 1.02:1
ToolbarMinimalPerf.default 540 530 1.02:1
ButtonOverridesMissPerf.default 661 656 1.01:1
DatepickerMinimalPerf.default 3534 3508 1.01:1
DropdownManyItemsPerf.default 386 382 1.01:1
DropdownMinimalPerf.default 1446 1432 1.01:1
ListWith60ListItems.default 363 360 1.01:1
SkeletonMinimalPerf.default 200 199 1.01:1
TableManyItemsPerf.default 1137 1130 1.01:1
TreeWith60ListItems.default 82 81 1.01:1
ButtonSlotsPerf.default 319 318 1:1
ChatDuplicateMessagesPerf.default 157 157 1:1
ChatWithPopoverPerf.default 195 195 1:1
CheckboxMinimalPerf.default 1164 1166 1:1
DialogMinimalPerf.default 446 446 1:1
EmbedMinimalPerf.default 1890 1888 1:1
LayoutMinimalPerf.default 199 199 1:1
MenuMinimalPerf.default 505 506 1:1
RefMinimalPerf.default 113 113 1:1
SplitButtonMinimalPerf.default 2282 2281 1:1
TooltipMinimalPerf.default 1312 1310 1:1
TreeMinimalPerf.default 483 485 1:1
AnimationMinimalPerf.default 297 299 0.99:1
HeaderMinimalPerf.default 208 212 0.98:1
RosterPerf.default 1567 1607 0.98:1
ProviderMergeThemesPerf.default 640 650 0.98:1
RadioGroupMinimalPerf.default 258 263 0.98:1
DividerMinimalPerf.default 202 208 0.97:1
ButtonMinimalPerf.default 86 90 0.96:1
PortalMinimalPerf.default 79 82 0.96:1
AlertMinimalPerf.default 156 164 0.95:1
ImageMinimalPerf.default 223 245 0.91:1

@fabricteam
Copy link
Collaborator

fabricteam commented Feb 8, 2024 •
edited
Loading

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Feb 8, 2024 •
edited
Loading

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext		 510 B
328 B
global-context
createContextSelector		 537 B
339 B
keyboard-key
keyboard-key package		 3.746 kB
1.928 kB
priority-overflow
createOverflowManager		 4.447 kB
1.853 kB
react
ActivityItem		 68.833 kB
22.613 kB
react
Announced		 36.473 kB
12.628 kB
react
Autofill		 15.365 kB
4.743 kB
react
Breadcrumb		 196.083 kB
58.757 kB
react
Button		 190.127 kB
55.019 kB
react
ButtonGrid		 175.918 kB
53.25 kB
react
Calendar		 118.756 kB
36.101 kB
react
Callout		 80.866 kB
26.564 kB
react
Check		 51.062 kB
17.152 kB
react
Checkbox		 57.791 kB
19.17 kB
react
ChoiceGroup		 63.339 kB
20.824 kB
react
ChoiceGroupOption		 56.601 kB
18.695 kB
react
Coachmark		 89.704 kB
28.407 kB
react
Color		 7.737 kB
3.106 kB
react
ColorPicker		 129.984 kB
40.589 kB
react
ComboBox		 245.355 kB
70.51 kB
react
CommandBar		 197.362 kB
58.46 kB
react
ContextualMenu		 150.967 kB
46.982 kB
react
DatePicker		 180.203 kB
54.911 kB
react
DateTimeUtilities		 5.244 kB
1.849 kB
react
DetailsList		 225.886 kB
64.647 kB
react
Dialog		 205.294 kB
61.428 kB
react
Divider		 17.63 kB
6.234 kB
react
DocumentCard		 211.08 kB
62.793 kB
react
DragDrop		 8.343 kB
2.724 kB
react
DraggableZone		 33.345 kB
11.166 kB
react
Dropdown		 227.732 kB
66.867 kB
react
ExtendedPicker		 94.987 kB
27.297 kB
react
Fabric		 39.75 kB
13.688 kB
react
Facepile		 205.992 kB
61.67 kB
react
FloatingPicker		 236.233 kB
67.368 kB
react
FocusTrapZone		 15.831 kB
5.54 kB
react
FocusZone		 53.259 kB
16.869 kB
react
Grid		 175.918 kB
53.25 kB
react
GroupedList		 131.636 kB
39.657 kB
react
GroupedListV2		 119.324 kB
36.822 kB
react
HoverCard		 93.735 kB
29.778 kB
react
Icon		 49.74 kB
16.603 kB
react
Icons		 65.829 kB
24.212 kB
react
Image		 44.79 kB
15.024 kB
react
Keytip		 78.588 kB
25.825 kB
react
KeytipData		 13.585 kB
4.418 kB
react
KeytipLayer		 100.422 kB
31.128 kB
react
Keytips		 103.175 kB
32.07 kB
react
Label		 36.347 kB
12.639 kB
react
Layer		 45.683 kB
15.585 kB
react
Link		 37.673 kB
12.993 kB
react
List		 38.136 kB
12.004 kB
react
MarqueeSelection		 72.119 kB
21.676 kB
react
MessageBar		 184.707 kB
55.523 kB
react
Modal		 90.409 kB
29.213 kB
react
Nav		 183.442 kB
55.093 kB
react
OverflowSet		 31.044 kB
10.593 kB
react
Overlay		 38.784 kB
13.401 kB
react
Panel		 194.946 kB
58.34 kB
react
Persona		 111.705 kB
35.58 kB
react
PersonaCoin		 111.705 kB
35.58 kB
react
PersonaPresence		 55.928 kB
18.715 kB
react
Pickers		 287.603 kB
80.607 kB
react
Pivot		 184.252 kB
55.823 kB
react
Popup		 12.032 kB
4.114 kB
react
Positioning		 21.821 kB
7.334 kB
react
PositioningContainer		 70.754 kB
22.84 kB
react
ProgressIndicator		 37.498 kB
12.906 kB
react
Rating		 78.989 kB
25.18 kB
react
ResizeGroup		 13.286 kB
4.365 kB
react
ResponsiveMode		 8.078 kB
2.95 kB
react
ScrollablePane		 53.538 kB
17.113 kB
react
SearchBox		 182.982 kB
55.1 kB
react
SelectableOption		 724 B
413 B
react
SelectedItemsList		 226.659 kB
66.321 kB
react
Selection		 41.202 kB
11.839 kB
react
Separator		 33.397 kB
11.529 kB
react
Shimmer		 47.265 kB
15.632 kB
react
ShimmeredDetailsList		 236.654 kB
67.42 kB
react
Slider		 55.575 kB
18.574 kB
react
SpinButton		 186.661 kB
56.205 kB
react
Spinner		 39.691 kB
13.815 kB
react
Stack		 40.761 kB
13.931 kB
react
Sticky		 32.064 kB
10.324 kB
react
Styling		 44.812 kB
14.688 kB
react
SwatchColorPicker		 186.166 kB
56.724 kB
react
TeachingBubble		 200.004 kB
59.345 kB
react
Text		 35.931 kB
12.486 kB
react
TextField		 78.587 kB
24.642 kB
react
Theme		 42.456 kB
13.773 kB
react
ThemeGenerator		 12.34 kB
4.106 kB
react
TimePicker		 235.197 kB
68.29 kB
react
Toggle		 44.17 kB
15.346 kB
react
Tooltip		 84.225 kB
27.277 kB
react
Utilities		 71.851 kB
21.843 kB
react
Viewport		 22.945 kB
7.292 kB
react
WeeklyDayPicker		 98.762 kB
30.828 kB
react
WindowProvider		 1.059 kB
541 B
react-accordion
Accordion (including children components)		 100.12 kB
30.422 kB
react-alert
Alert		 83.737 kB
23.474 kB
react-avatar
Avatar		 50.175 kB
15.944 kB
react-avatar
AvatarGroup		 19.704 kB
7.796 kB
react-avatar
AvatarGroupItem		 64.831 kB
20.274 kB
react-badge
Badge		 26.905 kB
8.729 kB
react-badge
CounterBadge		 27.806 kB
9.024 kB
react-badge
PresenceBadge		 25.311 kB
9.306 kB
react-button
Button		 39.513 kB
11.169 kB
react-button
CompoundButton		 46.874 kB
12.661 kB
react-button
MenuButton		 44.292 kB
12.542 kB
react-button
SplitButton		 52.306 kB
14.134 kB
react-button
ToggleButton		 56.559 kB
13.068 kB
react-calendar-compat
Calendar Compat		 152.029 kB
39.809 kB
react-card
Card - All		 101.55 kB
28.92 kB
react-card
Card		 96.373 kB
27.403 kB
react-card
CardFooter		 13.064 kB
5.385 kB
react-card
CardHeader		 15.307 kB
6.143 kB
react-card
CardPreview		 14.015 kB
5.752 kB
react-checkbox
Checkbox		 35.65 kB
12.076 kB
react-combobox
Combobox (including child components)		 98.361 kB
31.717 kB
react-combobox
Dropdown (including child components)		 99.582 kB
31.715 kB
react-components
react-components: Button, FluentProvider & webLightTheme		 70.688 kB
20.464 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 217.141 kB
61.938 kB
react-components
react-components: FluentProvider & webLightTheme		 43.173 kB
14.298 kB
react-datepicker-compat
DatePicker Compat		 224.19 kB
62.825 kB
react-dialog
Dialog (including children components)		 100.923 kB
29.928 kB
react-divider
Divider		 20.82 kB
7.763 kB
react-field
Field		 22.544 kB
8.61 kB
react-image
Image		 15.736 kB
6.228 kB
react-infobutton
InfoButton		 138.652 kB
43.388 kB
react-infobutton
InfoLabel		 142.453 kB
44.619 kB
react-input
Input		 26.887 kB
9.118 kB
react-jsx-runtime
Classic Pragma		 1.057 kB
530 B
react-jsx-runtime
JSX Dev Runtime		 3.783 kB
1.648 kB
react-jsx-runtime
JSX Runtime		 4.377 kB
1.881 kB
react-label
Label		 14.266 kB
5.828 kB
react-link
Link		 17.082 kB
6.911 kB
react-menu
Menu (including children components)		 149.37 kB
45.493 kB
react-menu
Menu (including selectable components)		 152.056 kB
46.004 kB
react-message-bar
MessageBar (all components)		 25.566 kB
9.131 kB
react-northstar
Accordion		 85.357 kB
26.509 kB
react-northstar
Alert		 87.425 kB
26.91 kB
react-northstar
Animation		 55.304 kB
17.834 kB
react-northstar
Attachment		 86.819 kB
26.7 kB
react-northstar
Avatar		 80.254 kB
24.634 kB
react-northstar
Box		 75.223 kB
23.814 kB
react-northstar
Breadcrumb		 79.889 kB
24.707 kB
react-northstar
Button		 83.135 kB
25.957 kB
react-northstar
Card		 82.674 kB
25.027 kB
react-northstar
Carousel		 105.15 kB
31.882 kB
react-northstar
Chat		 152.326 kB
45.963 kB
react-northstar
Checkbox		 79.782 kB
25.085 kB
react-northstar
Datepicker		 184.887 kB
56.167 kB
react-northstar
Debug		 8.801 kB
3.594 kB
react-northstar
Design		 36.564 kB
12.07 kB
react-northstar
Dialog		 112.02 kB
33.638 kB
react-northstar
Divider		 76.594 kB
24.137 kB
react-northstar
Dropdown		 196.43 kB
59.442 kB
react-northstar
Embed		 81.446 kB
25.42 kB
react-northstar
Flex		 47.702 kB
15.45 kB
react-northstar
Form		 92.492 kB
28.881 kB
react-northstar
Grid		 70.555 kB
22.283 kB
react-northstar
Header		 74.731 kB
23.476 kB
react-northstar
Image		 73.566 kB
23.339 kB
react-northstar
Input		 88.31 kB
27.784 kB
react-northstar
ItemLayout		 78.206 kB
24.458 kB
react-northstar
Label		 77.895 kB
24.415 kB
react-northstar
Layout		 75.368 kB
23.806 kB
react-northstar
List		 88.472 kB
27.57 kB
react-northstar
Loader		 78.591 kB
24.745 kB
react-northstar
Menu		 126.85 kB
39.875 kB
react-northstar
MenuButton		 161.254 kB
48.881 kB
react-northstar
Pill		 83.697 kB
26.077 kB
react-northstar
Popup		 133.56 kB
41.486 kB
react-northstar
Portal		 58.294 kB
18.855 kB
react-northstar
Provider		 93.114 kB
29.626 kB
react-northstar
RadioGroup		 83.25 kB
26.056 kB
react-northstar
Reaction		 77.255 kB
24.138 kB
react-northstar
Segment		 76.184 kB
23.899 kB
react-northstar
Skeleton		 77.74 kB
24.21 kB
react-northstar
Slider		 84.235 kB
26.744 kB
react-northstar
SplitButton		 176.487 kB
52.632 kB
react-northstar
Status		 76.247 kB
24.059 kB
react-northstar
SvgIcon		 36.819 kB
11.744 kB
react-northstar
Table		 80.765 kB
25.159 kB
react-northstar
Text		 74.089 kB
23.522 kB
react-northstar
TextArea		 74.223 kB
23.501 kB
react-northstar
Toolbar		 173.3 kB
52.087 kB
react-northstar
Tooltip		 108.23 kB
34.491 kB
react-northstar
Tree		 87.83 kB
27.223 kB
react-northstar
Video		 75.379 kB
23.794 kB
react-overflow
hooks only		 12.862 kB
4.827 kB
react-persona
Persona		 57.066 kB
17.821 kB
react-popover
Popover		 126.842 kB
39.8 kB
react-portal
Portal		 13.591 kB
4.869 kB
react-portal-compat
PortalCompatProvider		 7.902 kB
2.586 kB
react-positioning
usePositioning		 26.398 kB
9.539 kB
react-progress
ProgressBar		 17.428 kB
6.898 kB
react-provider
FluentProvider		 23.713 kB
8.655 kB
react-radio
Radio		 32.946 kB
10.252 kB
react-radio
RadioGroup		 15.345 kB
6.263 kB
react-select
Select		 28.609 kB
10.205 kB
react-slider
Slider		 39.943 kB
12.969 kB
react-spinbutton
SpinButton		 36.774 kB
11.788 kB
react-spinner
Spinner		 23.517 kB
8.512 kB
react-switch
Switch		 35.134 kB
11.198 kB
react-table
DataGrid		 165.124 kB
45.892 kB
react-table
Table (Primitives only)		 45.28 kB
14.111 kB
react-table
Table as DataGrid		 136.504 kB
36.822 kB
react-table
Table (Selection only)		 76.269 kB
20.541 kB
react-table
Table (Sort only)		 74.935 kB
20.151 kB
react-tags
InteractionTag		 15.259 kB
6.058 kB
react-tags
Tag		 29.982 kB
9.439 kB
react-tags
TagGroup		 80.55 kB
24.027 kB
react-text
Text - Default		 16.705 kB
6.569 kB
react-text
Text - Wrappers		 19.878 kB
6.896 kB
react-textarea
Textarea		 30.947 kB
10.476 kB
react-theme
Single theme token import		 69 B
89 B
react-theme
Teams: all themes		 34.616 kB
7.317 kB
react-theme
Teams: Light theme		 19.287 kB
5.498 kB
react-timepicker-compat
TimePicker		 100.234 kB
33.18 kB
react-toast
Toast (including Toaster)		 100.154 kB
29.761 kB
react-tooltip
Tooltip		 54.538 kB
19.187 kB
react-utilities
SSRProvider		 180 B
160 B
🤖 This report was generated against 0d209623de09cf40a7328494b3b00dc9207cd170

@fabricteam
Copy link
Collaborator

fabricteam commented Feb 8, 2024 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 639 631 5000
Breadcrumb mount 1705 1697 1000
Checkbox mount 1728 1666 5000
CheckboxBase mount 1509 1463 5000
ChoiceGroup mount 2978 2934 5000
ComboBox mount 658 682 1000
CommandBar mount 6303 6405 1000
ContextualMenu mount 12955 12910 1000
DefaultButton mount 767 751 5000
DetailsRow mount 2223 2188 5000
DetailsRowFast mount 2208 2207 5000
DetailsRowNoStyles mount 1997 2043 5000
Dialog mount 2823 2786 1000
DocumentCardTitle mount 222 229 1000
Dropdown mount 2001 1962 5000
FocusTrapZone mount 1140 1136 5000
FocusZone mount 1092 1067 5000
GroupedList mount 42232 42020 2
GroupedList virtual-rerender 20333 20038 2
GroupedList virtual-rerender-with-unmount 51054 51353 2
GroupedListV2 mount 233 234 2
GroupedListV2 virtual-rerender 205 224 2
GroupedListV2 virtual-rerender-with-unmount 223 231 2
IconButton mount 1083 1101 5000
Label mount 340 326 5000
Layer mount 2722 2760 5000
Link mount 394 382 5000
MenuButton mount 933 951 5000
MessageBar mount 23093 21508 5000
Nav mount 1964 1973 1000
OverflowSet mount 795 778 5000
Panel mount 1788 1750 1000
Persona mount 771 742 1000
Pivot mount 876 894 1000
PrimaryButton mount 848 848 5000
Rating mount 4616 4600 5000
SearchBox mount 923 893 5000
Shimmer mount 1858 1887 5000
Slider mount 1310 1346 5000
SpinButton mount 2905 2925 5000
Spinner mount 400 392 5000
SplitButton mount 1884 1827 5000
Stack mount 411 420 5000
StackWithIntrinsicChildren mount 853 901 5000
StackWithTextChildren mount 2625 2614 5000
SwatchColorPicker mount 6210 6265 5000
TagPicker mount 1451 1475 5000
Text mount 386 373 5000
TextField mount 908 966 5000
ThemeProvider mount 848 826 5000
ThemeProvider virtual-rerender 584 597 5000
ThemeProvider virtual-rerender-with-unmount 1280 1282 5000
Toggle mount 597 613 5000
buttonNative mount 189 190 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Feb 8, 2024 •
edited
Loading

🕵 fluentuiv9 No visual regressions between this PR and main

@Hotell Hotell marked this pull request as ready for review February 8, 2024 15:19
@Hotell Hotell requested a review from a team as a code owner February 8, 2024 15:19
@tudorpopams tudorpopams self-requested a review February 13, 2024 13:08
@Hotell Hotell merged commit f66e0d0 into microsoft:master Feb 13, 2024
21 checks passed
@Hotell Hotell deleted the nx-migration/migrate-lage-task-graph-definitions branch February 13, 2024 16:43
@Hotell Hotell mentioned this pull request Mar 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tudorpopams tudorpopams tudorpopams approved these changes

Assignees
No one assigned
Labels
NX: core
Projects
None yet
Milestone
February Project Cycle Q1 2024
Development

Successfully merging this pull request may close these issues.
3 participants
@Hotell @fabricteam @tudorpopams