-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit and vr tests to Rating #30414
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit bb405ac:
|
….json in vr tests
📊 Bundle size report🤖 This report was generated against ad5da7b666f33ecfb5b296ea9bb9824dc9f01662 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: ec4c7fe368e91c0ba4e2685e21b6d48780124269 (build) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple comments on the a11y bits, the other tests look good.
I think it makes sense to add this in a separate PR, but both Rating and Rating display probably need some sort of (value) => string
function prop to generate labels for individual rating items and also the display value text.
...ages/react-components/react-rating-preview/src/components/RatingDisplay/useRatingDisplay.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-rating-preview/src/components/Rating/Rating.test.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-rating-preview/src/components/Rating/Rating.test.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-rating-preview/src/components/Rating/Rating.test.tsx
Show resolved
Hide resolved
...ages/react-components/react-rating-preview/src/components/RatingDisplay/useRatingDisplay.tsx
Outdated
Show resolved
Hide resolved
...es/react-components/react-rating-preview/src/components/RatingDisplay/RatingDisplay.test.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-rating-preview/src/components/Rating/Rating.test.tsx
Show resolved
Hide resolved
packages/react-components/react-rating-preview/src/components/RatingItem/RatingItem.test.tsx
Show resolved
Hide resolved
packages/react-components/react-rating-preview/src/components/RatingItem/RatingItem.test.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-rating-preview/src/components/RatingItem/RatingItem.test.tsx
Outdated
Show resolved
Hide resolved
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
This PR is to add unit and vr tests to
Rating
. It adds unit tests forRating
,RatingDisplay
, andRatingItem
, and adds vr tests forRating
andRatingDisplay