Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit and vr tests to Rating #30414

Merged
merged 13 commits into from
Feb 2, 2024

Conversation

tomi-msft
Copy link
Contributor

This PR is to add unit and vr tests to Rating. It adds unit tests for Rating, RatingDisplay, and RatingItem, and adds vr tests for Rating and RatingDisplay

@tomi-msft tomi-msft requested review from a team as code owners January 29, 2024 09:34
Copy link

codesandbox-ci bot commented Jan 29, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bb405ac:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Jan 29, 2024

📊 Bundle size report

🤖 This report was generated against ad5da7b666f33ecfb5b296ea9bb9824dc9f01662

Copy link

size-auditor bot commented Jan 29, 2024

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: ec4c7fe368e91c0ba4e2685e21b6d48780124269 (build)

Copy link
Contributor

@smhigley smhigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple comments on the a11y bits, the other tests look good.

I think it makes sense to add this in a separate PR, but both Rating and Rating display probably need some sort of (value) => string function prop to generate labels for individual rating items and also the display value text.

@tomi-msft
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@tomi-msft tomi-msft self-assigned this Feb 1, 2024
@tomi-msft tomi-msft merged commit e45b040 into microsoft:master Feb 2, 2024
18 checks passed
@tomi-msft tomi-msft deleted the react-rating-tests branch February 2, 2024 21:03
@tomi-msft tomi-msft mentioned this pull request Feb 5, 2024
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants