Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(useActiveDescendant): Changing active descendant scrolls into view #29992

Merged

Conversation

ling1726
Copy link
Member

@ling1726 ling1726 commented Dec 5, 2023

During the change to the next active descendant, check if it needs to be scrolled into view and do so.

Addresses #26652

During the change to the next active descendant, check if it needs to be
scrolled into view and do so.
@ling1726 ling1726 marked this pull request as ready for review December 5, 2023 13:01
@ling1726 ling1726 requested a review from a team as a code owner December 5, 2023 13:01
@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 633 632 5000
Button mount 322 306 5000
Field mount 1162 1155 5000
FluentProvider mount 720 713 5000
FluentProviderWithTheme mount 87 84 10
FluentProviderWithTheme virtual-rerender 64 62 10
FluentProviderWithTheme virtual-rerender-with-unmount 70 77 10
MakeStyles mount 864 860 50000
Persona mount 1719 1746 5000
SpinButton mount 1351 1367 5000

Copy link

codesandbox-ci bot commented Dec 5, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4420940:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-accordion
Accordion (including children components)
93.224 kB
28.468 kB
react-alert
Alert
83.926 kB
23.362 kB
react-avatar
Avatar
50.167 kB
15.836 kB
react-avatar
AvatarGroup
19.696 kB
7.8 kB
react-avatar
AvatarGroupItem
64.823 kB
20.176 kB
react-button
Button
39.707 kB
11.207 kB
react-button
CompoundButton
47.063 kB
12.691 kB
react-button
MenuButton
44.481 kB
12.569 kB
react-button
SplitButton
52.495 kB
14.166 kB
react-button
ToggleButton
56.754 kB
13.104 kB
react-card
Card - All
93.207 kB
27.001 kB
react-card
Card
88.031 kB
25.501 kB
react-card
CardFooter
13.056 kB
5.388 kB
react-card
CardHeader
15.299 kB
6.143 kB
react-card
CardPreview
14.007 kB
5.757 kB
react-components
react-components: Button, FluentProvider & webLightTheme
69.816 kB
20.132 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
208.225 kB
59.512 kB
react-components
react-components: FluentProvider & webLightTheme
42.101 kB
13.957 kB
react-datepicker-compat
DatePicker Compat
213.203 kB
59.559 kB
react-dialog
Dialog (including children components)
94.805 kB
28.321 kB
react-infobutton
InfoButton
131.436 kB
41.374 kB
react-infobutton
InfoLabel
135.123 kB
42.51 kB
react-menu
Menu (including children components)
141.042 kB
43.238 kB
react-menu
Menu (including selectable components)
143.728 kB
43.739 kB
react-message-bar
MessageBar (all components)
25.173 kB
9.005 kB
react-persona
Persona
57.058 kB
17.711 kB
react-popover
Popover
120.17 kB
37.863 kB
react-portal-compat
PortalCompatProvider
6.822 kB
2.311 kB
react-table
DataGrid
153.989 kB
43.365 kB
react-table
Table (Primitives only)
43.805 kB
13.72 kB
react-table
Table as DataGrid
127.211 kB
34.69 kB
react-table
Table (Selection only)
72.389 kB
19.864 kB
react-table
Table (Sort only)
70.996 kB
19.467 kB
react-tags
InteractionTag
15.251 kB
6.062 kB
react-tags
Tag
29.974 kB
9.408 kB
react-tags
TagGroup
74.055 kB
22.168 kB
react-toast
Toast (including Toaster)
92.972 kB
27.892 kB
🤖 This report was generated against 419d7609ad9ce151f8f544c891d55e3a395c13d1

Copy link

size-auditor bot commented Dec 5, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 419d7609ad9ce151f8f544c891d55e3a395c13d1 (build)

@fabricteam
Copy link
Collaborator

🕵 fluentuiv9 No visual regressions between this PR and main

@ling1726 ling1726 merged commit 8a9fadf into microsoft:master Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants