Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(react-tags-preview): update dismiss and overflow story #29260

Merged
merged 12 commits into from
Sep 25, 2023

Conversation

YuanboXue-Amber
Copy link
Contributor

@YuanboXue-Amber YuanboXue-Amber commented Sep 22, 2023

fix #29221 - add reset button to dismiss example:
Screenshot 2023-09-22 at 13 02 04
When all tags are dismissed, the dismiss button is focused+enabled:
Screenshot 2023-09-22 at 13 02 14

fix #29220 - increase overflow example padding

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 22, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9dd4255:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 22, 2023

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-tags-preview
InteractionTag
14.356 kB
5.746 kB
react-tags-preview
Tag
30.349 kB
9.798 kB
react-tags-preview
TagGroup
72.851 kB
21.693 kB
🤖 This report was generated against c9b7dde0872c3fe5a639165a8f507b6099daed7f

@size-auditor
Copy link

size-auditor bot commented Sep 22, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: c9b7dde0872c3fe5a639165a8f507b6099daed7f (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 22, 2023

🕵 fluentuiv9 No visual regressions between this PR and main

@YuanboXue-Amber YuanboXue-Amber marked this pull request as ready for review September 22, 2023 14:02
@YuanboXue-Amber YuanboXue-Amber requested review from a team as code owners September 22, 2023 14:02
YuanboXue-Amber and others added 11 commits September 25, 2023 12:01
…onTag/InteractionTagDismiss.stories.tsx

Co-authored-by: Oleksandr Fediashov <[email protected]>
…onTag/InteractionTagDismiss.stories.tsx

Co-authored-by: Oleksandr Fediashov <[email protected]>
…TagGroupDismiss.stories.tsx

Co-authored-by: Oleksandr Fediashov <[email protected]>
…TagGroupDismiss.stories.tsx

Co-authored-by: Oleksandr Fediashov <[email protected]>
…TagGroupDismiss.stories.tsx

Co-authored-by: Oleksandr Fediashov <[email protected]>
…TagGroupDismiss.stories.tsx

Co-authored-by: Oleksandr Fediashov <[email protected]>
@YuanboXue-Amber YuanboXue-Amber requested a review from a team as a code owner September 25, 2023 10:03
@YuanboXue-Amber YuanboXue-Amber enabled auto-merge (squash) September 25, 2023 10:04
@YuanboXue-Amber YuanboXue-Amber merged commit 9512bd6 into microsoft:master Sep 25, 2023
@YuanboXue-Amber YuanboXue-Amber deleted the yuanboxue/tag-5 branch September 25, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tag dismiss examples should have a 'reset' button TagGroup overflow example needs more padding
4 participants