Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: v9 Option hover and pressed tokens #28592

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+9 −0
Open

fix: v9 Option hover and pressed tokens #28592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6539d1f
add color tokens for hover and pressed
smhigley Jul 20, 2023
06c689c
change file
smhigley Jul 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-combobox-61c39a8b-d105-4eb8-bcd6-542e55ca5db5.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵 fluentuiv9 Open the Visual Regressions report to inspect the affected screenshots

Combobox Converged 2 screenshots
Image Name Diff(in Pixels) Image Type
Combobox Converged.Disabled option.active option.chromium.png 53 Changed
Combobox Converged.Disabled option.hover.chromium.png 53 Changed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like you need to ensure that these colors are properly overriden when an Option is disabled.

"type": "patch",
"comment": "fix: add color tokens for option hover and pressed states",
"packageName": "@fluentui/react-combobox",
"email": "[email protected]",
"dependentChangeType": "patch"
}
2 changes: 2 additions & 0 deletions packages/react-components/react-combobox/src/components/Option/useOptionStyles.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,12 @@ const useStyles = makeStyles({

'&:hover': {
backgroundColor: tokens.colorNeutralBackground1Hover,
color: tokens.colorNeutralForeground1Hover,
},

'&:active': {
backgroundColor: tokens.colorNeutralBackground1Pressed,
color: tokens.colorNeutralForeground1Pressed,
},
},

Expand Down