Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump to chalk 4.1 and remove unnecessary syncpack version groups #28336

Closed

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Jun 27, 2023

New Behavior

  • removing unnecesary versionGroups
  • bumping react conformance to monorepo chalk version (which is also faster)

Related Issue(s)

@Hotell Hotell changed the title Hotell/deps/cleanup version groups chore: bump to chalk 4.1 and remove unnecessary syncpack version groups Jun 27, 2023
@github-actions github-actions bot added this to the June Project Cycle Q2 2023 milestone Jun 27, 2023
@Hotell Hotell added Area: Build System dependencies Pull requests that update a dependency file labels Jun 27, 2023
@fabricteam
Copy link
Collaborator

fabricteam commented Jun 27, 2023

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext
510 B
330 B
global-context
createContextSelector
537 B
342 B
priority-overflow
createOverflowManager
4.248 kB
1.671 kB
react-accordion
Accordion (including children components)
88.246 kB
26.712 kB
react-alert
Alert
82.552 kB
21.771 kB
react-avatar
Avatar
47.7 kB
14.504 kB
react-avatar
AvatarGroup
15.682 kB
6.306 kB
react-avatar
AvatarGroupItem
63.876 kB
18.984 kB
react-badge
Badge
23.591 kB
7.264 kB
react-badge
CounterBadge
24.493 kB
7.565 kB
react-badge
PresenceBadge
22.213 kB
7.872 kB
react-button
Button
36.778 kB
9.51 kB
react-button
CompoundButton
43.932 kB
10.99 kB
react-button
MenuButton
40.965 kB
10.705 kB
react-button
SplitButton
49.197 kB
12.27 kB
react-button
ToggleButton
55.06 kB
11.446 kB
react-card
Card - All
89.11 kB
25.236 kB
react-card
Card
83.764 kB
23.685 kB
react-card
CardFooter
9.229 kB
3.9 kB
react-card
CardHeader
11.402 kB
4.683 kB
react-card
CardPreview
10.034 kB
4.248 kB
react-checkbox
Checkbox
33.164 kB
10.699 kB
react-combobox
Combobox (including child components)
86.98 kB
28.084 kB
react-combobox
Dropdown (including child components)
85.321 kB
27.675 kB
react-components
react-components: Button, FluentProvider & webLightTheme
65.162 kB
17.952 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
210.395 kB
58.717 kB
react-components
react-components: FluentProvider & webLightTheme
36.395 kB
11.996 kB
react-datepicker-compat
DatePicker Compat
221.924 kB
59.118 kB
react-dialog
Dialog (including children components)
92.138 kB
27.487 kB
react-divider
Divider
17.477 kB
6.357 kB
react-field
Field
18.003 kB
6.931 kB
react-image
Image
11.55 kB
4.627 kB
react-infobutton
InfoButton
131.191 kB
40.269 kB
react-infobutton
InfoLabel
134.656 kB
41.338 kB
react-input
Input
24.219 kB
7.781 kB
react-label
Label
10.175 kB
4.243 kB
react-link
Link
12.375 kB
5.113 kB
react-menu
Menu (including children components)
132.388 kB
40.52 kB
react-menu
Menu (including selectable components)
135.152 kB
41.012 kB
react-overflow
hooks only
12.505 kB
4.626 kB
react-persona
Persona
54.621 kB
16.435 kB
react-popover
Popover
119.781 kB
36.844 kB
react-portal
Portal
11.82 kB
4.391 kB
react-portal-compat
PortalCompatProvider
6.473 kB
2.196 kB
react-positioning
usePositioning
24.249 kB
8.856 kB
react-progress
ProgressBar
13.927 kB
5.488 kB
react-provider
FluentProvider
18.115 kB
6.719 kB
react-radio
Radio
26.952 kB
8.608 kB
react-radio
RadioGroup
11.362 kB
4.753 kB
react-select
Select
24.915 kB
8.708 kB
react-slider
Slider
34.358 kB
11.107 kB
react-spinbutton
SpinButton
33.452 kB
10.296 kB
react-spinner
Spinner
21.363 kB
7.021 kB
react-switch
Switch
29.472 kB
9.226 kB
react-table
DataGrid
156.649 kB
42.835 kB
react-table
Table (Primitives only)
44.652 kB
12.468 kB
react-table
Table as DataGrid
132.304 kB
33.864 kB
react-table
Table (Selection only)
77.906 kB
19.26 kB
react-table
Table (Sort only)
76.891 kB
18.989 kB
react-tags
Tag
23.162 kB
7.925 kB
react-text
Text - Default
12.563 kB
4.972 kB
react-text
Text - Wrappers
15.713 kB
5.293 kB
react-textarea
Textarea
27.69 kB
9.125 kB
react-theme
Single theme token import
69 B
89 B
react-theme
Teams: all themes
31.987 kB
6.85 kB
react-theme
Teams: Light theme
18.121 kB
5.194 kB
react-tooltip
Tooltip
47.319 kB
16.618 kB
react-utilities
SSRProvider
180 B
159 B
🤖 This report was generated against a3e382f56ec5100024c29b14eaccd102adb54f86

@fabricteam
Copy link
Collaborator

fabricteam commented Jun 27, 2023

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
InfoButton mount 14 15 5000 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 591 590 5000
Button mount 286 290 5000
Field mount 1045 1060 5000
FluentProvider mount 652 636 5000
FluentProviderWithTheme mount 71 79 10
FluentProviderWithTheme virtual-rerender 62 59 10
FluentProviderWithTheme virtual-rerender-with-unmount 73 73 10
InfoButton mount 14 15 5000 Possible regression
MakeStyles mount 855 849 50000
Persona mount 1657 1558 5000
SpinButton mount 1294 1284 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Jun 27, 2023

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
TreeWith60ListItems.default 97 82 1.18:1
AttachmentMinimalPerf.default 88 75 1.17:1
RefMinimalPerf.default 117 106 1.1:1
TextAreaMinimalPerf.default 301 274 1.1:1
CardMinimalPerf.default 330 303 1.09:1
ImageMinimalPerf.default 229 214 1.07:1
SegmentMinimalPerf.default 209 196 1.07:1
FormMinimalPerf.default 233 219 1.06:1
PortalMinimalPerf.default 88 83 1.06:1
RadioGroupMinimalPerf.default 268 256 1.05:1
ChatDuplicateMessagesPerf.default 150 144 1.04:1
FlexMinimalPerf.default 160 154 1.04:1
ListWith60ListItems.default 378 365 1.04:1
PopupMinimalPerf.default 358 344 1.04:1
ReactionMinimalPerf.default 210 201 1.04:1
TextMinimalPerf.default 195 188 1.04:1
AttachmentSlotsPerf.default 666 644 1.03:1
ChatMinimalPerf.default 439 426 1.03:1
ListNestedPerf.default 318 310 1.03:1
LoaderMinimalPerf.default 189 183 1.03:1
ProviderMinimalPerf.default 201 196 1.03:1
TreeMinimalPerf.default 487 475 1.03:1
AccordionMinimalPerf.default 82 80 1.02:1
AvatarMinimalPerf.default 107 105 1.02:1
CheckboxMinimalPerf.default 1154 1131 1.02:1
HeaderSlotsPerf.default 467 458 1.02:1
ItemLayoutMinimalPerf.default 717 704 1.02:1
MenuMinimalPerf.default 502 490 1.02:1
AlertMinimalPerf.default 156 154 1.01:1
EmbedMinimalPerf.default 1878 1866 1.01:1
LayoutMinimalPerf.default 203 200 1.01:1
MenuButtonMinimalPerf.default 964 957 1.01:1
SliderMinimalPerf.default 733 724 1.01:1
SplitButtonMinimalPerf.default 2261 2230 1.01:1
TableManyItemsPerf.default 1130 1123 1.01:1
ButtonMinimalPerf.default 86 86 1:1
ButtonOverridesMissPerf.default 657 654 1:1
ListCommonPerf.default 393 394 1:1
ProviderMergeThemesPerf.default 671 669 1:1
SkeletonMinimalPerf.default 199 199 1:1
StatusMinimalPerf.default 396 396 1:1
CustomToolbarPrototype.default 1480 1479 1:1
AnimationMinimalPerf.default 292 295 0.99:1
DialogMinimalPerf.default 439 442 0.99:1
DropdownMinimalPerf.default 1420 1433 0.99:1
ButtonSlotsPerf.default 320 328 0.98:1
CarouselMinimalPerf.default 270 275 0.98:1
ChatWithPopoverPerf.default 196 201 0.98:1
DatepickerMinimalPerf.default 3536 3592 0.98:1
DividerMinimalPerf.default 209 214 0.98:1
InputMinimalPerf.default 530 541 0.98:1
ToolbarMinimalPerf.default 534 546 0.98:1
VideoMinimalPerf.default 428 436 0.98:1
DropdownManyItemsPerf.default 384 397 0.97:1
GridMinimalPerf.default 186 191 0.97:1
HeaderMinimalPerf.default 205 212 0.97:1
RosterPerf.default 1505 1558 0.97:1
TableMinimalPerf.default 236 244 0.97:1
TooltipMinimalPerf.default 1257 1301 0.97:1
ListMinimalPerf.default 300 316 0.95:1
LabelMinimalPerf.default 212 225 0.94:1
IconMinimalPerf.default 376 400 0.94:1
BoxMinimalPerf.default 192 218 0.88:1

@fabricteam
Copy link
Collaborator

fabricteam commented Jun 27, 2023

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Jun 27, 2023

🕵 FluentUI-v0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Jun 27, 2023

🕵 fluentuiv9 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Jun 27, 2023

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 653 622 5000
Breadcrumb mount 1653 1694 1000
Checkbox mount 1710 1711 5000
CheckboxBase mount 1494 1486 5000
ChoiceGroup mount 3001 2951 5000
ComboBox mount 643 671 1000
CommandBar mount 6217 6203 1000
ContextualMenu mount 12683 12580 1000
DefaultButton mount 734 746 5000
DetailsRow mount 2192 2184 5000
DetailsRowFast mount 2195 2214 5000
DetailsRowNoStyles mount 2012 1997 5000
Dialog mount 2766 2771 1000
DocumentCardTitle mount 237 216 1000
Dropdown mount 1980 1963 5000
FocusTrapZone mount 1125 1107 5000
FocusZone mount 1084 1059 5000
GroupedList mount 40902 41425 2
GroupedList virtual-rerender 19788 19732 2
GroupedList virtual-rerender-with-unmount 50213 54479 2
GroupedListV2 mount 224 231 2
GroupedListV2 virtual-rerender 210 207 2
GroupedListV2 virtual-rerender-with-unmount 226 217 2
IconButton mount 1077 1086 5000
Label mount 329 335 5000
Layer mount 2745 2738 5000
Link mount 390 384 5000
MenuButton mount 930 942 5000
MessageBar mount 21834 21915 5000
Nav mount 1979 1968 1000
OverflowSet mount 774 789 5000
Panel mount 2059 1775 1000
Persona mount 759 761 1000
Pivot mount 885 868 1000
PrimaryButton mount 863 867 5000
Rating mount 4598 4571 5000
SearchBox mount 917 932 5000
Shimmer mount 1891 1900 5000
Slider mount 1320 1314 5000
SpinButton mount 2902 2836 5000
Spinner mount 386 373 5000
SplitButton mount 1844 1863 5000
Stack mount 412 420 5000
StackWithIntrinsicChildren mount 871 865 5000
StackWithTextChildren mount 2647 2626 5000
SwatchColorPicker mount 6103 6156 5000
TagPicker mount 1514 1446 5000
Text mount 381 374 5000
TextField mount 964 976 5000
ThemeProvider mount 871 850 5000
ThemeProvider virtual-rerender 588 583 5000
ThemeProvider virtual-rerender-with-unmount 1268 1289 5000
Toggle mount 611 609 5000
buttonNative mount 190 187 5000

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 27, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit deccaad:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Jun 27, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: a3e382f56ec5100024c29b14eaccd102adb54f86 (build)

@Hotell Hotell force-pushed the hotell/deps/cleanup-version-groups branch from 5c27090 to 1c6914a Compare June 28, 2023 11:17
@Hotell Hotell force-pushed the hotell/deps/cleanup-version-groups branch from 1c6914a to deccaad Compare June 30, 2023 08:55
@Hotell Hotell closed this Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Build System dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants