chore: migrate to TS 4.6 #27999
Merged
chore: migrate to TS 4.6 #27999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit df1ecd1:
|
🕵 fluentuiv8 No visual regressions between this PR and main |
📊 Bundle size reportUnchanged fixtures
|
…ed in prevoius api-extractor calls, now triggering generation-api errors
Hotell
force-pushed
the
hotell/build/ts-4-6
branch
from
2618f29 to
df1ecd1
Compare
Hotell
commented
May 31, 2023
packages/react-components/babel-preset-storybook-full-source/tsconfig.lib.json
Show resolved
Hide resolved
Asset size changes
Baseline commit: 65f0125dd6a85c3c772d63ad3350561af77addbc (build) |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 580 | 572 | 5000 | |
| Button | mount | 299 | 290 | 5000 | |
| Field | mount | 1017 | 1009 | 5000 | |
| FluentProvider | mount | 640 | 641 | 5000 | |
| FluentProviderWithTheme | mount | 70 | 81 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 73 | 69 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 69 | 74 | 10 | |
| InfoButton | mount | 16 | 13 | 5000 | |
| MakeStyles | mount | 871 | 885 | 50000 | |
| Persona | mount | 1603 | 1554 | 5000 | |
| SpinButton | mount | 1310 | 1259 | 5000 |
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| RefMinimalPerf.default | 114 | 104 | 1.1:1 |
| ChatDuplicateMessagesPerf.default | 152 | 141 | 1.08:1 |
| FlexMinimalPerf.default | 157 | 146 | 1.08:1 |
| ReactionMinimalPerf.default | 219 | 205 | 1.07:1 |
| TableMinimalPerf.default | 248 | 231 | 1.07:1 |
| ButtonMinimalPerf.default | 91 | 87 | 1.05:1 |
| CarouselMinimalPerf.default | 275 | 262 | 1.05:1 |
| ChatMinimalPerf.default | 456 | 436 | 1.05:1 |
| TooltipMinimalPerf.default | 1318 | 1251 | 1.05:1 |
| AccordionMinimalPerf.default | 84 | 81 | 1.04:1 |
| AttachmentMinimalPerf.default | 81 | 78 | 1.04:1 |
| AttachmentSlotsPerf.default | 674 | 646 | 1.04:1 |
| BoxMinimalPerf.default | 200 | 193 | 1.04:1 |
| LoaderMinimalPerf.default | 202 | 194 | 1.04:1 |
| SegmentMinimalPerf.default | 198 | 190 | 1.04:1 |
| ItemLayoutMinimalPerf.default | 731 | 707 | 1.03:1 |
| LabelMinimalPerf.default | 218 | 212 | 1.03:1 |
| PopupMinimalPerf.default | 351 | 340 | 1.03:1 |
| PortalMinimalPerf.default | 95 | 92 | 1.03:1 |
| ProviderMinimalPerf.default | 203 | 197 | 1.03:1 |
| IconMinimalPerf.default | 397 | 385 | 1.03:1 |
| CheckboxMinimalPerf.default | 1140 | 1122 | 1.02:1 |
| DatepickerMinimalPerf.default | 3584 | 3523 | 1.02:1 |
| DialogMinimalPerf.default | 460 | 449 | 1.02:1 |
| GridMinimalPerf.default | 189 | 185 | 1.02:1 |
| HeaderMinimalPerf.default | 211 | 207 | 1.02:1 |
| ImageMinimalPerf.default | 224 | 219 | 1.02:1 |
| InputMinimalPerf.default | 549 | 540 | 1.02:1 |
| ListNestedPerf.default | 328 | 322 | 1.02:1 |
| MenuMinimalPerf.default | 502 | 493 | 1.02:1 |
| ProviderMergeThemesPerf.default | 678 | 667 | 1.02:1 |
| CustomToolbarPrototype.default | 1455 | 1424 | 1.02:1 |
| TreeWith60ListItems.default | 87 | 85 | 1.02:1 |
| EmbedMinimalPerf.default | 1761 | 1740 | 1.01:1 |
| SkeletonMinimalPerf.default | 199 | 198 | 1.01:1 |
| SliderMinimalPerf.default | 690 | 686 | 1.01:1 |
| ButtonOverridesMissPerf.default | 632 | 631 | 1:1 |
| ButtonSlotsPerf.default | 315 | 316 | 1:1 |
| DropdownManyItemsPerf.default | 388 | 389 | 1:1 |
| DropdownMinimalPerf.default | 1419 | 1415 | 1:1 |
| FormMinimalPerf.default | 227 | 227 | 1:1 |
| HeaderSlotsPerf.default | 476 | 478 | 1:1 |
| SplitButtonMinimalPerf.default | 2270 | 2269 | 1:1 |
| ToolbarMinimalPerf.default | 549 | 549 | 1:1 |
| AnimationMinimalPerf.default | 293 | 297 | 0.99:1 |
| ChatWithPopoverPerf.default | 188 | 190 | 0.99:1 |
| ListWith60ListItems.default | 362 | 366 | 0.99:1 |
| MenuButtonMinimalPerf.default | 959 | 972 | 0.99:1 |
| RosterPerf.default | 1551 | 1567 | 0.99:1 |
| RadioGroupMinimalPerf.default | 267 | 269 | 0.99:1 |
| TableManyItemsPerf.default | 1137 | 1144 | 0.99:1 |
| TreeMinimalPerf.default | 476 | 479 | 0.99:1 |
| CardMinimalPerf.default | 305 | 311 | 0.98:1 |
| LayoutMinimalPerf.default | 205 | 209 | 0.98:1 |
| VideoMinimalPerf.default | 434 | 443 | 0.98:1 |
| AlertMinimalPerf.default | 154 | 158 | 0.97:1 |
| DividerMinimalPerf.default | 201 | 208 | 0.97:1 |
| ListCommonPerf.default | 389 | 402 | 0.97:1 |
| StatusMinimalPerf.default | 394 | 405 | 0.97:1 |
| TextMinimalPerf.default | 190 | 196 | 0.97:1 |
| AvatarMinimalPerf.default | 105 | 109 | 0.96:1 |
| ListMinimalPerf.default | 300 | 316 | 0.95:1 |
| TextAreaMinimalPerf.default | 282 | 298 | 0.95:1 |
🕵 FluentUI-v0 No visual regressions between this PR and main |
🕵 fluentuiv9 No visual regressions between this PR and main |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 632 | 635 | 5000 | |
| Breadcrumb | mount | 1675 | 1696 | 1000 | |
| Checkbox | mount | 1706 | 1706 | 5000 | |
| CheckboxBase | mount | 1477 | 1479 | 5000 | |
| ChoiceGroup | mount | 2982 | 2994 | 5000 | |
| ComboBox | mount | 657 | 688 | 1000 | |
| CommandBar | mount | 6292 | 6283 | 1000 | |
| ContextualMenu | mount | 12354 | 13169 | 1000 | |
| DefaultButton | mount | 761 | 741 | 5000 | |
| DetailsRow | mount | 2190 | 2196 | 5000 | |
| DetailsRowFast | mount | 2216 | 2205 | 5000 | |
| DetailsRowNoStyles | mount | 1992 | 2058 | 5000 | |
| Dialog | mount | 2635 | 2639 | 1000 | |
| DocumentCardTitle | mount | 215 | 225 | 1000 | |
| Dropdown | mount | 1999 | 1998 | 5000 | |
| FocusTrapZone | mount | 1132 | 1095 | 5000 | |
| FocusZone | mount | 1088 | 1040 | 5000 | |
| GroupedList | mount | 41941 | 41986 | 2 | |
| GroupedList | virtual-rerender | 20018 | 20034 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 51001 | 51064 | 2 | |
| GroupedListV2 | mount | 237 | 222 | 2 | |
| GroupedListV2 | virtual-rerender | 206 | 213 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 222 | 226 | 2 | |
| IconButton | mount | 1099 | 1072 | 5000 | |
| Label | mount | 346 | 330 | 5000 | |
| Layer | mount | 2709 | 2725 | 5000 | |
| Link | mount | 405 | 389 | 5000 | |
| MenuButton | mount | 949 | 939 | 5000 | |
| MessageBar | mount | 21711 | 21470 | 5000 | |
| Nav | mount | 1952 | 1974 | 1000 | |
| OverflowSet | mount | 775 | 776 | 5000 | |
| Panel | mount | 1779 | 1793 | 1000 | |
| Persona | mount | 734 | 759 | 1000 | |
| Pivot | mount | 877 | 869 | 1000 | |
| PrimaryButton | mount | 850 | 831 | 5000 | |
| Rating | mount | 4623 | 4639 | 5000 | |
| SearchBox | mount | 921 | 887 | 5000 | |
| Shimmer | mount | 1876 | 1888 | 5000 | |
| Slider | mount | 1368 | 1355 | 5000 | |
| SpinButton | mount | 2901 | 2941 | 5000 | |
| Spinner | mount | 393 | 381 | 5000 | |
| SplitButton | mount | 1830 | 1808 | 5000 | |
| Stack | mount | 411 | 416 | 5000 | |
| StackWithIntrinsicChildren | mount | 882 | 870 | 5000 | |
| StackWithTextChildren | mount | 2696 | 2611 | 5000 | |
| SwatchColorPicker | mount | 6169 | 6121 | 5000 | |
| TagPicker | mount | 1444 | 1453 | 5000 | |
| Text | mount | 383 | 368 | 5000 | |
| TextField | mount | 976 | 949 | 5000 | |
| ThemeProvider | mount | 829 | 840 | 5000 | |
| ThemeProvider | virtual-rerender | 585 | 583 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1276 | 1278 | 5000 | |
| Toggle | mount | 592 | 606 | 5000 | |
| buttonNative | mount | 191 | 191 | 5000 |
Hotell
commented
May 31, 2023
spmonahan
approved these changes
May 31, 2023
TristanWatanabe
approved these changes
May 31, 2023
khmakoto
approved these changes
May 31, 2023
ling1726
approved these changes
Jun 1, 2023
miroslavstastny
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Behavior
typescript bump to 4.6 + api-extractor family of packages which is compatible with TS 4.6
TS release notes (affecting our codebase):
https://devblogs.microsoft.com/typescript/announcing-typescript-4-6/
API extractor changes:
Related Issue(s)