Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Bumping webpack to 5.76.0 to avoid vulnerability #27993

Closed
wants to merge 3 commits into from
Closed

fix: Bumping webpack to 5.76.0 to avoid vulnerability #27993

wants to merge 3 commits into from

Conversation

sopranopillow
Copy link
Contributor

This PR bumps webpack to avoid a vulnerability in 5.0.0 < 5.76.0 as seen in synk.

@sopranopillow sopranopillow self-assigned this May 24, 2023
@fabricteam
Copy link
Collaborator

fabricteam commented May 24, 2023 •
edited
Loading

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 541 577 5000
Button mount 293 304 5000
Field mount 991 964 5000
FluentProvider mount 647 648 5000
FluentProviderWithTheme mount 70 87 10
FluentProviderWithTheme virtual-rerender 58 63 10
FluentProviderWithTheme virtual-rerender-with-unmount 66 70 10
InfoButton mount 16 14 5000
MakeStyles mount 840 849 50000
Persona mount 1582 1535 5000
SpinButton mount 1242 1265 5000

@size-auditor
Copy link

size-auditor bot commented May 24, 2023 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 58a56ad073f6636f8c29773ff415e054b35af784 (build)

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 24, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1dd5512:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented May 24, 2023 •
edited
Loading

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented May 24, 2023 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
DividerMinimalPerf.default 219 197 1.11:1
AttachmentMinimalPerf.default 85 77 1.1:1
CarouselMinimalPerf.default 276 251 1.1:1
RefMinimalPerf.default 110 102 1.08:1
ImageMinimalPerf.default 228 213 1.07:1
ChatMinimalPerf.default 453 427 1.06:1
AccordionMinimalPerf.default 87 83 1.05:1
BoxMinimalPerf.default 203 194 1.05:1
ChatDuplicateMessagesPerf.default 153 146 1.05:1
HeaderSlotsPerf.default 478 456 1.05:1
PortalMinimalPerf.default 86 82 1.05:1
CardMinimalPerf.default 307 296 1.04:1
LayoutMinimalPerf.default 208 200 1.04:1
RadioGroupMinimalPerf.default 274 263 1.04:1
ButtonOverridesMissPerf.default 637 621 1.03:1
ChatWithPopoverPerf.default 194 188 1.03:1
HeaderMinimalPerf.default 199 194 1.03:1
SkeletonMinimalPerf.default 201 196 1.03:1
TableManyItemsPerf.default 1139 1102 1.03:1
CustomToolbarPrototype.default 1475 1436 1.03:1
InputMinimalPerf.default 538 525 1.02:1
ItemLayoutMinimalPerf.default 724 709 1.02:1
ListNestedPerf.default 325 320 1.02:1
LoaderMinimalPerf.default 185 182 1.02:1
IconMinimalPerf.default 381 372 1.02:1
AttachmentSlotsPerf.default 624 617 1.01:1
DropdownManyItemsPerf.default 384 380 1.01:1
MenuButtonMinimalPerf.default 956 948 1.01:1
SliderMinimalPerf.default 714 704 1.01:1
AlertMinimalPerf.default 159 159 1:1
AnimationMinimalPerf.default 300 300 1:1
CheckboxMinimalPerf.default 1130 1133 1:1
DialogMinimalPerf.default 455 457 1:1
DropdownMinimalPerf.default 1406 1401 1:1
FormMinimalPerf.default 219 220 1:1
MenuMinimalPerf.default 495 496 1:1
StatusMinimalPerf.default 393 394 1:1
ToolbarMinimalPerf.default 526 525 1:1
TreeMinimalPerf.default 478 479 1:1
ButtonMinimalPerf.default 84 85 0.99:1
DatepickerMinimalPerf.default 3595 3614 0.99:1
EmbedMinimalPerf.default 1737 1754 0.99:1
GridMinimalPerf.default 186 188 0.99:1
RosterPerf.default 1568 1587 0.99:1
PopupMinimalPerf.default 350 353 0.99:1
ReactionMinimalPerf.default 205 207 0.99:1
SplitButtonMinimalPerf.default 2273 2290 0.99:1
TextMinimalPerf.default 192 194 0.99:1
TextAreaMinimalPerf.default 278 281 0.99:1
ButtonSlotsPerf.default 305 310 0.98:1
ListWith60ListItems.default 359 365 0.98:1
ProviderMergeThemesPerf.default 658 670 0.98:1
ProviderMinimalPerf.default 201 206 0.98:1
SegmentMinimalPerf.default 193 196 0.98:1
TooltipMinimalPerf.default 1223 1244 0.98:1
AvatarMinimalPerf.default 104 107 0.97:1
LabelMinimalPerf.default 212 219 0.97:1
ListMinimalPerf.default 314 325 0.97:1
TableMinimalPerf.default 223 231 0.97:1
VideoMinimalPerf.default 423 434 0.97:1
FlexMinimalPerf.default 152 158 0.96:1
TreeWith60ListItems.default 85 91 0.93:1
ListCommonPerf.default 379 413 0.92:1

@fabricteam
Copy link
Collaborator

fabricteam commented May 24, 2023 •
edited
Loading

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext		 533 B
341 B
global-context
createContextSelector		 560 B
352 B
priority-overflow
createOverflowManager		 3.194 kB
1.315 kB
react-accordion
Accordion (including children components)		 88.329 kB
26.706 kB
react-alert
Alert		 93.534 kB
22.497 kB
react-avatar
Avatar		 57.754 kB
15.041 kB
react-avatar
AvatarGroup		 15.632 kB
6.258 kB
react-avatar
AvatarGroupItem		 73.968 kB
19.552 kB
react-badge
Badge		 23.512 kB
7.197 kB
react-badge
CounterBadge		 24.416 kB
7.506 kB
react-badge
PresenceBadge		 32.094 kB
8.367 kB
react-button
Button		 36.724 kB
9.458 kB
react-button
CompoundButton		 43.873 kB
10.939 kB
react-button
MenuButton		 41.411 kB
10.791 kB
react-button
SplitButton		 49.635 kB
12.364 kB
react-button
ToggleButton		 54.866 kB
11.367 kB
react-card
Card - All		 88.428 kB
25.004 kB
react-card
Card		 83.363 kB
23.556 kB
react-card
CardFooter		 9.158 kB
3.844 kB
react-card
CardHeader		 11.048 kB
4.538 kB
react-card
CardPreview		 9.963 kB
4.192 kB
react-checkbox
Checkbox		 34.268 kB
10.793 kB
react-combobox
Combobox (including child components)		 87.251 kB
28.1 kB
react-combobox
Dropdown (including child components)		 85.635 kB
27.697 kB
react-components
react-components: Button, FluentProvider & webLightTheme		 64.855 kB
17.852 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 205.944 kB
57.706 kB
react-components
react-components: FluentProvider & webLightTheme		 36.086 kB
11.9 kB
react-datepicker-compat
DatePicker Compat		 221.453 kB
58.858 kB
react-dialog
Dialog (including children components)		 91.892 kB
27.42 kB
react-divider
Divider		 17.399 kB
6.298 kB
react-field
Field		 18.864 kB
7.004 kB
react-image
Image		 11.479 kB
4.573 kB
react-infobutton
InfoButton		 129.685 kB
39.584 kB
react-infobutton
InfoLabel		 133.154 kB
40.672 kB
react-input
Input		 24.024 kB
7.682 kB
react-label
Label		 10.104 kB
4.185 kB
react-link
Link		 12.304 kB
5.061 kB
react-menu
Menu (including children components)		 130.392 kB
39.788 kB
react-menu
Menu (including selectable components)		 133.376 kB
40.307 kB
react-overflow
hooks only		 11.214 kB
4.271 kB
react-persona
Persona		 64.675 kB
16.968 kB
react-popover
Popover		 116.676 kB
35.957 kB
react-portal
Portal		 11.649 kB
4.262 kB
react-portal-compat
PortalCompatProvider		 6.446 kB
2.186 kB
react-positioning
usePositioning		 24.008 kB
8.798 kB
react-progress
ProgressBar		 13.856 kB
5.434 kB
react-provider
FluentProvider		 18.033 kB
6.666 kB
react-radio
Radio		 27.282 kB
8.661 kB
react-radio
RadioGroup		 11.312 kB
4.71 kB
react-select
Select		 25.357 kB
8.798 kB
react-slider
Slider		 34.164 kB
11.024 kB
react-spinbutton
SpinButton		 33.934 kB
10.328 kB
react-spinner
Spinner		 21.284 kB
6.965 kB
react-switch
Switch		 29.806 kB
9.274 kB
react-table
DataGrid		 149.721 kB
41.154 kB
react-table
Table (Primitives only)		 44.348 kB
12.347 kB
react-table
Table as DataGrid		 132.279 kB
33.668 kB
react-table
Table (Selection only)		 78.056 kB
19.084 kB
react-table
Table (Sort only)		 77.386 kB
18.896 kB
react-tags
Tag		 21.99 kB
7.887 kB
react-text
Text - Default		 12.492 kB
4.92 kB
react-text
Text - Wrappers		 15.624 kB
5.232 kB
react-textarea
Textarea		 27.528 kB
9.051 kB
react-theme
Single theme token import		 69 B
89 B
react-theme
Teams: all themes		 31.33 kB
6.764 kB
react-theme
Teams: Light theme		 17.895 kB
5.162 kB
react-tooltip
Tooltip		 46.708 kB
16.376 kB
react-utilities
SSRProvider		 180 B
159 B
🤖 This report was generated against 58a56ad073f6636f8c29773ff415e054b35af784

@fabricteam
Copy link
Collaborator

fabricteam commented May 24, 2023 •
edited
Loading

🕵 fluentuiv9 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented May 24, 2023 •
edited
Loading

🕵 FluentUI-v0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented May 24, 2023 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 619 639 5000
Breadcrumb mount 1685 1657 1000
Checkbox mount 1672 1666 5000
CheckboxBase mount 1527 1497 5000
ChoiceGroup mount 2929 2933 5000
ComboBox mount 626 662 1000
CommandBar mount 6288 6294 1000
ContextualMenu mount 14198 13893 1000
DefaultButton mount 749 755 5000
DetailsRow mount 2230 2179 5000
DetailsRowFast mount 2217 2209 5000
DetailsRowNoStyles mount 1979 2000 5000
Dialog mount 2607 2765 1000
DocumentCardTitle mount 230 220 1000
Dropdown mount 2011 1974 5000
FocusTrapZone mount 1118 1160 5000
FocusZone mount 1080 1090 5000
GroupedList mount 41253 41128 2
GroupedList virtual-rerender 17746 19862 2
GroupedList virtual-rerender-with-unmount 50637 50635 2
GroupedListV2 mount 236 230 2
GroupedListV2 virtual-rerender 213 204 2
GroupedListV2 virtual-rerender-with-unmount 217 229 2
IconButton mount 1092 1066 5000
Label mount 345 348 5000
Layer mount 2686 2712 5000
Link mount 409 399 5000
MenuButton mount 924 930 5000
MessageBar mount 21317 22467 5000
Nav mount 1914 1947 1000
OverflowSet mount 776 788 5000
Panel mount 1836 1783 1000
Persona mount 736 762 1000
Pivot mount 886 877 1000
PrimaryButton mount 820 854 5000
Rating mount 4730 4626 5000
SearchBox mount 930 923 5000
Shimmer mount 1908 1884 5000
Slider mount 1323 1334 5000
SpinButton mount 2875 2913 5000
Spinner mount 384 389 5000
SplitButton mount 1815 1763 5000
Stack mount 410 410 5000
StackWithIntrinsicChildren mount 864 854 5000
StackWithTextChildren mount 2630 2606 5000
SwatchColorPicker mount 6207 6034 5000
TagPicker mount 1492 1440 5000
Text mount 378 381 5000
TextField mount 978 938 5000
ThemeProvider mount 854 830 5000
ThemeProvider virtual-rerender 607 585 5000
ThemeProvider virtual-rerender-with-unmount 1292 1277 5000
Toggle mount 631 633 5000
buttonNative mount 188 189 5000

@sopranopillow sopranopillow marked this pull request as ready for review May 24, 2023 22:04
@sopranopillow sopranopillow requested a review from a team as a code owner May 24, 2023 22:04
@Hotell
Copy link
Contributor

Hotell commented May 25, 2023

will be handled by #27885

@sopranopillow
Copy link
Contributor Author

Closin in favor of #27885

@sopranopillow sopranopillow deleted the webpack-bump branch May 25, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khmakoto khmakoto khmakoto approved these changes

@ling1726 ling1726 ling1726 approved these changes

Assignees

@sopranopillow sopranopillow

Labels
None yet
Projects
None yet
Milestone
May Project Cycle Q2 2023
Development

Successfully merging this pull request may close these issues.
5 participants
@sopranopillow @fabricteam @Hotell @khmakoto @ling1726