chore: migrate to prettier 2.8.8 #27898

Hotell · 2023-05-18T08:41:16Z

New Behavior

Manually migrated to latest prettier to match nx migration deps

Related Issue(s)

Follows chore: migrate from nx 13 to 15.6.3 #27885

fabricteam · 2023-05-18T08:48:47Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`global-context` createContext	`533 B` `341 B`
`global-context` createContextSelector	`560 B` `352 B`
`priority-overflow` createOverflowManager	`3.194 kB` `1.315 kB`
`react-accordion` Accordion (including children components)	`86.064 kB` `26.1 kB`
`react-alert` Alert	`93.534 kB` `22.497 kB`
`react-avatar` Avatar	`57.754 kB` `15.041 kB`
`react-avatar` AvatarGroup	`15.632 kB` `6.258 kB`
`react-avatar` AvatarGroupItem	`73.968 kB` `19.552 kB`
`react-badge` Badge	`23.512 kB` `7.197 kB`
`react-badge` CounterBadge	`24.416 kB` `7.506 kB`
`react-badge` PresenceBadge	`32.094 kB` `8.367 kB`
`react-button` Button	`36.724 kB` `9.458 kB`
`react-button` CompoundButton	`43.873 kB` `10.939 kB`
`react-button` MenuButton	`41.411 kB` `10.791 kB`
`react-button` SplitButton	`49.635 kB` `12.364 kB`
`react-button` ToggleButton	`54.866 kB` `11.367 kB`
`react-card` Card - All	`86.061 kB` `24.345 kB`
`react-card` Card	`80.997 kB` `22.895 kB`
`react-card` CardFooter	`9.158 kB` `3.844 kB`
`react-card` CardHeader	`11.048 kB` `4.538 kB`
`react-card` CardPreview	`9.963 kB` `4.192 kB`
`react-checkbox` Checkbox	`34.268 kB` `10.793 kB`
`react-combobox` Combobox (including child components)	`87.251 kB` `28.1 kB`
`react-combobox` Dropdown (including child components)	`85.635 kB` `27.697 kB`
`react-components` react-components: Button, FluentProvider & webLightTheme	`64.855 kB` `17.852 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`203.937 kB` `57.086 kB`
`react-components` react-components: FluentProvider & webLightTheme	`36.086 kB` `11.9 kB`
`react-datepicker-compat` DatePicker Compat	`220.303 kB` `58.486 kB`
`react-dialog` Dialog (including children components)	`90.204 kB` `26.857 kB`
`react-divider` Divider	`17.399 kB` `6.298 kB`
`react-field` Field	`18.864 kB` `7.004 kB`
`react-image` Image	`11.479 kB` `4.573 kB`
`react-infobutton` InfoButton	`127.977 kB` `39.012 kB`
`react-infobutton` InfoLabel	`131.447 kB` `40.071 kB`
`react-input` Input	`24.024 kB` `7.682 kB`
`react-label` Label	`10.104 kB` `4.185 kB`
`react-link` Link	`12.304 kB` `5.061 kB`
`react-menu` Menu (including children components)	`128.254 kB` `39.184 kB`
`react-menu` Menu (including selectable components)	`131.238 kB` `39.7 kB`
`react-overflow` hooks only	`11.214 kB` `4.271 kB`
`react-persona` Persona	`64.675 kB` `16.968 kB`
`react-popover` Popover	`114.969 kB` `35.392 kB`
`react-portal` Portal	`11.649 kB` `4.262 kB`
`react-portal-compat` PortalCompatProvider	`6.446 kB` `2.186 kB`
`react-positioning` usePositioning	`24.008 kB` `8.798 kB`
`react-progress` ProgressBar	`13.856 kB` `5.434 kB`
`react-provider` FluentProvider	`18.033 kB` `6.666 kB`
`react-radio` Radio	`27.282 kB` `8.661 kB`
`react-radio` RadioGroup	`11.312 kB` `4.71 kB`
`react-select` Select	`25.357 kB` `8.798 kB`
`react-slider` Slider	`34.164 kB` `11.024 kB`
`react-spinbutton` SpinButton	`33.934 kB` `10.328 kB`
`react-spinner` Spinner	`20.882 kB` `6.798 kB`
`react-switch` Switch	`29.806 kB` `9.274 kB`
`react-table` DataGrid	`147.583 kB` `40.523 kB`
`react-table` Table (Primitives only)	`44.348 kB` `12.347 kB`
`react-table` Table as DataGrid	`130.142 kB` `33.083 kB`
`react-table` Table (Selection only)	`78.056 kB` `19.084 kB`
`react-table` Table (Sort only)	`77.386 kB` `18.896 kB`
`react-tags` Tag	`20.916 kB` `7.449 kB`
`react-text` Text - Default	`12.492 kB` `4.92 kB`
`react-text` Text - Wrappers	`15.624 kB` `5.232 kB`
`react-textarea` Textarea	`27.545 kB` `9.064 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`31.33 kB` `6.764 kB`
`react-theme` Teams: Light theme	`17.895 kB` `5.162 kB`
`react-tooltip` Tooltip	`46.708 kB` `16.376 kB`
`react-utilities` SSRProvider	`180 B` `159 B`

_{🤖 This report was generated against 31930f6a77d0473edea5eefef5acc63c78ff9de1}

fabricteam · 2023-05-18T08:56:01Z

Perf Analysis (`@fluentui/react-components`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	703	704	5000
Button	mount	367	376	5000
Field	mount	1275	1273	5000
FluentProvider	mount	922	901	5000
FluentProviderWithTheme	mount	111	119	10
FluentProviderWithTheme	virtual-rerender	103	95	10
FluentProviderWithTheme	virtual-rerender-with-unmount	116	118	10
InfoButton	mount	21	21	5000
MakeStyles	mount	1124	1141	50000
Persona	mount	2041	1985	5000
SpinButton	mount	1553	1556	5000

fabricteam · 2023-05-18T09:00:33Z

Perf Analysis (`@fluentui/react-northstar`)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario	Current PR Ticks	Baseline Ticks	Ratio	Regression Analysis
AccordionMinimalPerf.default	105	99	1.06:1	analysis

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
ButtonMinimalPerf.default	113	106	1.07:1
ChatDuplicateMessagesPerf.default	202	188	1.07:1
TableMinimalPerf.default	303	284	1.07:1
ReactionMinimalPerf.default	276	263	1.05:1
AttachmentMinimalPerf.default	101	97	1.04:1
AnimationMinimalPerf.default	372	360	1.03:1
DatepickerMinimalPerf.default	4851	4697	1.03:1
HeaderMinimalPerf.default	260	253	1.03:1
ListNestedPerf.default	419	405	1.03:1
ButtonOverridesMissPerf.default	841	827	1.02:1
ButtonSlotsPerf.default	413	406	1.02:1
CardMinimalPerf.default	382	373	1.02:1
CarouselMinimalPerf.default	352	345	1.02:1
ChatMinimalPerf.default	534	525	1.02:1
DividerMinimalPerf.default	260	256	1.02:1
EmbedMinimalPerf.default	2416	2380	1.02:1
InputMinimalPerf.default	740	724	1.02:1
LabelMinimalPerf.default	279	273	1.02:1
ListMinimalPerf.default	387	378	1.02:1
LoaderMinimalPerf.default	248	243	1.02:1
RadioGroupMinimalPerf.default	337	332	1.02:1
SkeletonMinimalPerf.default	250	246	1.02:1
IconMinimalPerf.default	466	458	1.02:1
TableManyItemsPerf.default	1432	1407	1.02:1
TooltipMinimalPerf.default	1642	1614	1.02:1
TreeWith60ListItems.default	108	106	1.02:1
AttachmentSlotsPerf.default	817	811	1.01:1
BoxMinimalPerf.default	252	249	1.01:1
CheckboxMinimalPerf.default	1565	1555	1.01:1
DialogMinimalPerf.default	578	572	1.01:1
DropdownMinimalPerf.default	1828	1812	1.01:1
ImageMinimalPerf.default	280	276	1.01:1
PopupMinimalPerf.default	452	446	1.01:1
ProviderMergeThemesPerf.default	973	967	1.01:1
RefMinimalPerf.default	138	136	1.01:1
SegmentMinimalPerf.default	247	245	1.01:1
SliderMinimalPerf.default	905	900	1.01:1
StatusMinimalPerf.default	499	496	1.01:1
ChatWithPopoverPerf.default	246	246	1:1
FlexMinimalPerf.default	205	205	1:1
FormMinimalPerf.default	280	279	1:1
ItemLayoutMinimalPerf.default	903	902	1:1
LayoutMinimalPerf.default	261	262	1:1
MenuMinimalPerf.default	621	618	1:1
MenuButtonMinimalPerf.default	1261	1261	1:1
RosterPerf.default	1822	1831	1:1
ProviderMinimalPerf.default	275	274	1:1
SplitButtonMinimalPerf.default	3012	2999	1:1
TextMinimalPerf.default	247	248	1:1
CustomToolbarPrototype.default	1912	1909	1:1
ToolbarMinimalPerf.default	662	661	1:1
TreeMinimalPerf.default	593	592	1:1
VideoMinimalPerf.default	523	524	1:1
DropdownManyItemsPerf.default	490	493	0.99:1
HeaderSlotsPerf.default	570	574	0.99:1
AlertMinimalPerf.default	195	198	0.98:1
AvatarMinimalPerf.default	131	134	0.98:1
GridMinimalPerf.default	247	253	0.98:1
PortalMinimalPerf.default	116	118	0.98:1
ListWith60ListItems.default	465	481	0.97:1
TextAreaMinimalPerf.default	343	352	0.97:1
ListCommonPerf.default	488	506	0.96:1

codesandbox-ci · 2023-05-18T09:00:57Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e68ea4f:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

size-auditor · 2023-05-18T09:02:07Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 31930f6a77d0473edea5eefef5acc63c78ff9de1 (build)

fabricteam · 2023-05-18T09:03:27Z

🕵 fluentuiv8 No visual regressions between this PR and main

fabricteam · 2023-05-18T09:13:58Z

🕵 fluentuiv9 No visual regressions between this PR and main

fabricteam · 2023-05-18T09:14:35Z

🕵 FluentUI-v0 No visual regressions between this PR and main

fabricteam · 2023-05-18T09:19:41Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	773	798	5000
Breadcrumb	mount	2026	2037	1000
Checkbox	mount	2095	2088	5000
CheckboxBase	mount	1826	1828	5000
ChoiceGroup	mount	3527	3540	5000
ComboBox	mount	800	801	1000
CommandBar	mount	7677	7652	1000
ContextualMenu	mount	13248	13248	1000
DefaultButton	mount	951	930	5000
DetailsRow	mount	2625	2622	5000
DetailsRowFast	mount	2636	2625	5000
DetailsRowNoStyles	mount	2442	2449	5000
Dialog	mount	3183	3217	1000
DocumentCardTitle	mount	286	284	1000
Dropdown	mount	2441	2476	5000
FocusTrapZone	mount	1421	1386	5000
FocusZone	mount	1397	1402	5000
GroupedList	mount	45294	45482	2
GroupedList	virtual-rerender	22061	22026	2
GroupedList	virtual-rerender-with-unmount	63107	62604	2
GroupedListV2	mount	295	294	2
GroupedListV2	virtual-rerender	260	269	2
GroupedListV2	virtual-rerender-with-unmount	287	289	2
IconButton	mount	1307	1312	5000
Label	mount	446	461	5000
Layer	mount	3348	3370	5000
Link	mount	518	523	5000
MenuButton	mount	1176	1154	5000
MessageBar	mount	25871	25816	5000
Nav	mount	2316	2341	1000
OverflowSet	mount	1000	1004	5000
Panel	mount	2169	2154	1000
Persona	mount	913	920	1000
Pivot	mount	1065	1060	1000
PrimaryButton	mount	1074	1052	5000
Rating	mount	5782	5781	5000
SearchBox	mount	1116	1093	5000
Shimmer	mount	2355	2329	5000
Slider	mount	1670	1666	5000
SpinButton	mount	3457	3421	5000
Spinner	mount	523	517	5000
SplitButton	mount	2177	2163	5000
Stack	mount	519	546	5000
StackWithIntrinsicChildren	mount	1077	1082	5000
StackWithTextChildren	mount	3375	3398	5000
SwatchColorPicker	mount	7481	7341	5000
TagPicker	mount	1742	1730	5000
Text	mount	492	499	5000
TextField	mount	1144	1148	5000
ThemeProvider	mount	1019	996	5000
ThemeProvider	virtual-rerender	785	796	5000
ThemeProvider	virtual-rerender-with-unmount	1552	1564	5000
Toggle	mount	773	783	5000
buttonNative	mount	244	247	5000

msft-fluent-ui-bot assigned TristanWatanabe May 18, 2023

github-actions bot added this to the May Project Cycle Q2 2023 milestone May 18, 2023

Hotell changed the title ~~Hotell/build/nx/manual deps migration/prettier 2.8~~ chore: migrate to prettier 2.8.8 May 18, 2023

Hotell unassigned TristanWatanabe May 18, 2023

Hotell added the Area: Build System label May 18, 2023

chore: migrate to prettier 2.8.8

1b66f2e

Hotell force-pushed the hotell/build/nx/manual-deps-migration/prettier-2.8 branch from 67ede4a to 1b66f2e Compare May 18, 2023 08:48

fixup! chore: migrate to prettier 2.8.8

e68ea4f

Hotell mentioned this pull request May 18, 2023

chore: migrate from nx 13 to 15.6.3 #27885

Merged

Hotell marked this pull request as ready for review May 18, 2023 10:30

Hotell requested a review from a team as a code owner May 18, 2023 10:30

Hotell enabled auto-merge (squash) May 18, 2023 10:47

tudorpopams self-requested a review May 18, 2023 12:12

TristanWatanabe approved these changes May 18, 2023

View reviewed changes

Hotell merged commit 24d5ad1 into microsoft:master May 18, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: migrate to prettier 2.8.8 #27898

chore: migrate to prettier 2.8.8 #27898

Hotell commented May 18, 2023

fabricteam commented May 18, 2023 •

edited

Loading

fabricteam commented May 18, 2023 •

edited

Loading

fabricteam commented May 18, 2023 •

edited

Loading

codesandbox-ci bot commented May 18, 2023 •

edited

Loading

size-auditor bot commented May 18, 2023 •

edited

Loading

fabricteam commented May 18, 2023 •

edited

Loading

fabricteam commented May 18, 2023 •

edited

Loading

fabricteam commented May 18, 2023 •

edited

Loading

fabricteam commented May 18, 2023 •

edited

Loading

chore: migrate to prettier 2.8.8 #27898

chore: migrate to prettier 2.8.8 #27898

Conversation

Hotell commented May 18, 2023

New Behavior

Related Issue(s)

fabricteam commented May 18, 2023 • edited Loading

📊 Bundle size report

fabricteam commented May 18, 2023 • edited Loading

Perf Analysis (@fluentui/react-components)

fabricteam commented May 18, 2023 • edited Loading

Perf Analysis (@fluentui/react-northstar)

Potential regressions comparing to master

codesandbox-ci bot commented May 18, 2023 • edited Loading

size-auditor bot commented May 18, 2023 • edited Loading

Asset size changes

fabricteam commented May 18, 2023 • edited Loading

🕵 fluentuiv8 No visual regressions between this PR and main

fabricteam commented May 18, 2023 • edited Loading

🕵 fluentuiv9 No visual regressions between this PR and main

fabricteam commented May 18, 2023 • edited Loading

🕵 FluentUI-v0 No visual regressions between this PR and main

fabricteam commented May 18, 2023 • edited Loading

Perf Analysis (@fluentui/react)

fabricteam commented May 18, 2023 •

edited

Loading

fabricteam commented May 18, 2023 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

fabricteam commented May 18, 2023 •

edited

Loading

Perf Analysis (`@fluentui/react-northstar`)

codesandbox-ci bot commented May 18, 2023 •

edited

Loading

size-auditor bot commented May 18, 2023 •

edited

Loading

fabricteam commented May 18, 2023 •

edited

Loading

fabricteam commented May 18, 2023 •

edited

Loading

fabricteam commented May 18, 2023 •

edited

Loading

fabricteam commented May 18, 2023 •

edited

Loading

Perf Analysis (`@fluentui/react`)