Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(scripts-tasks): remove not needed api-extractor task logs #27094

Merged
merged 1 commit into from
Mar 30, 2023
Merged

chore(scripts-tasks): remove not needed api-extractor task logs #27094

merged 1 commit into from
Mar 30, 2023

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Mar 6, 2023 •
edited
Loading

Previous Behavior

  • obsolete error messages might get printed on the local machine
  • ci spam without any benefit

New Behavior

  • no spam logs / confusing error messages with api-extractor

Related Issue(s)

@github-actions github-actions bot added this to the March Project Cycle Q1 2023 milestone Mar 6, 2023
@size-auditor
Copy link

size-auditor bot commented Mar 6, 2023 •
edited
Loading

Asset size changes

⚠️ Insufficient baseline data to detect size changes

Unable to find bundle size details for Baseline commit: 4f76849

Possible causes

  • The baseline build 4f76849 is broken
  • The Size Auditor run for the baseline build 4f76849 was not triggered

Recommendations

  • Please merge your branch for this Pull request with the latest master build and commit your changes once again

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 6, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3cfdc17:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Mar 6, 2023 •
edited
Loading

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 914 898 5000
Button mount 585 569 5000
Field mount 1692 1636 5000
FluentProvider mount 1172 1170 5000
FluentProviderWithTheme mount 306 310 10
FluentProviderWithTheme virtual-rerender 275 280 10
FluentProviderWithTheme virtual-rerender-with-unmount 292 296 10
InfoButton mount 198 206 5000
MakeStyles mount 1299 1309 50000
Persona mount 2270 2253 5000
SpinButton mount 1986 1993 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Mar 6, 2023 •
edited
Loading

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext		 533 B
341 B
global-context
createContextSelector		 560 B
352 B
priority-overflow
createOverflowManager		 3.194 kB
1.314 kB
react-accordion
Accordion (including children components)		 88.882 kB
26.551 kB
react-alert
Alert		 96.647 kB
23.133 kB
react-avatar
Avatar		 60.312 kB
15.579 kB
react-avatar
AvatarGroup		 18.178 kB
6.683 kB
react-avatar
AvatarGroupItem		 76.573 kB
20.086 kB
react-badge
Badge		 25.85 kB
7.585 kB
react-badge
CounterBadge		 26.833 kB
7.889 kB
react-badge
PresenceBadge		 34.458 kB
8.693 kB
react-button
Button		 39.749 kB
9.959 kB
react-button
CompoundButton		 46.921 kB
11.428 kB
react-button
MenuButton		 44.437 kB
11.306 kB
react-button
SplitButton		 52.931 kB
12.872 kB
react-button
ToggleButton		 58.121 kB
11.878 kB
react-card
Card - All		 83.489 kB
23.894 kB
react-card
Card		 78.308 kB
22.431 kB
react-card
CardFooter		 9.035 kB
3.799 kB
react-card
CardHeader		 10.959 kB
4.503 kB
react-card
CardPreview		 9.84 kB
4.153 kB
react-checkbox
Checkbox		 36.067 kB
10.856 kB
react-checkbox
CheckboxField		 43.019 kB
12.787 kB
react-combobox
Combobox (including child components)		 88.73 kB
28.105 kB
react-combobox
ComboboxField		 85.147 kB
27.871 kB
react-combobox
Dropdown (including child components)		 87.428 kB
27.853 kB
react-components
react-components: Button, FluentProvider & webLightTheme		 67.994 kB
18.395 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 207.4 kB
57.516 kB
react-components
react-components: FluentProvider & webLightTheme		 38.819 kB
12.351 kB
react-dialog
Dialog (including children components)		 93.616 kB
27.452 kB
react-divider
Divider		 19.863 kB
6.697 kB
react-field
Field		 20.552 kB
7.092 kB
react-image
Image		 14.011 kB
4.993 kB
react-infobutton
InfoButton		 130.577 kB
39.439 kB
react-infobutton
InfoLabel		 133.874 kB
40.488 kB
react-input
Input		 25.747 kB
7.697 kB
react-input
InputField		 35.723 kB
10.637 kB
react-label
Label		 12.57 kB
4.586 kB
react-link
Link		 12.301 kB
5.07 kB
react-menu
Menu (including children components)		 130.926 kB
39.629 kB
react-menu
Menu (including selectable components)		 134.062 kB
40.161 kB
react-overflow
hooks only		 11.214 kB
4.271 kB
react-persona
Persona		 67.338 kB
17.524 kB
react-popover
Popover		 117.58 kB
35.828 kB
react-portal
Portal		 11.649 kB
4.263 kB
react-portal-compat
PortalCompatProvider		 6.446 kB
2.185 kB
react-positioning
usePositioning		 24.008 kB
8.798 kB
react-progress
ProgressBar		 15.961 kB
5.675 kB
react-progress
ProgressField		 26.435 kB
8.859 kB
react-provider
FluentProvider		 20.766 kB
7.119 kB
react-radio
Radio		 35.48 kB
11.126 kB
react-radio
RadioGroup		 17.988 kB
6.544 kB
react-radio
RadioGroupField		 28.166 kB
9.735 kB
react-select
Select		 26.957 kB
8.766 kB
react-select
SelectField		 36.293 kB
11.316 kB
react-slider
Slider		 35.919 kB
11.059 kB
react-slider
SliderField		 45.847 kB
14.005 kB
react-spinbutton
SpinButton		 35.648 kB
10.348 kB
react-spinbutton
SpinButtonField		 44.671 kB
12.812 kB
react-spinner
Spinner		 23.425 kB
7.195 kB
react-switch
Switch		 31.413 kB
9.294 kB
react-switch
SwitchField		 38.317 kB
11.21 kB
react-table
DataGrid		 149.878 kB
40.662 kB
react-table
Table (Primitives only)		 47.119 kB
12.703 kB
react-table
Table as DataGrid		 138.018 kB
35.282 kB
react-table
Table (Selection only)		 85.849 kB
21.303 kB
react-table
Table (Sort only)		 85.179 kB
21.113 kB
react-text
Text - Default		 15.018 kB
5.327 kB
react-text
Text - Wrappers		 15.572 kB
5.23 kB
react-textarea
Textarea		 29.07 kB
9.081 kB
react-textarea
TextareaField		 39.454 kB
12.055 kB
react-theme
Single theme token import		 69 B
89 B
react-theme
Teams: all themes		 31.33 kB
6.764 kB
react-theme
Teams: Light theme		 17.895 kB
5.162 kB
react-tooltip
Tooltip		 49.388 kB
16.815 kB
react-utilities
SSRProvider		 180 B
159 B
🤖 This report was generated against 4f76849de438f2ee7842121ac3b8176ba1c0a2a5

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-northstar)

⚠️ No perf measurements available

@fabricteam
Copy link
Collaborator

fabricteam commented Mar 6, 2023 •
edited
Loading

🕵 fluentuiv9 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Mar 6, 2023 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 981 988 5000
Breadcrumb mount 2358 2359 1000
Checkbox mount 2231 2230 5000
CheckboxBase mount 1992 1970 5000
ChoiceGroup mount 3832 3883 5000
ComboBox mount 1043 1031 1000
CommandBar mount 8325 8350 1000
ContextualMenu mount 16561 16543 1000
DefaultButton mount 1151 1155 5000
DetailsRow mount 3017 3056 5000
DetailsRowFast mount 3047 3039 5000
DetailsRowNoStyles mount 2826 2852 5000
Dialog mount 3371 3371 1000
DocumentCardTitle mount 445 441 1000
Dropdown mount 2777 2716 5000
FocusTrapZone mount 1672 1651 5000
FocusZone mount 1624 1585 5000
GroupedList mount 50306 58134 2
GroupedList virtual-rerender 24582 24420 2
GroupedList virtual-rerender-with-unmount 76510 76477 2
GroupedListV2 mount 454 449 2
GroupedListV2 virtual-rerender 448 444 2
GroupedListV2 virtual-rerender-with-unmount 449 467 2
IconButton mount 1613 1584 5000
Label mount 577 577 5000
Layer mount 3669 3734 5000
Link mount 666 666 5000
MenuButton mount 1399 1408 5000
MessageBar mount 28159 28175 5000
Nav mount 2725 2804 1000
OverflowSet mount 1137 1136 5000
Panel mount 2172 2164 1000
Persona mount 1110 1099 1000
Pivot mount 1335 1326 1000
PrimaryButton mount 1273 1277 5000
Rating mount 5871 5882 5000
SearchBox mount 1256 1327 5000
Shimmer mount 2409 2441 5000
Slider mount 1795 1793 5000
SpinButton mount 3963 3884 5000
Spinner mount 641 641 5000
SplitButton mount 2640 2632 5000
Stack mount 666 671 5000
StackWithIntrinsicChildren mount 1255 1265 5000
StackWithTextChildren mount 3374 3374 5000
SwatchColorPicker mount 8332 8275 5000
TagPicker mount 2195 2153 5000
Text mount 623 625 5000
TextField mount 1321 1320 5000
ThemeProvider mount 1245 1242 5000
ThemeProvider virtual-rerender 886 898 5000
ThemeProvider virtual-rerender-with-unmount 1805 1830 5000
Toggle mount 895 932 5000
buttonNative mount 421 405 5000

@Hotell Hotell marked this pull request as ready for review March 8, 2023 16:49
@Hotell Hotell requested a review from a team as a code owner March 8, 2023 16:49
@Hotell Hotell force-pushed the hotell/api-extractor/remove-debug-logs branch from 5e02d2f to 2a3f426 Compare March 28, 2023 15:23
@Hotell Hotell enabled auto-merge (squash) March 28, 2023 15:23
@Hotell Hotell force-pushed the hotell/api-extractor/remove-debug-logs branch from 2a3f426 to 682cc23 Compare March 29, 2023 09:00
@Hotell Hotell force-pushed the hotell/api-extractor/remove-debug-logs branch from 682cc23 to 3cfdc17 Compare March 29, 2023 13:34
@fabricteam
Copy link
Collaborator

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

🕵 FluentUI-v0 No visual regressions between this PR and main

@Hotell Hotell disabled auto-merge March 30, 2023 14:50
@Hotell Hotell merged commit bad91e9 into microsoft:master Mar 30, 2023
@Hotell Hotell deleted the hotell/api-extractor/remove-debug-logs branch March 30, 2023 14:52
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Apr 4, 2023
@marcosmoura
Merge branch 'master' into marcosmoura/feat/drawer-component
eb96d10 
* master: (39 commits)
  Added merge tests for custom styles (microsoft#27086)
  fix: make Option's checkIcon slot render conditionally (microsoft#27409)
  docs: add subcomponents to Combobox and Dropdown docs (microsoft#27410)
  Breadcrumb spec (microsoft#26742)
  bugfix(react-utilities): increments SlotRenderFunction signature to include children (microsoft#27377)
  fix: Menu should not steal focus on close (microsoft#27414)
  Fixed Overflow component when there's more then one children element (microsoft#27402)
  feat(scripts-executors): support custom base and printing all affected packages for checkIfPackagesAffected (microsoft#27364)
  applying package updates
  feat(scripts-tasks): make perf test setup generic (microsoft#26920)
  fix: ColorPicker preview color updated to ignore forced colors (microsoft#27394)
  fix: Fix babel build error on windows (microsoft#27406)
  chore(react-datepicker-compat): Add vr-tests and bundle-size fixtures for DatePicker (microsoft#27351)
  fix(react-dialog): DialogContent scrollbar always visible (microsoft#27367)
  docs: Add tokens search (microsoft#27265)
  chore(scripts-tasks): remove not needed api-extractor task logs (microsoft#27094)
  chore(react-tree): adds e2e flat tree tests (microsoft#27318)
  applying package updates
  Accessibility fix for empty vertical bar chart (microsoft#26254)
  fix(react-datepicker-compat): Fix theming issues with all themes and WHCM (microsoft#27361)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ling1726 ling1726 ling1726 approved these changes

Assignees
No one assigned
Labels
Area: Build System
Projects
None yet
Milestone
March Project Cycle Q1 2023
Development

Successfully merging this pull request may close these issues.
5 participants
@Hotell @fabricteam @ling1726 @tomi-msft @msft-fluent-ui-bot