Fix missing icons on overflowset v7 #26798
Conversation
This PR is for Fluent UI React 7.X The overflowset custom examples overflow icons are not showing up, this resolves that. tested using the codepen link from the website. https://developer.microsoft.com/en-us/fluentui?fabricVer=8#/controls/web/overflowset
msft-fluent-ui-bot
added
the
needs cherry-pick
There was a problem hiding this comment.
It looks like this change to the 7.0 branch may not have been submitted to master yet. Now that version 8 has released, all changes must be submitted to the master branch first (except in emergencies or if the change is irrelevant to version 8).
Please do one of the following:
- If you've already created a PR to
master, add a link to it - If the change is irrelevant to version 8, add a comment explaining why
- Otherwise, create a PR to
masterwith this same change, and add a link to it
After that, you can dismiss this review and remove the "needs cherry-pick" label (or ask a team member to help do so).
Want to avoid this in the future? Include text like "Cherry-pick of ####" in the PR description (where #### is the real master PR number).
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 615f2aa:
|
advancewarsbest
changed the title
🕵 FluentUI-v7 Open the Visual Regressions report to inspect the 31 screenshots✅ There was 0 screenshots added, 0 screenshots removed, 1342 screenshots unchanged, 0 screenshots with different dimensions and 31 screenshots with visible difference. unknown 31 screenshots
|
Perf AnalysisNo significant results to display. All results
|
This change is irrelevant to version 8, but I do not seem to have the ability to remove the cherry pick label for this PR to be approved by the fluent-ui-bot, @micahgodbolt - can you kindly remove the cherry pick label for this PR so it can be approved by the bot due to its comment. Thank you in advance! |
Accident apologies - accidentally closed the PR |
micahgodbolt
removed
the
needs cherry-pick
Similar as recently submitted PR but for version 7.X
From the developer examples of fluent UI for React, the overflowset custom examples overflow icons are not displaying, this PR resolves it.
tested using the codepen link from the website.
Web page in question link v7:
https://developer.microsoft.com/en-us/fluentui?fabricVer=7#/controls/web/overflowset
Previous Behavior
the React FluentUI overflowset example does not show the icons that are in the code
New Behavior
Resolves the missing icon issues
Related Issue(s)
None