chore: move storywright to root package json to adhere to single version policy for devDeps #26131

Hotell · 2022-12-29T18:23:07Z

Related Issue(s)

Fixes partially feat: adopt single version policy for monorepo dependencies #21395

…ion policy for devDeps

DustyTheBot · 2022-12-29T18:27:19Z

	Warnings
⚠️	There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

Generated by 🚫 dangerJS against 05e6245

size-auditor · 2022-12-29T18:34:52Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 4931288491223778cffde64e6117da72d8143eae (build)

fabricteam · 2022-12-29T18:38:05Z

Perf Analysis (`@fluentui/react-components`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	1263	1260	5000
Button	mount	926	919	5000
FluentProvider	mount	1503	1482	5000
FluentProviderWithTheme	mount	572	579	10
FluentProviderWithTheme	virtual-rerender	541	542	10
FluentProviderWithTheme	virtual-rerender-with-unmount	581	582	10
MakeStyles	mount	1957	1949	50000
Persona	mount	2826	2734	5000
SpinButton	mount	2306	2323	5000

codesandbox-ci · 2022-12-29T18:38:28Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 05e6245:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

fabricteam · 2022-12-29T18:42:44Z

🕵 fluentuiv8 Open the Visual Regressions report to inspect the 2 screenshots

✅ There was 0 screenshots added, 2 screenshots removed, 1041 screenshots unchanged, 0 screenshots with different dimensions and 0 screenshots with visible difference.

unknown 2 screenshots

Image Name	Diff(in Pixels)	Image Type
Pivot - Overflow.Root.Narrow - Last tab selected.chromium.png	0	Removed
Pivot - Overflow.Root.Narrow - Overflow menu.chromium.png	0	Removed

fabricteam · 2022-12-29T18:45:05Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`global-context` createContext	`533 B` `341 B`
`global-context` createContextSelector	`554 B` `348 B`
`priority-overflow` createOverflowManager	`3.153 kB` `1.299 kB`
`react-accordion` Accordion (including children components)	`79.673 kB` `24.57 kB`
`react-alert` Alert	`84.15 kB` `21.28 kB`
`react-avatar` Avatar	`51.083 kB` `14.289 kB`
`react-avatar` AvatarGroup	`15.006 kB` `6.009 kB`
`react-avatar` AvatarGroupItem	`67.313 kB` `18.585 kB`
`react-badge` Badge	`23.357 kB` `7.361 kB`
`react-badge` CounterBadge	`24.247 kB` `7.643 kB`
`react-badge` PresenceBadge	`24.001 kB` `7.049 kB`
`react-button` Button	`32.923 kB` `8.61 kB`
`react-button` CompoundButton	`39.953 kB` `9.933 kB`
`react-button` MenuButton	`37.611 kB` `9.942 kB`
`react-button` SplitButton	`45.057 kB` `11.323 kB`
`react-button` ToggleButton	`48.753 kB` `10.715 kB`
`react-card` Card - All	`77.54 kB` `22.326 kB`
`react-card` Card	`72.484 kB` `20.915 kB`
`react-card` CardFooter	`8.617 kB` `3.62 kB`
`react-card` CardHeader	`10.382 kB` `4.258 kB`
`react-card` CardPreview	`9.424 kB` `3.97 kB`
`react-checkbox` Checkbox	`28.65 kB` `9.09 kB`
`react-checkbox` CheckboxField	`35.067 kB` `10.89 kB`
`react-combobox` Combobox (including child components)	`78.713 kB` `25.211 kB`
`react-combobox` ComboboxField	`75.916 kB` `25.158 kB`
`react-combobox` Dropdown (including child components)	`77.961 kB` `25.154 kB`
`react-components` react-components: Button, FluentProvider & webLightTheme	`59.381 kB` `16.465 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`187.536 kB` `52.644 kB`
`react-components` react-components: FluentProvider & webLightTheme	`33.843 kB` `11.129 kB`
`react-dialog` Dialog (including children components)	`83.035 kB` `24.76 kB`
`react-divider` Divider	`16.515 kB` `5.921 kB`
`react-image` Image	`10.836 kB` `4.283 kB`
`react-infobutton` InfoButton	`118.381 kB` `35.495 kB`
`react-input` Input	`24.194 kB` `7.89 kB`
`react-input` InputField	`33.408 kB` `10.584 kB`
`react-label` Label	`9.394 kB` `3.88 kB`
`react-link` Link	`11.862 kB` `4.885 kB`
`react-menu` Menu (including children components)	`118.257 kB` `36.535 kB`
`react-menu` Menu (including selectable components)	`121.326 kB` `37.065 kB`
`react-overflow` hooks only	`11.004 kB` `4.188 kB`
`react-persona` Persona	`57.12 kB` `15.945 kB`
`react-popover` Popover	`104.125 kB` `32.068 kB`
`react-portal` Portal	`10.697 kB` `3.938 kB`
`react-portal-compat` PortalCompatProvider	`5.857 kB` `1.978 kB`
`react-positioning` usePositioning	`19.883 kB` `7.439 kB`
`react-progress` ProgressBar	`13.155 kB` `5.048 kB`
`react-progress` ProgressField	`22.461 kB` `7.919 kB`
`react-provider` FluentProvider	`15.91 kB` `5.931 kB`
`react-radio` Radio	`31.827 kB` `10.316 kB`
`react-radio` RadioGroup	`14.304 kB` `5.72 kB`
`react-radio` RadioGroupField	`23.604 kB` `8.65 kB`
`react-select` Select	`23.474 kB` `8.017 kB`
`react-select` SelectField	`31.731 kB` `10.256 kB`
`react-slider` Slider	`32.091 kB` `10.183 kB`
`react-slider` SliderField	`41.113 kB` `12.903 kB`
`react-spinbutton` SpinButton	`44.502 kB` `12.812 kB`
`react-spinbutton` SpinButtonField	`52.784 kB` `15.085 kB`
`react-spinner` Spinner	`20.013 kB` `6.446 kB`
`react-switch` Switch	`33.427 kB` `10.581 kB`
`react-switch` SwitchField	`39.745 kB` `12.362 kB`
`react-text` Text - Default	`11.838 kB` `4.625 kB`
`react-text` Text - Wrappers	`15.148 kB` `5.06 kB`
`react-textarea` Textarea	`25.733 kB` `8.328 kB`
`react-textarea` TextareaField	`34.949 kB` `11.012 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`30.908 kB` `6.714 kB`
`react-theme` Teams: Light theme	`17.776 kB` `5.141 kB`
`react-tooltip` Tooltip	`42.158 kB` `14.796 kB`
`react-utilities` SSRProvider	`180 B` `159 B`

_{🤖 This report was generated against 4931288491223778cffde64e6117da72d8143eae}

fabricteam · 2022-12-29T18:45:13Z

Perf Analysis (`@fluentui/react-northstar`)

⚠️ No perf measurements available

fabricteam · 2022-12-29T18:46:48Z

🕵 fluentuiv9 No visual regressions between this PR and main

fabricteam · 2022-12-29T18:50:00Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	1188	1202	5000
Breadcrumb	mount	2834	2825	1000
Checkbox	mount	2590	2642	5000
CheckboxBase	mount	2365	2390	5000
ChoiceGroup	mount	4305	4235	5000
ComboBox	mount	1160	1158	1000
CommandBar	mount	9294	9237	1000
ContextualMenu	mount	10168	10123	1000
DefaultButton	mount	1351	1366	5000
DetailsRow	mount	3359	3352	5000
DetailsRowFast	mount	3357	3359	5000
DetailsRowNoStyles	mount	3207	3244	5000
Dialog	mount	2921	2918	1000
DocumentCardTitle	mount	580	587	1000
Dropdown	mount	3155	3130	5000
FocusTrapZone	mount	1970	1990	5000
FocusZone	mount	1938	1935	5000
GroupedList	mount	1828	2053	2
GroupedList	virtual-rerender	1098	1076	2
GroupedList	virtual-rerender-with-unmount	1603	1582	2
GroupedListV2	mount	568	557	2
GroupedListV2	virtual-rerender	547	534	2
GroupedListV2	virtual-rerender-with-unmount	577	566	2
IconButton	mount	1787	1807	5000
Label	mount	743	763	5000
Layer	mount	4243	4217	5000
Link	mount	837	829	5000
MenuButton	mount	1608	1608	5000
MessageBar	mount	2378	2379	5000
Nav	mount	3051	3044	1000
OverflowSet	mount	1396	1404	5000
Panel	mount	2507	2505	1000
Persona	mount	1283	1295	1000
Pivot	mount	1523	1524	1000
PrimaryButton	mount	1486	1491	5000
Rating	mount	6956	6928	5000
SearchBox	mount	1461	1516	5000
Shimmer	mount	2918	2888	5000
Slider	mount	2097	2111	5000
SpinButton	mount	4233	4241	5000
Spinner	mount	826	820	5000
SplitButton	mount	2817	2839	5000
Stack	mount	869	862	5000
StackWithIntrinsicChildren	mount	2295	2268	5000
StackWithTextChildren	mount	4994	4979	5000
SwatchColorPicker	mount	9450	9456	5000
TagPicker	mount	2322	2333	5000
TeachingBubble	mount	75189	75627	5000
Text	mount	830	821	5000
TextField	mount	1558	1579	5000
ThemeProvider	mount	1449	1447	5000
ThemeProvider	virtual-rerender	1144	1142	5000
ThemeProvider	virtual-rerender-with-unmount	2005	2016	5000
Toggle	mount	1132	1147	5000
buttonNative	mount	532	538	5000

fabricteam · 2022-12-29T19:02:13Z

🕵 FluentUI-v0 No visual regressions between this PR and main

…ion policy for devDeps (microsoft#26131)

chore: move storywright to root package json to adhere to single vers…

05e6245

…ion policy for devDeps

msft-fluent-ui-bot assigned smhigley Dec 29, 2022

github-actions bot added this to the October Project Cycle Q4 2022 milestone Dec 29, 2022

Hotell added Area: Build System dependencies Pull requests that update a dependency file labels Dec 29, 2022

Hotell marked this pull request as ready for review December 29, 2022 18:24

Hotell requested a review from a team as a code owner December 29, 2022 18:24

Hotell unassigned smhigley Dec 29, 2022

TristanWatanabe approved these changes Dec 29, 2022

View reviewed changes

Hotell merged commit 9a806eb into microsoft:master Dec 30, 2022

Hotell deleted the hotell/build/svp/storywright branch December 30, 2022 10:53

q1b pushed a commit to q1b/fluentui that referenced this pull request Jan 24, 2023

chore: move storywright to root package json to adhere to single vers…

db2c122

…ion policy for devDeps (microsoft#26131)

Hotell added a commit to Hotell/fluentui that referenced this pull request Feb 9, 2023

chore: move storywright to root package json to adhere to single vers…

6ed895d

…ion policy for devDeps (microsoft#26131)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: move storywright to root package json to adhere to single version policy for devDeps #26131

chore: move storywright to root package json to adhere to single version policy for devDeps #26131

Hotell commented Dec 29, 2022 •

edited

Loading

DustyTheBot commented Dec 29, 2022

size-auditor bot commented Dec 29, 2022

fabricteam commented Dec 29, 2022

codesandbox-ci bot commented Dec 29, 2022

fabricteam commented Dec 29, 2022

fabricteam commented Dec 29, 2022

fabricteam commented Dec 29, 2022

fabricteam commented Dec 29, 2022

fabricteam commented Dec 29, 2022

fabricteam commented Dec 29, 2022

chore: move storywright to root package json to adhere to single version policy for devDeps #26131

chore: move storywright to root package json to adhere to single version policy for devDeps #26131

Conversation

Hotell commented Dec 29, 2022 • edited Loading

Related Issue(s)

DustyTheBot commented Dec 29, 2022

size-auditor bot commented Dec 29, 2022

Asset size changes

fabricteam commented Dec 29, 2022

Perf Analysis (@fluentui/react-components)

codesandbox-ci bot commented Dec 29, 2022

fabricteam commented Dec 29, 2022

🕵 fluentuiv8 Open the Visual Regressions report to inspect the 2 screenshots

fabricteam commented Dec 29, 2022

📊 Bundle size report

fabricteam commented Dec 29, 2022

Perf Analysis (@fluentui/react-northstar)

fabricteam commented Dec 29, 2022

🕵 fluentuiv9 No visual regressions between this PR and main

fabricteam commented Dec 29, 2022

Perf Analysis (@fluentui/react)

fabricteam commented Dec 29, 2022

🕵 FluentUI-v0 No visual regressions between this PR and main

Hotell commented Dec 29, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

Perf Analysis (`@fluentui/react-northstar`)

Perf Analysis (`@fluentui/react`)