Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(react-migration-v8-v9): use same build process/setup as v9/ts-solution packages #25679

Merged

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Nov 15, 2022

Pre-requirements

Current Behavior

  • react-migration-v8-v9 is using v9 build setup but is opting out from defaults
  • stories are shipped to npm
  • copy-compiled task is restricted only for convergence

New Behavior

  • react-migration-v8-v9 is using v9 build setup to full extend
  • stories are not shipped to npm
  • copy-compiled works for any package with ts-solution config

Related Issue(s)

Follows #25422

@Hotell Hotell changed the title chore(react-migration-v8-v9): use same build process/setup as v9/ts-s… chore(react-migration-v8-v9): use same build process/setup as v9/ts-solution packages Nov 15, 2022
@fabricteam
Copy link
Collaborator

fabricteam commented Nov 15, 2022

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext
533 B
341 B
global-context
createContextSelector
554 B
348 B
priority-overflow
createOverflowManager
3.153 kB
1.299 kB
react-accordion
Accordion (including children components)
79.294 kB
24.443 kB
react-alert
Alert
86.996 kB
21.732 kB
react-avatar
Avatar
51.181 kB
14.31 kB
react-avatar
AvatarGroup
15.006 kB
6.009 kB
react-avatar
AvatarGroupItem
65.759 kB
18.408 kB
react-badge
Badge
22.656 kB
7.225 kB
react-badge
CounterBadge
23.546 kB
7.508 kB
react-badge
PresenceBadge
24.106 kB
7.087 kB
react-button
Button
36.86 kB
9.913 kB
react-button
CompoundButton
43.885 kB
11.131 kB
react-button
MenuButton
41.537 kB
11.187 kB
react-button
SplitButton
48.983 kB
12.588 kB
react-button
ToggleButton
52.685 kB
11.415 kB
react-card
Card - All
71.873 kB
20.936 kB
react-card
Card
67.651 kB
19.892 kB
react-card
CardFooter
8.617 kB
3.62 kB
react-card
CardHeader
9.792 kB
3.995 kB
react-card
CardPreview
8.718 kB
3.674 kB
react-combobox
Combobox (including child components)
78.086 kB
24.988 kB
react-combobox
Dropdown (including child components)
77.373 kB
24.891 kB
react-components
react-components: Button, FluentProvider & webLightTheme
62.951 kB
17.675 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
190.427 kB
53.087 kB
react-components
react-components: FluentProvider & webLightTheme
33.456 kB
11.029 kB
react-dialog
Dialog (including children components)
83.036 kB
24.754 kB
react-divider
Divider
16.515 kB
5.921 kB
react-image
Image
10.836 kB
4.283 kB
react-infobutton
InfoButton
117.938 kB
35.399 kB
react-input
Input
24.122 kB
7.889 kB
react-label
Label
9.394 kB
3.88 kB
react-link
Link
11.862 kB
4.885 kB
react-menu
Menu (including children components)
117.61 kB
36.287 kB
react-menu
Menu (including selectable components)
120.679 kB
36.82 kB
react-overflow
hooks only
11.004 kB
4.188 kB
react-persona
Persona
57.236 kB
15.976 kB
react-popover
Popover
103.682 kB
31.867 kB
react-portal
Portal
10.495 kB
3.851 kB
react-portal-compat
PortalCompatProvider
5.857 kB
1.978 kB
react-positioning
usePositioning
19.826 kB
7.417 kB
react-progress
Progress
13.536 kB
5.107 kB
react-provider
FluentProvider
15.817 kB
5.905 kB
react-radio
Radio
36.446 kB
12.123 kB
react-radio
RadioGroup
14.304 kB
5.72 kB
react-select
Select
23.438 kB
8.018 kB
react-slider
Slider
32.118 kB
10.192 kB
react-spinbutton
SpinButton
44.43 kB
12.812 kB
react-spinner
Spinner
20.013 kB
6.446 kB
react-switch
Switch
33.453 kB
10.581 kB
react-text
Text - Default
11.838 kB
4.625 kB
react-text
Text - Wrappers
15.148 kB
5.06 kB
react-textarea
Textarea
25.697 kB
8.328 kB
react-theme
Single theme token import
69 B
89 B
react-theme
Teams: all themes
29.65 kB
6.444 kB
react-theme
Teams: Light theme
17.486 kB
5.057 kB
react-tooltip
Tooltip
42.032 kB
14.739 kB
react-utilities
SSRProvider
180 B
159 B
🤖 This report was generated against bd0257fd347a38db6abda49f850baf38f960b610

@size-auditor
Copy link

size-auditor bot commented Nov 15, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: bd0257fd347a38db6abda49f850baf38f960b610 (build)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 15, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e98d5df:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Nov 16, 2022

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1284 1277 5000
Button mount 930 936 5000
FluentProvider mount 1524 1495 5000
FluentProviderWithTheme mount 582 585 10
FluentProviderWithTheme virtual-rerender 532 549 10
FluentProviderWithTheme virtual-rerender-with-unmount 587 569 10
MakeStyles mount 1952 1967 50000
SpinButton mount 2343 2359 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Nov 16, 2022

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
SkeletonMinimalPerf.default 301 280 1.08:1
AvatarMinimalPerf.default 157 151 1.04:1
RefMinimalPerf.default 178 171 1.04:1
VideoMinimalPerf.default 609 587 1.04:1
CardMinimalPerf.default 437 426 1.03:1
GridMinimalPerf.default 280 273 1.03:1
LabelMinimalPerf.default 311 302 1.03:1
ListMinimalPerf.default 423 411 1.03:1
LoaderMinimalPerf.default 277 268 1.03:1
PopupMinimalPerf.default 531 516 1.03:1
PortalMinimalPerf.default 142 138 1.03:1
RadioGroupMinimalPerf.default 365 355 1.03:1
TextMinimalPerf.default 282 274 1.03:1
TreeMinimalPerf.default 681 660 1.03:1
AnimationMinimalPerf.default 448 439 1.02:1
BoxMinimalPerf.default 280 275 1.02:1
CarouselMinimalPerf.default 381 373 1.02:1
DialogMinimalPerf.default 645 635 1.02:1
DividerMinimalPerf.default 291 285 1.02:1
InputMinimalPerf.default 960 940 1.02:1
ReactionMinimalPerf.default 305 298 1.02:1
SliderMinimalPerf.default 1342 1315 1.02:1
TableMinimalPerf.default 331 324 1.02:1
TreeWith60ListItems.default 127 124 1.02:1
AttachmentSlotsPerf.default 913 905 1.01:1
ButtonMinimalPerf.default 130 129 1.01:1
ButtonOverridesMissPerf.default 1090 1083 1.01:1
CheckboxMinimalPerf.default 1740 1718 1.01:1
DatepickerMinimalPerf.default 4802 4735 1.01:1
FormMinimalPerf.default 313 310 1.01:1
ItemLayoutMinimalPerf.default 976 965 1.01:1
ListNestedPerf.default 457 454 1.01:1
MenuButtonMinimalPerf.default 1424 1407 1.01:1
ProviderMinimalPerf.default 340 337 1.01:1
TextAreaMinimalPerf.default 381 378 1.01:1
CustomToolbarPrototype.default 2263 2245 1.01:1
AttachmentMinimalPerf.default 117 117 1:1
ButtonSlotsPerf.default 459 460 1:1
ChatDuplicateMessagesPerf.default 222 221 1:1
ChatMinimalPerf.default 603 602 1:1
ChatWithPopoverPerf.default 306 306 1:1
DropdownManyItemsPerf.default 543 544 1:1
EmbedMinimalPerf.default 3056 3062 1:1
LayoutMinimalPerf.default 290 289 1:1
RosterPerf.default 1765 1765 1:1
ProviderMergeThemesPerf.default 1066 1062 1:1
SplitButtonMinimalPerf.default 3665 3657 1:1
TableManyItemsPerf.default 1547 1554 1:1
ToolbarMinimalPerf.default 765 763 1:1
TooltipMinimalPerf.default 1922 1929 1:1
DropdownMinimalPerf.default 2234 2249 0.99:1
FlexMinimalPerf.default 232 235 0.99:1
HeaderSlotsPerf.default 620 627 0.99:1
ImageMinimalPerf.default 313 317 0.99:1
ListCommonPerf.default 520 524 0.99:1
ListWith60ListItems.default 522 527 0.99:1
SegmentMinimalPerf.default 280 282 0.99:1
StatusMinimalPerf.default 554 557 0.99:1
IconMinimalPerf.default 545 549 0.99:1
AlertMinimalPerf.default 224 229 0.98:1
MenuMinimalPerf.default 686 697 0.98:1
HeaderMinimalPerf.default 283 292 0.97:1
AccordionMinimalPerf.default 116 121 0.96:1

@fabricteam
Copy link
Collaborator

fabricteam commented Nov 16, 2022

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 1194 1189 5000
Breadcrumb mount 2806 2822 1000
Checkbox mount 2638 2656 5000
CheckboxBase mount 2369 2385 5000
ChoiceGroup mount 4286 4343 5000
ComboBox mount 1179 1195 1000
CommandBar mount 9219 9214 1000
ContextualMenu mount 10083 10080 1000
DefaultButton mount 1381 1361 5000
DetailsRow mount 3367 3372 5000
DetailsRowFast mount 3377 3346 5000
DetailsRowNoStyles mount 3265 3222 5000
Dialog mount 2961 2957 1000
DocumentCardTitle mount 575 580 1000
Dropdown mount 3141 3170 5000
FocusTrapZone mount 1959 1964 5000
FocusZone mount 1945 1920 5000
GroupedList mount 1840 2063 2
GroupedList virtual-rerender 1090 1079 2
GroupedList virtual-rerender-with-unmount 1589 1594 2
GroupedListV2 mount 574 567 2
GroupedListV2 virtual-rerender 538 540 2
GroupedListV2 virtual-rerender-with-unmount 552 563 2
IconButton mount 1809 1839 5000
Label mount 751 761 5000
Layer mount 4194 4173 5000
Link mount 861 846 5000
MenuButton mount 1602 1612 5000
MessageBar mount 2355 2335 5000
Nav mount 3047 3116 1000
OverflowSet mount 1404 1403 5000
Panel mount 2486 2500 1000
Persona mount 1263 1266 1000
Pivot mount 1517 1522 1000
PrimaryButton mount 1490 1493 5000
Rating mount 6984 6961 5000
SearchBox mount 1492 1489 5000
Shimmer mount 2872 2903 5000
Slider mount 2107 2127 5000
SpinButton mount 4276 4273 5000
Spinner mount 826 823 5000
SplitButton mount 2836 2983 5000
Stack mount 874 866 5000
StackWithIntrinsicChildren mount 2331 2346 5000
StackWithTextChildren mount 5057 5036 5000
SwatchColorPicker mount 9480 9463 5000
TagPicker mount 2342 2310 5000
TeachingBubble mount 74935 75381 5000
Text mount 821 817 5000
TextField mount 1546 1563 5000
ThemeProvider mount 1442 1449 5000
ThemeProvider virtual-rerender 1149 1150 5000
ThemeProvider virtual-rerender-with-unmount 1991 1990 5000
Toggle mount 1136 1118 5000
buttonNative mount 532 535 5000

@Hotell Hotell force-pushed the hotell/build/unify-build-task-in-v9-v8 branch from 2dea61e to 1f825a7 Compare November 16, 2022 13:31
@Hotell Hotell force-pushed the hotell/build/unify-build-task-in-v9-v8 branch from 1f825a7 to e98d5df Compare November 16, 2022 13:32
@Hotell Hotell removed this from the October Project Cycle Q4 2022 milestone Nov 16, 2022
@Hotell Hotell marked this pull request as ready for review November 16, 2022 14:43
@Hotell Hotell requested review from a team and GeoffCoxMSFT as code owners November 16, 2022 14:43
@tudorpopams tudorpopams self-requested a review November 22, 2022 13:16
@Hotell Hotell merged commit 0da8d75 into microsoft:master Nov 28, 2022
@Hotell Hotell deleted the hotell/build/unify-build-task-in-v9-v8 branch November 28, 2022 14:21
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Nov 29, 2022
* master: (34 commits)
  chore(react-tooltip): migrate to new package structure (microsoft#25818)
  chore(react-field): migrate to new package structure (microsoft#25817)
  Update vr screenshotdiff lib to accept vr host url as param (microsoft#25772)
  feat(scripts): enable strict checking for additional sub-folders(packages) v4 (microsoft#25710)
  fix(tools): bump norhtstar packages v9 deps on dep mismatch resolution (microsoft#25806)
  feat: remove react-storybook and replace its functionality via standard react-storybook-addon package (microsoft#25786)
  applying package updates
  chore(react-spinbutton): migrate to new package structure (microsoft#25813)
  chore(react-spinner): migrate to new package structure (microsoft#25814)
  chore(react-provider): migrate to new package structure (microsoft#25809)
  chore(react-radio, shared-contexts): migrate to new package structure (microsoft#25810)
  chore(react-theme): migrate to new package structure (microsoft#25812)
  docs: add Fluent UI Insights EP04 to README (microsoft#25775)
  chore(react-migration-v8-v9): use same build process/setup as v9/ts-solution packages (microsoft#25679)
  docs: Improves `Table` documentation (microsoft#25787)
  feat: improve react-18 tests (microsoft#25758)
  docs: Add examples for DataGrid (microsoft#25783)
  chore(react-tree): scaffold TreeItemLayout (microsoft#25781)
  perf: make ts-minbar test compilation faster and asset preparation simpler (microsoft#25754)
  chore: creates TreeItem and basic Tree (microsoft#25742)
  ...
Hotell added a commit to Hotell/fluentui that referenced this pull request Feb 9, 2023
…olution packages (microsoft#25679)

* chore(react-migration-v8-v9): use same build process/setup as v9/ts-solution packages

* feat(scripts): enable ts processing via ts solution config for non v9 packages

* generate changefiles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants