Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate @types/node to 14 to align with our supported node version #25510

Merged
merged 12 commits into from
Nov 9, 2022
Merged

chore: migrate @types/node to 14 to align with our supported node version #25510

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
350ff12
chore(deps): resolve only to 1 @types/node version to mitigate global…
Hotell Oct 20, 2022
93bb918
fix(bundle-size): fix type errors exposed by node 14 typings
Hotell Nov 3, 2022
5049f25
fix(tools): fix type errors exposed by node 14 typings
Hotell Nov 3, 2022
7675afb
fix(typings): fix type errors exposed by node 14 typings
Hotell Nov 3, 2022
690d6a5
revert: use resolution for @types/node
Hotell Nov 3, 2022
af4c39a
chore(ts-minbar-test-react): use @types/node 14 explicitly
Hotell Nov 3, 2022
deb0608
generate changefiles
Hotell Nov 3, 2022
0bcdc24
chore: dedupe deps
Hotell Nov 3, 2022
0e516b0
fix(scripts): fix type errors exposed by node 14 typings
Hotell Nov 4, 2022
23cc2c5
test: replace deprecated module.parent with require.main within isCon…
Hotell Nov 4, 2022
3c0b275
generate changefiles
Hotell Nov 4, 2022
e6fc681
test(react): clean up persona-coin test and use isConformant without …
Hotell Nov 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/ts-minbar-test-react/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ async function performTest() {

// Install dependencies, using the minimum TS version supported for consumers
const dependencies = [
'@types/node',
'@types/node@14',
'@types/react@17',
'@types/react-dom@17',
'react@17',
Expand Down
7 changes: 7 additions & 0 deletions change/@fluentui-bundle-size-c1ea3df8-acc9-4044-9944-7b960d1d40d6.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "minor",
"comment": "fix(typings): fix type errors exposed by node 14 typings",
"packageName": "@fluentui/bundle-size",
"email": "[email protected]",
"dependentChangeType": "none"
}
7 changes: 7 additions & 0 deletions change/@fluentui-react-accordion-14a67021-6f6e-4efa-b889-286f3c699080.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most of these are a mistake - #25531

"comment": "test: replace deprecated module.parent with require.main within isConformance",
"packageName": "@fluentui/react-accordion",
"email": "[email protected]",
"dependentChangeType": "none"
}
7 changes: 7 additions & 0 deletions change/@fluentui-react-alert-e81a5dca-681b-49a3-b176-ea058adf4c29.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "test: replace deprecated module.parent with require.main within isConformance",
"packageName": "@fluentui/react-alert",
"email": "[email protected]",
"dependentChangeType": "none"
}
7 changes: 7 additions & 0 deletions change/@fluentui-react-avatar-1ba4392f-adfc-4650-9a85-b86f896eee0e.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "test: replace deprecated module.parent with require.main within isConformance",
"packageName": "@fluentui/react-avatar",
"email": "[email protected]",
"dependentChangeType": "none"
}
7 changes: 7 additions & 0 deletions change/@fluentui-react-badge-024c280c-8f15-41b2-93b3-149a1c11d05e.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "test: replace deprecated module.parent with require.main within isConformance",
"packageName": "@fluentui/react-badge",
"email": "[email protected]",
"dependentChangeType": "none"
}
7 changes: 7 additions & 0 deletions change/@fluentui-react-button-461f70bc-251c-4c6f-9104-3cf26d4d1fb7.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "test: replace deprecated module.parent with require.main within isConformance",
"packageName": "@fluentui/react-button",
"email": "[email protected]",
"dependentChangeType": "none"
}
7 changes: 7 additions & 0 deletions change/@fluentui-react-card-d5917321-3b60-4068-9fb2-ccefcdd93ed7.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "test: replace deprecated module.parent with require.main within isConformance",
"packageName": "@fluentui/react-card",
"email": "[email protected]",
"dependentChangeType": "none"
}
7 changes: 7 additions & 0 deletions change/@fluentui-react-checkbox-e5ba1072-740b-4452-8632-c6706d93687b.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "test: replace deprecated module.parent with require.main within isConformance",
"packageName": "@fluentui/react-checkbox",
"email": "[email protected]",
"dependentChangeType": "none"
}
7 changes: 7 additions & 0 deletions change/@fluentui-react-conformance-a36f20ee-23ff-46d8-8df2-c7e4ef8035b3.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "test: replace deprecated module.parent with require.main within isConformance",
"packageName": "@fluentui/react-conformance",
"email": "[email protected]",
"dependentChangeType": "none"
}
7 changes: 7 additions & 0 deletions change/@fluentui-react-da22778f-cbbf-4200-b03c-752627517a9c.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "test(react): clean up persona-coin test and use isConformant without side-effects",
"packageName": "@fluentui/react",
"email": "[email protected]",
"dependentChangeType": "none"
}
7 changes: 7 additions & 0 deletions change/@fluentui-react-divider-2bc1605f-e9af-458b-a7fb-8f1fdcf34733.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "test: replace deprecated module.parent with require.main within isConformance",
"packageName": "@fluentui/react-divider",
"email": "[email protected]",
"dependentChangeType": "none"
}
7 changes: 7 additions & 0 deletions change/@fluentui-react-image-45ad5f93-4b5b-4c67-a944-7fccfae6bfc3.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "test: replace deprecated module.parent with require.main within isConformance",
"packageName": "@fluentui/react-image",
"email": "[email protected]",
"dependentChangeType": "none"
}
7 changes: 7 additions & 0 deletions change/@fluentui-react-input-5ed2b344-3969-406e-aaed-b050bd41b71f.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "test: replace deprecated module.parent with require.main within isConformance",
"packageName": "@fluentui/react-input",
"email": "[email protected]",
"dependentChangeType": "none"
}
7 changes: 7 additions & 0 deletions change/@fluentui-react-label-6a1213b1-4408-4638-9e96-05131413a17c.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "test: replace deprecated module.parent with require.main within isConformance",
"packageName": "@fluentui/react-label",
"email": "[email protected]",
"dependentChangeType": "none"
}
7 changes: 7 additions & 0 deletions change/@fluentui-react-link-b40f8272-57a7-4639-8c03-13ce6c1376c2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "test: replace deprecated module.parent with require.main within isConformance",
"packageName": "@fluentui/react-link",
"email": "[email protected]",
"dependentChangeType": "none"
}
7 changes: 7 additions & 0 deletions change/@fluentui-react-menu-ee5668bd-7c18-4a10-8c5f-d73781e0bb0a.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "test: replace deprecated module.parent with require.main within isConformance",
"packageName": "@fluentui/react-menu",
"email": "[email protected]",
"dependentChangeType": "none"
}
7 changes: 7 additions & 0 deletions change/@fluentui-react-select-dc08e75c-c7ec-43cd-a398-24c2ce691865.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "test: replace deprecated module.parent with require.main within isConformance",
"packageName": "@fluentui/react-select",
"email": "[email protected]",
"dependentChangeType": "none"
}
7 changes: 7 additions & 0 deletions change/@fluentui-react-slider-87f6c6a9-6d60-43cf-9a2c-e53d385b0003.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "test: replace deprecated module.parent with require.main within isConformance",
"packageName": "@fluentui/react-slider",
"email": "[email protected]",
"dependentChangeType": "none"
}
7 changes: 7 additions & 0 deletions change/@fluentui-react-table-13bce812-a740-4bf4-9fab-332e0b1938ed.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "test: replace deprecated module.parent with require.main within isConformance",
"packageName": "@fluentui/react-table",
"email": "[email protected]",
"dependentChangeType": "none"
}
7 changes: 7 additions & 0 deletions change/@fluentui-react-tabs-cb4fc9a7-01ba-4cca-9ca3-20525b961355.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "test: replace deprecated module.parent with require.main within isConformance",
"packageName": "@fluentui/react-tabs",
"email": "[email protected]",
"dependentChangeType": "none"
}
7 changes: 7 additions & 0 deletions change/@fluentui-react-text-4f821f14-0532-4b40-9d86-dba76ad60df0.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "test: replace deprecated module.parent with require.main within isConformance",
"packageName": "@fluentui/react-text",
"email": "[email protected]",
"dependentChangeType": "none"
}
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@
"@types/loader-utils": "2.0.3",
"@types/markdown-table": "2.0.0",
"@types/micromatch": "4.0.2",
"@types/node": "10.17.55",
"@types/node": "14.18.32",
"@types/node-fetch": "2.5.7",
"@types/prettier": "2.2.3",
"@types/progress": "2.0.5",
Expand Down
4 changes: 2 additions & 2 deletions packages/bundle-size/src/utils/buildFixture.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,8 +129,8 @@ module.exports = async function buildFixture(preparedFixture, quiet) {
/* eslint-enable @typescript-eslint/naming-convention */
]);

await fs.writeFile(webpackOutputPath, terserOutput.code);
await fs.writeFile(terserOutputPath, terserOutputMinified.code);
await fs.writeFile(webpackOutputPath, terserOutput.code ?? '');
await fs.writeFile(terserOutputPath, terserOutputMinified.code ?? '');

if (!quiet) {
console.log(
Expand Down
7 changes: 6 additions & 1 deletion packages/bundle-size/src/utils/prepareFixture.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@ const ajv = new Ajv();
/** @typedef {{ name: string }} FixtureMetadata */
/** @typedef {{ absolutePath: string, relativePath: string, name: string }} PreparedFixture */

/**
* @template T
* @typedef {NonNullable<T> & {[P in keyof T]-?: NonNullable<T[P]>;}} RequiredNonNullableRecord<T>
*/

/**
* Prepares a fixture file to be compiled with Webpack, grabs data from a default export and removes it.
*
Expand Down Expand Up @@ -59,7 +64,7 @@ module.exports = async function prepareFixture(fixture) {

/**
* @param {typeof result} value
* @return {value is Required<NonNullable<typeof result>> & {metadata: FixtureMetadata}}
* @return {value is RequiredNonNullableRecord<typeof result> & {metadata: FixtureMetadata}}
*/
function isTransformedFixtureResultHasMetadata(value) {
return Boolean(value && value.metadata && Object.keys(value.metadata).length);
Expand Down
2 changes: 1 addition & 1 deletion packages/react-components/react-accordion/src/testing/isConformant.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ export function isConformant<TProps = {}>(
testInfo: Omit<IsConformantOptions<TProps>, 'componentPath'> & { componentPath?: string },
) {
const defaultOptions: Partial<IsConformantOptions<TProps>> = {
componentPath: module!.parent!.filename.replace('.test', ''),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deprecated ! https://nodejs.org/api/modules.html#moduleparent

componentPath: require.main?.filename.replace('.test', ''),
extraTests: griffelTests as TestObject<TProps>,
};

Expand Down
2 changes: 1 addition & 1 deletion packages/react-components/react-alert/src/testing/isConformant.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ export function isConformant<TProps = {}>(
testInfo: Omit<IsConformantOptions<TProps>, 'componentPath'> & { componentPath?: string },
) {
const defaultOptions: Partial<IsConformantOptions<TProps>> = {
componentPath: module!.parent!.filename.replace('.test', ''),
componentPath: require.main?.filename.replace('.test', ''),
extraTests: griffelTests as TestObject<TProps>,
};

Expand Down
2 changes: 1 addition & 1 deletion packages/react-components/react-avatar/src/testing/isConformant.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ export function isConformant<TProps = {}>(
testInfo: Omit<IsConformantOptions<TProps>, 'componentPath'> & { componentPath?: string },
) {
const defaultOptions: Partial<IsConformantOptions<TProps>> = {
componentPath: module!.parent!.filename.replace('.test', ''),
componentPath: require.main?.filename.replace('.test', ''),
extraTests: griffelTests as TestObject<TProps>,
};

Expand Down
2 changes: 1 addition & 1 deletion packages/react-components/react-badge/src/testing/isConformant.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ export function isConformant<TProps = {}>(
testInfo: Omit<IsConformantOptions<TProps>, 'componentPath'> & { componentPath?: string },
) {
const defaultOptions: Partial<IsConformantOptions<TProps>> = {
componentPath: module!.parent!.filename.replace('.test', ''),
componentPath: require.main?.filename.replace('.test', ''),
extraTests: griffelTests as TestObject<TProps>,
};

Expand Down
2 changes: 1 addition & 1 deletion packages/react-components/react-button/src/testing/isConformant.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ export function isConformant<TProps = {}>(
testInfo: Omit<IsConformantOptions<TProps>, 'componentPath'> & { componentPath?: string },
) {
const defaultOptions: Partial<IsConformantOptions<TProps>> = {
componentPath: module!.parent!.filename.replace('.test', ''),
componentPath: require.main?.filename.replace('.test', ''),
extraTests: griffelTests as TestObject<TProps>,
};

Expand Down
2 changes: 1 addition & 1 deletion packages/react-components/react-card/src/testing/isConformant.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ export function isConformant<TProps = {}>(
testInfo: Omit<IsConformantOptions<TProps>, 'componentPath'> & { componentPath?: string },
) {
const defaultOptions: Partial<IsConformantOptions<TProps>> = {
componentPath: module!.parent!.filename.replace('.test', ''),
componentPath: require.main?.filename.replace('.test', ''),
extraTests: griffelTests as TestObject<TProps>,
};

Expand Down
2 changes: 1 addition & 1 deletion packages/react-components/react-checkbox/src/testing/isConformant.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ export function isConformant<TProps = {}>(
testInfo: Omit<IsConformantOptions<TProps>, 'componentPath'> & { componentPath?: string },
) {
const defaultOptions: Partial<IsConformantOptions<TProps>> = {
componentPath: module!.parent!.filename.replace('.test', ''),
componentPath: require.main?.filename.replace('.test', ''),
extraTests: griffelTests as TestObject<TProps>,
};

Expand Down
2 changes: 1 addition & 1 deletion packages/react-components/react-combobox/src/common/isConformant.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ export function isConformant<TProps = {}>(
testInfo: Omit<IsConformantOptions<TProps>, 'componentPath'> & { componentPath?: string },
) {
const defaultOptions: Partial<IsConformantOptions<TProps>> = {
componentPath: module!.parent!.filename.replace('.test', ''),
componentPath: require.main?.filename.replace('.test', ''),
extraTests: griffelTests as TestObject<TProps>,
};

Expand Down
2 changes: 1 addition & 1 deletion packages/react-components/react-dialog/src/testing/isConformant.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ export function isConformant<TProps = {}>(
testInfo: Omit<IsConformantOptions<TProps>, 'componentPath'> & { componentPath?: string },
) {
const defaultOptions: Partial<IsConformantOptions<TProps>> = {
componentPath: module!.parent!.filename.replace('.test', ''),
componentPath: require.main?.filename.replace('.test', ''),
extraTests: griffelTests as TestObject<TProps>,
};

Expand Down
2 changes: 1 addition & 1 deletion packages/react-components/react-divider/src/testing/isConformant.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ export function isConformant<TProps = {}>(
testInfo: Omit<IsConformantOptions<TProps>, 'componentPath'> & { componentPath?: string },
) {
const defaultOptions: Partial<IsConformantOptions<TProps>> = {
componentPath: module!.parent!.filename.replace('.test', ''),
componentPath: require.main?.filename.replace('.test', ''),
extraTests: griffelTests as TestObject<TProps>,
};

Expand Down
2 changes: 1 addition & 1 deletion packages/react-components/react-field/src/common/isConformant.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ export function isConformant<TProps = {}>(
testInfo: Omit<IsConformantOptions<TProps>, 'componentPath'> & { componentPath?: string },
) {
const defaultOptions: Partial<IsConformantOptions<TProps>> = {
componentPath: module!.parent!.filename.replace('.test', ''),
componentPath: require.main?.filename.replace('.test', ''),
extraTests: griffelTests as TestObject<TProps>,

// Field-specific defaults
Expand Down
2 changes: 1 addition & 1 deletion packages/react-components/react-image/src/testing/isConformant.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ export function isConformant<TProps = {}>(
testInfo: Omit<IsConformantOptions<TProps>, 'componentPath'> & { componentPath?: string },
) {
const defaultOptions: Partial<IsConformantOptions<TProps>> = {
componentPath: module!.parent!.filename.replace('.test', ''),
componentPath: require.main?.filename.replace('.test', ''),
extraTests: griffelTests as TestObject<TProps>,
};

Expand Down
2 changes: 1 addition & 1 deletion packages/react-components/react-infobutton/src/common/isConformant.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ export function isConformant<TProps = {}>(
testInfo: Omit<IsConformantOptions<TProps>, 'componentPath'> & { componentPath?: string },
) {
const defaultOptions: Partial<IsConformantOptions<TProps>> = {
componentPath: module!.parent!.filename.replace('.test', ''),
componentPath: require.main?.filename.replace('.test', ''),
extraTests: griffelTests as TestObject<TProps>,
};

Expand Down
2 changes: 1 addition & 1 deletion packages/react-components/react-input/src/testing/isConformant.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ export function isConformant<TProps = {}>(
testInfo: Omit<IsConformantOptions<TProps>, 'componentPath'> & { componentPath?: string },
) {
const defaultOptions: Partial<IsConformantOptions<TProps>> = {
componentPath: module!.parent!.filename.replace('.test', ''),
componentPath: require.main?.filename.replace('.test', ''),
extraTests: griffelTests as TestObject<TProps>,
};

Expand Down
2 changes: 1 addition & 1 deletion packages/react-components/react-label/src/testing/isConformant.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ export function isConformant<TProps = {}>(
testInfo: Omit<IsConformantOptions<TProps>, 'componentPath'> & { componentPath?: string },
) {
const defaultOptions: Partial<IsConformantOptions<TProps>> = {
componentPath: module!.parent!.filename.replace('.test', ''),
componentPath: require.main?.filename.replace('.test', ''),
extraTests: griffelTests as TestObject<TProps>,
};

Expand Down
2 changes: 1 addition & 1 deletion packages/react-components/react-link/src/testing/isConformant.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ export function isConformant<TProps = {}>(
testInfo: Omit<IsConformantOptions<TProps>, 'componentPath'> & { componentPath?: string },
) {
const defaultOptions: Partial<IsConformantOptions<TProps>> = {
componentPath: module!.parent!.filename.replace('.test', ''),
componentPath: require.main?.filename.replace('.test', ''),
extraTests: griffelTests as TestObject<TProps>,
};

Expand Down
2 changes: 1 addition & 1 deletion packages/react-components/react-menu/src/testing/isConformant.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ export function isConformant<TProps = {}>(
testInfo: Omit<IsConformantOptions<TProps>, 'componentPath'> & { componentPath?: string },
) {
const defaultOptions: Partial<IsConformantOptions<TProps>> = {
componentPath: module!.parent!.filename.replace('.test', ''),
componentPath: require.main?.filename.replace('.test', ''),
extraTests: griffelTests as TestObject<TProps>,
};

Expand Down
2 changes: 1 addition & 1 deletion packages/react-components/react-persona/src/common/isConformant.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ export function isConformant<TProps = {}>(
testInfo: Omit<IsConformantOptions<TProps>, 'componentPath'> & { componentPath?: string },
) {
const defaultOptions: Partial<IsConformantOptions<TProps>> = {
componentPath: module!.parent!.filename.replace('.test', ''),
componentPath: require.main?.filename.replace('.test', ''),
extraTests: griffelTests as TestObject<TProps>,
};

Expand Down
2 changes: 1 addition & 1 deletion packages/react-components/react-popover/src/common/isConformant.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ export function isConformant<TProps = {}>(
testInfo: Omit<IsConformantOptions<TProps>, 'componentPath'> & { componentPath?: string },
) {
const defaultOptions: Partial<IsConformantOptions<TProps>> = {
componentPath: module!.parent!.filename.replace('.test', ''),
componentPath: require.main?.filename.replace('.test', ''),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I would prefer to use require.main! as you expect that to be always set. The test should rather throw than run with componentPath: undefined if require.main is not set.

Copy link
Contributor Author

@Hotell Hotell Nov 8, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using ! is a red flag and antipattern ( also not recommended to use by TS team since optional chaining was ratified by ECMA ) . if componenPath will be undefined it will throw anyway

extraTests: griffelTests as TestObject<TProps>,
};

Expand Down
2 changes: 1 addition & 1 deletion packages/react-components/react-progress/src/common/isConformant.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ export function isConformant<TProps = {}>(
testInfo: Omit<IsConformantOptions<TProps>, 'componentPath'> & { componentPath?: string },
) {
const defaultOptions: Partial<IsConformantOptions<TProps>> = {
componentPath: module!.parent!.filename.replace('.test', ''),
componentPath: require.main?.filename.replace('.test', ''),
extraTests: griffelTests as TestObject<TProps>,
};

Expand Down
Loading