Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(react-slider): migrate to new package structure #25240

Merged
merged 2 commits into from
Oct 14, 2022

Conversation

TristanWatanabe
Copy link
Member

Changes:

Issue:

@TristanWatanabe TristanWatanabe self-assigned this Oct 14, 2022
@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
62.827 kB
17.599 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
189.375 kB
52.561 kB
react-components
react-components: FluentProvider & webLightTheme
33.446 kB
11.033 kB
react-portal-compat
PortalCompatProvider
5.857 kB
1.978 kB
react-slider
Slider
31.805 kB
10.085 kB
🤖 This report was generated against 61915ced2a350da17f8d1a1c520070796dc90d46

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 16d92f7:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Oct 14, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 61915ced2a350da17f8d1a1c520070796dc90d46 (build)

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1346 1340 5000
Button mount 962 947 5000
FluentProvider mount 1640 1604 5000
FluentProviderWithTheme mount 633 633 10
FluentProviderWithTheme virtual-rerender 582 592 10
FluentProviderWithTheme virtual-rerender-with-unmount 632 620 10
MakeStyles mount 1926 1900 50000
SpinButton mount 2550 2526 5000

@TristanWatanabe TristanWatanabe marked this pull request as ready for review October 14, 2022 15:54
@TristanWatanabe TristanWatanabe requested review from a team and micahgodbolt as code owners October 14, 2022 15:54
@TristanWatanabe TristanWatanabe merged commit 8b54aac into microsoft:master Oct 14, 2022
@TristanWatanabe TristanWatanabe deleted the migrate-slider branch October 14, 2022 19:07
NotWoods pushed a commit to NotWoods/fluentui that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants