Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(react-image): migrate to new package structure #25230

Merged
merged 3 commits into from
Oct 20, 2022

Conversation

TristanWatanabe
Copy link
Member

Changes:

Issue:

@TristanWatanabe TristanWatanabe self-assigned this Oct 14, 2022
@fabricteam
Copy link
Collaborator

fabricteam commented Oct 14, 2022

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
62.94 kB
17.663 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
189.603 kB
52.909 kB
react-components
react-components: FluentProvider & webLightTheme
33.446 kB
11.033 kB
react-image
Image
10.826 kB
4.286 kB
react-portal-compat
PortalCompatProvider
5.857 kB
1.978 kB
🤖 This report was generated against 3757c89720f0273ed00441f11104a000fe0edc52

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 14, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d1fcf8a:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Oct 14, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 3757c89720f0273ed00441f11104a000fe0edc52 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 14, 2022

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1288 1302 5000
Button mount 930 935 5000
FluentProvider mount 1509 1490 5000
FluentProviderWithTheme mount 582 579 10
FluentProviderWithTheme virtual-rerender 540 542 10
FluentProviderWithTheme virtual-rerender-with-unmount 586 569 10
MakeStyles mount 1961 1939 50000
SpinButton mount 2371 2355 5000

@TristanWatanabe TristanWatanabe marked this pull request as ready for review October 14, 2022 03:55
@TristanWatanabe TristanWatanabe requested a review from a team as a code owner October 14, 2022 03:55
@TristanWatanabe TristanWatanabe merged commit c483be0 into microsoft:master Oct 20, 2022
@TristanWatanabe TristanWatanabe deleted the migrate-image branch October 20, 2022 22:24
NotWoods pushed a commit to NotWoods/fluentui that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants