Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(react-card): migrate to new package structure #25229

Merged
merged 4 commits into from
Oct 18, 2022

Conversation

TristanWatanabe
Copy link
Member

Changes:

Issue:

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 07ea44f:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-card
Card - All
67.216 kB
19.304 kB
react-card
Card
62.898 kB
18.22 kB
react-card
CardFooter
8.607 kB
3.622 kB
react-card
CardHeader
9.65 kB
3.962 kB
react-card
CardPreview
8.708 kB
3.678 kB
react-components
react-components: Button, FluentProvider & webLightTheme
62.827 kB
17.599 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
189.375 kB
52.561 kB
react-components
react-components: FluentProvider & webLightTheme
33.446 kB
11.033 kB
react-portal-compat
PortalCompatProvider
5.857 kB
1.978 kB
🤖 This report was generated against 82650ef8b3d436c039e33f3eb8a658a3d878064f

@size-auditor
Copy link

size-auditor bot commented Oct 14, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 82650ef8b3d436c039e33f3eb8a658a3d878064f (build)

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1329 1326 5000
Button mount 947 956 5000
FluentProvider mount 1603 1580 5000
FluentProviderWithTheme mount 628 645 10
FluentProviderWithTheme virtual-rerender 588 594 10
FluentProviderWithTheme virtual-rerender-with-unmount 629 633 10
MakeStyles mount 1941 1933 50000
SpinButton mount 2565 2555 5000

@TristanWatanabe TristanWatanabe marked this pull request as ready for review October 14, 2022 03:24
@TristanWatanabe TristanWatanabe requested a review from a team as a code owner October 14, 2022 03:24
@TristanWatanabe TristanWatanabe merged commit ffad7cc into microsoft:master Oct 18, 2022
@TristanWatanabe TristanWatanabe deleted the migrate-card branch October 18, 2022 18:47
NotWoods pushed a commit to NotWoods/fluentui that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants