Adding contextmenu to the list of event the callout dismisses on #25051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asset size changes
Baseline commit: 0f198d87130e4f9fcacdaa187b850e507e0b1ec8 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d88a905:
|
📊 Bundle size reportUnchanged fixtures
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 953 | 931 | 5000 | |
| Breadcrumb | mount | 2167 | 2169 | 1000 | |
| Checkbox | mount | 2186 | 2198 | 5000 | |
| CheckboxBase | mount | 1943 | 1935 | 5000 | |
| ChoiceGroup | mount | 3680 | 3665 | 5000 | |
| ComboBox | mount | 934 | 950 | 1000 | |
| CommandBar | mount | 7895 | 7914 | 1000 | |
| ContextualMenu | mount | 13370 | 13728 | 1000 | |
| DefaultButton | mount | 1090 | 1085 | 5000 | |
| DetailsRow | mount | 2777 | 2761 | 5000 | |
| DetailsRowFast | mount | 2770 | 2794 | 5000 | |
| DetailsRowNoStyles | mount | 2574 | 2588 | 5000 | |
| Dialog | mount | 3145 | 3124 | 1000 | |
| DocumentCardTitle | mount | 417 | 424 | 1000 | |
| Dropdown | mount | 2593 | 2597 | 5000 | |
| FocusTrapZone | mount | 1575 | 1580 | 5000 | |
| FocusZone | mount | 1524 | 1534 | 5000 | |
| GroupedList | mount | 45665 | 52787 | 2 | |
| GroupedList | virtual-rerender | 22359 | 22539 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 63254 | 63014 | 2 | |
| GroupedListV2 | mount | 406 | 404 | 2 | |
| GroupedListV2 | virtual-rerender | 391 | 402 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 420 | 432 | 2 | |
| IconButton | mount | 1483 | 1480 | 5000 | |
| Label | mount | 558 | 561 | 5000 | |
| Layer | mount | 3483 | 3514 | 5000 | |
| Link | mount | 647 | 654 | 5000 | |
| MenuButton | mount | 1298 | 1310 | 5000 | |
| MessageBar | mount | 25996 | 26100 | 5000 | |
| Nav | mount | 2515 | 2499 | 1000 | |
| OverflowSet | mount | 1118 | 1132 | 5000 | |
| Panel | mount | 2095 | 2073 | 1000 | |
| Persona | mount | 1040 | 1053 | 1000 | |
| Pivot | mount | 1203 | 1197 | 1000 | |
| PrimaryButton | mount | 1198 | 1202 | 5000 | |
| Rating | mount | 5795 | 5778 | 5000 | |
| SearchBox | mount | 1208 | 1221 | 5000 | |
| Shimmer | mount | 2462 | 2413 | 5000 | |
| Slider | mount | 1722 | 1753 | 5000 | |
| SpinButton | mount | 3559 | 3582 | 5000 | |
| Spinner | mount | 636 | 640 | 5000 | |
| SplitButton | mount | 2391 | 2367 | 5000 | |
| Stack | mount | 663 | 660 | 5000 | |
| StackWithIntrinsicChildren | mount | 1209 | 1213 | 5000 | |
| StackWithTextChildren | mount | 3528 | 3559 | 5000 | |
| SwatchColorPicker | mount | 8406 | 7591 | 5000 | |
| TagPicker | mount | 1884 | 1881 | 5000 | |
| Text | mount | 629 | 634 | 5000 | |
| TextField | mount | 1249 | 1244 | 5000 | |
| ThemeProvider | mount | 1110 | 1116 | 5000 | |
| ThemeProvider | virtual-rerender | 910 | 917 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1639 | 1664 | 5000 | |
| Toggle | mount | 892 | 901 | 5000 | |
| buttonNative | mount | 373 | 366 | 5000 |
|
Change file is missing in the PR. Please run |
GeoffCoxMSFT
requested changes
Oct 17, 2022
|
This pull request has been automatically marked as stale because it was marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 5 days of this comment. Thank you for your contributions to Fluent UI! |
cocoyadoOlivares
force-pushed
the
master
branch
from
f3f35e5 to
f9436f5
Compare
added 4 commits
October 24, 2022 15:48
|
Apologies, RE Opening , bundling Tests are failing But I think is because they are configured for Unix paths and not windows ? |
|
Hey I Tried to Open contextMenu after rendering callout, it does not seem to trigger an event, what did you meant exactly ? |
GeoffCoxMSFT
approved these changes
Mar 20, 2023
🕵 fluentuiv8 No visual regressions between this PR and main |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 904 | 928 | 5000 | |
| Button | mount | 587 | 563 | 5000 | |
| Field | mount | 1686 | 1588 | 5000 | |
| FluentProvider | mount | 1192 | 1188 | 5000 | |
| FluentProviderWithTheme | mount | 299 | 313 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 279 | 278 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 297 | 284 | 10 | |
| InfoButton | mount | 201 | 213 | 5000 | |
| MakeStyles | mount | 1299 | 1303 | 50000 | |
| Persona | mount | 2321 | 2239 | 5000 | |
| SpinButton | mount | 1994 | 1991 | 5000 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Callout does not dismiss on right click
New Behavior
Callout now dismisses on right click
Related Issue(s)
Fixes #25046