Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrate react-table to use new build #24970

Merged
merged 2 commits into from
Sep 28, 2022

Conversation

ling1726
Copy link
Member

@ling1726 ling1726 commented Sep 27, 2022

Migrates the react-table package to use the new build experience introduced in #23369

Migrates the react-avatar package to use the new build experience introduced in microsoft#23369
@ling1726 ling1726 enabled auto-merge (squash) September 27, 2022 16:23
@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
188.681 kB
52.366 kB
react-components
react-components: FluentProvider & webLightTheme
33.394 kB
11.007 kB
react-portal-compat
PortalCompatProvider
5.851 kB
1.964 kB
🤖 This report was generated against d4e63670b2df10d81954275eb3479c279787ac06

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2211252:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Sep 27, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: d4e63670b2df10d81954275eb3479c279787ac06 (build)

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1620 1657 5000
Button mount 1154 1148 5000
FluentProvider mount 1901 1889 5000
FluentProviderWithTheme mount 730 717 10
FluentProviderWithTheme virtual-rerender 668 663 10
FluentProviderWithTheme virtual-rerender-with-unmount 715 695 10
MakeStyles mount 2238 2249 50000
SpinButton mount 3330 3180 5000

@ling1726 ling1726 merged commit cd88ecf into microsoft:master Sep 28, 2022
NotWoods pushed a commit to NotWoods/fluentui that referenced this pull request Nov 18, 2022
* chore: Migrate react-table to use new build

Migrates the react-avatar package to use the new build experience introduced in microsoft#23369

* changefile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants