Hoist more react-related deps to root #22438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5b82d35:
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1090 | 1109 | 5000 | |
| Button | mount | 667 | 668 | 5000 | |
| FluentProvider | mount | 2208 | 2176 | 5000 | |
| FluentProviderWithTheme | mount | 325 | 297 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 255 | 259 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 351 | 338 | 10 | |
| MakeStyles | mount | 1933 | 1845 | 50000 |
📊 Bundle size reportUnchanged fixtures
|
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| DividerMinimalPerf.default | 300 | 275 | 1.09:1 |
| FormMinimalPerf.default | 341 | 315 | 1.08:1 |
| AttachmentMinimalPerf.default | 128 | 120 | 1.07:1 |
| DropdownManyItemsPerf.default | 576 | 541 | 1.06:1 |
| SegmentMinimalPerf.default | 296 | 280 | 1.06:1 |
| AttachmentSlotsPerf.default | 911 | 867 | 1.05:1 |
| ChatDuplicateMessagesPerf.default | 248 | 236 | 1.05:1 |
| RadioGroupMinimalPerf.default | 377 | 360 | 1.05:1 |
| TextMinimalPerf.default | 286 | 272 | 1.05:1 |
| ChatWithPopoverPerf.default | 317 | 306 | 1.04:1 |
| GridMinimalPerf.default | 279 | 269 | 1.04:1 |
| HeaderMinimalPerf.default | 300 | 289 | 1.04:1 |
| RosterPerf.default | 950 | 914 | 1.04:1 |
| ReactionMinimalPerf.default | 313 | 301 | 1.04:1 |
| TreeMinimalPerf.default | 680 | 657 | 1.04:1 |
| TreeWith60ListItems.default | 144 | 138 | 1.04:1 |
| ButtonMinimalPerf.default | 137 | 133 | 1.03:1 |
| ButtonSlotsPerf.default | 453 | 439 | 1.03:1 |
| FlexMinimalPerf.default | 240 | 232 | 1.03:1 |
| ListWith60ListItems.default | 559 | 541 | 1.03:1 |
| ProviderMinimalPerf.default | 334 | 325 | 1.03:1 |
| SkeletonMinimalPerf.default | 286 | 277 | 1.03:1 |
| IconMinimalPerf.default | 533 | 516 | 1.03:1 |
| ToolbarMinimalPerf.default | 804 | 784 | 1.03:1 |
| BoxMinimalPerf.default | 281 | 276 | 1.02:1 |
| CarouselMinimalPerf.default | 392 | 385 | 1.02:1 |
| DialogMinimalPerf.default | 640 | 630 | 1.02:1 |
| ImageMinimalPerf.default | 312 | 305 | 1.02:1 |
| ListMinimalPerf.default | 424 | 416 | 1.02:1 |
| MenuButtonMinimalPerf.default | 1414 | 1384 | 1.02:1 |
| AvatarMinimalPerf.default | 154 | 153 | 1.01:1 |
| DropdownMinimalPerf.default | 2557 | 2535 | 1.01:1 |
| HeaderSlotsPerf.default | 626 | 617 | 1.01:1 |
| InputMinimalPerf.default | 1093 | 1085 | 1.01:1 |
| ItemLayoutMinimalPerf.default | 982 | 975 | 1.01:1 |
| LayoutMinimalPerf.default | 291 | 289 | 1.01:1 |
| ListCommonPerf.default | 517 | 511 | 1.01:1 |
| LoaderMinimalPerf.default | 574 | 566 | 1.01:1 |
| RefMinimalPerf.default | 196 | 195 | 1.01:1 |
| SliderMinimalPerf.default | 1425 | 1405 | 1.01:1 |
| SplitButtonMinimalPerf.default | 3666 | 3625 | 1.01:1 |
| TableMinimalPerf.default | 328 | 326 | 1.01:1 |
| TextAreaMinimalPerf.default | 400 | 398 | 1.01:1 |
| ButtonOverridesMissPerf.default | 1238 | 1237 | 1:1 |
| CardMinimalPerf.default | 453 | 452 | 1:1 |
| ChatMinimalPerf.default | 612 | 610 | 1:1 |
| CheckboxMinimalPerf.default | 2266 | 2255 | 1:1 |
| DatepickerMinimalPerf.default | 4771 | 4769 | 1:1 |
| EmbedMinimalPerf.default | 3464 | 3451 | 1:1 |
| ListNestedPerf.default | 463 | 463 | 1:1 |
| PopupMinimalPerf.default | 514 | 514 | 1:1 |
| TableManyItemsPerf.default | 1587 | 1586 | 1:1 |
| MenuMinimalPerf.default | 699 | 707 | 0.99:1 |
| PortalMinimalPerf.default | 139 | 141 | 0.99:1 |
| StatusMinimalPerf.default | 551 | 555 | 0.99:1 |
| CustomToolbarPrototype.default | 2246 | 2276 | 0.99:1 |
| TooltipMinimalPerf.default | 883 | 894 | 0.99:1 |
| AlertMinimalPerf.default | 216 | 221 | 0.98:1 |
| AnimationMinimalPerf.default | 445 | 454 | 0.98:1 |
| LabelMinimalPerf.default | 311 | 316 | 0.98:1 |
| ProviderMergeThemesPerf.default | 1048 | 1064 | 0.98:1 |
| VideoMinimalPerf.default | 509 | 520 | 0.98:1 |
| AccordionMinimalPerf.default | 118 | 124 | 0.95:1 |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 944 | 1023 | 5000 | |
| Breadcrumb | mount | 2887 | 2906 | 1000 | |
| Checkbox | mount | 1568 | 1618 | 5000 | |
| CheckboxBase | mount | 1438 | 1438 | 5000 | |
| ChoiceGroup | mount | 5043 | 5070 | 5000 | |
| ComboBox | mount | 1044 | 1057 | 1000 | |
| CommandBar | mount | 11385 | 11144 | 1000 | |
| ContextualMenu | mount | 12904 | 12111 | 1000 | |
| DefaultButton | mount | 1242 | 1238 | 5000 | |
| DetailsRow | mount | 4144 | 4147 | 5000 | |
| DetailsRowFast | mount | 4079 | 4082 | 5000 | |
| DetailsRowNoStyles | mount | 3879 | 3846 | 5000 | |
| Dialog | mount | 2298 | 2392 | 1000 | |
| DocumentCardTitle | mount | 174 | 179 | 1000 | |
| Dropdown | mount | 3456 | 3508 | 5000 | |
| FocusTrapZone | mount | 1988 | 1953 | 5000 | |
| FocusZone | mount | 1935 | 2000 | 5000 | |
| IconButton | mount | 1839 | 1935 | 5000 | |
| Label | mount | 358 | 357 | 5000 | |
| Layer | mount | 3135 | 3150 | 5000 | |
| Link | mount | 517 | 508 | 5000 | |
| MenuButton | mount | 1633 | 1577 | 5000 | |
| MessageBar | mount | 2269 | 2399 | 5000 | |
| Nav | mount | 3500 | 3670 | 1000 | |
| OverflowSet | mount | 1215 | 1226 | 5000 | |
| Panel | mount | 2268 | 2270 | 1000 | |
| Persona | mount | 1049 | 1150 | 1000 | |
| Pivot | mount | 1609 | 1565 | 1000 | |
| PrimaryButton | mount | 1352 | 1403 | 5000 | |
| Rating | mount | 8215 | 8088 | 5000 | |
| SearchBox | mount | 1454 | 1398 | 5000 | |
| Shimmer | mount | 2637 | 2730 | 5000 | |
| Slider | mount | 2083 | 2086 | 5000 | |
| SpinButton | mount | 5415 | 5475 | 5000 | |
| Spinner | mount | 471 | 459 | 5000 | |
| SplitButton | mount | 3543 | 3480 | 5000 | |
| Stack | mount | 545 | 579 | 5000 | |
| StackWithIntrinsicChildren | mount | 2507 | 2479 | 5000 | |
| StackWithTextChildren | mount | 5769 | 5670 | 5000 | |
| SwatchColorPicker | mount | 12626 | 12675 | 5000 | |
| TagPicker | mount | 2862 | 2991 | 5000 | |
| TeachingBubble | mount | 100413 | 100076 | 5000 | |
| Text | mount | 468 | 479 | 5000 | |
| TextField | mount | 1521 | 1536 | 5000 | |
| ThemeProvider | mount | 1276 | 1234 | 5000 | |
| ThemeProvider | virtual-rerender | 693 | 697 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1942 | 1974 | 5000 | |
| Toggle | mount | 871 | 881 | 5000 | |
| buttonNative | mount | 140 | 144 | 5000 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 72fa867ab6b084656b53c8f644df74b31077ae15 (build) |
layershifter
approved these changes
Apr 11, 2022
Hotell
requested changes
Apr 11, 2022
| @@ -42,8 +42,6 @@ | |||
| "@fluentui/theme-samples": "^8.4.17", | |||
| "@fluentui/react-monaco-editor": "^1.3.17", | |||
| "office-ui-fabric-core": "^11.0.0", | |||
| "react": "16.14.0", | |||
There was a problem hiding this comment.
this is incorrect. dependencies should remain for the time being in place as is for both libraries and applications.
For libraries it's self explanatory - consumers install library and needs all dependencies
For apps - imagine this would need to be run within docker container or similar
There was a problem hiding this comment.
It's kind of debatable for unpublished apps, which currently in our context work in one of two ways:
- Only intended to run within the repo
- Intended to be bundled and uploaded to a CDN or other host in a way that makes dependencies irrelevant (React and all other deps are included in the website bundles and any storybook-based bundles)
I'm not sure the docker container type scenario matters here since they're never actually run that way, and would pretty thoroughly not work already due to single version policy with dev deps + private scripts package.
Regardless, I'll revert this and let you figure it out later.
msft-fluent-ui-bot
added
Needs: Author Feedback
and removed
Needs: Author Feedback
labels
ecraig12345
force-pushed
the
hoist-more-react-deps
branch
from
ece793e to
5b82d35
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Hotell
approved these changes
Apr 12, 2022
ling1726
approved these changes
Apr 13, 2022
sopranopillow
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling out parts of React 17 upgrade (#22326) that can be merged now.
Hoist
devDependenciesonreact-isand@types/react-isto the root (and one for@types/react-domwhich was missed earlier).This will simplify the actual React 17 upgrade.