Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Announced (v8): convert tests to use testing-library #22210

Conversation

TristanWatanabe
Copy link
Member

Current Behavior

  • v8 Announced tests don't use testing-library

New Behavior

  • Convert Announced to fully use testing-library

Related Issue(s)

part of #21663

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 25, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit aef875f:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Mar 25, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: f10cc045484b962652a400ef2ef4f3412c8d168b (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Mar 25, 2022

📊 Bundle size report

🤖 This report was generated against f10cc045484b962652a400ef2ef4f3412c8d168b

@fabricteam
Copy link
Collaborator

fabricteam commented Mar 25, 2022

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 727 784 5000
Breadcrumb mount 2034 2048 1000
Checkbox mount 1167 1265 5000
CheckboxBase mount 1113 959 5000
ChoiceGroup mount 3832 3701 5000
ComboBox mount 743 784 1000
CommandBar mount 8376 8135 1000
ContextualMenu mount 9553 9975 1000
DefaultButton mount 879 878 5000
DetailsRow mount 2920 3182 5000
DetailsRowFast mount 3042 3130 5000
DetailsRowNoStyles mount 2897 2946 5000
Dialog mount 1844 1855 1000
DocumentCardTitle mount 118 153 1000
Dropdown mount 2744 2538 5000
FocusTrapZone mount 1436 1556 5000
FocusZone mount 1465 1440 5000
IconButton mount 1418 1507 5000
Label mount 300 255 5000
Layer mount 2480 2309 5000
Link mount 351 405 5000
MenuButton mount 1193 1120 5000
MessageBar mount 1708 1630 5000
Nav mount 2636 2594 1000
OverflowSet mount 872 917 5000
Panel mount 1708 1738 1000
Persona mount 633 678 1000
Pivot mount 1181 1160 1000
PrimaryButton mount 1002 1083 5000
Rating mount 6554 6302 5000
SearchBox mount 1019 1063 5000
Shimmer mount 1923 2137 5000
Slider mount 1561 1595 5000
SpinButton mount 3961 3946 5000
Spinner mount 323 358 5000
SplitButton mount 2484 2666 5000
Stack mount 390 395 5000
StackWithIntrinsicChildren mount 1862 1844 5000
StackWithTextChildren mount 4050 4289 5000
SwatchColorPicker mount 9137 9523 5000
TagPicker mount 2303 2159 5000
TeachingBubble mount 84532 48175 5000
Text mount 325 357 5000
TextField mount 1191 1054 5000
ThemeProvider mount 963 884 5000
ThemeProvider virtual-rerender 501 514 5000
ThemeProvider virtual-rerender-with-unmount 1439 1441 5000
Toggle mount 597 635 5000
buttonNative mount 100 101 5000

@TristanWatanabe TristanWatanabe marked this pull request as ready for review March 25, 2022 15:05
@TristanWatanabe TristanWatanabe requested review from a team and khmakoto as code owners March 25, 2022 15:05
@TristanWatanabe TristanWatanabe merged commit d88aa37 into microsoft:master Mar 28, 2022
@TristanWatanabe TristanWatanabe deleted the announced-convert-to-testing-library branch March 28, 2022 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants