-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/react conformance version #22119
Fix/react conformance version #22119
Conversation
released and bumped, it broke master because there was duplicate packages.
This reverts commit 5f09b90.
📊 Bundle size reportUnchanged fixtures
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9021a1c:
|
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 1327 | 1374 | 5000 | |
Button | mount | 813 | 773 | 5000 | |
FluentProvider | mount | 2254 | 2264 | 5000 | |
FluentProviderWithTheme | mount | 397 | 393 | 10 | |
FluentProviderWithTheme | virtual-rerender | 359 | 352 | 10 | |
FluentProviderWithTheme | virtual-rerender-with-unmount | 410 | 456 | 10 | |
MakeStyles | mount | 2000 | 1997 | 50000 |
Asset size changesUnable to find bundle size details for Baseline commit: 559eea5 Possible causes
Recommendations
|
@@ -30,7 +30,7 @@ | |||
"typescript": "^4.3.0" | |||
}, | |||
"dependencies": { | |||
"@fluentui/react-conformance": "^0.11.0", | |||
"@fluentui/react-conformance": "*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not a very good idea. can you revert to proper version as this is a direct dependency
#21924
released and bumped, it broke master because there was duplicate
packages.