Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/react conformance version #22119

Merged
merged 5 commits into from
Mar 16, 2022

Conversation

ling1726
Copy link
Member

@ling1726 ling1726 commented Mar 16, 2022

#21924

released and bumped, it broke master because there was duplicate
packages.

released and bumped, it broke master because there was duplicate
packages.
This reverts commit 5f09b90.
@ling1726 ling1726 marked this pull request as ready for review March 16, 2022 08:39
@ling1726 ling1726 requested a review from a team as a code owner March 16, 2022 08:39
@ling1726 ling1726 enabled auto-merge (squash) March 16, 2022 08:43
@fabricteam
Copy link
Collaborator

fabricteam commented Mar 16, 2022

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-accordion
Accordion (including children components)
74.792 kB
22.516 kB
react-avatar
Avatar
45.18 kB
13.128 kB
react-badge
Badge
20.895 kB
6.567 kB
react-badge
CounterBadge
21.848 kB
6.883 kB
react-badge
PresenceBadge
21.951 kB
6.565 kB
react-button
Button
28.013 kB
8.059 kB
react-button
CompoundButton
33.508 kB
9.092 kB
react-button
MenuButton
29.796 kB
8.665 kB
react-button
SplitButton
36.268 kB
9.863 kB
react-button
ToggleButton
37.395 kB
8.68 kB
react-card
Card - All
53.619 kB
15.372 kB
react-card
Card
48.904 kB
14.089 kB
react-card
CardFooter
7.686 kB
3.264 kB
react-card
CardHeader
9.251 kB
3.78 kB
react-card
CardPreview
7.658 kB
3.291 kB
react-combobox
Combobox
6.817 kB
2.901 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
176.084 kB
49.112 kB
react-components
react-components: FluentProvider & webLightTheme
32.526 kB
10.645 kB
react-divider
Divider
15.385 kB
5.539 kB
react-image
Image
10.109 kB
3.958 kB
react-input
Input
21.635 kB
7.166 kB
react-label
Label
8.371 kB
3.504 kB
react-link
Link
11.106 kB
4.507 kB
react-menu
Menu (including children components)
105.847 kB
32.431 kB
react-menu
Menu (including selectable components)
109.026 kB
32.895 kB
react-popover
Popover
96.782 kB
29.558 kB
react-provider
FluentProvider
14.009 kB
5.25 kB
react-select
Select
7.853 kB
3.297 kB
react-slider
Slider
25.402 kB
8.251 kB
react-spinner
Spinner
6.815 kB
2.9 kB
react-switch
Switch
24.279 kB
8.001 kB
react-text
Text - Default
10.797 kB
4.233 kB
react-text
Text - Wrappers
14.113 kB
4.576 kB
react-tooltip
Tooltip
42.789 kB
14.712 kB
🤖 This report was generated against 559eea51dbae189b4f2f198b0c6dd657d5d2cb61

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9021a1c:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1327 1374 5000
Button mount 813 773 5000
FluentProvider mount 2254 2264 5000
FluentProviderWithTheme mount 397 393 10
FluentProviderWithTheme virtual-rerender 359 352 10
FluentProviderWithTheme virtual-rerender-with-unmount 410 456 10
MakeStyles mount 2000 1997 50000

@size-auditor
Copy link

size-auditor bot commented Mar 16, 2022

Asset size changes

⚠️ Insufficient baseline data to detect size changes

Unable to find bundle size details for Baseline commit: 559eea5

Possible causes

  • The baseline build 559eea5 is broken
  • The Size Auditor run for the baseline build 559eea5 was not triggered

Recommendations

  • Please merge your branch for this Pull request with the latest master build and commit your changes once again

@ling1726 ling1726 merged commit df62b07 into microsoft:master Mar 16, 2022
@@ -30,7 +30,7 @@
"typescript": "^4.3.0"
},
"dependencies": {
"@fluentui/react-conformance": "^0.11.0",
"@fluentui/react-conformance": "*",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not a very good idea. can you revert to proper version as this is a direct dependency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants