-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Migrate package @fluentui/react-storybook-addon #20797
chore: Migrate package @fluentui/react-storybook-addon #20797
Conversation
📊 Bundle size report🤖 This report was generated against ec0e785df9c70a2202dc5cc3cb4001d1ee635124 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 3ca42a594827a2ce3d5d18fcd4a399c92fda3bd7 (build) |
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 965 | 965 | 5000 | |
BaseButton | mount | 992 | 991 | 5000 | |
Breadcrumb | mount | 2639 | 2655 | 1000 | |
ButtonNext | mount | 606 | 602 | 5000 | |
Checkbox | mount | 1592 | 1589 | 5000 | |
CheckboxBase | mount | 1350 | 1326 | 5000 | |
ChoiceGroup | mount | 4714 | 4664 | 5000 | |
ComboBox | mount | 1087 | 1051 | 1000 | |
CommandBar | mount | 9822 | 9872 | 1000 | |
ContextualMenu | mount | 15540 | 15561 | 1000 | |
DefaultButton | mount | 1191 | 1252 | 5000 | |
DetailsRow | mount | 3775 | 3720 | 5000 | |
DetailsRowFast | mount | 3749 | 3702 | 5000 | |
DetailsRowNoStyles | mount | 3495 | 3527 | 5000 | |
Dialog | mount | 2572 | 2646 | 1000 | |
DocumentCardTitle | mount | 271 | 241 | 1000 | |
Dropdown | mount | 3153 | 3157 | 5000 | |
FluentProviderNext | mount | 4088 | 4102 | 5000 | |
FluentProviderWithTheme | mount | 347 | 316 | 10 | |
FluentProviderWithTheme | virtual-rerender | 186 | 200 | 10 | |
FluentProviderWithTheme | virtual-rerender-with-unmount | 375 | 372 | 10 | |
FocusTrapZone | mount | 1842 | 1808 | 5000 | |
FocusZone | mount | 1868 | 1842 | 5000 | |
IconButton | mount | 1766 | 1848 | 5000 | |
Label | mount | 454 | 447 | 5000 | |
Layer | mount | 2920 | 2953 | 5000 | |
Link | mount | 570 | 578 | 5000 | |
MakeStyles | mount | 1845 | 1832 | 50000 | |
MenuButton | mount | 1508 | 1527 | 5000 | |
MessageBar | mount | 2006 | 2001 | 5000 | |
Nav | mount | 3204 | 3262 | 1000 | |
OverflowSet | mount | 1176 | 1177 | 5000 | |
Panel | mount | 2482 | 2476 | 1000 | |
Persona | mount | 902 | 932 | 1000 | |
Pivot | mount | 1490 | 1471 | 1000 | |
PrimaryButton | mount | 1347 | 1347 | 5000 | |
Rating | mount | 7330 | 7449 | 5000 | |
SearchBox | mount | 1394 | 1434 | 5000 | |
Shimmer | mount | 2481 | 2565 | 5000 | |
Slider | mount | 1966 | 1982 | 5000 | |
SpinButton | mount | 5035 | 4905 | 5000 | |
Spinner | mount | 533 | 517 | 5000 | |
SplitButton | mount | 3162 | 3156 | 5000 | |
Stack | mount | 589 | 590 | 5000 | |
StackWithIntrinsicChildren | mount | 1796 | 1705 | 5000 | |
StackWithTextChildren | mount | 4660 | 4705 | 5000 | |
SwatchColorPicker | mount | 10155 | 10198 | 5000 | |
TagPicker | mount | 2628 | 2600 | 5000 | |
TeachingBubble | mount | 12694 | 12756 | 5000 | |
Text | mount | 519 | 517 | 5000 | |
TextField | mount | 1418 | 1421 | 5000 | |
ThemeProvider | mount | 1226 | 1239 | 5000 | |
ThemeProvider | virtual-rerender | 700 | 705 | 5000 | |
ThemeProvider | virtual-rerender-with-unmount | 1941 | 1911 | 5000 | |
Toggle | mount | 890 | 927 | 5000 | |
buttonNative | mount | 239 | 224 | 5000 |
Perf Analysis (@fluentui/react-northstar
)
Perf tests with no regressions
Scenario | Current PR Ticks | Baseline Ticks | Ratio |
---|---|---|---|
AttachmentMinimalPerf.default | 160 | 141 | 1.13:1 |
DividerMinimalPerf.default | 352 | 333 | 1.06:1 |
IconMinimalPerf.default | 600 | 564 | 1.06:1 |
ButtonMinimalPerf.default | 171 | 163 | 1.05:1 |
FormMinimalPerf.default | 389 | 370 | 1.05:1 |
GridMinimalPerf.default | 322 | 308 | 1.05:1 |
CarouselMinimalPerf.default | 454 | 438 | 1.04:1 |
ListCommonPerf.default | 602 | 580 | 1.04:1 |
ListMinimalPerf.default | 500 | 482 | 1.04:1 |
ListWith60ListItems.default | 613 | 587 | 1.04:1 |
TextMinimalPerf.default | 334 | 321 | 1.04:1 |
TreeWith60ListItems.default | 173 | 166 | 1.04:1 |
AnimationMinimalPerf.default | 400 | 390 | 1.03:1 |
AttachmentSlotsPerf.default | 1035 | 1007 | 1.03:1 |
ChatMinimalPerf.default | 626 | 610 | 1.03:1 |
FlexMinimalPerf.default | 277 | 269 | 1.03:1 |
ImageMinimalPerf.default | 345 | 336 | 1.03:1 |
RadioGroupMinimalPerf.default | 420 | 409 | 1.03:1 |
TooltipMinimalPerf.default | 987 | 959 | 1.03:1 |
BoxMinimalPerf.default | 332 | 327 | 1.02:1 |
ButtonSlotsPerf.default | 545 | 534 | 1.02:1 |
DialogMinimalPerf.default | 722 | 709 | 1.02:1 |
ItemLayoutMinimalPerf.default | 1139 | 1121 | 1.02:1 |
MenuMinimalPerf.default | 809 | 793 | 1.02:1 |
RefMinimalPerf.default | 231 | 227 | 1.02:1 |
SegmentMinimalPerf.default | 331 | 324 | 1.02:1 |
StatusMinimalPerf.default | 641 | 630 | 1.02:1 |
VideoMinimalPerf.default | 591 | 581 | 1.02:1 |
AvatarMinimalPerf.default | 188 | 186 | 1.01:1 |
LabelMinimalPerf.default | 362 | 358 | 1.01:1 |
ListNestedPerf.default | 520 | 515 | 1.01:1 |
MenuButtonMinimalPerf.default | 1555 | 1537 | 1.01:1 |
RosterPerf.default | 1136 | 1128 | 1.01:1 |
PopupMinimalPerf.default | 564 | 558 | 1.01:1 |
SliderMinimalPerf.default | 1584 | 1568 | 1.01:1 |
SplitButtonMinimalPerf.default | 4040 | 3993 | 1.01:1 |
TableManyItemsPerf.default | 1795 | 1769 | 1.01:1 |
CustomToolbarPrototype.default | 3884 | 3862 | 1.01:1 |
TreeMinimalPerf.default | 759 | 751 | 1.01:1 |
CardMinimalPerf.default | 524 | 522 | 1:1 |
ChatWithPopoverPerf.default | 353 | 352 | 1:1 |
DatepickerMinimalPerf.default | 5139 | 5164 | 1:1 |
DropdownMinimalPerf.default | 2853 | 2867 | 1:1 |
EmbedMinimalPerf.default | 3916 | 3931 | 1:1 |
HeaderMinimalPerf.default | 336 | 336 | 1:1 |
InputMinimalPerf.default | 1227 | 1230 | 1:1 |
LoaderMinimalPerf.default | 650 | 651 | 1:1 |
ProviderMergeThemesPerf.default | 1621 | 1628 | 1:1 |
ProviderMinimalPerf.default | 1039 | 1034 | 1:1 |
ReactionMinimalPerf.default | 349 | 349 | 1:1 |
ToolbarMinimalPerf.default | 902 | 900 | 1:1 |
ChatDuplicateMessagesPerf.default | 282 | 284 | 0.99:1 |
CheckboxMinimalPerf.default | 2538 | 2559 | 0.99:1 |
DropdownManyItemsPerf.default | 627 | 636 | 0.99:1 |
HeaderSlotsPerf.default | 703 | 707 | 0.99:1 |
LayoutMinimalPerf.default | 344 | 346 | 0.99:1 |
SkeletonMinimalPerf.default | 326 | 330 | 0.99:1 |
TextAreaMinimalPerf.default | 470 | 474 | 0.99:1 |
ButtonOverridesMissPerf.default | 1590 | 1621 | 0.98:1 |
PortalMinimalPerf.default | 165 | 168 | 0.98:1 |
TableMinimalPerf.default | 378 | 387 | 0.98:1 |
AccordionMinimalPerf.default | 148 | 153 | 0.97:1 |
AlertMinimalPerf.default | 247 | 273 | 0.9:1 |
Co-authored-by: Martin Hochel <[email protected]>
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e5f05e3:
|
* Export ThemeIds as a type Co-authored-by: Martin Hochel <[email protected]>
Pull request checklist
Include a change request file using$ yarn change
Description of changes
Ran
migrate-converged-pkg
for the@fluentui/react-storybook-addon
package.