Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrate package @fluentui/react-storybook #20787

Merged
merged 1 commit into from
Nov 25, 2021
Merged

chore: Migrate package @fluentui/react-storybook #20787

merged 1 commit into from
Nov 25, 2021

Conversation

andrefcdias
Copy link
Contributor

Pull request checklist

Description of changes

Ran migrate-converged-pkg.

@fabricteam
Copy link
Collaborator

📊 Bundle size report

🤖 This report was generated against ef4491a62061313d0aa1ad3f4eafd18745d536dc

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2561aae:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Nov 25, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: ef4491a62061313d0aa1ad3f4eafd18745d536dc (build)

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1055 1064 5000
BaseButton mount 1056 1056 5000
Breadcrumb mount 2814 2772 1000
ButtonNext mount 654 629 5000
Checkbox mount 1712 1682 5000
CheckboxBase mount 1457 1416 5000
ChoiceGroup mount 4977 5016 5000
ComboBox mount 1111 1106 1000
CommandBar mount 10762 10551 1000
ContextualMenu mount 8912 8612 1000
DefaultButton mount 1273 1283 5000
DetailsRow mount 4013 3961 5000
DetailsRowFast mount 3996 4043 5000
DetailsRowNoStyles mount 3918 3888 5000
Dialog mount 2767 2779 1000
DocumentCardTitle mount 289 297 1000
Dropdown mount 3414 3364 5000
FluentProviderNext mount 4376 4371 5000
FluentProviderWithTheme mount 361 351 10
FluentProviderWithTheme virtual-rerender 240 218 10
FluentProviderWithTheme virtual-rerender-with-unmount 430 389 10
FocusTrapZone mount 1994 1981 5000
FocusZone mount 2000 1994 5000
IconButton mount 1858 1909 5000
Label mount 511 494 5000
Layer mount 3149 3086 5000
Link mount 639 585 5000
MakeStyles mount 1964 2007 50000
MenuButton mount 1645 1617 5000
MessageBar mount 2142 2097 5000
Nav mount 3447 3494 1000
OverflowSet mount 1270 1252 5000
Panel mount 2760 2734 1000
Persona mount 987 1023 1000
Pivot mount 1706 1568 1000
PrimaryButton mount 1496 1505 5000
Rating mount 7860 8053 5000
SearchBox mount 1496 1579 5000
Shimmer mount 2670 2733 5000
Slider mount 2151 2180 5000
SpinButton mount 5249 5354 5000
Spinner mount 562 549 5000
SplitButton mount 3386 3356 5000
Stack mount 633 644 5000
StackWithIntrinsicChildren mount 1842 1829 5000
StackWithTextChildren mount 4880 4810 5000
SwatchColorPicker mount 10798 10880 5000
TagPicker mount 2802 2817 5000
TeachingBubble mount 13432 13532 5000
Text mount 534 573 5000
TextField mount 1539 1516 5000
ThemeProvider mount 1317 1385 5000
ThemeProvider virtual-rerender 738 735 5000
ThemeProvider virtual-rerender-with-unmount 2095 1996 5000
Toggle mount 942 957 5000
buttonNative mount 256 250 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ButtonMinimalPerf.default 201 168 1.2:1
AttachmentMinimalPerf.default 170 149 1.14:1
AvatarMinimalPerf.default 215 194 1.11:1
FlexMinimalPerf.default 320 288 1.11:1
HeaderSlotsPerf.default 807 739 1.09:1
ListMinimalPerf.default 572 526 1.09:1
RefMinimalPerf.default 249 231 1.08:1
TreeMinimalPerf.default 848 786 1.08:1
BoxMinimalPerf.default 362 339 1.07:1
FormMinimalPerf.default 421 392 1.07:1
LayoutMinimalPerf.default 383 361 1.06:1
ReactionMinimalPerf.default 398 374 1.06:1
IconMinimalPerf.default 614 580 1.06:1
PortalMinimalPerf.default 196 186 1.05:1
AttachmentSlotsPerf.default 1100 1061 1.04:1
DividerMinimalPerf.default 385 371 1.04:1
StatusMinimalPerf.default 679 656 1.04:1
TextMinimalPerf.default 358 343 1.04:1
CardMinimalPerf.default 566 551 1.03:1
DialogMinimalPerf.default 797 772 1.03:1
GridMinimalPerf.default 353 344 1.03:1
ItemLayoutMinimalPerf.default 1240 1201 1.03:1
LabelMinimalPerf.default 386 375 1.03:1
SkeletonMinimalPerf.default 361 352 1.03:1
AccordionMinimalPerf.default 158 155 1.02:1
AlertMinimalPerf.default 295 289 1.02:1
ButtonSlotsPerf.default 562 553 1.02:1
CarouselMinimalPerf.default 502 490 1.02:1
DropdownManyItemsPerf.default 706 689 1.02:1
DropdownMinimalPerf.default 3097 3032 1.02:1
EmbedMinimalPerf.default 4253 4166 1.02:1
ChatMinimalPerf.default 682 673 1.01:1
CheckboxMinimalPerf.default 2748 2730 1.01:1
ImageMinimalPerf.default 373 371 1.01:1
ListWith60ListItems.default 658 650 1.01:1
MenuMinimalPerf.default 859 853 1.01:1
SegmentMinimalPerf.default 344 339 1.01:1
SliderMinimalPerf.default 1720 1704 1.01:1
SplitButtonMinimalPerf.default 4258 4231 1.01:1
ToolbarMinimalPerf.default 935 929 1.01:1
TooltipMinimalPerf.default 1028 1019 1.01:1
ChatWithPopoverPerf.default 388 389 1:1
ListCommonPerf.default 643 640 1:1
LoaderMinimalPerf.default 693 694 1:1
MenuButtonMinimalPerf.default 1663 1668 1:1
RadioGroupMinimalPerf.default 448 450 1:1
TableManyItemsPerf.default 1870 1872 1:1
CustomToolbarPrototype.default 4088 4088 1:1
DatepickerMinimalPerf.default 5679 5748 0.99:1
InputMinimalPerf.default 1314 1326 0.99:1
ListNestedPerf.default 558 566 0.99:1
ProviderMergeThemesPerf.default 1740 1752 0.99:1
ProviderMinimalPerf.default 1139 1150 0.99:1
TableMinimalPerf.default 414 420 0.99:1
ButtonOverridesMissPerf.default 1681 1712 0.98:1
ChatDuplicateMessagesPerf.default 291 297 0.98:1
RosterPerf.default 1209 1237 0.98:1
PopupMinimalPerf.default 598 609 0.98:1
VideoMinimalPerf.default 645 658 0.98:1
AnimationMinimalPerf.default 408 424 0.96:1
TextAreaMinimalPerf.default 485 507 0.96:1
HeaderMinimalPerf.default 366 392 0.93:1
TreeWith60ListItems.default 179 196 0.91:1

@andrefcdias andrefcdias merged commit bd3e92b into microsoft:master Nov 25, 2021
mlp73 pushed a commit to mlp73/fluentui that referenced this pull request Jan 17, 2022
@andrefcdias andrefcdias deleted the migrate-storybook branch May 12, 2022 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants