Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate @fluentui/react-theme #20755

Merged
merged 3 commits into from
Nov 24, 2021
Merged

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Nov 24, 2021

Pull request checklist

Description of changes

  • Ran generator

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 497a887:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

📊 Bundle size report

🤖 This report was generated against 59b3bebb1944aa35f8e8754beec16dcc95f1d5fb

@size-auditor
Copy link

size-auditor bot commented Nov 24, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 34c3e9d5788b53b3df39821a612dd9ecf3b35c22 (build)

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1041 1088 5000
BaseButton mount 1148 1121 5000
Breadcrumb mount 2714 2710 1000
ButtonNext mount 642 625 5000
Checkbox mount 1737 1750 5000
CheckboxBase mount 1508 1518 5000
ChoiceGroup mount 5038 5137 5000
ComboBox mount 1139 1098 1000
CommandBar mount 10243 10208 1000
ContextualMenu mount 8388 8546 1000
DefaultButton mount 1306 1307 5000
DetailsRow mount 4014 4069 5000
DetailsRowFast mount 4038 4131 5000
DetailsRowNoStyles mount 3866 3809 5000
Dialog mount 2684 2768 1000
DocumentCardTitle mount 355 294 1000
Dropdown mount 3550 3460 5000
FluentProviderNext mount 4073 3966 5000
FluentProviderWithTheme mount 360 359 10
FluentProviderWithTheme virtual-rerender 280 251 10
FluentProviderWithTheme virtual-rerender-with-unmount 411 415 10
FocusTrapZone mount 1926 2047 5000
FocusZone mount 1913 1945 5000
IconButton mount 1952 1967 5000
Label mount 506 500 5000
Layer mount 3196 3168 5000
Link mount 640 629 5000
MakeStyles mount 1947 1868 50000
MenuButton mount 1678 1667 5000
MessageBar mount 2186 2146 5000
Nav mount 3564 3552 1000
OverflowSet mount 1280 1306 5000
Panel mount 2540 2638 1000
Persona mount 1025 1003 1000
Pivot mount 1660 1588 1000
PrimaryButton mount 1486 1568 5000
Rating mount 8371 8190 5000
SearchBox mount 1543 1506 5000
Shimmer mount 2913 2731 5000
Slider mount 2145 2130 5000
SpinButton mount 5286 5315 5000
Spinner mount 558 571 5000
SplitButton mount 3334 3364 5000
Stack mount 686 681 5000
StackWithIntrinsicChildren mount 1956 1961 5000
StackWithTextChildren mount 5269 5200 5000
SwatchColorPicker mount 10828 10996 5000
TagPicker mount 2872 3003 5000
TeachingBubble mount 13033 12991 5000
Text mount 591 607 5000
TextField mount 1579 1633 5000
ThemeProvider mount 1325 1359 5000
ThemeProvider virtual-rerender 772 774 5000
ThemeProvider virtual-rerender-with-unmount 2074 2067 5000
Toggle mount 1056 988 5000
buttonNative mount 277 290 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
LabelMinimalPerf.default 449 384 1.17:1
ButtonMinimalPerf.default 201 184 1.09:1
IconMinimalPerf.default 699 650 1.08:1
TreeWith60ListItems.default 203 188 1.08:1
TextMinimalPerf.default 378 354 1.07:1
ToolbarMinimalPerf.default 1015 954 1.06:1
TooltipMinimalPerf.default 1127 1060 1.06:1
AnimationMinimalPerf.default 445 425 1.05:1
AttachmentMinimalPerf.default 180 172 1.05:1
DropdownManyItemsPerf.default 778 741 1.05:1
LayoutMinimalPerf.default 390 370 1.05:1
RefMinimalPerf.default 259 246 1.05:1
StatusMinimalPerf.default 753 718 1.05:1
AttachmentSlotsPerf.default 1173 1131 1.04:1
AvatarMinimalPerf.default 212 204 1.04:1
GridMinimalPerf.default 361 346 1.04:1
LoaderMinimalPerf.default 708 680 1.04:1
PopupMinimalPerf.default 615 593 1.04:1
SkeletonMinimalPerf.default 376 360 1.04:1
ChatDuplicateMessagesPerf.default 324 315 1.03:1
ChatMinimalPerf.default 681 664 1.03:1
DividerMinimalPerf.default 389 379 1.03:1
MenuButtonMinimalPerf.default 1712 1657 1.03:1
PortalMinimalPerf.default 184 178 1.03:1
AlertMinimalPerf.default 296 290 1.02:1
ButtonOverridesMissPerf.default 1743 1712 1.02:1
DialogMinimalPerf.default 818 802 1.02:1
DropdownMinimalPerf.default 3052 3002 1.02:1
HeaderMinimalPerf.default 382 376 1.02:1
HeaderSlotsPerf.default 809 796 1.02:1
SliderMinimalPerf.default 1782 1752 1.02:1
TextAreaMinimalPerf.default 564 552 1.02:1
TreeMinimalPerf.default 865 847 1.02:1
BoxMinimalPerf.default 371 368 1.01:1
ButtonSlotsPerf.default 577 571 1.01:1
DatepickerMinimalPerf.default 5657 5581 1.01:1
ListMinimalPerf.default 547 542 1.01:1
TableManyItemsPerf.default 2150 2138 1.01:1
CarouselMinimalPerf.default 491 493 1:1
EmbedMinimalPerf.default 4303 4297 1:1
InputMinimalPerf.default 1330 1335 1:1
ListCommonPerf.default 679 680 1:1
ListNestedPerf.default 581 582 1:1
MenuMinimalPerf.default 876 873 1:1
SegmentMinimalPerf.default 364 364 1:1
CustomToolbarPrototype.default 4188 4188 1:1
CheckboxMinimalPerf.default 2740 2766 0.99:1
FormMinimalPerf.default 455 461 0.99:1
ItemLayoutMinimalPerf.default 1236 1243 0.99:1
ListWith60ListItems.default 703 713 0.99:1
ProviderMergeThemesPerf.default 1707 1724 0.99:1
SplitButtonMinimalPerf.default 4709 4753 0.99:1
TableMinimalPerf.default 420 426 0.99:1
VideoMinimalPerf.default 652 659 0.99:1
ImageMinimalPerf.default 384 392 0.98:1
CardMinimalPerf.default 590 611 0.97:1
ChatWithPopoverPerf.default 403 418 0.96:1
RosterPerf.default 1266 1317 0.96:1
RadioGroupMinimalPerf.default 474 493 0.96:1
ProviderMinimalPerf.default 1164 1242 0.94:1
FlexMinimalPerf.default 306 338 0.91:1
AccordionMinimalPerf.default 159 177 0.9:1
ReactionMinimalPerf.default 374 430 0.87:1

@layershifter layershifter merged commit 66670cf into master Nov 24, 2021
@layershifter layershifter deleted the chore/migrate-rtheme branch November 24, 2021 14:53
mlp73 pushed a commit to mlp73/fluentui that referenced this pull request Jan 17, 2022
* chore: migrate @fluentui/react-theme

* Change files

* add missing configs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants