Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate @fluentui/keyboard-keys #20754

Merged
merged 2 commits into from
Nov 24, 2021
Merged

chore: migrate @fluentui/keyboard-keys #20754

merged 2 commits into from
Nov 24, 2021

Conversation

layershifter
Copy link
Member

Pull request checklist

Description of changes

  • Ran generator
  • Removed Storybook related scripts & files
  • Added --passWithNoTests

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ceb4f04:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

📊 Bundle size report

🤖 This report was generated against cc3fe8e29cbb4b9d03f26e9a06b58d7aa24ffb65

@size-auditor
Copy link

size-auditor bot commented Nov 24, 2021

Asset size changes

⚠️ Insufficient baseline data to detect size changes

Unable to find bundle size details for Baseline commit: 34c3e9d

Possible causes

  • The baseline build 34c3e9d is broken
  • The Size Auditor run for the baseline build 34c3e9d was not triggered

Recommendations

  • Please merge your branch for this Pull request with the latest master build and commit your changes once again

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 900 917 5000
BaseButton mount 888 882 5000
Breadcrumb mount 2230 2267 1000
ButtonNext mount 576 572 5000
Checkbox mount 1382 1341 5000
CheckboxBase mount 1195 1181 5000
ChoiceGroup mount 4072 4056 5000
ComboBox mount 846 859 1000
CommandBar mount 8599 8569 1000
ContextualMenu mount 6998 7009 1000
DefaultButton mount 1053 1065 5000
DetailsRow mount 3131 3104 5000
DetailsRowFast mount 3149 3144 5000
DetailsRowNoStyles mount 2955 2969 5000
Dialog mount 2194 2217 1000
DocumentCardTitle mount 235 243 1000
Dropdown mount 2790 2783 5000
FluentProviderNext mount 3689 3708 5000
FluentProviderWithTheme mount 287 299 10
FluentProviderWithTheme virtual-rerender 182 210 10
FluentProviderWithTheme virtual-rerender-with-unmount 318 320 10
FocusTrapZone mount 1612 1591 5000
FocusZone mount 1644 1616 5000
IconButton mount 1501 1506 5000
Label mount 431 417 5000
Layer mount 2639 2638 5000
Link mount 527 547 5000
MakeStyles mount 1809 1854 50000
MenuButton mount 1283 1296 5000
MessageBar mount 1800 1819 5000
Nav mount 2744 2741 1000
OverflowSet mount 1115 1115 5000
Panel mount 2144 2117 1000
Persona mount 831 815 1000
Pivot mount 1233 1226 1000
PrimaryButton mount 1170 1168 5000
Rating mount 6845 6895 5000
SearchBox mount 1253 1231 5000
Shimmer mount 2355 2360 5000
Slider mount 1779 1796 5000
SpinButton mount 4077 4090 5000
Spinner mount 498 514 5000
SplitButton mount 2561 2544 5000
Stack mount 579 579 5000
StackWithIntrinsicChildren mount 1572 1609 5000
StackWithTextChildren mount 4365 4353 5000
SwatchColorPicker mount 8405 8495 5000
TagPicker mount 2146 2135 5000
TeachingBubble mount 10592 10612 5000
Text mount 491 489 5000
TextField mount 1234 1291 5000
ThemeProvider mount 1043 1051 5000
ThemeProvider virtual-rerender 683 683 5000
ThemeProvider virtual-rerender-with-unmount 1546 1515 5000
Toggle mount 829 823 5000
buttonNative mount 217 210 5000

Perf Analysis (@fluentui/react-northstar)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
ToolbarMinimalPerf.default 838 829 1.01:1 analysis
Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
TreeWith60ListItems.default 157 147 1.07:1
AvatarMinimalPerf.default 189 179 1.06:1
VideoMinimalPerf.default 576 547 1.05:1
AttachmentMinimalPerf.default 145 140 1.04:1
ChatDuplicateMessagesPerf.default 254 246 1.03:1
FlexMinimalPerf.default 273 264 1.03:1
GridMinimalPerf.default 317 309 1.03:1
LayoutMinimalPerf.default 339 330 1.03:1
ListCommonPerf.default 547 531 1.03:1
ListWith60ListItems.default 542 525 1.03:1
AttachmentSlotsPerf.default 867 852 1.02:1
ButtonOverridesMissPerf.default 1400 1376 1.02:1
ListMinimalPerf.default 484 476 1.02:1
MenuMinimalPerf.default 772 755 1.02:1
ReactionMinimalPerf.default 350 344 1.02:1
SegmentMinimalPerf.default 331 324 1.02:1
IconMinimalPerf.default 562 553 1.02:1
TableMinimalPerf.default 380 373 1.02:1
TextAreaMinimalPerf.default 455 448 1.02:1
CarouselMinimalPerf.default 379 375 1.01:1
ChatMinimalPerf.default 605 599 1.01:1
DatepickerMinimalPerf.default 4666 4602 1.01:1
DropdownMinimalPerf.default 2577 2555 1.01:1
FormMinimalPerf.default 365 363 1.01:1
LoaderMinimalPerf.default 564 558 1.01:1
ProviderMinimalPerf.default 954 947 1.01:1
SliderMinimalPerf.default 1392 1385 1.01:1
StatusMinimalPerf.default 632 627 1.01:1
TableManyItemsPerf.default 1629 1616 1.01:1
CustomToolbarPrototype.default 3417 3375 1.01:1
TooltipMinimalPerf.default 943 935 1.01:1
AnimationMinimalPerf.default 381 381 1:1
BoxMinimalPerf.default 329 328 1:1
ButtonMinimalPerf.default 154 154 1:1
CardMinimalPerf.default 506 504 1:1
DividerMinimalPerf.default 338 337 1:1
EmbedMinimalPerf.default 3134 3120 1:1
HeaderSlotsPerf.default 693 693 1:1
InputMinimalPerf.default 1038 1035 1:1
ItemLayoutMinimalPerf.default 1014 1011 1:1
LabelMinimalPerf.default 355 355 1:1
MenuButtonMinimalPerf.default 1349 1350 1:1
PopupMinimalPerf.default 540 539 1:1
RefMinimalPerf.default 220 219 1:1
SkeletonMinimalPerf.default 324 325 1:1
SplitButtonMinimalPerf.default 3361 3352 1:1
AccordionMinimalPerf.default 137 139 0.99:1
AlertMinimalPerf.default 244 247 0.99:1
ButtonSlotsPerf.default 426 430 0.99:1
ChatWithPopoverPerf.default 319 323 0.99:1
CheckboxMinimalPerf.default 1965 1979 0.99:1
DialogMinimalPerf.default 697 701 0.99:1
DropdownManyItemsPerf.default 561 567 0.99:1
HeaderMinimalPerf.default 327 329 0.99:1
ListNestedPerf.default 489 494 0.99:1
ProviderMergeThemesPerf.default 1401 1411 0.99:1
RadioGroupMinimalPerf.default 408 414 0.99:1
TextMinimalPerf.default 315 319 0.99:1
ImageMinimalPerf.default 343 351 0.98:1
TreeMinimalPerf.default 707 720 0.98:1
RosterPerf.default 918 959 0.96:1
PortalMinimalPerf.default 146 157 0.93:1

@layershifter layershifter merged commit 532579e into master Nov 24, 2021
@layershifter layershifter deleted the chore/migrate-rkk branch November 24, 2021 14:27
mlp73 pushed a commit to mlp73/fluentui that referenced this pull request Jan 17, 2022
* chore: migrate @fluentui/keyboard-keys

* Change files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants