Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate @fluentui/react-aria #20753

Merged
merged 3 commits into from
Nov 24, 2021
Merged

chore: migrate @fluentui/react-aria #20753

merged 3 commits into from
Nov 24, 2021

Conversation

layershifter
Copy link
Member

Pull request checklist

Description of changes

  • Ran generator

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0290196:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

📊 Bundle size report

🤖 This report was generated against 59b3bebb1944aa35f8e8754beec16dcc95f1d5fb

@size-auditor
Copy link

size-auditor bot commented Nov 24, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 34c3e9d5788b53b3df39821a612dd9ecf3b35c22 (build)

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 866 859 5000
BaseButton mount 904 899 5000
Breadcrumb mount 2407 2413 1000
ButtonNext mount 525 542 5000
Checkbox mount 1417 1459 5000
CheckboxBase mount 1200 1215 5000
ChoiceGroup mount 4175 4168 5000
ComboBox mount 951 938 1000
CommandBar mount 8865 8914 1000
ContextualMenu mount 7383 7380 1000
DefaultButton mount 1073 1067 5000
DetailsRow mount 3367 3354 5000
DetailsRowFast mount 3334 3375 5000
DetailsRowNoStyles mount 3200 3208 5000
Dialog mount 2290 2319 1000
DocumentCardTitle mount 223 238 1000
Dropdown mount 2826 2879 5000
FluentProviderNext mount 3619 3623 5000
FluentProviderWithTheme mount 312 298 10
FluentProviderWithTheme virtual-rerender 203 184 10
FluentProviderWithTheme virtual-rerender-with-unmount 328 335 10
FocusTrapZone mount 1677 1647 5000
FocusZone mount 1648 1684 5000
IconButton mount 1604 1598 5000
Label mount 405 403 5000
Layer mount 2623 2641 5000
Link mount 509 521 5000
MakeStyles mount 1666 1697 50000
MenuButton mount 1349 1407 5000
MessageBar mount 1828 1829 5000
Nav mount 2914 2893 1000
OverflowSet mount 1061 1078 5000
Panel mount 2246 2227 1000
Persona mount 822 806 1000
Pivot mount 1330 1353 1000
PrimaryButton mount 1212 1208 5000
Rating mount 6677 6700 5000
SearchBox mount 1260 1229 5000
Shimmer mount 2281 2325 5000
Slider mount 1775 1739 5000
SpinButton mount 4431 4354 5000
Spinner mount 472 477 5000
SplitButton mount 2775 2819 5000
Stack mount 560 546 5000
StackWithIntrinsicChildren mount 1573 1575 5000
StackWithTextChildren mount 4071 4057 5000
SwatchColorPicker mount 9064 9062 5000
TagPicker mount 2392 2347 5000
TeachingBubble mount 11326 11337 5000
Text mount 476 466 5000
TextField mount 1259 1296 5000
ThemeProvider mount 1110 1112 5000
ThemeProvider virtual-rerender 636 640 5000
ThemeProvider virtual-rerender-with-unmount 1668 1694 5000
Toggle mount 795 807 5000
buttonNative mount 195 222 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
TreeWith60ListItems.default 172 149 1.15:1
ImageMinimalPerf.default 342 301 1.14:1
AttachmentMinimalPerf.default 147 135 1.09:1
CarouselMinimalPerf.default 416 393 1.06:1
FlexMinimalPerf.default 253 239 1.06:1
RadioGroupMinimalPerf.default 391 370 1.06:1
DividerMinimalPerf.default 317 303 1.05:1
InputMinimalPerf.default 1136 1082 1.05:1
RefMinimalPerf.default 213 203 1.05:1
SegmentMinimalPerf.default 298 284 1.05:1
TreeMinimalPerf.default 709 676 1.05:1
BoxMinimalPerf.default 305 293 1.04:1
GridMinimalPerf.default 289 278 1.04:1
HeaderSlotsPerf.default 652 629 1.04:1
LoaderMinimalPerf.default 598 577 1.04:1
CardMinimalPerf.default 476 464 1.03:1
ChatDuplicateMessagesPerf.default 262 255 1.03:1
ChatMinimalPerf.default 566 551 1.03:1
TableMinimalPerf.default 345 335 1.03:1
AlertMinimalPerf.default 236 231 1.02:1
AttachmentSlotsPerf.default 906 888 1.02:1
DropdownMinimalPerf.default 2616 2569 1.02:1
LabelMinimalPerf.default 324 319 1.02:1
ListMinimalPerf.default 445 438 1.02:1
SliderMinimalPerf.default 1454 1427 1.02:1
StatusMinimalPerf.default 572 560 1.02:1
TableManyItemsPerf.default 1610 1583 1.02:1
TextMinimalPerf.default 296 290 1.02:1
VideoMinimalPerf.default 546 535 1.02:1
DropdownManyItemsPerf.default 578 571 1.01:1
FormMinimalPerf.default 348 343 1.01:1
ItemLayoutMinimalPerf.default 1011 1003 1.01:1
ListNestedPerf.default 473 468 1.01:1
MenuMinimalPerf.default 725 717 1.01:1
PopupMinimalPerf.default 514 508 1.01:1
PortalMinimalPerf.default 150 149 1.01:1
ReactionMinimalPerf.default 325 322 1.01:1
IconMinimalPerf.default 530 525 1.01:1
ToolbarMinimalPerf.default 810 803 1.01:1
TooltipMinimalPerf.default 879 874 1.01:1
ButtonOverridesMissPerf.default 1429 1431 1:1
CheckboxMinimalPerf.default 2282 2288 1:1
DatepickerMinimalPerf.default 4680 4692 1:1
ProviderMergeThemesPerf.default 1464 1463 1:1
ProviderMinimalPerf.default 957 957 1:1
SplitButtonMinimalPerf.default 3603 3593 1:1
CustomToolbarPrototype.default 3472 3458 1:1
AvatarMinimalPerf.default 169 170 0.99:1
ButtonMinimalPerf.default 143 144 0.99:1
ButtonSlotsPerf.default 463 466 0.99:1
EmbedMinimalPerf.default 3482 3500 0.99:1
LayoutMinimalPerf.default 306 309 0.99:1
ListCommonPerf.default 537 545 0.99:1
ListWith60ListItems.default 549 555 0.99:1
MenuButtonMinimalPerf.default 1381 1389 0.99:1
RosterPerf.default 1005 1015 0.99:1
SkeletonMinimalPerf.default 296 299 0.99:1
TextAreaMinimalPerf.default 416 421 0.99:1
AccordionMinimalPerf.default 132 135 0.98:1
DialogMinimalPerf.default 638 651 0.98:1
HeaderMinimalPerf.default 306 311 0.98:1
ChatWithPopoverPerf.default 318 329 0.97:1
AnimationMinimalPerf.default 334 348 0.96:1

@layershifter layershifter merged commit 8a82033 into master Nov 24, 2021
@layershifter layershifter deleted the chore/migrate-ra branch November 24, 2021 14:38
mlp73 pushed a commit to mlp73/fluentui that referenced this pull request Jan 17, 2022
* chore: migrate @fluentui/react-aria

* Change files

* add missing configs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants