Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run migration for @fluentui/jest-serializer-make-styles #20747

Merged
merged 4 commits into from
Nov 25, 2021

Conversation

layershifter
Copy link
Member

Pull request checklist

Description of changes

@fabricteam
Copy link
Collaborator

fabricteam commented Nov 24, 2021

📊 Bundle size report

🤖 This report was generated against 532579ec884b3bad9e2db6dff139eb467f3c2bbc

@layershifter
Copy link
Member Author

layershifter commented Nov 24, 2021

image

The same problem as in #20744.

✅ Solved, see #20744 (comment)

@layershifter layershifter added the Status: Blocked Resolution blocked by another issue label Nov 24, 2021
@size-auditor
Copy link

size-auditor bot commented Nov 24, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 8a820339f7f4084d8c46e97f06eebbeb18111397 (build)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 24, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 882f664:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Nov 24, 2021

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1225 1123 5000
BaseButton mount 1218 1270 5000
Breadcrumb mount 2953 3011 1000
ButtonNext mount 744 751 5000
Checkbox mount 1866 1910 5000
CheckboxBase mount 1655 1669 5000
ChoiceGroup mount 5431 5594 5000
ComboBox mount 1196 1222 1000
CommandBar mount 10960 10952 1000
ContextualMenu mount 9242 9231 1000
DefaultButton mount 1445 1448 5000
DetailsRow mount 4395 4289 5000
DetailsRowFast mount 4292 4285 5000
DetailsRowNoStyles mount 4140 4255 5000
Dialog mount 2851 2835 1000
DocumentCardTitle mount 365 343 1000
Dropdown mount 3719 3715 5000
FluentProviderNext mount 4195 4264 5000
FluentProviderWithTheme mount 416 390 10
FluentProviderWithTheme virtual-rerender 271 260 10
FluentProviderWithTheme virtual-rerender-with-unmount 430 453 10
FocusTrapZone mount 2108 2120 5000
FocusZone mount 2191 2123 5000
IconButton mount 2176 2151 5000
Label mount 527 522 5000
Layer mount 3398 3447 5000
Link mount 760 685 5000
MakeStyles mount 2059 2131 50000
MenuButton mount 1826 1896 5000
MessageBar mount 2307 2299 5000
Nav mount 3845 3768 1000
OverflowSet mount 1365 1392 5000
Panel mount 2877 2826 1000
Persona mount 1116 1120 1000
Pivot mount 1731 1756 1000
PrimaryButton mount 1662 1609 5000
Rating mount 9005 9095 5000
SearchBox mount 1762 1689 5000
Shimmer mount 3123 3029 5000
Slider mount 2355 2331 5000
SpinButton mount 5743 5745 5000
Spinner mount 630 621 5000
SplitButton mount 3687 3676 5000
Stack mount 732 760 5000
StackWithIntrinsicChildren mount 2194 2211 5000
StackWithTextChildren mount 5691 5593 5000
SwatchColorPicker mount 11961 12021 5000
TagPicker mount 3169 3222 5000
TeachingBubble mount 13963 14243 5000
Text mount 647 667 5000
TextField mount 1735 1718 5000
ThemeProvider mount 1428 1449 5000
ThemeProvider virtual-rerender 826 802 5000
ThemeProvider virtual-rerender-with-unmount 2290 2317 5000
Toggle mount 1066 1086 5000
buttonNative mount 322 326 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
TreeWith60ListItems.default 227 201 1.13:1
CardMinimalPerf.default 708 631 1.12:1
GridMinimalPerf.default 416 382 1.09:1
AlertMinimalPerf.default 336 314 1.07:1
CarouselMinimalPerf.default 561 525 1.07:1
HeaderSlotsPerf.default 910 853 1.07:1
ListMinimalPerf.default 610 578 1.06:1
TreeMinimalPerf.default 934 880 1.06:1
HeaderMinimalPerf.default 423 402 1.05:1
LayoutMinimalPerf.default 414 396 1.05:1
PortalMinimalPerf.default 186 177 1.05:1
AvatarMinimalPerf.default 228 219 1.04:1
ChatWithPopoverPerf.default 433 418 1.04:1
DropdownManyItemsPerf.default 819 789 1.04:1
ItemLayoutMinimalPerf.default 1374 1319 1.04:1
ListCommonPerf.default 753 722 1.04:1
ListNestedPerf.default 650 628 1.04:1
AttachmentMinimalPerf.default 185 180 1.03:1
AttachmentSlotsPerf.default 1236 1203 1.03:1
ButtonMinimalPerf.default 217 210 1.03:1
LoaderMinimalPerf.default 779 757 1.03:1
StatusMinimalPerf.default 791 766 1.03:1
TableMinimalPerf.default 450 437 1.03:1
TextAreaMinimalPerf.default 592 575 1.03:1
CustomToolbarPrototype.default 4554 4414 1.03:1
VideoMinimalPerf.default 727 709 1.03:1
AccordionMinimalPerf.default 204 200 1.02:1
BoxMinimalPerf.default 405 398 1.02:1
ChatDuplicateMessagesPerf.default 336 328 1.02:1
ListWith60ListItems.default 743 727 1.02:1
RefMinimalPerf.default 263 258 1.02:1
SliderMinimalPerf.default 1837 1797 1.02:1
SplitButtonMinimalPerf.default 4788 4703 1.02:1
AnimationMinimalPerf.default 469 463 1.01:1
ChatMinimalPerf.default 761 753 1.01:1
DatepickerMinimalPerf.default 6122 6069 1.01:1
DropdownMinimalPerf.default 3246 3212 1.01:1
InputMinimalPerf.default 1430 1416 1.01:1
MenuButtonMinimalPerf.default 1845 1830 1.01:1
PopupMinimalPerf.default 650 644 1.01:1
ToolbarMinimalPerf.default 1094 1085 1.01:1
TooltipMinimalPerf.default 1153 1147 1.01:1
CheckboxMinimalPerf.default 2892 2900 1:1
FlexMinimalPerf.default 323 323 1:1
RadioGroupMinimalPerf.default 522 520 1:1
SkeletonMinimalPerf.default 396 397 1:1
IconMinimalPerf.default 707 705 1:1
TextMinimalPerf.default 405 403 1:1
DialogMinimalPerf.default 842 852 0.99:1
EmbedMinimalPerf.default 4561 4615 0.99:1
FormMinimalPerf.default 482 487 0.99:1
ProviderMergeThemesPerf.default 1808 1821 0.99:1
ProviderMinimalPerf.default 1265 1272 0.99:1
TableManyItemsPerf.default 2156 2178 0.99:1
MenuMinimalPerf.default 955 972 0.98:1
SegmentMinimalPerf.default 406 415 0.98:1
ButtonOverridesMissPerf.default 1876 1927 0.97:1
DividerMinimalPerf.default 416 430 0.97:1
LabelMinimalPerf.default 429 441 0.97:1
ButtonSlotsPerf.default 628 654 0.96:1
ReactionMinimalPerf.default 426 446 0.96:1
RosterPerf.default 1301 1369 0.95:1
ImageMinimalPerf.default 439 470 0.93:1

@layershifter layershifter removed the Status: Blocked Resolution blocked by another issue label Nov 24, 2021
@layershifter layershifter merged commit 3f521b7 into master Nov 25, 2021
@layershifter layershifter deleted the chore/migrate-jsms branch November 25, 2021 09:22
mlp73 pushed a commit to mlp73/fluentui that referenced this pull request Jan 17, 2022
…soft#20747)

* chore: run migration for @fluentui/jest-serializer-make-styles

* Change files

* fix devs

* applied suggestions from another PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants