chore: run migration for @fluentui/react-make-styles #20728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 tasks
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d59a658:
|
ling1726
approved these changes
Nov 23, 2021
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
📊 Bundle size report🤖 This report was generated against 6183f8ae46233d7ecec2a3d12e7348b7b41eea0c |
Asset size changesUnable to find bundle size details for Baseline commit: 01af977 Possible causes
Recommendations
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 787 | 807 | 5000 | |
| BaseButton | mount | 792 | 805 | 5000 | |
| Breadcrumb | mount | 2306 | 2242 | 1000 | |
| ButtonNext | mount | 444 | 444 | 5000 | |
| Checkbox | mount | 1324 | 1314 | 5000 | |
| CheckboxBase | mount | 1103 | 1107 | 5000 | |
| ChoiceGroup | mount | 4016 | 4028 | 5000 | |
| ComboBox | mount | 840 | 858 | 1000 | |
| CommandBar | mount | 8868 | 8740 | 1000 | |
| ContextualMenu | mount | 7250 | 7293 | 1000 | |
| DefaultButton | mount | 954 | 968 | 5000 | |
| DetailsRow | mount | 3254 | 3193 | 5000 | |
| DetailsRowFast | mount | 3260 | 3254 | 5000 | |
| DetailsRowNoStyles | mount | 3064 | 3085 | 5000 | |
| Dialog | mount | 2196 | 2225 | 1000 | |
| DocumentCardTitle | mount | 143 | 140 | 1000 | |
| Dropdown | mount | 2753 | 2745 | 5000 | |
| FluentProviderNext | mount | 3487 | 3485 | 5000 | |
| FluentProviderWithTheme | mount | 207 | 206 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 78 | 91 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 223 | 237 | 10 | |
| FocusTrapZone | mount | 1564 | 1547 | 5000 | |
| FocusZone | mount | 1506 | 1553 | 5000 | |
| IconButton | mount | 1526 | 1510 | 5000 | |
| Label | mount | 306 | 309 | 5000 | |
| Layer | mount | 2545 | 2550 | 5000 | |
| Link | mount | 421 | 407 | 5000 | |
| MakeStyles | mount | 1592 | 1586 | 50000 | |
| MenuButton | mount | 1268 | 1269 | 5000 | |
| MessageBar | mount | 1724 | 1722 | 5000 | |
| Nav | mount | 2894 | 2849 | 1000 | |
| OverflowSet | mount | 969 | 962 | 5000 | |
| Panel | mount | 2106 | 2151 | 1000 | |
| Persona | mount | 719 | 728 | 1000 | |
| Pivot | mount | 1241 | 1216 | 1000 | |
| PrimaryButton | mount | 1098 | 1092 | 5000 | |
| Rating | mount | 6595 | 6534 | 5000 | |
| SearchBox | mount | 1127 | 1139 | 5000 | |
| Shimmer | mount | 2166 | 2173 | 5000 | |
| Slider | mount | 1679 | 1665 | 5000 | |
| SpinButton | mount | 4269 | 4272 | 5000 | |
| Spinner | mount | 391 | 370 | 5000 | |
| SplitButton | mount | 2715 | 2702 | 5000 | |
| Stack | mount | 438 | 439 | 5000 | |
| StackWithIntrinsicChildren | mount | 1450 | 1457 | 5000 | |
| StackWithTextChildren | mount | 3994 | 3979 | 5000 | |
| SwatchColorPicker | mount | 9101 | 8951 | 5000 | |
| TagPicker | mount | 2239 | 2299 | 5000 | |
| TeachingBubble | mount | 11228 | 11196 | 5000 | |
| Text | mount | 368 | 367 | 5000 | |
| TextField | mount | 1197 | 1176 | 5000 | |
| ThemeProvider | mount | 1021 | 1024 | 5000 | |
| ThemeProvider | virtual-rerender | 534 | 533 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1602 | 1584 | 5000 | |
| Toggle | mount | 703 | 696 | 5000 | |
| buttonNative | mount | 122 | 115 | 5000 |
Perf Analysis (@fluentui/react-northstar)
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| ImageMinimalPerf.default | 328 | 299 | 1.1:1 |
| TableMinimalPerf.default | 336 | 308 | 1.09:1 |
| TreeWith60ListItems.default | 163 | 151 | 1.08:1 |
| ButtonMinimalPerf.default | 151 | 141 | 1.07:1 |
| FormMinimalPerf.default | 350 | 328 | 1.07:1 |
| AvatarMinimalPerf.default | 172 | 162 | 1.06:1 |
| ChatDuplicateMessagesPerf.default | 266 | 251 | 1.06:1 |
| RadioGroupMinimalPerf.default | 387 | 366 | 1.06:1 |
| BoxMinimalPerf.default | 302 | 287 | 1.05:1 |
| CarouselMinimalPerf.default | 408 | 393 | 1.04:1 |
| ListCommonPerf.default | 543 | 522 | 1.04:1 |
| PortalMinimalPerf.default | 156 | 150 | 1.04:1 |
| AnimationMinimalPerf.default | 357 | 346 | 1.03:1 |
| HeaderMinimalPerf.default | 306 | 296 | 1.03:1 |
| LayoutMinimalPerf.default | 315 | 307 | 1.03:1 |
| ListNestedPerf.default | 472 | 459 | 1.03:1 |
| LoaderMinimalPerf.default | 595 | 576 | 1.03:1 |
| MenuMinimalPerf.default | 739 | 717 | 1.03:1 |
| ReactionMinimalPerf.default | 314 | 305 | 1.03:1 |
| StatusMinimalPerf.default | 564 | 548 | 1.03:1 |
| TextAreaMinimalPerf.default | 423 | 409 | 1.03:1 |
| TooltipMinimalPerf.default | 893 | 869 | 1.03:1 |
| ButtonSlotsPerf.default | 473 | 463 | 1.02:1 |
| DialogMinimalPerf.default | 643 | 631 | 1.02:1 |
| DividerMinimalPerf.default | 309 | 303 | 1.02:1 |
| DropdownMinimalPerf.default | 2589 | 2544 | 1.02:1 |
| PopupMinimalPerf.default | 508 | 497 | 1.02:1 |
| ProviderMinimalPerf.default | 978 | 957 | 1.02:1 |
| RefMinimalPerf.default | 206 | 201 | 1.02:1 |
| TextMinimalPerf.default | 292 | 285 | 1.02:1 |
| CustomToolbarPrototype.default | 3540 | 3458 | 1.02:1 |
| AccordionMinimalPerf.default | 138 | 137 | 1.01:1 |
| AttachmentMinimalPerf.default | 136 | 135 | 1.01:1 |
| ButtonOverridesMissPerf.default | 1443 | 1428 | 1.01:1 |
| ChatWithPopoverPerf.default | 328 | 325 | 1.01:1 |
| DropdownManyItemsPerf.default | 585 | 580 | 1.01:1 |
| EmbedMinimalPerf.default | 3501 | 3472 | 1.01:1 |
| InputMinimalPerf.default | 1100 | 1092 | 1.01:1 |
| SplitButtonMinimalPerf.default | 3617 | 3597 | 1.01:1 |
| ToolbarMinimalPerf.default | 800 | 793 | 1.01:1 |
| TreeMinimalPerf.default | 686 | 677 | 1.01:1 |
| AlertMinimalPerf.default | 223 | 222 | 1:1 |
| AttachmentSlotsPerf.default | 897 | 895 | 1:1 |
| CardMinimalPerf.default | 457 | 456 | 1:1 |
| DatepickerMinimalPerf.default | 4747 | 4728 | 1:1 |
| FlexMinimalPerf.default | 232 | 233 | 1:1 |
| GridMinimalPerf.default | 284 | 283 | 1:1 |
| ItemLayoutMinimalPerf.default | 1007 | 1004 | 1:1 |
| ListMinimalPerf.default | 434 | 436 | 1:1 |
| ListWith60ListItems.default | 557 | 556 | 1:1 |
| ProviderMergeThemesPerf.default | 1462 | 1455 | 1:1 |
| SegmentMinimalPerf.default | 297 | 297 | 1:1 |
| IconMinimalPerf.default | 510 | 512 | 1:1 |
| ChatMinimalPerf.default | 552 | 556 | 0.99:1 |
| CheckboxMinimalPerf.default | 2228 | 2246 | 0.99:1 |
| LabelMinimalPerf.default | 322 | 324 | 0.99:1 |
| MenuButtonMinimalPerf.default | 1379 | 1390 | 0.99:1 |
| RosterPerf.default | 992 | 1005 | 0.99:1 |
| SliderMinimalPerf.default | 1412 | 1429 | 0.99:1 |
| TableManyItemsPerf.default | 1579 | 1588 | 0.99:1 |
| VideoMinimalPerf.default | 511 | 517 | 0.99:1 |
| HeaderSlotsPerf.default | 627 | 644 | 0.97:1 |
| SkeletonMinimalPerf.default | 294 | 304 | 0.97:1 |
mlp73
pushed a commit
to mlp73/fluentui
that referenced
this pull request
Jan 17, 2022
* chore: run migration for @fluentui/react-make-styles * Change files * add configs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
.babelrc(issue created #migrate-converged-pkg: adds @fluentui/babel-make-styles and causes circular deps #20727)package.json#devDependencies(the same problem, migrate-converged-pkg: adds @fluentui/babel-make-styles and causes circular deps #20727)