Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: run migration for @fluentui/react-provider #20726

Merged
merged 2 commits into from
Nov 24, 2021
Merged

chore: run migration for @fluentui/react-provider #20726

merged 2 commits into from
Nov 24, 2021

Conversation

layershifter
Copy link
Member

Pull request checklist

Description of changes

Ran generator 🚀

@layershifter layershifter requested a review from a team as a code owner November 23, 2021 17:02
layershifter
layershifter commented Nov 23, 2021
View reviewed changes
packages/react-provider/src/stories/FluentProviderFrame.stories.tsx
import { Button } from '@fluentui/react-button';
import { createDOMRenderer, makeStyles, RendererProvider } from '@fluentui/react-make-styles';
import { FluentProvider } from '../FluentProvider'; // codesandbox-dependency: @fluentui/react-components ^9.0.0-beta
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ling1726 This comment is not longer necessary, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, no longer necessary

@layershifter layershifter requested a review from a team November 23, 2021 17:02
@layershifter layershifter mentioned this pull request Nov 23, 2021
Closed
39 tasks
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8bd2092:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@ling1726
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@fabricteam
Copy link
Collaborator

📊 Bundle size report

🤖 This report was generated against a54302c0b2017db41a4ac6056ec676d11926243e

@size-auditor
Copy link

size-auditor bot commented Nov 24, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: a54302c0b2017db41a4ac6056ec676d11926243e (build)

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 868 845 5000
BaseButton mount 851 862 5000
Breadcrumb mount 2420 2648 1000
ButtonNext mount undefined err 5000
Checkbox mount 1373 1401 5000
CheckboxBase mount 1235 1202 5000
ChoiceGroup mount 4088 4052 5000
ComboBox mount 960 867 1000
CommandBar mount 8881 8902 1000
ContextualMenu mount 7221 7283 1000
DefaultButton mount 1072 1089 5000
DetailsRow mount 3334 3355 5000
DetailsRowFast mount 3181 3266 5000
DetailsRowNoStyles mount 3096 2904 5000
Dialog mount 2170 2173 1000
DocumentCardTitle mount 211 230 1000
Dropdown mount 2633 2689 5000
FluentProviderNext mount 3291 3407 5000
FluentProviderWithTheme mount 270 294 10
FluentProviderWithTheme virtual-rerender 176 178 10
FluentProviderWithTheme virtual-rerender-with-unmount 319 302 10
FocusTrapZone mount 1511 1485 5000
FocusZone mount 1581 1659 5000
IconButton mount 1509 1425 5000
Label mount 371 354 5000
Layer mount 2485 2440 5000
Link mount 470 454 5000
MakeStyles mount 1546 1600 50000
MenuButton mount 1227 1306 5000
MessageBar mount 1832 1830 5000
Nav mount 2658 2811 1000
OverflowSet mount 932 969 5000
Panel mount 2102 2196 1000
Persona mount 757 774 1000
Pivot mount 1186 1235 1000
PrimaryButton mount 1068 1086 5000
Rating mount 6382 6343 5000
SearchBox mount 1207 1195 5000
Shimmer mount 2116 2146 5000
Slider mount 1568 1686 5000
SpinButton mount 4389 4034 5000
Spinner mount 463 432 5000
SplitButton mount 2810 2737 5000
Stack mount 501 540 5000
StackWithIntrinsicChildren mount 1523 1422 5000
StackWithTextChildren mount 3850 3939 5000
SwatchColorPicker mount 8534 8786 5000
TagPicker mount 2237 2138 5000
TeachingBubble mount 10905 10989 5000
Text mount 420 463 5000
TextField mount 1208 1248 5000
ThemeProvider mount 1114 1013 5000
ThemeProvider virtual-rerender 558 604 5000
ThemeProvider virtual-rerender-with-unmount 1564 1597 5000
Toggle mount 717 719 5000
buttonNative mount 192 197 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
SkeletonMinimalPerf.default 342 266 1.29:1
DividerMinimalPerf.default 341 284 1.2:1
FormMinimalPerf.default 369 309 1.19:1
ChatWithPopoverPerf.default 366 313 1.17:1
MenuMinimalPerf.default 755 652 1.16:1
TextAreaMinimalPerf.default 438 381 1.15:1
HeaderSlotsPerf.default 639 572 1.12:1
ProviderMinimalPerf.default 1003 897 1.12:1
StatusMinimalPerf.default 582 525 1.11:1
HeaderMinimalPerf.default 304 276 1.1:1
TableMinimalPerf.default 361 332 1.09:1
ImageMinimalPerf.default 346 319 1.08:1
BoxMinimalPerf.default 323 301 1.07:1
ListMinimalPerf.default 422 396 1.07:1
PortalMinimalPerf.default 168 159 1.06:1
DatepickerMinimalPerf.default 5521 5281 1.05:1
FlexMinimalPerf.default 232 220 1.05:1
ReactionMinimalPerf.default 307 292 1.05:1
InputMinimalPerf.default 1085 1044 1.04:1
ItemLayoutMinimalPerf.default 965 926 1.04:1
AttachmentMinimalPerf.default 129 125 1.03:1
ButtonMinimalPerf.default 140 136 1.03:1
ChatMinimalPerf.default 547 531 1.03:1
ProviderMergeThemesPerf.default 1417 1372 1.03:1
RadioGroupMinimalPerf.default 371 361 1.03:1
ButtonSlotsPerf.default 487 478 1.02:1
CardMinimalPerf.default 432 422 1.02:1
CheckboxMinimalPerf.default 2266 2225 1.02:1
DropdownManyItemsPerf.default 592 580 1.02:1
TextMinimalPerf.default 273 268 1.02:1
ButtonOverridesMissPerf.default 1495 1479 1.01:1
DropdownMinimalPerf.default 2504 2468 1.01:1
ListWith60ListItems.default 493 488 1.01:1
MenuButtonMinimalPerf.default 1368 1351 1.01:1
RefMinimalPerf.default 187 186 1.01:1
SplitButtonMinimalPerf.default 3476 3427 1.01:1
CustomToolbarPrototype.default 3448 3427 1.01:1
ToolbarMinimalPerf.default 735 729 1.01:1
TooltipMinimalPerf.default 906 893 1.01:1
ListNestedPerf.default 487 487 1:1
PopupMinimalPerf.default 480 487 0.99:1
TableManyItemsPerf.default 1516 1525 0.99:1
LoaderMinimalPerf.default 598 611 0.98:1
AlertMinimalPerf.default 242 250 0.97:1
AvatarMinimalPerf.default 165 170 0.97:1
EmbedMinimalPerf.default 3269 3408 0.96:1
GridMinimalPerf.default 255 266 0.96:1
TreeWith60ListItems.default 165 172 0.96:1
AccordionMinimalPerf.default 135 142 0.95:1
AnimationMinimalPerf.default 357 375 0.95:1
AttachmentSlotsPerf.default 912 965 0.95:1
TreeMinimalPerf.default 651 686 0.95:1
CarouselMinimalPerf.default 388 414 0.94:1
RosterPerf.default 977 1040 0.94:1
LayoutMinimalPerf.default 280 302 0.93:1
ListCommonPerf.default 492 532 0.92:1
SliderMinimalPerf.default 1310 1457 0.9:1
IconMinimalPerf.default 469 519 0.9:1
ChatDuplicateMessagesPerf.default 252 285 0.88:1
DialogMinimalPerf.default 582 662 0.88:1
VideoMinimalPerf.default 477 543 0.88:1
LabelMinimalPerf.default 293 338 0.87:1
SegmentMinimalPerf.default 265 312 0.85:1

@layershifter layershifter merged commit 14b1e35 into master Nov 24, 2021
@layershifter layershifter deleted the chore/migrate-rp branch November 24, 2021 08:17
mlp73 pushed a commit to mlp73/fluentui that referenced this pull request Jan 17, 2022
@layershifter
chore: run migration for @fluentui/react-provider (microsoft#20726)
4c98b30 
* chore: run migration for @fluentui/react-provider

* Change files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ling1726 ling1726 ling1726 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@layershifter @ling1726 @fabricteam