Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider refactor #20657

Merged
merged 67 commits into from
Jan 5, 2022
Merged
Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
67 commits
Select commit Hold shift + click to select a range
30659ae
init refactor of slider
micahgodbolt Nov 9, 2021
8ad4cfd
start bringing marks back in
micahgodbolt Nov 12, 2021
e2ae6cd
stories for slider
micahgodbolt Nov 18, 2021
0c9ad2a
story cleanup
micahgodbolt Nov 18, 2021
50c6f84
cleanup
micahgodbolt Nov 18, 2021
40d8a97
update spec
micahgodbolt Nov 18, 2021
6dc8efc
Change files
micahgodbolt Nov 18, 2021
d312352
update api
micahgodbolt Nov 18, 2021
d4236a7
Apply suggestions from code review
micahgodbolt Nov 19, 2021
07e60a1
move stateful styles into css variables
micahgodbolt Nov 19, 2021
5171836
merge conflicts
micahgodbolt Nov 29, 2021
47e7079
add slider to react-components main export
micahgodbolt Nov 29, 2021
ae6f7ed
cleanup and add ticks
micahgodbolt Nov 30, 2021
ab2b781
change var name
micahgodbolt Nov 30, 2021
663fe05
cleanup snaps
micahgodbolt Nov 30, 2021
66281f2
remove ranged fixture
micahgodbolt Nov 30, 2021
50509a4
Merge branch 'master' into slider-refactor
micahgodbolt Dec 1, 2021
964b130
fix package version
micahgodbolt Dec 1, 2021
4d65009
fix prettier
micahgodbolt Dec 1, 2021
5f2b8de
add primary slot
micahgodbolt Dec 2, 2021
b93be27
api update
micahgodbolt Dec 2, 2021
ab02143
react components api
micahgodbolt Dec 2, 2021
cb4bbd4
Merge branch 'master' into slider-refactor
micahgodbolt Dec 3, 2021
48ab826
revert react components to remove slider
micahgodbolt Dec 7, 2021
37ba000
merge conflicts
micahgodbolt Dec 7, 2021
e4c542b
merge conflicts
micahgodbolt Dec 7, 2021
334e632
update api md
micahgodbolt Dec 7, 2021
efec9c4
Delete @fluentui-react-components-2b36a74e-2147-4df0-a4f2-ab6c12c5603…
micahgodbolt Dec 7, 2021
b2a4ced
cleanup testing
micahgodbolt Dec 7, 2021
461fb9e
Merge branch 'slider-refactor' of https://github.com/micahgodbolt/flu…
micahgodbolt Dec 7, 2021
ac453d3
slider types
micahgodbolt Dec 7, 2021
30ce476
simplify onChange prop
micahgodbolt Dec 8, 2021
2d620ec
update api
micahgodbolt Dec 8, 2021
49003d2
move back to onChange with data
micahgodbolt Dec 8, 2021
1c9db3c
remove unused stuff
micahgodbolt Dec 8, 2021
f2a5f74
Update packages/react-slider/src/components/Slider/Slider.types.ts
micahgodbolt Dec 10, 2021
1295f39
Update packages/react-slider/src/components/Slider/Slider.types.ts
micahgodbolt Dec 10, 2021
9c4b7d6
refactor css variables
micahgodbolt Dec 10, 2021
a20674a
Merge branch 'slider-refactor' of https://github.com/micahgodbolt/flu…
micahgodbolt Dec 10, 2021
e74747e
api update fix build
micahgodbolt Dec 10, 2021
eb37683
fix RTL issues
micahgodbolt Dec 10, 2021
91989cc
remove utils, cleanup tests, update ids
micahgodbolt Dec 13, 2021
40e3e85
remove unnecessary code
micahgodbolt Dec 13, 2021
bcdc3b8
new snaps
micahgodbolt Dec 13, 2021
8c30db3
Merge branch 'master' into slider-refactor
micahgodbolt Dec 14, 2021
95a2ef7
fixed thumb alignment, moved input to bottom of DOM stack
micahgodbolt Dec 14, 2021
f9ab541
Update packages/react-slider/src/components/Slider/Slider.test.tsx
micahgodbolt Dec 14, 2021
dbd71a4
Update packages/react-slider/src/components/Slider/Slider.types.ts
micahgodbolt Dec 14, 2021
8bc8246
updated stories with descriptions, fixed stateful bug
micahgodbolt Dec 14, 2021
6143326
updated tests
micahgodbolt Dec 14, 2021
b4cab2c
Merge branch 'slider-refactor' of https://github.com/micahgodbolt/flu…
micahgodbolt Dec 14, 2021
ea4a6c9
fixed pretty
micahgodbolt Dec 14, 2021
f504078
Merge branch 'master' into slider-refactor
micahgodbolt Dec 14, 2021
7de4704
api
micahgodbolt Dec 15, 2021
060dbb5
Merge branch 'master' into slider-refactor
micahgodbolt Dec 16, 2021
22d35ae
remove old snaps
micahgodbolt Dec 16, 2021
dfc2d9e
snaps
micahgodbolt Dec 16, 2021
9ba550a
update snaps
micahgodbolt Dec 16, 2021
6134a50
Merge branch 'master' into slider-refactor
micahgodbolt Dec 21, 2021
96895c5
test clean up
micahgodbolt Dec 21, 2021
3ee76d2
remove unused methods
micahgodbolt Dec 21, 2021
9a9b6cd
Merge branch 'master' into slider-refactor
micahgodbolt Jan 3, 2022
45c399a
change private to true
micahgodbolt Jan 3, 2022
67ddf8e
add outline for HC
micahgodbolt Jan 4, 2022
56292cf
Merge branch 'master' into slider-refactor
micahgodbolt Jan 4, 2022
4be0680
cleanup linting
micahgodbolt Jan 4, 2022
7c824ac
snaps
micahgodbolt Jan 4, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "Add slider package",
"packageName": "@fluentui/react-components",
"email": "[email protected]",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "Refactor slider component",
"packageName": "@fluentui/react-slider",
"email": "[email protected]",
"dependentChangeType": "patch"
}
1 change: 1 addition & 0 deletions packages/react-components/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@
"@fluentui/react-popover": "9.0.0-beta.4",
"@fluentui/react-portal": "9.0.0-beta.4",
"@fluentui/react-provider": "9.0.0-beta.4",
"@fluentui/react-slider": "9.0.0-beta.4",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing a change to actually export Slider (this just adds it as a dep). Also, Slider shouldn't be exported from the suite until we fix the primary slot issue. So it's best to just revert this change for now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed

"@fluentui/react-theme": "9.0.0-beta.3",
"@fluentui/react-tooltip": "9.0.0-beta.4",
"@fluentui/react-utilities": "9.0.0-beta.3",
Expand Down
12 changes: 6 additions & 6 deletions packages/react-slider/etc/react-slider.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,12 @@ import type { ForwardRefComponent } from '@fluentui/react-utilities';
import { IntrinsicShorthandProps } from '@fluentui/react-utilities';
import * as React_2 from 'react';

// @public (undocumented)
export const lowerThumbClassName: string;

// @public
export const RangedSlider: ForwardRefComponent<RangedSliderProps>;

// @public (undocumented)
export const rangedSliderClassName = "fui-RangedSlider";

// @public (undocumented)
export interface RangedSliderCommons extends Omit<SliderCommons, 'value' | 'defaultValue' | 'origin' | 'onChange'> {
defaultValue?: [number, number];
Expand Down Expand Up @@ -52,9 +52,6 @@ export const renderSlider: (state: SliderState) => JSX.Element;
// @public
export const Slider: ForwardRefComponent<SliderProps>;

// @public (undocumented)
export const sliderClassName = "fui-Slider";

// @public (undocumented)
export type SliderCommons = {
defaultValue?: number;
Expand Down Expand Up @@ -101,6 +98,9 @@ export type SliderSlots = {
// @public (undocumented)
export type SliderState = ComponentState<SliderSlots> & SliderCommons;

// @public (undocumented)
export const upperThumbClassName: string;

// @public
export const useRangedSlider: (props: RangedSliderProps, ref: React_2.Ref<HTMLElement>) => RangedSliderState;

Expand Down
80 changes: 0 additions & 80 deletions packages/react-slider/src/RangedSlider.stories.tsx

This file was deleted.

1 change: 0 additions & 1 deletion packages/react-slider/src/RangedSlider.ts

This file was deleted.

194 changes: 0 additions & 194 deletions packages/react-slider/src/Slider.stories.tsx

This file was deleted.

Loading