Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react-text - Migrate converged packages to TS Solution style config #20653

Merged
merged 2 commits into from
Nov 19, 2021
Merged

react-text - Migrate converged packages to TS Solution style config #20653

merged 2 commits into from
Nov 19, 2021

Conversation

andrefcdias
Copy link
Contributor

Pull request checklist

Description of changes

See parent issue #20597.

@andrefcdias andrefcdias requested a review from a team as a code owner November 18, 2021 16:26
@andrefcdias andrefcdias mentioned this pull request Nov 18, 2021
Closed
39 tasks
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 705a21a:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Nov 18, 2021 •
edited
Loading

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-card
Card - All		 49.986 kB
14.787 kB
react-card
Card		 45.406 kB
13.558 kB
react-card
CardFooter		 7.418 kB
3.182 kB
react-card
CardHeader		 8.778 kB
3.64 kB
react-card
CardPreview		 7.682 kB
3.341 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 169.377 kB
48.544 kB
react-components
react-components: FluentProvider & webLightTheme		 32.669 kB
10.652 kB
react-text
Text - Default		 10.603 kB
4.172 kB
react-text
Text - Wrappers		 13.899 kB
4.513 kB
🤖 This report was generated against 42c69701f6af74ab511549343c01a88d1889cfd3

@size-auditor
Copy link

size-auditor bot commented Nov 18, 2021 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 42c69701f6af74ab511549343c01a88d1889cfd3 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Nov 18, 2021 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 999 1038 5000
BaseButton mount 1032 1040 5000
Breadcrumb mount 2770 2730 1000
ButtonNext mount 533 551 5000
Checkbox mount 1684 1690 5000
CheckboxBase mount 1458 1464 5000
ChoiceGroup mount 5252 5263 5000
ComboBox mount 1041 1014 1000
CommandBar mount 10966 10908 1000
ContextualMenu mount 8815 8906 1000
DefaultButton mount 1287 1249 5000
DetailsRow mount 4220 4049 5000
DetailsRowFast mount 4166 4222 5000
DetailsRowNoStyles mount 3911 3918 5000
Dialog mount 2786 2717 1000
DocumentCardTitle mount 184 177 1000
Dropdown mount 3575 3565 5000
FluentProviderNext mount 4046 4059 5000
FluentProviderWithTheme mount 236 232 10
FluentProviderWithTheme virtual-rerender 110 109 10
FluentProviderWithTheme virtual-rerender-with-unmount 290 259 10
FocusTrapZone mount 2005 1902 5000
FocusZone mount 1903 1956 5000
IconButton mount 1944 1969 5000
Label mount 377 386 5000
Layer mount 3251 3266 5000
Link mount 520 512 5000
MakeStyles mount 1899 1875 50000
MenuButton mount 1612 1636 5000
MessageBar mount 2153 2101 5000
Nav mount 3738 3558 1000
OverflowSet mount 1202 1172 5000
Panel mount 2665 2645 1000
Persona mount 929 881 1000
Pivot mount 1541 1572 1000
PrimaryButton mount 1419 1407 5000
Rating mount 8703 8560 5000
SearchBox mount 1509 1460 5000
Shimmer mount 2856 2808 5000
Slider mount 2183 2120 5000
SpinButton mount 5433 5416 5000
Spinner mount 478 452 5000
SplitButton mount 3497 3464 5000
Stack mount 584 583 5000
StackWithIntrinsicChildren mount 1883 1895 5000
StackWithTextChildren mount 5220 5320 5000
SwatchColorPicker mount 11500 11388 5000
TagPicker mount 2870 2881 5000
TeachingBubble mount 13805 13966 5000
Text mount 484 475 5000
TextField mount 1578 1556 5000
ThemeProvider mount 1261 1250 5000
ThemeProvider virtual-rerender 652 645 5000
ThemeProvider virtual-rerender-with-unmount 2110 2070 5000
Toggle mount 927 912 5000
buttonNative mount 146 150 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AnimationMinimalPerf.default 478 438 1.09:1
AvatarMinimalPerf.default 241 222 1.09:1
AttachmentMinimalPerf.default 187 173 1.08:1
TreeWith60ListItems.default 213 198 1.08:1
AlertMinimalPerf.default 316 296 1.07:1
SkeletonMinimalPerf.default 411 385 1.07:1
DividerMinimalPerf.default 419 396 1.06:1
GridMinimalPerf.default 396 372 1.06:1
RefMinimalPerf.default 271 256 1.06:1
ButtonSlotsPerf.default 630 601 1.05:1
FormMinimalPerf.default 498 474 1.05:1
ListNestedPerf.default 637 609 1.05:1
SegmentMinimalPerf.default 406 385 1.05:1
TableMinimalPerf.default 454 431 1.05:1
BoxMinimalPerf.default 396 379 1.04:1
ButtonMinimalPerf.default 211 203 1.04:1
HeaderSlotsPerf.default 860 828 1.04:1
ImageMinimalPerf.default 433 418 1.04:1
ListMinimalPerf.default 588 564 1.04:1
ReactionMinimalPerf.default 428 412 1.04:1
AttachmentSlotsPerf.default 1182 1144 1.03:1
ChatDuplicateMessagesPerf.default 328 319 1.03:1
LabelMinimalPerf.default 431 420 1.03:1
RadioGroupMinimalPerf.default 510 494 1.03:1
IconMinimalPerf.default 714 690 1.03:1
TableManyItemsPerf.default 2165 2109 1.03:1
CarouselMinimalPerf.default 540 528 1.02:1
ChatMinimalPerf.default 728 716 1.02:1
CheckboxMinimalPerf.default 2956 2897 1.02:1
DatepickerMinimalPerf.default 5922 5814 1.02:1
ItemLayoutMinimalPerf.default 1340 1319 1.02:1
PortalMinimalPerf.default 183 180 1.02:1
TextMinimalPerf.default 378 370 1.02:1
CardMinimalPerf.default 630 625 1.01:1
FlexMinimalPerf.default 333 329 1.01:1
ListWith60ListItems.default 712 706 1.01:1
SplitButtonMinimalPerf.default 4735 4688 1.01:1
ToolbarMinimalPerf.default 1069 1062 1.01:1
TreeMinimalPerf.default 878 869 1.01:1
DialogMinimalPerf.default 819 821 1:1
DropdownMinimalPerf.default 3314 3317 1:1
EmbedMinimalPerf.default 4614 4603 1:1
HeaderMinimalPerf.default 416 417 1:1
LayoutMinimalPerf.default 415 413 1:1
PopupMinimalPerf.default 635 632 1:1
ProviderMinimalPerf.default 1248 1243 1:1
SliderMinimalPerf.default 1866 1869 1:1
StatusMinimalPerf.default 751 752 1:1
TextAreaMinimalPerf.default 569 570 1:1
TooltipMinimalPerf.default 1142 1143 1:1
VideoMinimalPerf.default 697 698 1:1
ButtonOverridesMissPerf.default 1923 1942 0.99:1
DropdownManyItemsPerf.default 760 769 0.99:1
InputMinimalPerf.default 1405 1419 0.99:1
LoaderMinimalPerf.default 761 765 0.99:1
MenuMinimalPerf.default 946 954 0.99:1
CustomToolbarPrototype.default 4377 4420 0.99:1
MenuButtonMinimalPerf.default 1807 1838 0.98:1
RosterPerf.default 1350 1379 0.98:1
ChatWithPopoverPerf.default 409 420 0.97:1
ListCommonPerf.default 699 724 0.97:1
ProviderMergeThemesPerf.default 1800 1847 0.97:1
AccordionMinimalPerf.default 170 180 0.94:1

@andrefcdias andrefcdias reopened this Nov 19, 2021
@andrefcdias andrefcdias enabled auto-merge (squash) November 19, 2021 09:43
@varholak-peter varholak-peter self-requested a review November 19, 2021 13:15
varholak-peter
varholak-peter approved these changes Nov 19, 2021
View reviewed changes
Copy link
Contributor

@varholak-peter varholak-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🇵🇰

@andrefcdias andrefcdias merged commit 168b934 into microsoft:master Nov 19, 2021
mlp73 pushed a commit to mlp73/fluentui that referenced this pull request Jan 17, 2022
@andrefcdias
react-text - Migrate converged packages to TS Solution style config (m…
0b8df35 
…icrosoft#20653)
@andrefcdias andrefcdias deleted the migrate-text branch May 12, 2022 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varholak-peter varholak-peter varholak-peter approved these changes

Assignees
No one assigned
Labels
Area: Build System Component: Text
Projects
None yet
Milestone
November Project Cycle Q4 2021
Development

Successfully merging this pull request may close these issues.
3 participants
@andrefcdias @fabricteam @varholak-peter