Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make-styles: fix types.ts compatibility with typescript < v4 #19281

Merged
merged 14 commits into from
Aug 6, 2021
Merged

make-styles: fix types.ts compatibility with typescript < v4 #19281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
68fffc2
Make callouts aware of the WindowSegments
jspurlin Sep 5, 2019
bfd68c1
Revert "Make callouts aware of the WindowSegments"
jspurlin Sep 5, 2019
5d89c48
Merge branch 'master' of https://github.com/OfficeDev/office-ui-fabri…
jspurlin Sep 5, 2019
297ccfb
Merge branch 'master' of https://github.com/OfficeDev/office-ui-fabri…
jspurlin Sep 11, 2019
b0a90af
Merge branch 'master' of https://github.com/OfficeDev/office-ui-fabri…
jspurlin Sep 19, 2019
f84ee51
Merge branch 'master' of https://github.com/OfficeDev/office-ui-fabri…
jspurlin Jan 9, 2020
4a22530
Merge branch 'master' of http://github.com/microsoft/fluentui
jspurlin Jul 28, 2020
60042cd
Merge branch 'master' of http://github.com/microsoft/fluentui
jspurlin Oct 30, 2020
06343aa
Merge branch 'master' of https://github.com/microsoft/fluentui
jspurlin Jan 19, 2021
af21a19
Merge branch 'master' of http://github.com/microsoft/fluentui
jspurlin Aug 5, 2021
59f4cd1
Make-styles: Types.ts was updated in a way that's not compatible with…
jspurlin Aug 5, 2021
95c85b4
Change files
jspurlin Aug 5, 2021
3841f1c
yarn update-api
jspurlin Aug 5, 2021
aa83086
Update change/@fluentui-make-styles-221c14b4-6ba3-4256-833e-ababcabba…
behowell Aug 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-make-styles-221c14b4-6ba3-4256-833e-ababcabba480.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "Make-styles: Types.ts was updated in a way that's not compatible with typescript < v4 (named tuples)",
"packageName": "@fluentui/make-styles",
"email": "[email protected]",
"dependentChangeType": "patch"
}
5 changes: 2 additions & 3 deletions packages/make-styles/etc/make-styles.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export function createCSSVariablesProxy(prefix?: string): unknown;
export function createDOMRenderer(target?: Document | undefined): MakeStylesRenderer;

// @public (undocumented)
export type CSSClasses = /* ltrClassName */ string | [ltrClassName: string, rtlClassName: string];
export type CSSClasses = /* ltrClassName */ string | [/* ltrClassName */ string, /* rtlClassName */ string];

// @public (undocumented)
export type CSSClassesMap = Record<PropertyHash, CSSClasses>;
Expand Down Expand Up @@ -50,7 +50,7 @@ export const LOOKUP_DEFINITIONS_INDEX = 0;
export const LOOKUP_DIR_INDEX = 1;

// @public (undocumented)
export type LookupItem = [definitions: CSSClassesMap, dir: 'rtl' | 'ltr'];
export type LookupItem = [/* definitions */ CSSClassesMap, /* dir */ /* dir */ 'rtl' | 'ltr'];

// @public (undocumented)
export type MakeStaticStyles = ({
Expand Down Expand Up @@ -159,7 +159,6 @@ export const styleBucketOrdering: StyleBucketName[];
// @public (undocumented)
export type StylesBySlots<Slots extends string | number, Tokens> = Record<Slots, MakeStylesStyleRule<Tokens>>;


// (No @packageDocumentation comment for this package)

```
4 changes: 2 additions & 2 deletions packages/make-styles/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ export type StyleBucketName =
export type SequenceHash = string;
export type PropertyHash = string;

export type CSSClasses = /* ltrClassName */ string | [ltrClassName: string, rtlClassName: string];
export type CSSClasses = /* ltrClassName */ string | [/* ltrClassName */ string, /* rtlClassName */ string];

export type CSSClassesMap = Record<PropertyHash, CSSClasses>;
export type CSSClassesMapBySlot<Slots extends string | number> = Record<Slots, CSSClassesMap>;
Expand All @@ -97,4 +97,4 @@ export type CSSRulesByBucket = Partial<Record<StyleBucketName, string[]>>;

export type StylesBySlots<Slots extends string | number, Tokens> = Record<Slots, MakeStylesStyleRule<Tokens>>;

export type LookupItem = [definitions: CSSClassesMap, dir: 'rtl' | 'ltr'];
export type LookupItem = [/* definitions */ CSSClassesMap, /* dir */ 'rtl' | 'ltr'];