Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tools): remove test:watch task from converged pkg when migrating #18743

Merged
merged 1 commit into from
Jun 28, 2021

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Jun 28, 2021

Pull request checklist

Description of changes

(give an overview)

Focus areas to test

(optional)

@size-auditor
Copy link

size-auditor bot commented Jun 28, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 24a66eb9f92725089d09517cfe782dcd16763a59 (build)

@Hotell Hotell enabled auto-merge (squash) June 28, 2021 09:13
@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 850 859 5000
BaseButton mount 972 951 5000
Breadcrumb mount 2591 2649 1000
ButtonNext mount 576 525 5000
Checkbox mount 1543 1704 5000
CheckboxBase mount 1404 1400 5000
ChoiceGroup mount 5059 4914 5000
ComboBox mount 976 1013 1000
CommandBar mount 10150 10373 1000
ContextualMenu mount 6273 6300 1000
DefaultButton mount 1171 1179 5000
DetailsRow mount 3968 3855 5000
DetailsRowFast mount 3864 3927 5000
DetailsRowNoStyles mount 3649 3606 5000
Dialog mount 2138 2127 1000
DocumentCardTitle mount 155 142 1000
Dropdown mount 3509 3415 5000
FocusTrapZone mount 1863 1892 5000
FocusZone mount 1851 1836 5000
IconButton mount 1826 1830 5000
Label mount 327 354 5000
Layer mount 1803 1816 5000
Link mount 495 487 5000
MakeStyles mount 1780 1757 50000
MenuButton mount 1512 1524 5000
MessageBar mount 2054 2053 5000
Nav mount 3444 3361 1000
OverflowSet mount 1033 1020 5000
Panel mount 2096 2133 1000
Persona mount 858 851 1000
Pivot mount 1434 1449 1000
PrimaryButton mount 1342 1347 5000
Rating mount 8210 8238 5000
SearchBox mount 1410 1442 5000
Shimmer mount 2700 2769 5000
Slider mount 2028 2051 5000
SpinButton mount 5242 5221 5000
Spinner mount 415 414 5000
SplitButton mount 3422 3530 5000
Stack mount 559 549 5000
StackWithIntrinsicChildren mount 1755 1708 5000
StackWithTextChildren mount 5202 5199 5000
SwatchColorPicker mount 11014 12437 5000
Tabs mount 1471 1434 1000
TagPicker mount 2597 2621 5000
TeachingBubble mount 11850 11973 5000
Text mount 437 427 5000
TextField mount 1432 1422 5000
ThemeProvider mount 1194 1225 5000
ThemeProvider virtual-rerender 590 611 5000
ThemeProviderNext mount 6778 6733 5000
Toggle mount 855 857 5000
buttonNative mount 122 122 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
RefMinimalPerf.default 286 254 1.13:1
TableMinimalPerf.default 461 409 1.13:1
FlexMinimalPerf.default 322 288 1.12:1
AvatarMinimalPerf.default 218 199 1.1:1
TreeWith60ListItems.default 200 182 1.1:1
AlertMinimalPerf.default 307 281 1.09:1
SegmentMinimalPerf.default 414 384 1.08:1
ChatWithPopoverPerf.default 391 369 1.06:1
ToolbarMinimalPerf.default 1030 975 1.06:1
BoxMinimalPerf.default 388 370 1.05:1
CarouselMinimalPerf.default 507 484 1.05:1
ReactionMinimalPerf.default 416 395 1.05:1
IconMinimalPerf.default 669 639 1.05:1
TextMinimalPerf.default 386 369 1.05:1
AccordionMinimalPerf.default 163 156 1.04:1
AttachmentMinimalPerf.default 169 162 1.04:1
AttachmentSlotsPerf.default 1179 1139 1.04:1
LabelMinimalPerf.default 427 410 1.04:1
CheckboxMinimalPerf.default 2875 2792 1.03:1
MenuMinimalPerf.default 922 896 1.03:1
ButtonSlotsPerf.default 582 572 1.02:1
DividerMinimalPerf.default 393 387 1.02:1
EmbedMinimalPerf.default 4379 4286 1.02:1
FormMinimalPerf.default 452 443 1.02:1
GridMinimalPerf.default 369 363 1.02:1
HeaderMinimalPerf.default 376 368 1.02:1
SliderMinimalPerf.default 1659 1620 1.02:1
SplitButtonMinimalPerf.default 4022 3941 1.02:1
VideoMinimalPerf.default 700 689 1.02:1
ButtonMinimalPerf.default 178 177 1.01:1
ButtonOverridesMissPerf.default 1768 1748 1.01:1
ChatDuplicateMessagesPerf.default 301 299 1.01:1
ChatMinimalPerf.default 684 675 1.01:1
ImageMinimalPerf.default 427 421 1.01:1
ItemLayoutMinimalPerf.default 1310 1293 1.01:1
LayoutMinimalPerf.default 399 396 1.01:1
ListMinimalPerf.default 570 564 1.01:1
ListNestedPerf.default 607 602 1.01:1
ListWith60ListItems.default 675 670 1.01:1
MenuButtonMinimalPerf.default 1733 1709 1.01:1
CardMinimalPerf.default 600 603 1:1
DialogMinimalPerf.default 788 786 1:1
DropdownManyItemsPerf.default 744 743 1:1
InputMinimalPerf.default 1296 1301 1:1
ProviderMergeThemesPerf.default 1665 1673 1:1
ProviderMinimalPerf.default 1048 1051 1:1
RadioGroupMinimalPerf.default 468 469 1:1
CustomToolbarPrototype.default 3939 3928 1:1
TooltipMinimalPerf.default 1038 1040 1:1
TreeMinimalPerf.default 823 822 1:1
AnimationMinimalPerf.default 431 435 0.99:1
DropdownMinimalPerf.default 3143 3184 0.99:1
LoaderMinimalPerf.default 722 728 0.99:1
PortalMinimalPerf.default 172 173 0.99:1
StatusMinimalPerf.default 731 735 0.99:1
DatepickerMinimalPerf.default 5509 5618 0.98:1
TableManyItemsPerf.default 2049 2094 0.98:1
ListCommonPerf.default 669 691 0.97:1
RosterPerf.default 1272 1308 0.97:1
SkeletonMinimalPerf.default 385 395 0.97:1
TextAreaMinimalPerf.default 555 570 0.97:1
HeaderSlotsPerf.default 809 842 0.96:1
PopupMinimalPerf.default 593 619 0.96:1

@Hotell Hotell merged commit 1468347 into microsoft:master Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tools: "test:watch" is not handled by a generator
5 participants