react-link: Migrating to new DX #18614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 tasks
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 3fccf5c8a8ea30529b736b9189e294969242f886 (build) |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 895 | 929 | 5000 | |
| BaseButton | mount | 962 | 973 | 5000 | |
| Breadcrumb | mount | 2661 | 2596 | 1000 | |
| ButtonNext | mount | 546 | 548 | 5000 | |
| Checkbox | mount | 1615 | 1584 | 5000 | |
| CheckboxBase | mount | 1420 | 1395 | 5000 | |
| ChoiceGroup | mount | 5072 | 5063 | 5000 | |
| ComboBox | mount | 1003 | 1030 | 1000 | |
| CommandBar | mount | 10221 | 10211 | 1000 | |
| ContextualMenu | mount | 6216 | 6427 | 1000 | |
| DefaultButton | mount | 1200 | 1154 | 5000 | |
| DetailsRow | mount | 3919 | 3849 | 5000 | |
| DetailsRowFast | mount | 3886 | 3911 | 5000 | |
| DetailsRowNoStyles | mount | 3630 | 3704 | 5000 | |
| Dialog | mount | 2197 | 2192 | 1000 | |
| DocumentCardTitle | mount | 149 | 157 | 1000 | |
| Dropdown | mount | 3472 | 3435 | 5000 | |
| FocusTrapZone | mount | 1854 | 1857 | 5000 | |
| FocusZone | mount | 1830 | 1880 | 5000 | |
| IconButton | mount | 1904 | 1879 | 5000 | |
| Label | mount | 339 | 344 | 5000 | |
| Layer | mount | 1833 | 1846 | 5000 | |
| Link | mount | 470 | 483 | 5000 | |
| MakeStyles | mount | 1786 | 1789 | 50000 | |
| MenuButton | mount | 1524 | 1564 | 5000 | |
| MessageBar | mount | 2032 | 2068 | 5000 | |
| Nav | mount | 3336 | 3375 | 1000 | |
| OverflowSet | mount | 1046 | 1018 | 5000 | |
| Panel | mount | 2147 | 2103 | 1000 | |
| Persona | mount | 840 | 828 | 1000 | |
| Pivot | mount | 1474 | 1467 | 1000 | |
| PrimaryButton | mount | 1352 | 1403 | 5000 | |
| Rating | mount | 8143 | 8177 | 5000 | |
| SearchBox | mount | 1391 | 1429 | 5000 | |
| Shimmer | mount | 2706 | 2683 | 5000 | |
| Slider | mount | 2141 | 2109 | 5000 | |
| SpinButton | mount | 5427 | 5188 | 5000 | |
| Spinner | mount | 435 | 409 | 5000 | |
| SplitButton | mount | 3264 | 3264 | 5000 | |
| Stack | mount | 548 | 544 | 5000 | |
| StackWithIntrinsicChildren | mount | 1660 | 1737 | 5000 | |
| StackWithTextChildren | mount | 4906 | 4923 | 5000 | |
| SwatchColorPicker | mount | 10567 | 10494 | 5000 | |
| Tabs | mount | 1476 | 1445 | 1000 | |
| TagPicker | mount | 2549 | 2515 | 5000 | |
| TeachingBubble | mount | 12122 | 12166 | 5000 | |
| Text | mount | 452 | 428 | 5000 | |
| TextField | mount | 1441 | 1437 | 5000 | |
| ThemeProvider | mount | 1219 | 1200 | 5000 | |
| ThemeProvider | virtual-rerender | 614 | 614 | 5000 | |
| ThemeProviderNext | mount | 6730 | 6630 | 5000 | |
| Toggle | mount | 840 | 848 | 5000 | |
| buttonNative | mount | 114 | 111 | 5000 |
Perf Analysis (@fluentui/react-northstar)
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| AttachmentMinimalPerf.default | 200 | 174 | 1.15:1 |
| SegmentMinimalPerf.default | 407 | 363 | 1.12:1 |
| PortalMinimalPerf.default | 187 | 169 | 1.11:1 |
| TextAreaMinimalPerf.default | 600 | 541 | 1.11:1 |
| ListMinimalPerf.default | 591 | 549 | 1.08:1 |
| DividerMinimalPerf.default | 423 | 395 | 1.07:1 |
| ButtonMinimalPerf.default | 199 | 187 | 1.06:1 |
| RadioGroupMinimalPerf.default | 500 | 473 | 1.06:1 |
| SkeletonMinimalPerf.default | 398 | 375 | 1.06:1 |
| HeaderMinimalPerf.default | 391 | 371 | 1.05:1 |
| LayoutMinimalPerf.default | 395 | 376 | 1.05:1 |
| ListCommonPerf.default | 684 | 654 | 1.05:1 |
| TreeWith60ListItems.default | 194 | 184 | 1.05:1 |
| VideoMinimalPerf.default | 678 | 644 | 1.05:1 |
| GridMinimalPerf.default | 378 | 362 | 1.04:1 |
| PopupMinimalPerf.default | 602 | 580 | 1.04:1 |
| StatusMinimalPerf.default | 760 | 731 | 1.04:1 |
| TreeMinimalPerf.default | 861 | 825 | 1.04:1 |
| AttachmentSlotsPerf.default | 1254 | 1218 | 1.03:1 |
| ChatWithPopoverPerf.default | 403 | 393 | 1.03:1 |
| CheckboxMinimalPerf.default | 2903 | 2823 | 1.03:1 |
| DropdownManyItemsPerf.default | 784 | 758 | 1.03:1 |
| FlexMinimalPerf.default | 312 | 302 | 1.03:1 |
| SplitButtonMinimalPerf.default | 4147 | 4013 | 1.03:1 |
| ToolbarMinimalPerf.default | 1003 | 978 | 1.03:1 |
| AnimationMinimalPerf.default | 467 | 458 | 1.02:1 |
| ButtonSlotsPerf.default | 603 | 593 | 1.02:1 |
| FormMinimalPerf.default | 462 | 455 | 1.02:1 |
| InputMinimalPerf.default | 1342 | 1310 | 1.02:1 |
| ItemLayoutMinimalPerf.default | 1371 | 1340 | 1.02:1 |
| LabelMinimalPerf.default | 413 | 406 | 1.02:1 |
| MenuMinimalPerf.default | 930 | 915 | 1.02:1 |
| TableMinimalPerf.default | 445 | 435 | 1.02:1 |
| CustomToolbarPrototype.default | 4016 | 3931 | 1.02:1 |
| CardMinimalPerf.default | 614 | 607 | 1.01:1 |
| HeaderSlotsPerf.default | 820 | 814 | 1.01:1 |
| ListWith60ListItems.default | 722 | 716 | 1.01:1 |
| MenuButtonMinimalPerf.default | 1740 | 1717 | 1.01:1 |
| ProviderMergeThemesPerf.default | 1674 | 1659 | 1.01:1 |
| TableManyItemsPerf.default | 2176 | 2151 | 1.01:1 |
| TextMinimalPerf.default | 364 | 362 | 1.01:1 |
| BoxMinimalPerf.default | 375 | 375 | 1:1 |
| ButtonOverridesMissPerf.default | 1780 | 1779 | 1:1 |
| CarouselMinimalPerf.default | 495 | 495 | 1:1 |
| ChatMinimalPerf.default | 645 | 647 | 1:1 |
| DialogMinimalPerf.default | 825 | 826 | 1:1 |
| EmbedMinimalPerf.default | 4338 | 4322 | 1:1 |
| LoaderMinimalPerf.default | 741 | 738 | 1:1 |
| RosterPerf.default | 1302 | 1298 | 1:1 |
| RefMinimalPerf.default | 238 | 239 | 1:1 |
| TooltipMinimalPerf.default | 1040 | 1041 | 1:1 |
| DropdownMinimalPerf.default | 3216 | 3242 | 0.99:1 |
| ImageMinimalPerf.default | 397 | 400 | 0.99:1 |
| ListNestedPerf.default | 615 | 626 | 0.98:1 |
| ProviderMinimalPerf.default | 1024 | 1040 | 0.98:1 |
| ReactionMinimalPerf.default | 413 | 423 | 0.98:1 |
| SliderMinimalPerf.default | 1621 | 1646 | 0.98:1 |
| IconMinimalPerf.default | 688 | 700 | 0.98:1 |
| AlertMinimalPerf.default | 299 | 308 | 0.97:1 |
| AvatarMinimalPerf.default | 202 | 208 | 0.97:1 |
| DatepickerMinimalPerf.default | 5493 | 5731 | 0.96:1 |
| ChatDuplicateMessagesPerf.default | 285 | 316 | 0.9:1 |
| AccordionMinimalPerf.default | 156 | 181 | 0.86:1 |
Hotell
reviewed
Jun 22, 2021
| @@ -52,6 +52,7 @@ | |||
| "@fluentui/react-focus": "^8.1.4", | |||
| "@fluentui/react-hooks": "^8.2.2", | |||
| "@fluentui/react-icons-mdl2": "^1.1.3", | |||
| "@fluentui/react-image": "^9.0.0-alpha.45", | |||
There was a problem hiding this comment.
hmm bad rebase ? react-image was migrated to new DX, thus it should not figure within react-examples
Suggested change
| "@fluentui/react-image": "^9.0.0-alpha.45", |
ecraig12345
approved these changes
Jun 22, 2021
2 tasks
msft-fluent-ui-bot
pushed a commit
that referenced
this pull request
Jun 22, 2021
#### Pull request checklist - [ ] Addresses an existing issue: Fixes #0000 - [ ] Include a change request file using `$ yarn change` #### Description of changes Removing unused `@fluentui/react-image` dependency from `@fluentui/react-examples` that happened after a bad merge with master in #18614.
|
🎉 Handy links: |
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
This PR migrates the
@fluentui/react-linkpackage to the new DX we have been building.