Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(tools): add docs for type utils and cover those utils by tests #18584

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Jun 16, 2021

Pull request checklist

Description of changes

Focus areas to test

(optional)

@size-auditor
Copy link

size-auditor bot commented Jun 16, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: bbbed62d08a2c928b913a80d197938a2f5aea9db (build)

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 796 806 5000
BaseButton mount 921 911 5000
Breadcrumb mount 2664 2633 1000
ButtonNext mount 542 522 5000
Checkbox mount 1540 1555 5000
CheckboxBase mount 1262 1317 5000
ChoiceGroup mount 4761 4761 5000
ComboBox mount 964 985 1000
CommandBar mount 10186 10305 1000
ContextualMenu mount 6313 6337 1000
DefaultButton mount 1154 1138 5000
DetailsRow mount 3658 3696 5000
DetailsRowFast mount 3706 3727 5000
DetailsRowNoStyles mount 3505 3490 5000
Dialog mount 2159 2157 1000
DocumentCardTitle mount 136 139 1000
Dropdown mount 3216 3269 5000
FocusTrapZone mount 1805 1873 5000
FocusZone mount 1845 1802 5000
IconButton mount 1773 1771 5000
Label mount 349 326 5000
Layer mount 1805 1779 5000
Link mount 465 470 5000
MakeStyles mount 1844 1834 50000
MenuButton mount 1490 1455 5000
MessageBar mount 2026 2045 5000
Nav mount 3295 3296 1000
OverflowSet mount 1056 1045 5000
Panel mount 2075 2067 1000
Persona mount 847 802 1000
Pivot mount 1360 1429 1000
PrimaryButton mount 1300 1300 5000
Rating mount 7640 7587 5000
SearchBox mount 1270 1321 5000
Shimmer mount 2556 2570 5000
Slider mount 1998 1969 5000
SpinButton mount 4912 4975 5000
Spinner mount 451 408 5000
SplitButton mount 3168 3156 5000
Stack mount 503 501 5000
StackWithIntrinsicChildren mount 1545 1558 5000
StackWithTextChildren mount 4484 4446 5000
SwatchColorPicker mount 10126 10253 5000
Tabs mount 1400 1410 1000
TagPicker mount 2448 2461 5000
TeachingBubble mount 11918 11899 5000
Text mount 435 422 5000
TextField mount 1402 1367 5000
ThemeProvider mount 1207 1203 5000
ThemeProvider virtual-rerender 599 590 5000
ThemeProviderNext mount 7111 7221 5000
Toggle mount 808 813 5000
buttonNative mount 122 115 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ButtonMinimalPerf.default 179 164 1.09:1
AccordionMinimalPerf.default 159 148 1.07:1
AlertMinimalPerf.default 290 271 1.07:1
AttachmentSlotsPerf.default 1181 1107 1.07:1
AttachmentMinimalPerf.default 162 153 1.06:1
FormMinimalPerf.default 409 385 1.06:1
HeaderMinimalPerf.default 366 346 1.06:1
GridMinimalPerf.default 348 331 1.05:1
TreeMinimalPerf.default 811 773 1.05:1
HeaderSlotsPerf.default 777 749 1.04:1
TreeWith60ListItems.default 170 164 1.04:1
ButtonOverridesMissPerf.default 1705 1658 1.03:1
CarouselMinimalPerf.default 467 453 1.03:1
InputMinimalPerf.default 1274 1231 1.03:1
LayoutMinimalPerf.default 371 359 1.03:1
ListMinimalPerf.default 516 502 1.03:1
ListNestedPerf.default 549 533 1.03:1
LoaderMinimalPerf.default 703 684 1.03:1
PortalMinimalPerf.default 193 188 1.03:1
RefMinimalPerf.default 252 245 1.03:1
AvatarMinimalPerf.default 196 193 1.02:1
ChatMinimalPerf.default 615 602 1.02:1
FlexMinimalPerf.default 287 282 1.02:1
TableMinimalPerf.default 402 396 1.02:1
TextAreaMinimalPerf.default 511 500 1.02:1
ToolbarMinimalPerf.default 954 937 1.02:1
CheckboxMinimalPerf.default 2733 2718 1.01:1
DialogMinimalPerf.default 760 756 1.01:1
EmbedMinimalPerf.default 4178 4127 1.01:1
LabelMinimalPerf.default 382 379 1.01:1
MenuMinimalPerf.default 857 851 1.01:1
PopupMinimalPerf.default 581 575 1.01:1
ProviderMergeThemesPerf.default 1692 1682 1.01:1
ProviderMinimalPerf.default 963 950 1.01:1
SegmentMinimalPerf.default 354 352 1.01:1
SkeletonMinimalPerf.default 361 356 1.01:1
TextMinimalPerf.default 364 359 1.01:1
TooltipMinimalPerf.default 983 972 1.01:1
VideoMinimalPerf.default 646 642 1.01:1
AnimationMinimalPerf.default 402 403 1:1
ButtonSlotsPerf.default 559 560 1:1
CardMinimalPerf.default 543 541 1:1
ChatWithPopoverPerf.default 367 366 1:1
DatepickerMinimalPerf.default 5384 5404 1:1
DropdownManyItemsPerf.default 682 684 1:1
DropdownMinimalPerf.default 3070 3056 1:1
ItemLayoutMinimalPerf.default 1276 1270 1:1
SliderMinimalPerf.default 1556 1562 1:1
SplitButtonMinimalPerf.default 3712 3726 1:1
StatusMinimalPerf.default 667 664 1:1
IconMinimalPerf.default 608 607 1:1
TableManyItemsPerf.default 1865 1858 1:1
CustomToolbarPrototype.default 3794 3786 1:1
BoxMinimalPerf.default 346 350 0.99:1
ChatDuplicateMessagesPerf.default 294 296 0.99:1
MenuButtonMinimalPerf.default 1591 1599 0.99:1
RadioGroupMinimalPerf.default 443 449 0.99:1
ReactionMinimalPerf.default 383 385 0.99:1
ListCommonPerf.default 627 638 0.98:1
RosterPerf.default 1146 1173 0.98:1
ImageMinimalPerf.default 351 367 0.96:1
ListWith60ListItems.default 624 647 0.96:1
DividerMinimalPerf.default 343 370 0.93:1

@Hotell Hotell merged commit a561562 into microsoft:master Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants