Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tools): run formatter in migration generator #18485

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Jun 8, 2021

Pull request checklist

Description of changes

(give an overview)

Focus areas to test

(optional)

@Hotell Hotell requested a review from a team as a code owner June 8, 2021 15:57
@Hotell Hotell enabled auto-merge (squash) June 8, 2021 15:57
@size-auditor
Copy link

size-auditor bot commented Jun 8, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: b7549f7316c033888edd79fa51a02258275925f2 (build)

@Hotell Hotell added this to the June Project Cycle Q2 2021 milestone Jun 8, 2021
@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 797 801 5000
BaseButton mount 891 890 5000
Breadcrumb mount 2587 2643 1000
ButtonNext mount 472 470 5000
Checkbox mount 1481 1555 5000
CheckboxBase mount 1266 1276 5000
ChoiceGroup mount 4646 4623 5000
ComboBox mount 960 955 1000
CommandBar mount 10077 10068 1000
ContextualMenu mount 6019 5971 1000
DefaultButton mount 1118 1107 5000
DetailsRow mount 3729 3656 5000
DetailsRowFast mount 3679 3693 5000
DetailsRowNoStyles mount 3481 3430 5000
Dialog mount 2150 2107 1000
DocumentCardTitle mount 146 132 1000
Dropdown mount 3165 3168 5000
FocusTrapZone mount 1797 1759 5000
FocusZone mount 1777 1783 5000
IconButton mount 1710 1743 5000
Label mount 339 331 5000
Layer mount 1743 1774 5000
Link mount 452 449 5000
MakeStyles mount 1821 1789 50000
MenuButton mount 1434 1447 5000
MessageBar mount 1993 1990 5000
Nav mount 3229 3206 1000
OverflowSet mount 1053 1032 5000
Panel mount 2028 2044 1000
Persona mount 831 795 1000
Pivot mount 1407 1377 1000
PrimaryButton mount 1261 1266 5000
Rating mount 7536 7524 5000
SearchBox mount 1254 1238 5000
Shimmer mount 2472 2474 5000
Slider mount 1920 1947 5000
SpinButton mount 4961 5142 5000
Spinner mount 406 429 5000
SplitButton mount 3093 3091 5000
Stack mount 482 493 5000
StackWithIntrinsicChildren mount 1555 1515 5000
StackWithTextChildren mount 4481 4491 5000
SwatchColorPicker mount 10164 10178 5000
Tabs mount 1389 1413 1000
TagPicker mount 2410 2387 5000
TeachingBubble mount 11837 11719 5000
Text mount 415 433 5000
TextField mount 1331 1336 5000
ThemeProvider mount 1166 1221 5000
ThemeProvider virtual-rerender 598 603 5000
ThemeProviderNext mount 7103 7091 5000
Toggle mount 814 792 5000
buttonNative mount 112 114 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ChatWithPopoverPerf.default 405 380 1.07:1
ListNestedPerf.default 594 556 1.07:1
PortalMinimalPerf.default 201 187 1.07:1
RefMinimalPerf.default 255 240 1.06:1
TreeWith60ListItems.default 178 171 1.04:1
ButtonMinimalPerf.default 175 170 1.03:1
FormMinimalPerf.default 427 416 1.03:1
LayoutMinimalPerf.default 388 378 1.03:1
SegmentMinimalPerf.default 358 347 1.03:1
SkeletonMinimalPerf.default 358 347 1.03:1
AlertMinimalPerf.default 270 266 1.02:1
CarouselMinimalPerf.default 479 468 1.02:1
ChatDuplicateMessagesPerf.default 301 296 1.02:1
ChatMinimalPerf.default 633 619 1.02:1
DialogMinimalPerf.default 782 765 1.02:1
ItemLayoutMinimalPerf.default 1283 1262 1.02:1
ListCommonPerf.default 634 620 1.02:1
MenuMinimalPerf.default 871 857 1.02:1
ButtonOverridesMissPerf.default 1738 1723 1.01:1
DividerMinimalPerf.default 380 375 1.01:1
DropdownManyItemsPerf.default 698 694 1.01:1
EmbedMinimalPerf.default 4242 4217 1.01:1
FlexMinimalPerf.default 296 293 1.01:1
HeaderMinimalPerf.default 371 367 1.01:1
HeaderSlotsPerf.default 767 758 1.01:1
InputMinimalPerf.default 1290 1273 1.01:1
ProviderMinimalPerf.default 1050 1040 1.01:1
SliderMinimalPerf.default 1596 1579 1.01:1
SplitButtonMinimalPerf.default 3726 3701 1.01:1
StatusMinimalPerf.default 686 682 1.01:1
TooltipMinimalPerf.default 973 963 1.01:1
VideoMinimalPerf.default 629 623 1.01:1
AttachmentSlotsPerf.default 1149 1152 1:1
LoaderMinimalPerf.default 687 688 1:1
MenuButtonMinimalPerf.default 1608 1604 1:1
TextMinimalPerf.default 343 342 1:1
CustomToolbarPrototype.default 3808 3804 1:1
BoxMinimalPerf.default 362 365 0.99:1
RosterPerf.default 1147 1157 0.99:1
IconMinimalPerf.default 591 598 0.99:1
TableManyItemsPerf.default 1857 1873 0.99:1
TextAreaMinimalPerf.default 489 492 0.99:1
ToolbarMinimalPerf.default 918 927 0.99:1
AccordionMinimalPerf.default 156 159 0.98:1
AnimationMinimalPerf.default 417 425 0.98:1
AttachmentMinimalPerf.default 160 163 0.98:1
ButtonSlotsPerf.default 542 555 0.98:1
CheckboxMinimalPerf.default 2739 2784 0.98:1
DatepickerMinimalPerf.default 5711 5804 0.98:1
ImageMinimalPerf.default 382 388 0.98:1
PopupMinimalPerf.default 594 608 0.98:1
RadioGroupMinimalPerf.default 451 459 0.98:1
TableMinimalPerf.default 393 399 0.98:1
TreeMinimalPerf.default 778 793 0.98:1
DropdownMinimalPerf.default 3104 3191 0.97:1
ProviderMergeThemesPerf.default 1762 1821 0.97:1
ListMinimalPerf.default 497 520 0.96:1
ReactionMinimalPerf.default 383 397 0.96:1
AvatarMinimalPerf.default 208 219 0.95:1
GridMinimalPerf.default 331 349 0.95:1
LabelMinimalPerf.default 381 404 0.94:1
CardMinimalPerf.default 533 576 0.93:1
ListWith60ListItems.default 640 688 0.93:1

@Hotell Hotell merged commit cda2ff9 into microsoft:master Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants