feat(tools): add --stats flag and update nx workspace config #18483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ling1726
reviewed
Jun 8, 2021
| @@ -58,6 +72,8 @@ export default async function (tree: Tree, schema: MigrateConvergedPkgGeneratorS | |||
| updateNpmScripts(tree, options); | |||
| updateApiExtractorForLocalBuilds(tree, options); | |||
|
|
|||
| updateNxWorkspace(tree, options); | |||
There was a problem hiding this comment.
What about the packages that are currently already migrated ? should those tags be added in this PR ?
There was a problem hiding this comment.
you can run it again on those
ling1726
reviewed
Jun 8, 2021
| project: T, | ||
| ): project is T & Required<Pick<ProjectConfiguration, 'tags' | 'sourceRoot'>> { | ||
| // eslint-disable-next-line eqeqeq | ||
| return project.sourceRoot != null && Boolean(project.tags?.includes('vNext')); |
There was a problem hiding this comment.
will this tag still be useful after all packages are migrated ? then I imagine we'll go back to a v9 validation
There was a problem hiding this comment.
they will, we can enforce lint rules based on those - restrict importing anything to vNext besides vNext for example
There was a problem hiding this comment.
to provide more context: nx.json and workspace.json gonna be main source of truth for any kind of project config metadata. (while we are in hybrid mode for convergence and non convergence, this approach is the best I could think of for now)
andrefcdias
approved these changes
Jun 8, 2021
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: c9574d52587940f26dbc58c030fd0b01e8732057 (build) |
andrefcdias
reviewed
Jun 8, 2021
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 871 | 856 | 5000 | |
| BaseButton | mount | 981 | 961 | 5000 | |
| Breadcrumb | mount | 2678 | 2705 | 1000 | |
| ButtonNext | mount | 524 | 510 | 5000 | |
| Checkbox | mount | 1695 | 1701 | 5000 | |
| CheckboxBase | mount | 1410 | 1435 | 5000 | |
| ChoiceGroup | mount | 5148 | 5079 | 5000 | |
| ComboBox | mount | 1024 | 1029 | 1000 | |
| CommandBar | mount | 10697 | 10792 | 1000 | |
| ContextualMenu | mount | 6549 | 6645 | 1000 | |
| DefaultButton | mount | 1242 | 1217 | 5000 | |
| DetailsRow | mount | 4015 | 3995 | 5000 | |
| DetailsRowFast | mount | 4077 | 4092 | 5000 | |
| DetailsRowNoStyles | mount | 3737 | 3764 | 5000 | |
| Dialog | mount | 2293 | 2281 | 1000 | |
| DocumentCardTitle | mount | 145 | 163 | 1000 | |
| Dropdown | mount | 3495 | 3556 | 5000 | |
| FocusTrapZone | mount | 1892 | 1906 | 5000 | |
| FocusZone | mount | 1920 | 1908 | 5000 | |
| IconButton | mount | 1883 | 1925 | 5000 | |
| Label | mount | 354 | 388 | 5000 | |
| Layer | mount | 1898 | 1930 | 5000 | |
| Link | mount | 488 | 508 | 5000 | |
| MakeStyles | mount | 1918 | 1850 | 50000 | |
| MenuButton | mount | 1622 | 1620 | 5000 | |
| MessageBar | mount | 2135 | 2111 | 5000 | |
| Nav | mount | 3507 | 3512 | 1000 | |
| OverflowSet | mount | 1103 | 1102 | 5000 | |
| Panel | mount | 2143 | 2172 | 1000 | |
| Persona | mount | 848 | 887 | 1000 | |
| Pivot | mount | 1516 | 1481 | 1000 | |
| PrimaryButton | mount | 1400 | 1378 | 5000 | |
| Rating | mount | 8434 | 8431 | 5000 | |
| SearchBox | mount | 1449 | 1410 | 5000 | |
| Shimmer | mount | 2739 | 2728 | 5000 | |
| Slider | mount | 2088 | 2075 | 5000 | |
| SpinButton | mount | 5243 | 5319 | 5000 | |
| Spinner | mount | 427 | 423 | 5000 | |
| SplitButton | mount | 3432 | 3294 | 5000 | |
| Stack | mount | 532 | 545 | 5000 | |
| StackWithIntrinsicChildren | mount | 1709 | 1717 | 5000 | |
| StackWithTextChildren | mount | 5112 | 5098 | 5000 | |
| SwatchColorPicker | mount | 10949 | 11071 | 5000 | |
| Tabs | mount | 1525 | 1476 | 1000 | |
| TagPicker | mount | 2599 | 2614 | 5000 | |
| TeachingBubble | mount | 12085 | 12145 | 5000 | |
| Text | mount | 450 | 467 | 5000 | |
| TextField | mount | 1573 | 1510 | 5000 | |
| ThemeProvider | mount | 1217 | 1247 | 5000 | |
| ThemeProvider | virtual-rerender | 610 | 621 | 5000 | |
| ThemeProviderNext | mount | 6888 | 6841 | 5000 | |
| Toggle | mount | 869 | 853 | 5000 | |
| buttonNative | mount | 121 | 134 | 5000 |
Perf Analysis (@fluentui/react-northstar)
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| PortalMinimalPerf.default | 196 | 176 | 1.11:1 |
| AttachmentMinimalPerf.default | 182 | 166 | 1.1:1 |
| FlexMinimalPerf.default | 340 | 314 | 1.08:1 |
| TableMinimalPerf.default | 460 | 426 | 1.08:1 |
| AnimationMinimalPerf.default | 457 | 429 | 1.07:1 |
| ButtonSlotsPerf.default | 641 | 600 | 1.07:1 |
| CardMinimalPerf.default | 632 | 598 | 1.06:1 |
| LabelMinimalPerf.default | 470 | 443 | 1.06:1 |
| LayoutMinimalPerf.default | 437 | 413 | 1.06:1 |
| TextAreaMinimalPerf.default | 595 | 560 | 1.06:1 |
| VideoMinimalPerf.default | 703 | 666 | 1.06:1 |
| AlertMinimalPerf.default | 314 | 302 | 1.04:1 |
| ChatMinimalPerf.default | 693 | 669 | 1.04:1 |
| GridMinimalPerf.default | 388 | 372 | 1.04:1 |
| ListCommonPerf.default | 734 | 707 | 1.04:1 |
| ListMinimalPerf.default | 588 | 563 | 1.04:1 |
| ReactionMinimalPerf.default | 435 | 417 | 1.04:1 |
| SkeletonMinimalPerf.default | 407 | 391 | 1.04:1 |
| AttachmentSlotsPerf.default | 1248 | 1209 | 1.03:1 |
| ChatWithPopoverPerf.default | 404 | 393 | 1.03:1 |
| HeaderSlotsPerf.default | 871 | 846 | 1.03:1 |
| ListNestedPerf.default | 631 | 615 | 1.03:1 |
| RadioGroupMinimalPerf.default | 503 | 488 | 1.03:1 |
| SplitButtonMinimalPerf.default | 4149 | 4042 | 1.03:1 |
| CarouselMinimalPerf.default | 509 | 497 | 1.02:1 |
| DatepickerMinimalPerf.default | 5760 | 5657 | 1.02:1 |
| DialogMinimalPerf.default | 812 | 797 | 1.02:1 |
| DropdownMinimalPerf.default | 3238 | 3167 | 1.02:1 |
| HeaderMinimalPerf.default | 420 | 411 | 1.02:1 |
| MenuButtonMinimalPerf.default | 1782 | 1745 | 1.02:1 |
| SliderMinimalPerf.default | 1711 | 1684 | 1.02:1 |
| ChatDuplicateMessagesPerf.default | 314 | 310 | 1.01:1 |
| DividerMinimalPerf.default | 387 | 384 | 1.01:1 |
| DropdownManyItemsPerf.default | 762 | 757 | 1.01:1 |
| InputMinimalPerf.default | 1319 | 1310 | 1.01:1 |
| PopupMinimalPerf.default | 644 | 640 | 1.01:1 |
| TableManyItemsPerf.default | 2112 | 2085 | 1.01:1 |
| CustomToolbarPrototype.default | 4006 | 3983 | 1.01:1 |
| TooltipMinimalPerf.default | 1093 | 1085 | 1.01:1 |
| TreeMinimalPerf.default | 873 | 868 | 1.01:1 |
| CheckboxMinimalPerf.default | 2917 | 2928 | 1:1 |
| EmbedMinimalPerf.default | 4422 | 4407 | 1:1 |
| FormMinimalPerf.default | 480 | 481 | 1:1 |
| ListWith60ListItems.default | 700 | 702 | 1:1 |
| LoaderMinimalPerf.default | 748 | 750 | 1:1 |
| ProviderMergeThemesPerf.default | 1747 | 1747 | 1:1 |
| ProviderMinimalPerf.default | 1069 | 1068 | 1:1 |
| ButtonMinimalPerf.default | 188 | 189 | 0.99:1 |
| ItemLayoutMinimalPerf.default | 1404 | 1414 | 0.99:1 |
| SegmentMinimalPerf.default | 400 | 405 | 0.99:1 |
| IconMinimalPerf.default | 685 | 690 | 0.99:1 |
| TreeWith60ListItems.default | 191 | 192 | 0.99:1 |
| BoxMinimalPerf.default | 384 | 391 | 0.98:1 |
| MenuMinimalPerf.default | 944 | 960 | 0.98:1 |
| TextMinimalPerf.default | 386 | 394 | 0.98:1 |
| AccordionMinimalPerf.default | 176 | 181 | 0.97:1 |
| AvatarMinimalPerf.default | 211 | 217 | 0.97:1 |
| RosterPerf.default | 1271 | 1316 | 0.97:1 |
| StatusMinimalPerf.default | 733 | 758 | 0.97:1 |
| ToolbarMinimalPerf.default | 1007 | 1034 | 0.97:1 |
| ButtonOverridesMissPerf.default | 1813 | 1883 | 0.96:1 |
| ImageMinimalPerf.default | 427 | 446 | 0.96:1 |
| RefMinimalPerf.default | 233 | 246 | 0.95:1 |
ling1726
approved these changes
Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
[ ] Include a change request file using$ yarn changeDescription of changes
srcRootand addsvNexttag to migrated project↓↓↓
Focus areas to test
(optional)